1 2013-05-20T02:09:24 <sharky93> TheSheep, please review @ https://codereview.appspot.com/9104050/
2 2013-05-20T02:20:35 *** sharky93
3 2013-05-20T02:33:20 *** sharky93
4 2013-05-20T02:36:06 *** sharky93
5 2013-05-20T02:36:15 *** dwcramer
6 2013-05-20T02:36:19 *** sharky93
7 2013-05-20T02:51:41 *** dwcramer
8 2013-05-20T03:11:58 *** dwcramer
9 2013-05-20T04:30:04 *** dwcramer
10 2013-05-20T05:32:12 *** ronny_
11 2013-05-20T06:06:53 *** ana_ananasova
12 2013-05-20T06:26:20 *** ana_ananasova
13 2013-05-20T07:01:54 *** ronny_
14 2013-05-20T09:17:41 *** greg_f
15 2013-05-20T09:58:00 <sharky93> moin
16 2013-05-20T10:03:26 <sharky93> TheSheep, how about making the removal of class a global function, may just improve readability ?
17 2013-05-20T10:03:53 <sharky93> i mean @ https://codereview.appspot.com/9104050
18 2013-05-20T10:07:49 <TheSheep> sharky93: I think that calling that function would be actually longer than just removing this class, no?
19 2013-05-20T10:15:02 <sharky93> TheSheep, yeah
20 2013-05-20T10:15:34 <TheSheep> sharky93: we can always move it to a global function later if we decide that we need it
21 2013-05-20T10:16:47 <sharky93> TheSheep, hmm, ok
22 2013-05-20T10:18:40 <sharky93> TheSheep, one more thing, when JS is disable the input file box does not get resized to cover the whole width, it remains at 85%, should that be a concern ?
23 2013-05-20T10:18:53 <sharky93> *disabled
24 2013-05-20T10:19:24 <TheSheep> sharky93: I think it's ok, that's why we used visibility:hidden and not display:none
25 2013-05-20T10:19:32 <TheSheep> sharky93: so that the layout is not affected
26 2013-05-20T10:19:43 <TheSheep> sharky93: but perhaps it shouldn't be removed, but just disabled?
27 2013-05-20T10:20:54 <sharky93> TheSheep, that would further intermix JS and styles, so i thought of abstracting it a bit
28 2013-05-20T10:51:20 *** sharky93
29 2013-05-20T10:51:37 *** sharky93
30 2013-05-20T11:24:07 *** breton
31 2013-05-20T11:26:02 *** breton
32 2013-05-20T11:28:22 <sharky93> TheSheep, the rest is fine ?
33 2013-05-20T11:34:54 <TheSheep> sharky93: yes
34 2013-05-20T11:37:18 <sharky93> ThomasWaldmann, ^
35 2013-05-20T11:37:50 <sharky93> should i commit ?
36 2013-05-20T12:02:59 <sharky93> TheSheep, so finally we use .removeClass?
37 2013-05-20T12:04:29 <TheSheep> sharky93: I think it's fine for now
38 2013-05-20T12:06:20 <sharky93> ok
39 2013-05-20T12:41:36 *** dave_largo
40 2013-05-20T13:05:50 *** sharky93
41 2013-05-20T13:17:13 *** sharky93
42 2013-05-20T13:27:48 <ThomasWaldmann> moin
43 2013-05-20T13:44:54 *** brunomartin
44 2013-05-20T13:56:24 *** dwcramer
45 2013-05-20T13:59:17 *** chitrank
46 2013-05-20T14:02:44 <chitrank> ThomasWaldmann: My Apologies for late reply due to system overheat problem. Nice work done would definitely help me while doing porting to python 3.
47 2013-05-20T14:21:07 *** sharky93
48 2013-05-20T15:14:41 *** ashutosh1461
49 2013-05-20T15:37:53 *** dreimark
50 2013-05-20T15:46:40 <chitrank> Hello Moin developers I need to review some code changes in EmeraldTree so please review my code changes . The code changes are as per the requirement of Python 3.x porting with backward compatibility Here is the link: https://codereview.appspot.com/9491043/
51 2013-05-20T16:24:12 <ThomasWaldmann> chitrank: review done.
52 2013-05-20T16:27:45 *** kolyaflash
53 2013-05-20T16:32:44 <chitrank> ThomasWaldmann: thanks I'll keep in mind and do some positive fix. Sorry for clumsy mistakes of indentation, tabs.
54 2013-05-20T16:37:53 *** dreimark
55 2013-05-20T16:38:20 *** dreimark
56 2013-05-20T16:38:29 *** dreimark
57 2013-05-20T16:40:24 *** dreimark
58 2013-05-20T16:43:09 <ThomasWaldmann> chitrank: what editor do you use?
59 2013-05-20T16:44:10 <ThomasWaldmann> btw, you should do first review yourself. many of such mistakes can be spotted and fixes before asking for review.
60 2013-05-20T16:45:43 <chitrank> I use simple IDLE . When I run on python 2 it runs fine but gives TabError in python 3 maybe I shouls reinstall python 2 IDLE
61 2013-05-20T16:47:27 <ThomasWaldmann> chitrank: idle is nice for python course, but for real development I'ld suggest something better
62 2013-05-20T16:47:49 <ThomasWaldmann> courses* (like when teaching python)
63 2013-05-20T16:48:24 <ThomasWaldmann> chitrank: did you check pycharm? (sorry if we already talked about it)
64 2013-05-20T16:49:40 <ThomasWaldmann> in any case, you need a editor that can reliably expand tabs and only inserts 4 spaces when you press tab
65 2013-05-20T16:51:12 <chitrank> no I have not used pycharm. Nice advice I am getting lots of problem with these taberror . Okay I should use that
66 2013-05-20T16:52:32 <ThomasWaldmann> pycharm is nice, but commercial sw. if you work on moin and like to use it, you can use the free project license we have from them.
67 2013-05-20T16:54:33 <ThomasWaldmann> you can just test it with the 1 month testing period and decide then
68 2013-05-20T16:54:34 <chitrank> ThomasWaldmann: I am in need of such an IDE. Earlier I used eclipse but it is slight lazy in working. So It would be better to use Pycharm.
69 2013-05-20T16:54:54 <ThomasWaldmann> for eclipse there is pydev, which is not bad either
70 2013-05-20T16:55:20 * ThomasWaldmann used if before switching to pycharm (now and then, when not just using vim/mc)
71 2013-05-20T16:56:18 <chitrank> Yes pydev is not bad but it is lazy in working that is the reason I avoid it. But should use it either for working. To avoid such simple mistakes that could be solved and avoided by me.
72 2013-05-20T16:59:21 *** ana-balica
73 2013-05-20T17:00:25 *** greg_f
74 2013-05-20T17:08:50 <ashutosh1461> ThomasWaldmann, what is Rabbithole about ?
75 2013-05-20T17:14:59 <ThomasWaldmann> chitrank: lazy in working means "runs too slow"?
76 2013-05-20T17:15:19 <dav1d> I never understood that, it always ran smooth for me
77 2013-05-20T17:16:44 <chitrank> ThomasWaldmann: yes maybe I need to backup the system and free some space. Remove unwanted applications. I would fix it up by tomorrow anyhow with all these errors.
78 2013-05-20T17:16:45 <ThomasWaldmann> java stuff is often a bit slow, but if you have >>1GB RAM and >>1GHz dualcore, both eclipse and pycharm should be usable
79 2013-05-20T17:16:54 <dav1d> oh windows
80 2013-05-20T17:17:10 <dav1d> ThomasWaldmann: is pycharm also so ugly for you?
81 2013-05-20T17:17:15 <ThomasWaldmann> (what i said was for linux, for windows you might need more)
82 2013-05-20T17:17:25 <ashutosh1461> pycharm runs slow on my Ubuntu as well
83 2013-05-20T17:17:27 <dav1d> idea looks way better, guess they are using a different Java gui toolkit
84 2013-05-20T17:17:39 <ThomasWaldmann> dav1d: there are some themes, choose whatever you like
85 2013-05-20T17:17:52 <dav1d> idea with a different style looks pretty good (the dark theme)
86 2013-05-20T17:17:54 *** ReimarBauer
87 2013-05-20T17:17:56 <dav1d> neat
88 2013-05-20T17:18:13 <dav1d> first time I started pycharm, I shut it down because of the awful look
89 2013-05-20T17:19:04 <ThomasWaldmann> when it indexes stuff (when files changed, or on first startup, indexing takes a while - but afterwards you can use global search very quickly, which is nice)
90 2013-05-20T17:19:21 <dreimark> for windows there is also pyscript
91 2013-05-20T17:21:35 <chitrank> ThomasWaldmann: Okay I should remove some java projects that are reciding in the workspace of eclipse then it would work fine and Never let you see such clumsy mistakes
92 2013-05-20T17:21:48 <dav1d> chitrank: use a different workspace
93 2013-05-20T17:24:54 <chitrank> dav1d: okay I am using different workspace
94 2013-05-20T17:25:29 <dav1d> well I never ran into these problems, but using a different workspaces simply made for me more sense then mixing languages in one workspace
95 2013-05-20T17:30:36 *** TheSheep
96 2013-05-20T17:31:10 <ana-balica> when pycharm starts indexing my laptop reboots without a warning. that is really confusing.
97 2013-05-20T17:32:07 *** TheSheep
98 2013-05-20T17:32:39 <ThomasWaldmann> ana-balica: then your laptop has a defect, likely
99 2013-05-20T17:33:12 <ana-balica> yeah. i think so. i'm having a thinkpad i3 with 3gb ram.
100 2013-05-20T17:33:23 * ThomasWaldmann suggests checking RAM with memtest86+ and SMART values of the hdd (after doing a SMART long test)
101 2013-05-20T17:33:59 * ana-balica says thanks for the suggestion
102 2013-05-20T17:34:38 <ThomasWaldmann> btw, everybody please consider the case of having a machine defect in GSOC, have a plan B
103 2013-05-20T17:34:57 <ThomasWaldmann> (and a backup :)
104 2013-05-20T17:35:05 <ana-balica> hm.. i also have a desktop
105 2013-05-20T17:35:49 <ThomasWaldmann> ana-balica: your laptop is more modern than mine :D
106 2013-05-20T17:35:55 <ana-balica> is it ok to store the project on ubuntu one (or any other cloud) while working?
107 2013-05-20T17:36:31 <ana-balica> aka back-up
108 2013-05-20T17:36:53 <ThomasWaldmann> well, moin itself is FOSS sw, so are your contributions. just be careful with passwords or other secrets, e.g. in config files.
109 2013-05-20T17:37:37 *** ashutosh1461
110 2013-05-20T17:37:45 <ThomasWaldmann> also, a good idea is to test the backup, whether it really works in the case...
111 2013-05-20T17:38:06 <chitrank> I have my brother's laptop so I should prepare it for development as well
112 2013-05-20T17:39:16 <ana-balica> everybody collect all the computers around for plan B :D
113 2013-05-20T17:40:42 <ThomasWaldmann> we had last year such a case. he was very late with working on his project already, then machine got defect. project failed.
114 2013-05-20T17:41:25 <ThomasWaldmann> i suspect that the machine defect was not the main reason for failing, but maybe has contributed to it.
115 2013-05-20T17:42:08 *** kolyaflash
116 2013-05-20T17:45:22 *** ashutosh1461
117 2013-05-20T17:46:25 *** sharky93
118 2013-05-20T17:54:10 *** ReimarBauer2
119 2013-05-20T18:25:17 *** chitrank
120 2013-05-20T18:25:40 <sharky93> moin
121 2013-05-20T18:36:52 <sharky93> ThomasWaldmann, about https://codereview.appspot.com/9104050 , should i commit?
122 2013-05-20T18:47:16 *** chitrank
123 2013-05-20T18:54:03 *** ana-balica
124 2013-05-20T19:26:47 *** chitrank
125 2013-05-20T19:55:46 *** kolyaflash
126 2013-05-20T19:58:24 *** sunu
127 2013-05-20T20:21:22 *** ashutosh1461
128 2013-05-20T20:52:29 *** sharky93
129 2013-05-20T21:04:59 *** sharky93
130 2013-05-20T21:13:32 *** dave_largo
131 2013-05-20T21:15:15 *** ronny_
132 2013-05-20T21:18:40 <dreimark> http://www.earley.com/webinars/jumpstarts/content-in-context
133 2013-05-20T21:18:52 <dreimark> interesting sessions
134 2013-05-20T21:28:44 *** kolyaflash
135 2013-05-20T21:40:54 *** ronny_
136 2013-05-20T21:45:02 *** ronny_
137 2013-05-20T21:46:04 *** dreimark_
138 2013-05-20T21:48:07 *** dreimark_
139 2013-05-20T21:48:17 *** r2
140 2013-05-20T22:22:43 *** dwcramer
141 2013-05-20T22:24:13 *** dreimark
142 2013-05-20T22:24:15 *** dreimark2
143 2013-05-20T22:38:49 *** sunu_
144 2013-05-20T22:39:30 *** ronny_
145 2013-05-20T22:39:54 *** sunu
146 2013-05-20T22:43:46 *** sharky93
147 2013-05-20T22:43:55 *** tmishra
148 2013-05-20T22:44:34 *** tmishra
149 2013-05-20T22:45:31 *** sunu
150 2013-05-20T23:19:13 *** dwcramer
151 2013-05-20T23:37:49 *** brunomartin
152
