MoinMoin: MoinMoinChat/Logs/moin-dev/2013-06-19

   1 2013-06-19T02:41:24  *** sharky93 has quit IRC
   2 2013-06-19T02:42:09  *** sharky93_ has joined #moin-dev
   3 2013-06-19T02:42:11  *** sharky93_ is now known as sharky93
   4 2013-06-19T02:42:49  *** ReimarBauer has quit IRC
   5 2013-06-19T02:42:49  *** eSyr-ng has quit IRC
   6 2013-06-19T02:42:55  *** ReimarBauer has joined #moin-dev
   7 2013-06-19T02:42:55  *** eSyr-ng has joined #moin-dev
   8 2013-06-19T03:44:01  *** spy_ has quit IRC
   9 2013-06-19T03:44:12  *** spy_ has joined #moin-dev
  10 2013-06-19T03:44:33  *** MarcelH has quit IRC
  11 2013-06-19T03:45:26  *** MarcelH has joined #moin-dev
  12 2013-06-19T03:50:47  *** TheSheep has quit IRC
  13 2013-06-19T03:50:48  *** breton has quit IRC
  14 2013-06-19T03:51:55  *** birkenfeld has quit IRC
  15 2013-06-19T03:52:43  *** TheSheep has joined #moin-dev
  16 2013-06-19T03:52:44  *** breton has joined #moin-dev
  17 2013-06-19T03:53:43  *** birkenfeld has joined #moin-dev
  18 2013-06-19T03:54:00  *** TheSheep has quit IRC
  19 2013-06-19T03:54:01  *** breton has quit IRC
  20 2013-06-19T03:55:42  *** TheSheep has joined #moin-dev
  21 2013-06-19T03:55:42  *** breton has joined #moin-dev
  22 2013-06-19T05:41:27  *** ashutosh1461 has joined #moin-dev
  23 2013-06-19T06:09:57  *** vpv has quit IRC
  24 2013-06-19T06:10:56  *** vpv has joined #moin-dev
  25 2013-06-19T08:09:51  *** sharky93 is now known as sharkyraj
  26 2013-06-19T08:10:19  *** sharky93 has joined #moin-dev
  27 2013-06-19T08:10:26  *** sharkyraj is now known as sharkyraj_
  28 2013-06-19T11:07:42  <ashutosh1461> ThomasWaldmann, updated http://etherpad.osuosl.org/moin-itemid
  29 2013-06-19T11:10:32  *** greg_f has joined #moin-dev
  30 2013-06-19T11:56:33  <ThomasWaldmann> ashutosh1461: replied there
  31 2013-06-19T12:05:36  <sharky93> moin
  32 2013-06-19T12:11:09  <sharky93> TheSheep, so the next task is removing the not necessary global functions and variables?
  33 2013-06-19T12:12:23  <TheSheep> sharky93: and making them local
  34 2013-06-19T12:12:47  <TheSheep> sharky93: alre, removing all the onclick="" etc. from templates and replacing with $(..).click()
  35 2013-06-19T12:19:21  <sharky93> TheSheep, for tackling functions like @ https://bitbucket.org/thomaswaldmann/moin-2.0/src/ad303592c64c1743ac218d42835493cb9d97440b/MoinMoin/templates/common.js?at=default#cl-16 .. do we just enclose it directly in the document.ready() ?
  36 2013-06-19T12:20:03  <TheSheep> sharky93: you have to find where it is being called
  37 2013-06-19T12:20:21  <TheSheep> sharky93: I don't have the moin source handy here at work
  38 2013-06-19T12:23:19  <sharky93> TheSheep, okay, i got it
  39 2013-06-19T12:32:47  *** ashutosh1461 has quit IRC
  40 2013-06-19T12:37:41  *** brunomartin has joined #moin-dev
  41 2013-06-19T12:40:09  *** dave_largo has joined #moin-dev
  42 2013-06-19T14:23:18  *** ana_ananasova has joined #moin-dev
  43 2013-06-19T14:52:13  *** dave_largo has quit IRC
  44 2013-06-19T15:00:11  *** sharky93_ has joined #moin-dev
  45 2013-06-19T15:15:01  *** ana_ananasova has quit IRC
  46 2013-06-19T15:16:35  *** ana_ananasova has joined #moin-dev
  47 2013-06-19T15:22:55  *** brunomartin has quit IRC
  48 2013-06-19T15:23:12  *** brunomartin has joined #moin-dev
  49 2013-06-19T15:33:31  *** brunomartin has quit IRC
  50 2013-06-19T15:35:26  *** brunomartin has joined #moin-dev
  51 2013-06-19T16:23:53  *** ashutosh1461 has joined #moin-dev
  52 2013-06-19T17:52:28  *** xjjk has quit IRC
  53 2013-06-19T18:02:54  *** greg_f has quit IRC
  54 2013-06-19T18:10:29  <ashutosh1461> ThomasWaldmann, updated http://etherpad.osuosl.org/moin-itemid
  55 2013-06-19T18:20:06  <sharky93> TheSheep, the changesets for changes to the templates and the changes to the template should be different?
  56 2013-06-19T18:55:37  <TheSheep> sharky93: I don't understand
  57 2013-06-19T19:04:35  <sharky93> TheSheep, ah, my bad :| .. i mean changes to the template and changes to the main JS file (mostly reducing global stuff).
  58 2013-06-19T19:05:35  <TheSheep> what do you mean by different?
  59 2013-06-19T19:05:42  <TheSheep> of course they are different
  60 2013-06-19T19:05:51  <TheSheep> those are different files with different content
  61 2013-06-19T19:06:07  <TheSheep> there is no way they would be the same
  62 2013-06-19T19:06:13  <sharky93> i mean a different commit
  63 2013-06-19T19:06:22  <TheSheep> ah, separate
  64 2013-06-19T19:06:34  <sharky93> ouch :P
  65 2013-06-19T19:06:46  <TheSheep> well, it makes sense to make the i18n stuff separate from the jslint stuff
  66 2013-06-19T19:07:26  <TheSheep> but not based on which file it is
  67 2013-06-19T19:07:50  <TheSheep> it's ok to commit changes to several files together, as long as they belong together logically
  68 2013-06-19T19:08:31  <sharky93> hmm, i'll rebase as 'general cleanup'
  69 2013-06-19T19:20:55  *** brunomartin has quit IRC
  70 2013-06-19T19:23:04  <ThomasWaldmann> re
  71 2013-06-19T19:32:31  *** brunomartin has joined #moin-dev
  72 2013-06-19T19:42:39  <TheSheep> sharky93: so, next thing, perhaps the image sizing?
  73 2013-06-19T19:46:13  *** brunomartin has quit IRC
  74 2013-06-19T19:50:51  <sharky93> TheSheep, yeah, we should get it done. Much required.
  75 2013-06-19T19:51:26  <ana_ananasova> waldi: cr https://codereview.appspot.com/10386044/ and ep section 1.4 again http://etherpad.osuosl.org/moin-mail
  76 2013-06-19T20:00:30  *** brunomartin has joined #moin-dev
  77 2013-06-19T20:25:27  *** ashu1481 has joined #moin-dev
  78 2013-06-19T20:27:28  *** ashu1481 is now known as ashu1461
  79 2013-06-19T20:30:03  *** ashu1461 has quit IRC
  80 2013-06-19T20:42:24  *** ashutosh1461 has quit IRC
  81 2013-06-19T20:45:46  <ReimarBauer> moin
  82 2013-06-19T20:49:52  <sharky93> TheSheep, two quick cr's https://codereview.appspot.com/10364047 and https://codereview.appspot.com/10427043/
  83 2013-06-19T20:50:20  <sharky93> have not been able to work much today :(
  84 2013-06-19T20:50:34  <sharky93> been a rather eventful day.
  85 2013-06-19T20:55:39  <ReimarBauer> sharky93: a event driven day?
  86 2013-06-19T21:03:44  <TheSheep> sharky93: how about putting all of that file in one large document.ready?
  87 2013-06-19T21:09:01  <sharky93> TheSheep, hmm, may as well do that.
  88 2013-06-19T21:09:07  <sharky93> ReimarBauer, i did not understand
  89 2013-06-19T21:16:41  <TheSheep> sharky93: Reimar just joked
  90 2013-06-19T21:23:48  <sharky93> hmm, I see the pun now :(  ..
  91 2013-06-19T21:23:53  <sharky93> some tuning required i guess
  92 2013-06-19T21:27:32  <sharky93> TheSheep, what sense does a document.ready make inside a document.ready ?
  93 2013-06-19T21:32:55  <sharky93> TheSheep, line 251, common.js
  94 2013-06-19T21:33:00  <ReimarBauer> 22:50 < sharky93> been a rather eventful day.
  95 2013-06-19T21:33:26  <ReimarBauer> ah, TheSheep explained already
  96 2013-06-19T21:48:46  <sharky93> TheSheep, have you had a look at the image resizing stuff? any estimates in terms of time?
  97 2013-06-19T22:10:53  <TheSheep> sharky93: you only need one level of document.ready, of course
  98 2013-06-19T22:18:07  *** xjjk has joined #moin-dev
  99 2013-06-19T22:18:40  <sharky93> TheSheep, lines such as https://bitbucket.org/thomaswaldmann/moin-2.0/src/ad303592c64c1743ac218d42835493cb9d97440b/MoinMoin/templates/common.js?at=default#cl-251 cause conflicts with a single document.ready
 100 2013-06-19T22:19:48  <sharky93> TheSheep, we could fix that easily but we may not want to introduce dependencies? how about leaving that part untouched?
 101 2013-06-19T22:22:02  <TheSheep> sharky93: well, negate the condition and put the function body instead of return in that case
 102 2013-06-19T22:23:31  <sharky93> TheSheep, hmm, the fix is easy but, well, i checked again no such conditions anywhere else. okay.
 103 2013-06-19T22:25:23  *** brunomartin has quit IRC
 104 2013-06-19T22:34:39  <sharky93> TheSheep, what about the onclick @ https://bitbucket.org/thomaswaldmann/moin-2.0/src/ad303592c64c1743ac218d42835493cb9d97440b/MoinMoin/templates/modify.html?at=default#cl-26
 105 2013-06-19T22:38:10  <sharky93> TheSheep, we could use a workaround by defining the "fullname" as some attribute and then bind this.attr with the onclick event and the last global function will be dealt with.. ??
 106 2013-06-19T22:39:55  <sharky93> rather pass "this.attr" with the function which we bind
 107 2013-06-19T23:54:35  <sharky93> gn
 108 2013-06-19T23:54:42  *** sharky93 has quit IRC
 109