1 2013-06-23T03:26:19 <xiaq> spy_: hi! i have always kept an eye on that EP, but i'm busy preparing for final exams ATM :-|
2 2013-06-23T06:31:26 <TheSheep> sharky93: doesn't work too well on a small screen
3 2013-06-23T06:34:48 <TheSheep> sharky93: also, it looks worse because there are no margins
4 2013-06-23T06:35:10 <TheSheep> sharky93: and I'm sure you can make the menus have rounded corners
5 2013-06-23T06:37:42 *** spy_mob
6 2013-06-23T06:38:59 *** spy_mob
7 2013-06-23T06:54:12 <spy_> xiaq: Thanks, all the best with your final exams!
8 2013-06-23T06:55:54 <spy_> ReimarBauer: ThomasWaldmann: I'm sorry, but I completely forgot to plan today in accordance with today's meeting. So I will try hard with my cell phone.
9 2013-06-23T07:05:04 <TheSheep> sharky93: look at the listview at http://view.jquerymobile.com/1.3.1/dist/demos/
10 2013-06-23T07:05:16 <TheSheep> sharky93: they have some additional classes added for the corners
11 2013-06-23T08:15:12 *** ashutosh1461
12 2013-06-23T08:20:23 <ashutosh1461> moin
13 2013-06-23T08:21:52 <sharky93> TheSheep: yes, support for the small screen is not present in this custom layout of 20/60/20, i think we'll have to write maedia queries of our own
14 2013-06-23T08:24:20 <TheSheep> that sounds like a pain
15 2013-06-23T08:24:44 <TheSheep> there are no ready layouts that we could utilize?
16 2013-06-23T08:25:11 <TheSheep> maybe as plugins?
17 2013-06-23T08:34:40 <sharky93> TheSheep: there's a 960gs plugin, im not sure what it does.
18 2013-06-23T08:35:07 <sharky93> TheSheep: ThomasWaldmann i'll bbl. may get a bit late for the meeting . i may join around 10:15-20 UTC. Very Sorry.
19 2013-06-23T08:35:12 *** sharky93
20 2013-06-23T08:39:50 *** spy_mob
21 2013-06-23T08:39:57 *** spy_mob
22 2013-06-23T08:43:24 *** spy_mob_
23 2013-06-23T08:45:32 *** spy_mob
24 2013-06-23T08:49:44 *** spy_mob_
25 2013-06-23T09:30:37 *** sharky93
26 2013-06-23T09:31:41 <sharky93> moin
27 2013-06-23T09:54:36 <TheSheep> moin
28 2013-06-23T09:56:45 *** spy_mob
29 2013-06-23T09:57:40 <xiaq> moin
30 2013-06-23T09:59:43 <ThomasWaldmann> moin
31 2013-06-23T09:59:49 <ReimarBauer> moi
32 2013-06-23T10:00:00 <ana_ananasova> moin
33 2013-06-23T10:00:01 <ashutosh1461> moin
34 2013-06-23T10:00:54 <ThomasWaldmann> ok, welcome to our first coding phase meeting. every student/mentor pair gets about 12 minutes.
35 2013-06-23T10:01:40 <ThomasWaldmann> spy_: ReimarBauer: can you begin?
36 2013-06-23T10:01:44 <ReimarBauer> yes
37 2013-06-23T10:02:35 <ReimarBauer> spy_: please start with the report
38 2013-06-23T10:03:24 <ThomasWaldmann> hmm, maybe he's not here yet. xiaq and eSyr maybe?
39 2013-06-23T10:05:15 <ThomasWaldmann> xiaq: can you start?
40 2013-06-23T10:05:24 <ThomasWaldmann> eSyr: are you with us?
41 2013-06-23T10:06:28 <xiaq> LAST: started ticket view split, looked at xstatic packaing BLOCKER: that was very few work. i'm preparing for my final exams... NEXT: final exams finish at 29th, so perhaps no much work next week :-|
42 2013-06-23T10:07:22 <ThomasWaldmann> any questions about xstatic?
43 2013-06-23T10:07:28 <ThomasWaldmann> or other stuff?
44 2013-06-23T10:08:11 <xiaq> ThomasWaldmann: not yet
45 2013-06-23T10:08:19 <ThomasWaldmann> xiaq: you should also clone the moin-2.0 repo on BB and link it from https://moinmo.in/GoogleSoc2013/
46 2013-06-23T10:09:11 <ThomasWaldmann> were your exams shifted somehow by date?
47 2013-06-23T10:09:14 <xiaq> fixed
48 2013-06-23T10:09:33 * ReimarBauer all the best with your final exam
49 2013-06-23T10:10:00 <xiaq> ah, yes. i got wrong news when writing the proposal
50 2013-06-23T10:10:03 *** sharky93
51 2013-06-23T10:10:43 <xiaq> ReimarBauer: thx :)
52 2013-06-23T10:10:58 <ThomasWaldmann> ok. all the best. you'll catch up after your exams. if there is discussion need, I'ld suggest you start this in parallel to your preparations, though.
53 2013-06-23T10:11:13 <ThomasWaldmann> (because discussions take time ...)
54 2013-06-23T10:11:59 <xiaq> ThomasWaldmann: got it
55 2013-06-23T10:12:13 <ThomasWaldmann> spy_: you tell us when you join us here
56 2013-06-23T10:12:45 <ThomasWaldmann> ReimarBauer: any questions left?
57 2013-06-23T10:13:10 <ThomasWaldmann> (or from any other mentor/student to xiaq?)
58 2013-06-23T10:13:11 <ReimarBauer> not now
59 2013-06-23T10:13:50 <ThomasWaldmann> ok, thanks xiaq / ReimarBauer
60 2013-06-23T10:14:25 <ThomasWaldmann> sharky93_: TheSheep: your stage
61 2013-06-23T10:15:44 <TheSheep> ThomasWaldmann: sharky just left, he will be back in 15 minutes, should I summarize what we did?
62 2013-06-23T10:15:55 <TheSheep> .oO( this meeting is in shambles :( )
63 2013-06-23T10:15:57 <ThomasWaldmann> oops, missed that
64 2013-06-23T10:16:10 <ThomasWaldmann> ok, ana_ananasova / waldi: can you start?
65 2013-06-23T10:16:16 <ana_ananasova> yep
66 2013-06-23T10:16:22 <ana_ananasova> DONE:
67 2013-06-23T10:16:33 <ana_ananasova> * Coded storing subscribers to the content item meta. Had a codereview. Eventually throw-away code.
68 2013-06-23T10:16:39 <ana_ananasova> * Discussions/decisions on determining the list of subscribers by storing to the user profile meta and using whoosh index
69 2013-06-23T10:16:57 <ana_ananasova> * Started coding the part with storing subscription_ids
70 2013-06-23T10:17:07 <ana_ananasova> TODO next week:
71 2013-06-23T10:17:17 <ana_ananasova> * Tests, code part B and cr - subscription_patterns
72 2013-06-23T10:17:23 <ana_ananasova> * Change the User subscribe tests, methods. cr
73 2013-06-23T10:17:38 <ana_ananasova> * Notification/signalling on item modification/create/rename/destroy
74 2013-06-23T10:17:53 <ana_ananasova> * Start prepare the templates for mail notifications
75 2013-06-23T10:18:01 <ana_ananasova> the end
76 2013-06-23T10:18:08 <ThomasWaldmann> :D
77 2013-06-23T10:18:23 <ThomasWaldmann> that mean BLOCKERS: None?
78 2013-06-23T10:18:53 <ana_ananasova> none specific or related to somebody's else work
79 2013-06-23T10:19:18 <ReimarBauer> the cr is this one? https://codereview.appspot.com/10386044/
80 2013-06-23T10:19:21 *** spy_mob
81 2013-06-23T10:19:29 <ThomasWaldmann> waldi: are you here? any questions? anybody else has questions for ana_ananasova?
82 2013-06-23T10:20:03 <ana_ananasova> ReimarBauer: yes
83 2013-06-23T10:20:51 <ThomasWaldmann> that CR wasn't much - keep us updated with regular CRs
84 2013-06-23T10:20:59 * ReimarBauer has no usecase for "Apparently user can subscribe to non-existing items."
85 2013-06-23T10:21:28 *** sharky93_
86 2013-06-23T10:21:36 <ReimarBauer> is that a bug?
87 2013-06-23T10:21:41 <ReimarBauer> or feature?
88 2013-06-23T10:22:17 <ashutosh1461> ReimarBauer, has to be a bug
89 2013-06-23T10:22:20 <ana_ananasova> ReimarBauer: the cr is already not relevant - we won't be storing subscribers to content item meta
90 2013-06-23T10:22:21 <ThomasWaldmann> if we'll support pattern subscription, you can subsribe to NAME .* (that includes yet-to-be-created items)
91 2013-06-23T10:23:05 <ThomasWaldmann> ReimarBauer: the EP is more interesting, it has rather specific pseudo code
92 2013-06-23T10:23:22 <ana_ananasova> here http://etherpad.osuosl.org/moin-mail
93 2013-06-23T10:23:46 <ReimarBauer> is meta stored after data and can an item accessed if meta is empty or while storing meta
94 2013-06-23T10:23:57 <ThomasWaldmann> (and it looks like we can finally solve that slowness / scalability issue)
95 2013-06-23T10:24:28 <ReimarBauer> if data can be accessed someone may get notified on protected content
96 2013-06-23T10:24:42 <ThomasWaldmann> you can't find an item before meta is indexed, and that happens last
97 2013-06-23T10:24:49 <ReimarBauer> ok
98 2013-06-23T10:25:28 <ThomasWaldmann> anything else?
99 2013-06-23T10:25:40 <ThomasWaldmann> sharky93: are you there now?
100 2013-06-23T10:26:01 <sharky93> ThomasWaldmann: yes, just got back
101 2013-06-23T10:26:01 * ReimarBauer reads EP - not now
102 2013-06-23T10:26:09 *** spy_mob
103 2013-06-23T10:26:45 <ThomasWaldmann> ok, so thanks to ana_ananasova, sharky93 / TheSheep is next
104 2013-06-23T10:27:12 <sharky93> DONE is @ http://etherpad.osuosl.org/moin-ui, line 235+
105 2013-06-23T10:27:23 * ThomasWaldmann added a weekly reminder into his (android) phone for sun 10:00 utc
106 2013-06-23T10:27:35 <sharky93> Pushed 3 commits to local repo after cr @ https://bitbucket.org/sharky93/moin-2.0/commits/all
107 2013-06-23T10:28:56 <sharky93> The main task for the current week is fixing the resizing for images, transclusions.
108 2013-06-23T10:29:06 <ThomasWaldmann> sharky93: you fixed all stuff the js linter found?
109 2013-06-23T10:29:15 <sharky93> ThomasWaldmann: yes
110 2013-06-23T10:29:29 <ThomasWaldmann> great :)
111 2013-06-23T10:30:15 <ThomasWaldmann> sharky93: and also work on framework planning next week?
112 2013-06-23T10:30:30 <sharky93> i made diary entries which show some problems we faced and the solution implemented.
113 2013-06-23T10:30:36 <ReimarBauer> i am not sure if you have all the recent version of that linter, it may a good idea to verify that
114 2013-06-23T10:31:02 <sharky93> ReimarBauer: i used jslint.com
115 2013-06-23T10:31:14 <sharky93> that shows edition 31st May '13
116 2013-06-23T10:31:36 <ThomasWaldmann> sharky93: did you test (manually or else) that the code still works?
117 2013-06-23T10:31:48 <sharky93> ThomasWaldmann: yes, i tested manually.
118 2013-06-23T10:32:48 <ReimarBauer> https://github.com/douglascrockford/JSLint
119 2013-06-23T10:33:17 <ThomasWaldmann> (we should try to decide on framewok asap or we'll be blocked by that after next week)
120 2013-06-23T10:34:06 <ThomasWaldmann> ok, any other questions for sharky93 / TheSheep ?
121 2013-06-23T10:34:17 <ThomasWaldmann> spy_mob: you are with us?
122 2013-06-23T10:34:17 <sharky93> ThomasWaldmann: TheSheep the framework planning is a major task ..
123 2013-06-23T10:34:31 <sharky93> I feel that is bit of a blocker
124 2013-06-23T10:34:59 <TheSheep> sharky93: well, you still have some work for this week, but it will surely become a blocker next week
125 2013-06-23T10:35:01 * sharky93 just noticed thomas mentioned the same :)
126 2013-06-23T10:35:10 <spy_mob> Yes
127 2013-06-23T10:35:26 <TheSheep> to be honest, I'm not entirely sure what we should do though
128 2013-06-23T10:35:50 <TheSheep> perhaps more detailed mockups
129 2013-06-23T10:36:08 <TheSheep> to see if jquery-mobile can be used the way we want it
130 2013-06-23T10:36:31 <ThomasWaldmann> yeah, every framework seems to have its own issues
131 2013-06-23T10:36:56 <ThomasWaldmann> if some other mentor / student has ideas about that, feedback would be welcome!
132 2013-06-23T10:37:23 <ThomasWaldmann> http://etherpad.osuosl.org/moin-ui see framework stuff there
133 2013-06-23T10:37:44 <ThomasWaldmann> ok, looks like we are through, thanks sharky93 / TheSheep
134 2013-06-23T10:38:00 <ThomasWaldmann> spy_mob: ReimarBauer: your stage
135 2013-06-23T10:38:28 <spy_mob> DONE: discussed key features of the comment system on EP, started to implement a new contentfull itemtype to be used for comment items (will help to find many other pitfalls to be discussed).
136 2013-06-23T10:40:01 <ThomasWaldmann> btw ashutosh1461: spy_mob will need itemid addressability for comments
137 2013-06-23T10:41:42 *** ashutosh1461
138 2013-06-23T10:42:05 <ThomasWaldmann> spy_mob: BLOCKERS/NEXT?
139 2013-06-23T10:42:05 *** ashutosh1461
140 2013-06-23T10:42:24 <ashutosh1461> ThomasWaldmann, no worries, soon we should be able to do that :D
141 2013-06-23T10:43:16 <spy_mob> BLOCKED nameless items and access by itemid (maybe it is not a blocker). I will try to emulate this, first create a new item with some unique name and then put its itemid into the name, then access by that name (==itemid).
142 2013-06-23T10:44:22 <spy_mob> TODO customize +show view, add a simple form for creating a comment (only one level, no threads).
143 2013-06-23T10:44:45 <ThomasWaldmann> spy_mob: btw, i left some comments on your EP yesterday
144 2013-06-23T10:45:02 <spy_mob> Great, will see soon
145 2013-06-23T10:46:32 <ashutosh1461> spy_mob, i am working on it (accessing by itemid), will report it to you when the job gets done.
146 2013-06-23T10:47:17 <ReimarBauer> spy_mob: have you worked on a list which views should have this feature?
147 2013-06-23T10:47:42 <ThomasWaldmann> spy_mob: hmm, that "show" view, will it every directly be used?
148 2013-06-23T10:48:09 <ThomasWaldmann> i mean, on usually visits the content items and comments are somehow expected to be below them.
149 2013-06-23T10:48:27 <ThomasWaldmann> s/every/ever/
150 2013-06-23T10:50:32 <spy_mob> Do you mean to have different ways to show the page with or without comments?
151 2013-06-23T10:51:35 <ThomasWaldmann> could be collapsible
152 2013-06-23T10:51:50 <ThomasWaldmann> or loaded on demand
153 2013-06-23T10:51:53 <spy_mob> Reimar: not yet
154 2013-06-23T10:53:11 <spy_mob> Using Ajax queries it is possible to load on demand on the same view
155 2013-06-23T10:53:21 <ThomasWaldmann> btw, that ACL discussion need more thoughts iirc
156 2013-06-23T10:53:53 <spy_mob> Totally agree
157 2013-06-23T10:55:23 <ThomasWaldmann> spy_mob: btw, as you want to search for all comments that comment on a specific content item anyway, you can get all those random names you chose in the search results
158 2013-06-23T10:55:47 <ThomasWaldmann> so you can address by them and don't need to do tricks with itemid
159 2013-06-23T10:55:58 <ThomasWaldmann> (like putting it into name)
160 2013-06-23T10:56:13 <spy_mob> Just want to have a basic implementation to understand better what we already have and have to do,
161 2013-06-23T10:56:59 <ThomasWaldmann> ok, anything else for spy_mob ?
162 2013-06-23T10:57:12 <ReimarBauer> ok
163 2013-06-23T10:57:33 * ReimarBauer not now
164 2013-06-23T10:57:51 <ThomasWaldmann> ok, last but not least: ashutosh1461 (and me). ashutosh1461: your stage
165 2013-06-23T10:58:01 <ashutosh1461> ok
166 2013-06-23T10:58:28 <ashutosh1461> DONE LAST WEEK
167 2013-06-23T10:58:29 <ashutosh1461> Discussions on what composite name should be?
168 2013-06-23T10:58:29 <ashutosh1461> FIXED interwiki.py
169 2013-06-23T10:58:29 <ashutosh1461> FIXED tests_interwiki.py
170 2013-06-23T10:58:29 <ashutosh1461> - did changes as suggestions to the cr
171 2013-06-23T10:58:29 <ashutosh1461> did changes in the items/__init__.py file
172 2013-06-23T10:58:49 <ashutosh1461> TODO
173 2013-06-23T10:58:49 <ashutosh1461> READ ABOUT REST/SPHINX MARKUP
174 2013-06-23T10:58:49 <ashutosh1461> Complete fixing items/__init__.py file
175 2013-06-23T10:58:49 <ashutosh1461> Fix all the views
176 2013-06-23T10:58:49 <ashutosh1461> Start Validation stuff
177 2013-06-23T11:00:09 <ThomasWaldmann> "FIXED interwiki" sounds much like finished, but I only saw one codereview that had more todo and no final thing yet.
178 2013-06-23T11:00:49 <ThomasWaldmann> so, if you did more work afterwards, I suggest you update the same codereview (use same id)
179 2013-06-23T11:01:45 <ashutosh1461> ThomasWaldmann, yes, i did some changes after your comments, will upload it to the cr.
180 2013-06-23T11:01:53 <ThomasWaldmann> and try to do small, clean, relatively frequent commits
181 2013-06-23T11:03:11 <ThomasWaldmann> and no "fixing all the views" until on view is completely finished, reviewed, approved and committed.
182 2013-06-23T11:03:16 <ThomasWaldmann> one*
183 2013-06-23T11:04:09 <ashutosh1461> got it.
184 2013-06-23T11:04:12 <ThomasWaldmann> ashutosh1461: give link to your ep / codereview
185 2013-06-23T11:04:20 <ThomasWaldmann> (so others can have a look)
186 2013-06-23T11:04:33 <ashutosh1461> EP http://etherpad.osuosl.org/moin-itemid
187 2013-06-23T11:04:33 <ReimarBauer> yeah no mass commit of several solutions
188 2013-06-23T11:04:57 <ashutosh1461> cr for interwiki https://codereview.appspot.com/10439044/
189 2013-06-23T11:06:00 <ThomasWaldmann> http://server/[NAMESPACE/][[@FIELD/]NAME][/+VIEW] somehow like that is the currently planned url layout
190 2013-06-23T11:06:30 <ThomasWaldmann> [NAMESPACE/][[@FIELD/]NAME] is called "composite name"
191 2013-06-23T11:07:55 <ThomasWaldmann> could be something like: research/projectX, research/@tags/todo, research/subspace/ProjectY
192 2013-06-23T11:08:38 <ThomasWaldmann> research and research/subspace being namespaces, todo being a tag, projectX/Y being a item name
193 2013-06-23T11:09:12 <ThomasWaldmann> research/@itemid/123456780abcdef.... would also work
194 2013-06-23T11:11:39 <ThomasWaldmann> ashutosh1461: you can also look at moin2 docs (or even create them yourself locally) to see some good rendered docstrings and how docstrings with wrong markup look like
195 2013-06-23T11:12:21 <ThomasWaldmann> btw, what plan for "fixing items __init__ are you following currently"?
196 2013-06-23T11:12:41 <ThomasWaldmann> questions from other students/mentors to ashutosh1461 / me?
197 2013-06-23T11:13:15 <ashutosh1461> making DummyItem / DummyRev / get_storage_rev, _save and other functions compatible with fqnames
198 2013-06-23T11:14:38 * ThomasWaldmann hopes you don't want to mix that all you have done yet + all what you will have to do to get that into a good state into a single commit
199 2013-06-23T11:16:24 <ashutosh1461> sure, i will finalize the interwiki stuff and do a commit for that first.
200 2013-06-23T11:16:46 <ReimarBauer> and a final review too
201 2013-06-23T11:17:17 <ThomasWaldmann> ok, seems there are no questions. and we are through with all projects for today. thanks to everybody who managed to be here.
202 2013-06-23T11:17:37 <ThomasWaldmann> random discussions now :)
203 2013-06-23T11:19:48 <ThomasWaldmann> http://pythonbooks.revolunet.com/ found that yesterday btw
204 2013-06-23T11:20:10 <ashutosh1461> ThomasWaldmann, we would not like to do validation in interwiki.py file if something in @itemid/Something is someitemid or somepage ?
205 2013-06-23T11:22:37 <ThomasWaldmann> if you say @itemid/ it has to be an itemid
206 2013-06-23T11:24:16 <ThomasWaldmann> if it is wrong, it won't work (like if you spell a name wrong if a name was required)
207 2013-06-23T11:24:35 <ashutosh1461> yes, but the validation can be later ? right same thing about rejecting name involving a '@'
208 2013-06-23T11:26:12 <ThomasWaldmann> validation is esp. needed for stuff we store into metadata (like e.g. that an email address in a userprofile is really an email and not just rubbish)
209 2013-06-23T11:27:05 <eSyr> oh, sorry, missed the meeting. so, we settled with sunday 14:00?
210 2013-06-23T11:27:39 <ThomasWaldmann> in the user-edited data (content), we can't validate much. but we can validate e.g. that for text, decoding with the specified charset does not crash.
211 2013-06-23T11:27:46 <ThomasWaldmann> eSyr: 10:00 utc, yes
212 2013-06-23T11:28:06 <ThomasWaldmann> you got a notify from the GoogleSoc2013 about it
213 2013-06-23T11:28:17 <ThomasWaldmann> (but you get many notifies... :)
214 2013-06-23T11:29:19 <ThomasWaldmann> but xiaq is maybe still here, so ...
215 2013-06-23T11:33:43 *** sharkyraj_
216 2013-06-23T12:22:19 <ashutosh1461> ThomasWaldmann, updated https://codereview.appspot.com/10439044/
217 2013-06-23T12:38:09 * ThomasWaldmann will be rather busy for the rest of the day...
218 2013-06-23T12:50:33 <ThomasWaldmann> eSyr: ReimarBauer: waldi: ^ can you have a look?
219 2013-06-23T13:33:46 *** ashutosh1461
220 2013-06-23T13:39:34 *** spy_mob
221 2013-06-23T13:39:51 *** spy_mob
222 2013-06-23T13:48:20 <sharky93> ThomasWaldmann: the Issue Number TBD in the last comment @ https://bitbucket.org/thomaswaldmann/moin-2.0/issue/340/image-scaling-markup-does-not-work is #360
223 2013-06-23T13:55:21 *** dav1d
224 2013-06-23T13:55:33 *** dav1dde
225 2013-06-23T13:59:45 *** spy_mob
226 2013-06-23T13:59:59 *** spy_mob
227 2013-06-23T14:33:55 *** spy_mob
228 2013-06-23T14:34:11 *** spy_mob
229 2013-06-23T14:35:43 <ThomasWaldmann> sharky93: you know what TBD means?
230 2013-06-23T14:46:52 <sharky93> ThomasWaldmann: to be decided?
231 2013-06-23T14:48:12 <sharky93> i mean its already fixed but if someone browses the comment it helps in the continuity
232 2013-06-23T14:48:27 *** ana_ananasova
233 2013-06-23T14:49:22 *** ana_ananasova
234 2013-06-23T14:50:45 <ana_ananasova> ThomasWaldmann: if you have a minute - please take a look - http://rn0.ru/show/iUgCewKXWbOzw0f6YZZM/
235 2013-06-23T14:52:42 <ana_ananasova> the return values from the function are newly created User objects (which are in a different memory location)
236 2013-06-23T14:53:49 <ana_ananasova> and so `assert expected_users == users` doesn't work in this case.
237 2013-06-23T14:54:16 <ana_ananasova> is there a better way? not checking the itemids of the objects.
238 2013-06-23T15:03:31 *** bilal
239 2013-06-23T15:18:37 <sharky93> how do we trigger PIL by the URL?
240 2013-06-23T15:38:00 *** spy_mob
241 2013-06-23T15:43:43 *** sharky93_
242 2013-06-23T15:59:42 *** greg_f
243 2013-06-23T16:00:41 <TheSheep> sharky93: I didn't have internet access, I should be home in 1.5h
244 2013-06-23T16:37:13 *** spy_mob
245 2013-06-23T16:40:46 *** spy_mob_
246 2013-06-23T16:40:46 *** spy_mob
247 2013-06-23T16:53:44 *** bilal
248 2013-06-23T17:22:47 *** ashutosh1461
249 2013-06-23T17:22:48 *** spy_mob_
250 2013-06-23T17:22:52 *** ashutosh1461
251 2013-06-23T17:23:09 *** ashu1461
252 2013-06-23T17:25:55 <ashu_s> ThomasWaldmann, what to use instead of name ? id or identifier or value ?
253 2013-06-23T17:29:17 <TheSheep> sharky93: re
254 2013-06-23T17:34:53 <TheSheep> sharky93: what's the problem?
255 2013-06-23T17:41:53 *** spy_mob_
256 2013-06-23T17:46:38 *** spy_mob_
257 2013-06-23T18:04:51 *** greg_f
258 2013-06-23T18:21:29 <sharky93> TheSheep: ThomasWaldmann so for the resizing issue, there are two ways to solve it. Lines 9-22 @ http://etherpad.osuosl.org/moin-ui
259 2013-06-23T18:24:18 <TheSheep> sharky93: read the lines 26-32 again
260 2013-06-23T18:28:48 <sharky93> TheSheep: yeah, i meant to clarify that itself :) .. lines 26-32 hint at the first method, we going with it?
261 2013-06-23T18:35:14 <TheSheep> sharky93: it's easy to change later anyways
262 2013-06-23T18:37:14 *** ashu_s
263 2013-06-23T18:43:55 *** ashu_s
264 2013-06-23T18:54:02 <sharky93> TheSheep: so the first step is getting to parse the '&' since moin's current parser ignores it.
265 2013-06-23T18:55:40 <TheSheep> yup
266 2013-06-23T18:57:49 <sharky93> TheSheep: lets take an example,
267 2013-06-23T18:58:56 <sharky93> suppose we parse '&w=100,&h=100' .. this becomes { '&w' : 100, '&h' : 100 } in the dictionary of args
268 2013-06-23T19:01:36 <sharky93> but in cases we parse 'width=100, height=100', we do not want to form query strings with such values.. since there's no '&' and we dont want them to get into the qs.
269 2013-06-23T19:01:50 <sharky93> strikeout 'we'
270 2013-06-23T19:02:25 <sharky93> arrgh.
271 2013-06-23T19:02:58 <sharky93> TheSheep: i refer to the function @ https://bitbucket.org/thomaswaldmann/moin-2.0/src/ad303592c64c1743ac218d42835493cb9d97440b/MoinMoin/converter/moinwiki_in.py?at=default#cl-828
272 2013-06-23T19:03:26 <TheSheep> basically you want all arguments that start with & to be put in the query string, with the & stripped
273 2013-06-23T19:11:08 <sharky93> TheSheep: yep, so how do we handle the other case. where we have arguments but dont want them in the qs. instead we want them as html attributes.
274 2013-06-23T19:17:12 <TheSheep> sharky93: it's already handled, no?
275 2013-06-23T19:18:09 <TheSheep> sharky93: all the attributes that don't have a & go into the html tag? maybe with a whitelist of allowed attribute names, just to be safe
276 2013-06-23T19:18:32 <TheSheep> you don't want people to put onclick in there
277 2013-06-23T19:20:28 <sharky93> TheSheep: no its not handled.
278 2013-06-23T19:21:33 <sharky93> TheSheep: yes i too think there should be a whitelist. But that case is not handled.
279 2013-06-23T19:22:44 <TheSheep> it was in moin1
280 2013-06-23T19:22:51 <TheSheep> I may be mixing it up
281 2013-06-23T19:27:47 <sharky93> TheSheep: yeah, it worked i think in moin1.9 but has not been handled in moin2
282 2013-06-23T19:33:41 <sharky93> TheSheep: so how do we treat that case?
283 2013-06-23T19:34:28 <TheSheep> sharky93: you put the attribues that are listed in the whitelist in the tag
284 2013-06-23T19:34:46 <TheSheep> sharky93: or did you mean something else?
285 2013-06-23T19:36:00 *** xiaq
286 2013-06-23T19:36:41 *** xiaq
287 2013-06-23T19:37:07 *** xiaq
288 2013-06-23T19:52:00 <sharky93> TheSheep: i mean, after we decide what goes into the query and what does not go .. we put the former in the "query" and have that as a parameter we can access as part of the IRI object
289 2013-06-23T19:52:47 <sharky93> TheSheep: how to handle the later case?, we introduce a new parameter in the object?
290 2013-06-23T19:53:11 <TheSheep> what object?
291 2013-06-23T19:55:32 <sharky93> this function @ https://bitbucket.org/thomaswaldmann/moin-2.0/src/ad303592c64c1743ac218d42835493cb9d97440b/MoinMoin/converter/moinwiki_in.py?at=default#cl-828
292 2013-06-23T19:55:38 <sharky93> i refer to line 840
293 2013-06-23T19:56:21 <sharky93> we can add a query, but we do not want other attributes to go there.
294 2013-06-23T19:58:07 <TheSheep> sharky93: I don't think I get what you mean
295 2013-06-23T19:58:16 <TheSheep> sharky93: it has to go into the generated tag
296 2013-06-23T19:58:47 <TheSheep> sharky93: so, once you have changed it to use <img>, it would be <img href="..." width="..." height="...">
297 2013-06-23T19:59:16 <TheSheep> sharky93: only the &-parameters go into the href, the rest (whitelisted) goes into attributes of themselves
298 2013-06-23T19:59:42 <TheSheep> sharky93: what's the doubt in there?
299 2013-06-23T20:01:39 <sharky93> TheSheep: the doubt is simply what method to use to get that in there :)
300 2013-06-23T20:02:16 <TheSheep> sharky93: is there a choice?
301 2013-06-23T20:02:37 <sharky93> this final conversion happens in html_out .. so we have to get this information till there.
302 2013-06-23T20:02:57 <TheSheep> ok?
303 2013-06-23T20:03:28 <sharky93> i was wondering about how to represent this in moin's internal represation of the DOM
304 2013-06-23T20:03:36 <sharky93> *representation
305 2013-06-23T20:03:45 <TheSheep> as attributes of the nodes, perhpas?
306 2013-06-23T20:03:48 <TheSheep> perhaps?
307 2013-06-23T20:08:20 <sharky93> hmm
308 2013-06-23T20:08:34 <sharky93> could you explain the Iri() line?
309 2013-06-23T20:09:34 <TheSheep> it creates a new Iri object and assigns it to target
310 2013-06-23T20:10:20 <TheSheep> Iri is an object responsible for generating URLs
311 2013-06-23T20:10:30 <sharky93> so our solution will involve introducing a new variable in this object
312 2013-06-23T20:10:55 <TheSheep> in Iri? no!
313 2013-06-23T20:11:04 <TheSheep> that's what goes into the href
314 2013-06-23T20:11:14 <TheSheep> why would you want to put tag attributes into the href?
315 2013-06-23T20:11:58 <sharky93> hmm, i missed the 'responsible for generating URL's' part .
316 2013-06-23T20:13:26 <TheSheep> the tree element is created in line 845
317 2013-06-23T20:13:34 <TheSheep> 844 actually
318 2013-06-23T20:13:43 <TheSheep> but that's an include
319 2013-06-23T20:14:49 <TheSheep> line 854 creates an img tag
320 2013-06-23T20:14:52 <TheSheep> I suppose
321 2013-06-23T20:15:12 <TheSheep> or rather an <object> tag
322 2013-06-23T20:15:27 <TheSheep> that is later handled by the emitter
323 2013-06-23T20:30:04 <sharky93> TheSheep: so we somehow have to extend the attributes which are being added
324 2013-06-23T20:30:15 <sharky93> currently its's only the 'href' being added.
325 2013-06-23T20:30:34 *** ashu_s
326 2013-06-23T20:30:38 <sharky93> i.e extend line 843
327 2013-06-23T20:33:53 <TheSheep> sure, just add them to the dict
328 2013-06-23T20:36:38 <sharky93> TheSheep: is there an expected way to do it? like using 'xinclude.width/height' maybe?
329 2013-06-23T20:37:21 <sharky93> like "xinclude.href"
330 2013-06-23T20:46:33 <TheSheep> include doesn't have width and height, as far as I know
331 2013-06-23T20:48:32 <sharky93> TheSheep: so we just add the pairs?
332 2013-06-23T20:50:37 <TheSheep> but it won't work with include
333 2013-06-23T20:55:31 <sharky93> TheSheep: then how to add it to the tree?
334 2013-06-23T20:58:31 <TheSheep> sharky93: as ThomasWaldmann commented in that issue, first you need to make the separate change to use img
335 2013-06-23T21:01:01 <sharky93> TheSheep: you mean handling svg by img?
336 2013-06-23T21:01:27 <TheSheep> hmm, or maybe not
337 2013-06-23T21:01:41 <TheSheep> I guess you sould try just adding it and see what happens
338 2013-06-23T21:01:48 <TheSheep> if you don't get an error, we can go with that
339 2013-06-23T21:02:01 <sharky93> TheSheep: that is done already
340 2013-06-23T21:02:09 <sharky93> TheSheep: have a look @ https://bitbucket.org/thomaswaldmann/moin-2.0/issue/360
341 2013-06-23T21:02:26 <TheSheep> ah, cool
342 2013-06-23T21:02:51 <sharky93> that is why i had asked thomas to change the TBD
343 2013-06-23T21:03:58 <sharky93> TheSheep: so back to how do we add it to the tree? :)
344 2013-06-23T21:07:22 <TheSheep> sharky93: try to just add the attributes to the include, maybe it will work
345 2013-06-23T21:10:01 <sharky93> TheSheep: just in case it doesnt work that way ..
346 2013-06-23T21:12:18 <TheSheep> then I guess we use the moin_page.object or something, and add the code to handle it on the other side
347 2013-06-23T21:49:15 *** ashutosh1461
348 2013-06-23T22:50:40 *** ashutosh1461
349 2013-06-23T22:59:37 <sharky93> gn
