MoinMoin: MoinMoinChat/Logs/moin-dev/2013-06-26

   1 2013-06-26T00:23:45  *** allure has joined #moin-dev
   2 2013-06-26T00:23:45  *** allure has joined #moin-dev
   3 2013-06-26T00:32:53  *** diofeher has joined #moin-dev
   4 2013-06-26T00:46:22  *** allure has quit IRC
   5 2013-06-26T01:23:11  *** diofeher has quit IRC
   6 2013-06-26T02:33:07  *** kolyaflash has joined #moin-dev
   7 2013-06-26T02:47:29  *** xiaq_ is now known as xiaq
   8 2013-06-26T03:01:35  *** bilal has quit IRC
   9 2013-06-26T03:39:23  *** kolyaflash has quit IRC
  10 2013-06-26T03:50:10  *** ashutosh1461 has joined #moin-dev
  11 2013-06-26T04:40:33  <sharky93> moin
  12 2013-06-26T05:15:39  *** GummiBear has joined #moin-dev
  13 2013-06-26T05:31:43  <ashutosh1461> ThomasWaldmann, replied to your comments https://codereview.appspot.com/10519045/diff/7001/MoinMoin/items/__init__.py
  14 2013-06-26T06:36:00  *** kolyaflash has joined #moin-dev
  15 2013-06-26T07:46:53  *** kolyaflash has quit IRC
  16 2013-06-26T08:39:55  <sharky93> TheSheep: test cr for resizing @ https://codereview.appspot.com/10599043/
  17 2013-06-26T08:40:36  <sharky93> TheSheep: i've added a width parameter just for testing the method i use, it works.
  18 2013-06-26T08:40:59  *** kolyaflash has joined #moin-dev
  19 2013-06-26T08:43:00  <sharky93> TheSheep: please ignore pep8 errors, this is just for the method
  20 2013-06-26T08:45:26  <TheSheep> sharky93: xlink.width?
  21 2013-06-26T08:45:33  <TheSheep> sharky93: why xlink?
  22 2013-06-26T08:49:06  <TheSheep> sharky93: I don't quite get what you are trying to do around line 347 of the include.py, care to elaborate?
  23 2013-06-26T08:59:47  <ThomasWaldmann> ashutosh1461: i don't see replies, did you forget to submit them?
  24 2013-06-26T09:01:00  <ashutosh1461> ThomasWaldmann, done
  25 2013-06-26T09:09:18  <ana_ananasova> ThomasWaldmann: left some comments and uploaded a patch - https://codereview.appspot.com/10537043/
  26 2013-06-26T09:19:16  *** greg_f has joined #moin-dev
  27 2013-06-26T09:29:21  <ThomasWaldmann> ana_ananasova: review done
  28 2013-06-26T09:32:50  <ana_ananasova> did you publish the comments? i see nothing
  29 2013-06-26T09:34:54  <sharky93> TheSheep: around line 347 the querystring of the object is updated and contains the revid etc, i am adding the qs we parsed from the user and adding that to it.
  30 2013-06-26T09:37:51  <sharky93> TheSheep: as is, after expanding the include, we convert its attibutes to the xlink ns, like is done in the image converter.., so followed the continuity like is done in  line 194 in include.py
  31 2013-06-26T09:48:27  <ThomasWaldmann> too many students starting with "a". that was for ashutosh1461.
  32 2013-06-26T09:48:44  <ThomasWaldmann> ana_ananasova: your review is done now also. :)
  33 2013-06-26T09:49:08  <ashutosh1461> ThomasWaldmann, yes checked it out :)
  34 2013-06-26T09:49:48  <TheSheep> sharky93: why is it done in the include, and not in the moinwiki_in?
  35 2013-06-26T09:52:01  <sharky93> TheSheep: you mean adding the qs?, it is done in moinwiki_in too.. but the image converter loses it which is called @ line 346 include.py
  36 2013-06-26T09:52:38  <sharky93> TheSheep: i can maybe lookup adding that stuff to the image converter itself.. should we do that instead?
  37 2013-06-26T09:54:19  <TheSheep> sharky93: sounds less hacky
  38 2013-06-26T09:54:24  <TheSheep> sharky93: or even make it not lose it
  39 2013-06-26T09:56:23  <sharky93> TheSheep: yes, if we add it to the image converter, i think there'll be no phase in which it loses it.
  40 2013-06-26T10:27:41  *** ana_ananasova is now known as pineapple_ostric
  41 2013-06-26T10:29:04  *** pineapple_ostric is now known as pineapple_narwha
  42 2013-06-26T10:31:25  *** pineapple_narwha is now known as pineapple_koala
  43 2013-06-26T10:31:46  <pineapple_koala> and now there won't be any name collisions
  44 2013-06-26T10:38:38  <ashutosh1461> ThomasWaldmann, updated https://codereview.appspot.com/10439044
  45 2013-06-26T11:19:30  *** greg_f has quit IRC
  46 2013-06-26T11:20:08  *** greg_f has joined #moin-dev
  47 2013-06-26T12:15:09  <GummiBear> sharky93: ping!
  48 2013-06-26T12:17:13  <sharky93> GummiBear: pong! :)
  49 2013-06-26T12:19:31  <GummiBear> I installed nginx and stopped apache .. so your jqm demo is not working for now. I will fix that.
  50 2013-06-26T12:20:19  <TheSheep> sharky93: btw, you can host static files on bitbucket
  51 2013-06-26T12:21:28  <TheSheep> sharky93: https://confluence.atlassian.com/display/BITBUCKET/Publishing+a+Website+on+Bitbucket
  52 2013-06-26T12:22:28  <GummiBear> TheSheep: I was suggesting github pages earlier :-)
  53 2013-06-26T12:23:20  <sharky93> GummiBear: ah, no problem. nginx cool!, i'll take a peek later :)
  54 2013-06-26T12:23:40  <GummiBear> Ok.
  55 2013-06-26T12:24:28  <sharky93> TheSheep: i'll have a look at that too.. it is just that somehow i dont like git :P
  56 2013-06-26T12:25:10  <GummiBear> sharky93: The bickbucket one supports hg too :-P
  57 2013-06-26T12:25:31  <sharky93> GummiBear: see that's what im talking about :P
  58 2013-06-26T12:26:08  <GummiBear> Reading that article .. it works exactly similar to github pages.
  59 2013-06-26T12:26:32  <sharky93> alias hg git :P
  60 2013-06-26T12:27:10  <TheSheep> sharky93: then use hg
  61 2013-06-26T12:27:51  <TheSheep> GummiBear: except that bitbucket lets you use mercurial and dosn't have as nazi tos as github
  62 2013-06-26T12:29:03  <sharky93> ^ +1
  63 2013-06-26T12:30:19  <GummiBear> Hmm.
  64 2013-06-26T12:30:26  <sharky93> TheSheep: i meant i hate github.., i kinda assumed that bitbucket is hg :P
  65 2013-06-26T12:32:40  <GummiBear> sharky93: I'm trying out mosh too :) Feels a lot better than ssh :-D
  66 2013-06-26T12:32:41  <TheSheep> it has both git and hg
  67 2013-06-26T12:33:15  <GummiBear> I somehow find bitbucket's UI more confusing than github
  68 2013-06-26T12:33:55  <GummiBear> But may be that's because I haven't used it enough.
  69 2013-06-26T12:34:03  <sharky93> GummiBear: necessity is the mother of invention :P
  70 2013-06-26T12:34:24  <TheSheep> GummiBear: switch github to the new ui and you will no longer have that problem :)
  71 2013-06-26T12:34:32  <sharky93> ^ hehe
  72 2013-06-26T12:34:33  <GummiBear> But I love the fact that they give you free private repos \o/
  73 2013-06-26T12:34:45  <sharky93> yeah, that's a big plus!
  74 2013-06-26T12:35:51  <sharky93> GummiBear: are you still in contact with the ninja clan?
  75 2013-06-26T12:37:25  <GummiBear> sharky93: Do a whois on me you'll know xD
  76 2013-06-26T12:39:02  <sharky93> GummiBear: hmm, i guess its against the rules of the ninja clan to leave :P
  77 2013-06-26T12:39:08  *** dave_largo has joined #moin-dev
  78 2013-06-26T12:40:08  <sharky93> GummiBear: your nick is a bit misleading :P
  79 2013-06-26T12:40:46  <GummiBear> Ok. Let me change it then :(
  80 2013-06-26T12:40:55  *** GummiBear is now known as sunuTheNinja
  81 2013-06-26T12:41:24  <sharky93> once a ninja, always a ninja..
  82 2013-06-26T13:24:28  *** kolyaflash has quit IRC
  83 2013-06-26T13:25:49  <sharky93> TheSheep: i was wrong, there is not a good way to not losing the query when the image converter is called ..
  84 2013-06-26T13:27:28  <TheSheep> sharky93: why is that?
  85 2013-06-26T13:29:08  <sharky93> TheSheep: The image converter, just gives an internal rep. of the object. without any arguments.
  86 2013-06-26T13:29:58  <sharky93> For ex. the moinwiki converter is able to put in args because arguments are parsed within that .. which is not the case with the image converter..
  87 2013-06-26T13:30:29  <sharky93> TheSheep: ^
  88 2013-06-26T13:30:33  <TheSheep> sharky93: can you point me to the code in question?
  89 2013-06-26T13:31:03  <TheSheep> the image_in.py?
  90 2013-06-26T13:31:38  <sharky93> yeah
  91 2013-06-26T13:32:04  <TheSheep> it takes arguments?
  92 2013-06-26T13:33:54  <sharky93> TheSheep: yeah, but it is called from here, https://bitbucket.org/thomaswaldmann/moin-2.0/src/ad303592c64c1743ac218d42835493cb9d97440b/MoinMoin/items/content.py?at=default#cl-206 ..
  93 2013-06-26T13:34:53  <sharky93> this has only the information about the document, like the rev.
  94 2013-06-26T13:39:45  <TheSheep> sharky93: and that is called from the include converter
  95 2013-06-26T13:43:36  <sharky93> TheSheep: we could figure out a mechanism to pass the values and achieve this, should that be enough reason to change the prototype for these functions.?
  96 2013-06-26T13:45:21  <TheSheep> sharky93: lets ask ThomasWaldmann
  97 2013-06-26T13:46:11  <TheSheep> sharky93: would be OK to add an optional parameter to the content.internal_representation to pass things that affect the rendering of that representation?
  98 2013-06-26T13:49:36  *** ashutosh1461 has quit IRC
  99 2013-06-26T14:04:21  <sharky93> TheSheep: hmm, optional parameters should do it .. changing the prototype has too much dependencies
 100 2013-06-26T14:04:26  <sharky93> TheSheep: should i go ahead?
 101 2013-06-26T14:13:22  <TheSheep> sharky93: in the worst case you can undo it
 102 2013-06-26T15:04:26  *** brunomartin has joined #moin-dev
 103 2013-06-26T15:32:38  *** ashutosh1461 has joined #moin-dev
 104 2013-06-26T16:29:39  *** sunuTheNinja has quit IRC
 105 2013-06-26T16:44:34  *** ashutosh1461 has quit IRC
 106 2013-06-26T16:46:09  *** ashutosh1461 has joined #moin-dev
 107 2013-06-26T18:17:44  *** greg_f has quit IRC
 108 2013-06-26T18:19:16  *** ashutosh1461 is now known as ashu1461
 109 2013-06-26T19:03:28  <ashu1461> ThomasWaldmann, i think before proceeding to fixing views, maybe first fix up the code to deal with multiple names
 110 2013-06-26T19:04:10  <ashu1461> see the name function here, https://bitbucket.org/thomaswaldmann/moin-2.0/src/ad303592c64c1743ac218d42835493cb9d97440b/MoinMoin/storage/middleware/indexing.py?at=default#cl-1165
 111 2013-06-26T19:48:34  <ThomasWaldmann> can you just produce some clean changesets of what you have?
 112 2013-06-26T19:57:26  <ashu1461> ThomasWaldmann, i updated the interwiki patch, https://codereview.appspot.com/10439044/
 113 2013-06-26T20:03:13  <sharky93> TheSheep: please review the resize patch @ http://codereview.appspot.com/10599043
 114 2013-06-26T20:13:13  <sharky93> TheSheep: i've whitelisted height and width.
 115 2013-06-26T20:19:40  *** bilal has joined #moin-dev
 116 2013-06-26T20:24:27  *** bilal has quit IRC
 117 2013-06-26T20:40:06  <ReimarBauer> ashu1461: done
 118 2013-06-26T20:40:10  <ReimarBauer> sharky93: done
 119 2013-06-26T20:42:12  <TheSheep> sharky93: I still don't understand why you are using xlink.width
 120 2013-06-26T20:43:36  <TheSheep> I mean, why xlink?
 121 2013-06-26T20:45:04  <sharky93> TheSheep: i dont have a very valid reason for that.. after the include converter, all the stuff is converted to the xlink ns, so i used that
 122 2013-06-26T20:50:49  <TheSheep> sharky93: I added some comments, but don't push it yet
 123 2013-06-26T20:54:16  <ashu1461> ReimarBauer, replied to your comments https://codereview.appspot.com/10439044/
 124 2013-06-26T20:55:00  <sharky93> TheSheep: after i act according to the suggested changes.. what do we wait for?
 125 2013-06-26T20:57:13  *** dave_largo has quit IRC
 126 2013-06-26T21:07:18  <TheSheep> sharky93: I need to read some parts of moin code and think about it, but I'm too tired for that right now
 127 2013-06-26T21:08:44  <sharky93> TheSheep: ok, maybe tomorrow :)
 128 2013-06-26T21:40:45  <sharky93> TheSheep: i too have some doubt if using the html ns would be better there, but anyway would only lead to changing the handlers.. so not much work
 129 2013-06-26T22:16:11  *** ashu1461 has quit IRC
 130 2013-06-26T22:20:36  *** brunomartin has quit IRC
 131 2013-06-26T22:33:41  <ThomasWaldmann> spy_: what's up? i don't see any communication/work.
 132 2013-06-26T22:43:31  *** bilal has joined #moin-dev
 133 2013-06-26T22:53:49  *** bilal has quit IRC
 134 2013-06-26T23:38:08  <sharky93> TheSheep: updated cr @ https://codereview.appspot.com/10599043/