1 2013-06-27T01:43:49 *** yufra_
2 2013-06-27T04:02:19 *** xjjk
3 2013-06-27T04:34:18 *** hughperkins
4 2013-06-27T04:54:46 *** TheSheep
5 2013-06-27T04:54:54 *** TheSheep
6 2013-06-27T05:13:41 *** hughperkins
7 2013-06-27T07:35:10 *** sunu
8 2013-06-27T07:35:10 *** asingla
9 2013-06-27T07:35:12 *** vpv
10 2013-06-27T07:35:15 *** spy_
11 2013-06-27T07:35:17 *** ChanServ
12 2013-06-27T07:35:18 *** birkenfeld
13 2013-06-27T07:35:19 *** dav1d
14 2013-06-27T07:35:21 *** yufra_
15 2013-06-27T07:35:23 *** MarcelH
16 2013-06-27T07:35:25 *** H0arry
17 2013-06-27T07:35:26 *** eSyr
18 2013-06-27T07:35:27 *** TheSheep
19 2013-06-27T07:35:29 *** ronny
20 2013-06-27T07:35:29 *** waldi
21 2013-06-27T07:35:29 *** ThomasWaldmann
22 2013-06-27T07:35:34 *** pineapple_koala
23 2013-06-27T07:35:36 *** SteveMcIntyre
24 2013-06-27T07:35:36 *** eSyr-ng
25 2013-06-27T07:35:37 *** sharky93
26 2013-06-27T07:35:37 *** xiaq
27 2013-06-27T07:35:37 *** sharky93__
28 2013-06-27T07:35:37 *** ReimarBauer
29 2013-06-27T07:35:38 *** xorAxAx
30 2013-06-27T07:37:46 *** yufra_
31 2013-06-27T07:37:46 *** waldi
32 2013-06-27T07:37:46 *** ThomasWaldmann
33 2013-06-27T07:37:46 *** TheSheep
34 2013-06-27T07:37:46 *** eSyr-ng
35 2013-06-27T07:37:46 *** pineapple_koala
36 2013-06-27T07:37:46 *** sharky93
37 2013-06-27T07:37:46 *** xiaq
38 2013-06-27T07:37:46 *** asingla
39 2013-06-27T07:37:46 *** sunu
40 2013-06-27T07:37:46 *** birkenfeld
41 2013-06-27T07:37:46 *** sharky93__
42 2013-06-27T07:37:46 *** H0arry
43 2013-06-27T07:37:46 *** vpv
44 2013-06-27T07:37:46 *** MarcelH
45 2013-06-27T07:37:46 *** spy_
46 2013-06-27T07:37:46 *** ReimarBauer
47 2013-06-27T07:37:46 *** ronny
48 2013-06-27T07:37:46 *** dav1d
49 2013-06-27T07:37:46 *** xorAxAx
50 2013-06-27T07:37:46 *** eSyr
51 2013-06-27T07:37:46 *** ChanServ
52 2013-06-27T07:37:46 *** SteveMcIntyre
53 2013-06-27T07:37:46 *** card.freenode.net
54 2013-06-27T07:39:32 *** waldi
55 2013-06-27T07:39:32 *** waldi
56 2013-06-27T08:09:30 *** xjjk
57 2013-06-27T08:28:48 <sharky93> moin
58 2013-06-27T08:28:55 <sharky93> TheSheep: are we fine with xlink?
59 2013-06-27T08:49:08 *** xjjk
60 2013-06-27T09:45:08 *** ashutosh1461
61 2013-06-27T09:50:03 <ashutosh1461> moin
62 2013-06-27T09:54:36 <ashutosh1461> ThomasWaldmann, suppose for an item (name : [foo,bar], tags :[moin]) , how should we show the names in tags view?
63 2013-06-27T09:54:49 <ashutosh1461> Option one :
64 2013-06-27T09:55:21 <ashutosh1461> multiple names separated by '|' as we do in history views
65 2013-06-27T09:55:28 <ashutosh1461> *foo | bar
66 2013-06-27T09:55:43 <ashutosh1461> or show both of them separately
67 2013-06-27T09:55:46 <ashutosh1461> *foo
68 2013-06-27T09:55:48 <ashutosh1461> *bar
69 2013-06-27T11:11:35 <ThomasWaldmann> ashutosh1461: what is the "tags view"?
70 2013-06-27T11:18:32 <sharky93> TheSheep: there's dependencies with passing attributes to all converters.
71 2013-06-27T11:19:10 <sharky93> TheSheep: check lines 1021, 1022, moinwiki converter.. i think that should be corrected. it checks for arguments but uses arguments.keyword .. isnt that weird?
72 2013-06-27T11:19:33 <sharky93> i.e being a bit more optimistic
73 2013-06-27T11:22:34 <sharky93> TheSheep: moreover what we pass as argumetns is a dict, it will not have .keyword
74 2013-06-27T11:29:23 <ThomasWaldmann> ashutosh1461: i am still waiting for clean changesets and more review of them.
75 2013-06-27T11:35:19 <sharky93> ThomasWaldmann: btw, did you have a look at the later jm mockup? @ http://web.iiit.ac.in/~rishabh.raj/jm/jmobile.html
76 2013-06-27T11:47:01 <sharky93> TheSheep: should we introduce "hasattr" in the code to handle, i.e lines 1021-22 in moinwiki
77 2013-06-27T11:47:49 <sharky93> i think we may have to verify with other converters too
78 2013-06-27T11:50:13 <ashutosh1461> ThomasWaldmann, like currently we have _tags/itemname
79 2013-06-27T11:50:13 <ashutosh1461> +tags/itemname*
80 2013-06-27T11:52:00 <ThomasWaldmann> ashutosh1461: i have no idea what your question is about. please (in general) be more precise when asking.
81 2013-06-27T11:58:24 <ashutosh1461> ThomasWaldmann, in case of a item having multiple names, how should we render results in case of any query ?
82 2013-06-27T11:59:18 <ashutosh1461> like in case of tags,
83 2013-06-27T12:01:46 <ashutosh1461> suppose for an item (name : [foo,bar], tags :[moin]) exists, there are two possibilities of displaying results if the user accesses, http://localhost:8080/+tags/moin
84 2013-06-27T12:03:02 <ashutosh1461> ->item with name foo|bar matched your query
85 2013-06-27T12:03:04 <ashutosh1461> or we can say
86 2013-06-27T12:03:08 <ThomasWaldmann> didn't we agree that we do not work on any other view than +show until the stuff is ready, reviewed, approved and committed?
87 2013-06-27T12:04:34 <ashutosh1461> i was fixing some of the classes, that relate directly to the views
88 2013-06-27T12:06:00 <ThomasWaldmann> i want to see the stuff finished that you worked on. not touching new stuff.
89 2013-06-27T12:06:36 <ashutosh1461> ThomasWaldmann, i updated the new patch for interwiki yesterday https://codereview.appspot.com/10439044/
90 2013-06-27T12:06:56 <ThomasWaldmann> stuff means: code + unit tests + docs (if there is any)
91 2013-06-27T12:07:24 <ThomasWaldmann> and also, please check that you addressed ALL stuff that was mentioned in a review, not just a tiny bit of it.
92 2013-06-27T12:08:16 <ThomasWaldmann> https://codereview.appspot.com/10439044/diff/31001/MoinMoin/constants/keys.py e.g. there, don't just say fine, fix it and upload again after you finished all of them.
93 2013-06-27T12:12:31 * ThomasWaldmann reviews that
94 2013-06-27T12:19:51 <ThomasWaldmann> done. /me needs to go, bbl.
95 2013-06-27T12:19:54 <ThomasWaldmann> ashutosh1461: ^
96 2013-06-27T12:21:55 <ashutosh1461> ThomasWaldmann, app.cfg.namespace_mapping appears to be a list of tuples so we have to use dict() there.
97 2013-06-27T12:38:44 *** dave_largo
98 2013-06-27T13:59:10 <sharky93> TheSheep: updated cr @ https://codereview.appspot.com/10599043/
99 2013-06-27T13:59:39 <sharky93> TheSheep: im currently looking up this for other converters, if this is ok, i can put up the rest for cr ?
100 2013-06-27T14:55:39 *** brunomartin
101 2013-06-27T15:14:14 *** moin9
102 2013-06-27T15:14:50 *** moin9
103 2013-06-27T15:16:08 *** brunomartin
104 2013-06-27T15:22:51 *** yufra_
105 2013-06-27T16:15:34 *** diofeher
106 2013-06-27T16:18:11 *** ronny
107 2013-06-27T16:26:21 *** twtw
108 2013-06-27T16:27:15 *** moin8
109 2013-06-27T16:41:43 <TheSheep> sharky93: ok
110 2013-06-27T17:03:11 *** moin8
111 2013-06-27T17:52:44 *** diofeher
112 2013-06-27T18:12:10 <ashutosh1461> ThomasWaldmann, should i define a constant for field ?
113 2013-06-27T18:14:06 *** ronny
114 2013-06-27T18:54:29 <pineapple_koala> ThomasWaldmann: do you have some other comments regarding the cr? https://codereview.appspot.com/10537043/
115 2013-06-27T19:43:10 <ThomasWaldmann> re
116 2013-06-27T19:45:10 <ThomasWaldmann> ashutosh1461: ah, well, instead of building a dict and then using .keys() you could also use [k for k, v in nsmap]
117 2013-06-27T19:46:22 <ThomasWaldmann> ashutosh1461: constant? like how exactly?
118 2013-06-27T19:47:04 <ashutosh1461> ThomasWaldmann, FIELD = u'field' i mean in the keys.py file
119 2013-06-27T19:56:07 <ThomasWaldmann> do you need that string multiple times?
120 2013-06-27T19:56:45 <ThomasWaldmann> pineapple_koala: review done.
121 2013-06-27T20:00:42 <ThomasWaldmann> pineapple_koala: btw, i meant the create_user that already exists (in user.py?)
122 2013-06-27T20:01:51 <ashutosh1461> ThomasWaldmann, updated https://codereview.appspot.com/10439044/
123 2013-06-27T20:02:53 <ashutosh1461> no, not that much.
124 2013-06-27T20:11:52 <ashutosh1461> ThomasWaldmann, also updated https://codereview.appspot.com/10519045/
125 2013-06-27T20:13:49 <ThomasWaldmann> (if it is not used at multiple places, there isn't much sense in making a constant for it)
126 2013-06-27T20:13:59 <ThomasWaldmann> ashutosh1461: review done
127 2013-06-27T20:14:31 <pineapple_koala> ThomasWaldmann: hmm... create_user from user.py doesn't allow setting such meta as subscriptions
128 2013-06-27T20:14:51 <ThomasWaldmann> pineapple_koala: should it be able to do that?
129 2013-06-27T20:16:56 <ashutosh1461> ThomasWaldmann, if the token is not in fileds eg for fqname '@notid/name', it is possibly a part of the name, then the function returns (ns = '', field = '' and name = '@notid/name')
130 2013-06-27T20:18:14 <pineapple_koala> no. after creating the user (user.create_user()) i need to set meta. so far subscribe method is not updated, so i'm setting meta directly by getting access to user profile
131 2013-06-27T20:19:20 <ThomasWaldmann> ashutosh1461: ah, ok. (then it is just the question if we want to allow names with @, but we can define that later)
132 2013-06-27T20:19:20 * pineapple_koala feels strange with the new nickname
133 2013-06-27T20:19:37 <ThomasWaldmann> pineapple_koala: what's with the old nickname? :)
134 2013-06-27T20:21:02 <pineapple_koala> you pinged me several times instead of ashutosh1461. too many A nicknames here
135 2013-06-27T20:22:50 <sharky93> you could maybe lose the underscore.. :P
136 2013-06-27T20:23:22 <pineapple_koala> in pineapple_koala ?
137 2013-06-27T20:23:40 <sharky93> yeah
138 2013-06-27T20:24:40 <pineapple_koala> that won't make me feel more comfy ) still the same. anyway not a big deal
139 2013-06-27T20:25:17 <ashutosh1461> ThomasWaldmann, any other change to do expect Fully -> fully ?
140 2013-06-27T20:33:09 <ThomasWaldmann> ashutosh1461: i wrote all i found in this review. if you are unsure whether there is more, look at all old comments and do an own review.
141 2013-06-27T20:33:16 <ThomasWaldmann> also run the tests...
142 2013-06-27T20:33:29 <ThomasWaldmann> pineapple_koala: ah :D
143 2013-06-27T20:33:42 <ashutosh1461> ThomasWaldmann, old comments checked
144 2013-06-27T20:34:16 <ThomasWaldmann> pineapple_koala: well, that's not your fault, i just need to be less lazy and type 2 chars before hitting tab.
145 2013-06-27T20:34:23 <pineapple_koala> ThomasWaldmann: left some comments https://codereview.appspot.com/10537043/
146 2013-06-27T20:35:20 <pineapple_koala> ThomasWaldmann: no problems actually :) changes are for the good
147 2013-06-27T20:40:30 <ThomasWaldmann> ashutosh1461: other review done.
148 2013-06-27T20:47:03 <ashutosh1461> ThomasWaldmann, we would only need to create the DummyRev in case the field is ITEMID/NAME_EXACT, so there are only two possibilities, field being NAME_EXACT or ITEMID.
149 2013-06-27T20:50:04 <ThomasWaldmann> pineapple_koala: commented there...
150 2013-06-27T20:50:49 <ThomasWaldmann> ashutosh1461: or any other unique key, right?
151 2013-06-27T20:51:22 <ThomasWaldmann> REVID, EMAIL (for user items), ...
152 2013-06-27T21:03:58 *** diofeher
153 2013-06-27T21:07:51 <ashutosh1461> ThomasWaldmann, ran tests, https://codereview.appspot.com/10439044
154 2013-06-27T21:13:57 <pineapple_koala> ThomasWaldmann: removed the check, but didn't inline the code. so should i change the create_user method in some other way?
155 2013-06-27T21:14:40 *** dave_largo
156 2013-06-27T21:15:55 <ashutosh1461> ThomasWaldmann, also tell what should i do next?
157 2013-06-27T21:16:58 <pineapple_koala> waldi: please review the cr https://codereview.appspot.com/10716043/
158 2013-06-27T21:18:34 <ThomasWaldmann> ashutosh1461: you should commit stuff that is finished. clean, working changesets.
159 2013-06-27T21:19:28 <ashutosh1461> ThomasWaldmann, should i commit the interwiki patch ?
160 2013-06-27T21:21:54 <pineapple_koala> ThomasWaldmann: now the subscription_id is going to be tags:<ns>:<tag_name> or just use 'tag' string?
161 2013-06-27T21:22:27 <ThomasWaldmann> tags
162 2013-06-27T21:22:49 <ThomasWaldmann> (and add a todo or ticket to review plurals)
163 2013-06-27T21:30:44 <pineapple_koala> https://codereview.appspot.com/10537043/ ready for commit or not yet?
164 2013-06-27T21:35:06 <ThomasWaldmann> the create_user wrapper is still there...
165 2013-06-27T21:37:26 <ThomasWaldmann> pineapple_koala: you can do that also in a 2nd changeset if you prefer...
166 2013-06-27T21:38:13 <ThomasWaldmann> but i think user.create_user should be modified so that such wrappers are not necessary just to put some metadata values
167 2013-06-27T21:38:55 <pineapple_koala> so just remove the wrapper and set meta values directly in tests?
168 2013-06-27T21:40:29 <ThomasWaldmann> no, if you want to have a user with specific value in the profile, call user.create_user(..., key=value)
169 2013-06-27T21:40:48 <pineapple_koala> or maybe modify user.create_user to accept **kw
170 2013-06-27T21:41:08 <ThomasWaldmann> exactly
171 2013-06-27T21:42:09 <ThomasWaldmann> you need to keep some stuff like name and password (first because it is used often and is NOT a list, second because it needs processing)
172 2013-06-27T21:42:22 <pineapple_koala> maybe we need a separate commit for that? doesn't belong to subscription ids
173 2013-06-27T21:42:27 <ThomasWaldmann> yes
174 2013-06-27T21:43:13 <ashutosh1461> ThomasWaldmann, its the name only between the unique keys than is stored in a list, all of the other are strings ? am i right ?
175 2013-06-27T21:44:40 <pineapple_koala> ok, that's for tomorrow.
176 2013-06-27T21:44:47 <pineapple_koala> gn everyone
177 2013-06-27T21:44:58 <ThomasWaldmann> ashutosh1461: NAME is a list, TAGS is a list, ... - other stuff is not a list. see the validation code.
178 2013-06-27T21:45:08 <ThomasWaldmann> gn pineapple_koala
179 2013-06-27T21:46:24 <ashutosh1461> ThomasWaldmann, i meant between the unique keys
180 2013-06-27T21:47:12 <ashutosh1461> if that is the case we can use NAME_EXACT vs all others.
181 2013-06-27T22:04:47 *** xjjk
182 2013-06-27T22:10:07 <ThomasWaldmann> ashutosh1461: why don't you just classify using sets or lists?
183 2013-06-27T22:10:34 <ThomasWaldmann> then stuff can be easily added to the respective set/list
184 2013-06-27T22:19:31 *** diofeher
185 2013-06-27T22:34:26 <sharky93> ThomasWaldmann: docs for other markups such as ReST, are they uptodate?
186 2013-06-27T22:48:01 * ashutosh1461 says gn
187 2013-06-27T22:48:02 *** ashutosh1461
188 2013-06-27T22:59:21 <sharky93> ThomasWaldmann: TheSheep update etherpad @ http://etherpad.osuosl.org/moin-ui lines 7-25 ..
189 2013-06-27T22:59:27 <sharky93> *updated
190 2013-06-27T22:59:33 <sharky93> gn :)
