1 2013-06-30T07:53:11 <sharky93> moin
2 2013-06-30T07:53:34 <ThomasWaldmann> moin
3 2013-06-30T07:53:44 <sharky93> TheSheep: the ReST patchset @ https://codereview.appspot.com/10782043/ .. and the moinwiki patchset @ https://codereview.appspot.com/10599043/ :)
4 2013-06-30T07:55:56 <TheSheep> sharky93: what does scale do?
5 2013-06-30T08:18:10 * ThomasWaldmann leaving soon, bbl....
6 2013-06-30T08:20:49 <sharky93> TheSheep: as mentioned here @ http://docutils.sourceforge.net/docs/ref/rst/directives.html#image it is the scaling factor.. im not sure how to treat that in the html emitter ..
7 2013-06-30T08:21:18 <TheSheep> sharky93: well, you'd have to multiply the image size by it
8 2013-06-30T08:21:42 <TheSheep> sharky93: and convert it to width and height that way
9 2013-06-30T08:22:20 <sharky93> TheSheep: but if there's no height and width specified .. how to fetch that
10 2013-06-30T08:22:33 <TheSheep> sharky93: actually, if you do with=200 scale=0.5, then it should be width=100
11 2013-06-30T08:22:46 <TheSheep> sharky93: you don't have to, it says it's optional
12 2013-06-30T08:22:56 <TheSheep> If no "height" or "width" options are specified, the Python Imaging Library (PIL) may be used to determine them, if it is installed and the image file is available.
13 2013-06-30T08:23:11 <TheSheep> so you can ignore scale if no width or height is provided
14 2013-06-30T08:23:16 <sharky93> TheSheep: hmm, ok
15 2013-06-30T08:23:34 <sharky93> TheSheep: safe to pass that with html ns ?
16 2013-06-30T08:24:00 <TheSheep> sharky93: no, compute the final width and height in the rst parser and just pass them
17 2013-06-30T08:24:11 <sharky93> ok
18 2013-06-30T08:24:40 <sharky93> TheSheep: btw, the moinwiki patchset, commit?
19 2013-06-30T08:24:54 <TheSheep> yes
20 2013-06-30T08:25:30 <sharky93> ok, brb .
21 2013-06-30T08:31:41 <TheSheep> by the way, how about adding support for align and target? :)
22 2013-06-30T08:41:05 *** ashutosh1461
23 2013-06-30T08:55:55 *** ashutosh1461
24 2013-06-30T08:58:27 *** xiaq
25 2013-06-30T09:11:32 <sharky93> TheSheep: isnt align by tag attributes deprecated?
26 2013-06-30T09:13:16 <TheSheep> practicality beats purity
27 2013-06-30T09:25:20 *** ashutosh1461
28 2013-06-30T09:26:32 <sharky93> TheSheep: ideas on next week .. im a bit worried
29 2013-06-30T09:27:09 <TheSheep> sharky93: well, at the minimum you have the mockups to make
30 2013-06-30T09:27:16 <TheSheep> for the foundation at least
31 2013-06-30T09:29:28 <TheSheep> sharky93: how about working on the incremental search next?
32 2013-06-30T09:32:14 <sharky93> TheSheep: search as you type ?
33 2013-06-30T09:32:47 <sharky93> hmm yeah, the official name :D
34 2013-06-30T09:34:03 *** ashutosh1461
35 2013-06-30T09:37:01 <sharky93> can anybody access etherpad ?
36 2013-06-30T10:01:55 * sharky93 pushes changes to local repo
37 2013-06-30T10:06:14 *** ashutosh1461
38 2013-06-30T10:08:07 <pineapple_koala> shall we start the weekly meeting?
39 2013-06-30T10:10:37 <waldi> ups
40 2013-06-30T10:11:57 <TheSheep> ThomasWaldmann: should we be starting?
41 2013-06-30T10:12:06 <waldi> thomas isn't here
42 2013-06-30T10:12:14 <TheSheep> ah, right, flying to Italy
43 2013-06-30T10:12:35 <TheSheep> I suppose we need to do it alone
44 2013-06-30T10:12:42 <TheSheep> who's present?
45 2013-06-30T10:13:12 <pineapple_koala> ping student/mentor and we will see who is present
46 2013-06-30T10:13:14 <sharky93> Present Sir!
47 2013-06-30T10:13:20 <sharky93> :)
48 2013-06-30T10:14:37 <ashutosh1461> present :D
49 2013-06-30T10:15:00 <TheSheep> pineapple_koala: but I don't know your nicks :/
50 2013-06-30T10:15:19 <sharky93> TheSheep: http://moinmo.in/GoogleSoc2013/ :)
51 2013-06-30T10:15:27 <TheSheep> sharky93: those are real names
52 2013-06-30T10:15:37 <sharky93> each profile has the nick
53 2013-06-30T10:16:21 <TheSheep> ashutosh1461: anyways, since ThomasWaldmann is not here, can you start?
54 2013-06-30T10:16:29 <ashutosh1461> sure
55 2013-06-30T10:17:27 <TheSheep> eSyr, ReimarBauer are you there?
56 2013-06-30T10:18:21 <eSyr> yes.
57 2013-06-30T10:19:23 <ashutosh1461> DONE LAST WEEK
58 2013-06-30T10:19:24 <ashutosh1461> Pushed 2 commits into private repo
59 2013-06-30T10:19:24 <ashutosh1461> Fixed subitems view made a cr
60 2013-06-30T10:19:24 <ashutosh1461> pratical testing to see which code is affected by changing name -> fqname
61 2013-06-30T10:19:24 <ashutosh1461> /+modify view done
62 2013-06-30T10:19:25 <ashutosh1461> started with validation
63 2013-06-30T10:20:05 <ashutosh1461> TODO
64 2013-06-30T10:20:06 <ashutosh1461> Finish validation
65 2013-06-30T10:20:06 <ashutosh1461> start with other views
66 2013-06-30T10:21:02 <ashutosh1461> that's it :)
67 2013-06-30T10:21:05 <pineapple_koala> private repo you mean your personal public fork?
68 2013-06-30T10:21:20 <ashutosh1461> yes
69 2013-06-30T10:21:21 <TheSheep> ashutosh1461: any blockers?
70 2013-06-30T10:21:51 <eSyr> (aside note: "2 commits" says nothing, sice two commits can easily become 20, and 25 become 1)
71 2013-06-30T10:22:14 <ashutosh1461> TheSheep, no blockers
72 2013-06-30T10:23:16 <ashutosh1461> eSyr, 2 commits -> one to fix the interwiki module and the other to add basic composite name support
73 2013-06-30T10:24:48 <TheSheep> ashutosh1461: ok, thank you
74 2013-06-30T10:24:55 <TheSheep> waldi, pineapple_koala your turn
75 2013-06-30T10:25:15 <pineapple_koala> ok
76 2013-06-30T10:25:19 <pineapple_koala> DONE:
77 2013-06-30T10:25:19 <pineapple_koala> * Update `user.user_create()` function (commit+push)
78 2013-06-30T10:25:19 <pineapple_koala> * Refactoring implementation and tests for determining subscribers by subscription_ids
79 2013-06-30T10:25:22 <pineapple_koala> * Implemented a validator (on cr now)
80 2013-06-30T10:25:36 <pineapple_koala> TODO next week
81 2013-06-30T10:25:36 <pineapple_koala> * Code subscription_pattens
82 2013-06-30T10:25:36 <pineapple_koala> * Change user subscription methods
83 2013-06-30T10:25:37 <pineapple_koala> * Prepare mail templates
84 2013-06-30T10:25:49 <pineapple_koala> BLOKERS
85 2013-06-30T10:26:27 <pineapple_koala> * none, but some of work is dependent on ashutosh1461 multiple namespace stuff
86 2013-06-30T10:26:44 <pineapple_koala> some work*
87 2013-06-30T10:31:35 <pineapple_koala> questions?
88 2013-06-30T10:33:22 * eSyr doesn't have any
89 2013-06-30T10:33:52 <TheSheep> ok
90 2013-06-30T10:34:15 <TheSheep> eSyr: CheerXiao is not yet working, no?
91 2013-06-30T10:35:01 <TheSheep> spy_, ReimarBauer: your turn
92 2013-06-30T10:35:52 <eSyr> yes, last exam was yesterday afaik.
93 2013-06-30T10:41:51 <TheSheep> ok, I guess they are not here
94 2013-06-30T10:41:57 <TheSheep> sharky93: your turn
95 2013-06-30T10:42:11 <sharky93> ok
96 2013-06-30T10:42:46 <sharky93> This weeks task was mainly based on fixing https://bitbucket.org/thomaswaldmann/moin-2.0/issue/340
97 2013-06-30T10:43:15 <sharky93> One cr successfull, commit and push, @ https://codereview.appspot.com/10599043/
98 2013-06-30T10:43:35 <sharky93> TODO:
99 2013-06-30T10:44:01 <sharky93> Add similar features for ReST (cr @ https://codereview.appspot.com/10782043/ ) and MediaWiki markups
100 2013-06-30T10:44:11 <sharky93> Add docs for the same
101 2013-06-30T10:44:26 <sharky93> BLOCKERS:
102 2013-06-30T10:44:48 <sharky93> Mainly to decide if we go for framework related stuff or wait for reply from Bootstrap guys
103 2013-06-30T10:45:01 <sharky93> i.e stuff for next week
104 2013-06-30T10:45:16 <sharky93> EOF
105 2013-06-30T10:51:21 <TheSheep> ok, thank you everyone
106 2013-06-30T10:51:48 *** ashutosh1461
107 2013-06-30T10:54:49 * pineapple_koala is wondering if it's possible to point out somehow that a cr is dependent on other cr now being on review (like on gerrit)
108 2013-06-30T11:05:11 <sharky93> TheSheep: any update from the twitter guys ?
109 2013-06-30T11:07:08 <TheSheep> sharky93: no, you know as much as me
110 2013-06-30T11:14:40 <sharky93> TheSheep: so we hold it for another week ?
111 2013-06-30T11:33:48 *** pineapple_koala
112 2013-06-30T12:03:55 <TheSheep> sharky93: try with foundation
113 2013-06-30T12:29:51 <sharky93> TheSheep: you mean try with mockups for foundation.. ok will surely do .. but that should be the major task for next week or something else ?
114 2013-06-30T12:36:59 <TheSheep> sharky93: I think the search is the next thing
115 2013-06-30T12:37:09 <TheSheep> sharky93: as it doesn't need the framework
116 2013-06-30T12:39:05 <TheSheep> sharky93: as for the mockups, it would be nice to contact the respective communities of those frameworks and get some feedback on what could be improved in them
117 2013-06-30T12:42:29 <sharky93> TheSheep: the frameworks in question are just foundation and jm ? ..
118 2013-06-30T12:43:32 <TheSheep> sharky93: and gumby
119 2013-06-30T12:43:46 <sharky93> btw when i tried with the jquery people they were themselves pretty surprised that someone is working on a full desktop version with jm
120 2013-06-30T12:43:51 <sharky93> TheSheep: ^
121 2013-06-30T12:44:39 <TheSheep> I see
122 2013-06-30T15:12:55 <sharky93> re
123 2013-06-30T15:37:37 <sharky93> TheSheep: the item-wrapper for objects has a style for display:inline-block .. im clueless. how to get the align to work
124 2013-06-30T15:37:48 <sharky93> ReST markup ^
125 2013-06-30T15:42:31 *** Gnarlodious
126 2013-06-30T15:45:01 *** Gnarlodious
127 2013-06-30T15:45:32 *** Gnarlodious
128 2013-06-30T15:46:35 *** Gnarlodious
129 2013-06-30T15:46:42 <ananasova> foundation -> http://ana-balica.github.io/moin-foundation-mockup/
130 2013-06-30T15:46:51 <ananasova> sharky93: ^
131 2013-06-30T15:47:43 <ananasova> mostly default elements, the tabs are ugly, they need lots of customization, no grid set for small screens
132 2013-06-30T15:59:34 <TheSheep> ananasova: awesome, the menus don't change on hover?
133 2013-06-30T16:01:35 <ananasova> you mean tabs? on click
134 2013-06-30T16:01:56 <TheSheep> no, the menus
135 2013-06-30T16:02:01 <TheSheep> left and right
136 2013-06-30T16:02:09 <ananasova> side navs... yeah
137 2013-06-30T16:02:16 <TheSheep> they are not highlighted on hover
138 2013-06-30T16:02:38 <TheSheep> that's strange for a default behavior
139 2013-06-30T16:03:06 <ananasova> i guess there was nothing default for that... it's just a proof of concept that foundation is quite nice
140 2013-06-30T16:03:27 <TheSheep> yeah
141 2013-06-30T16:14:50 <sharky93> ananasova: that is pretty cool! :D i guess you we right about the framework :)
142 2013-06-30T16:15:11 <sharky93> *were
143 2013-06-30T16:16:15 <ananasova> what if i am right about git? :D
144 2013-06-30T16:16:33 <sharky93> heh! still dont like :P
145 2013-06-30T16:45:27 <sharky93> TheSheep: cr for ReST @ https://codereview.appspot.com/10782043/
146 2013-06-30T16:58:12 <sharky93> TheSheep: line 385, html_out, marks stuff as transclusion, adding the item-wrapper which has display:inlin-block .. and hence the align does not work in that case..
147 2013-06-30T17:09:22 *** Gnarlodious
148 2013-06-30T18:09:11 <TheSheep> sharky93: ok, lets leave it
149 2013-06-30T18:12:53 <sharky93> TheSheep: i've still added it since it works with all images which have no href.scheme
150 2013-06-30T18:13:36 <sharky93> TheSheep: since the transclusion code does not execute then .. as only executes for stuff like {{ http:// moinmo.in }} as mentioned in the comment in the code.
151 2013-06-30T18:16:53 <sharky93> TheSheep: is the code pushable?
152 2013-06-30T18:18:15 *** ashutosh1461
153 2013-06-30T18:22:51 <TheSheep> sharky93: suggested a little shorter version
154 2013-06-30T18:26:34 <sharky93> TheSheep: will have to add type conversion there..
155 2013-06-30T18:26:41 <sharky93> TheSheep: so, change that and push?
156 2013-06-30T18:35:57 <TheSheep> yeah
157 2013-06-30T18:36:33 <TheSheep> sharky93: well, stop
158 2013-06-30T18:36:47 <TheSheep> sharky93: what happens when the user provides witdth=abc?
159 2013-06-30T18:36:51 <TheSheep> width=abc
160 2013-06-30T18:40:23 <sharky93> TheSheep: hmm, had thought about that once, but we're not validating much input all across moin ..
161 2013-06-30T18:40:44 <sharky93> TheSheep: insert a try: catch: ?
162 2013-06-30T18:41:08 <sharky93> or maybe just typecheck .. and default to no size.
163 2013-06-30T18:41:56 <sharky93> TheSheep: ^
164 2013-06-30T18:49:11 <TheSheep> Errors should never pass silently.
165 2013-06-30T18:49:14 <TheSheep> Unless explicitly silenced.
166 2013-06-30T18:49:50 <TheSheep> I think it should somehow generate a warning
167 2013-06-30T18:50:50 <TheSheep> like displaying "'abc' is not a valid width, use an integer"
168 2013-06-30T18:51:06 <TheSheep> moin1 had a nice argument parser for that
169 2013-06-30T18:51:58 <TheSheep> come to think about it, it should also warn about attributes that are not whitelisted and were thus ignored
170 2013-06-30T18:52:38 <TheSheep> sharky93: for now make it just ignore it if it's somehow bad, and we will discuss error reporting when ThomasWaldmann is back
171 2013-06-30T18:54:10 <TheSheep> I'm off to the conference
172 2013-06-30T18:58:30 <sharky93> TheSheep: ok :)
173 2013-06-30T20:59:23 *** spy_
174 2013-06-30T21:58:20 <ThomasWaldmann> re
175 2013-06-30T21:59:29 <ThomasWaldmann> greetings from the conference in florence
176 2013-06-30T22:05:09 * sharky93 wishes for a productive conference and hopes he's around next time :P
177 2013-06-30T22:10:30 <sharky93> ThomasWaldmann: if you're on mobile mind trying this foundation mockup @ http://web.iiit.ac.in/~rishabh.raj/moin-foundation/ , ananasova really helped with this :)
178 2013-06-30T22:17:42 <ThomasWaldmann> ananasova: sharky93: looks quite good!
179 2013-06-30T22:18:04 <ThomasWaldmann> (desktop browser)
180 2013-06-30T22:20:43 <ThomasWaldmann> there is a style between head and body?
181 2013-06-30T22:21:28 <sharky93> oh, missed that :(
182 2013-06-30T22:22:12 <sharky93> i should get some more sleep! -_-
183 2013-06-30T22:26:43 * sharky93 pushes commits to local repo
184 2013-06-30T22:29:22 <sharky93> good night
185 2013-06-30T23:22:31 * ashutosh1461 is tired
186 2013-06-30T23:22:48 <ashutosh1461> good night all
187 2013-06-30T23:22:51 *** ashutosh1461
188
