1 2013-07-21T00:14:58 *** ashutosh1461
2 2013-07-21T03:50:54 * xiaq might be outside and unable to attend meeting at 10am utc :-|
3 2013-07-21T07:15:36 <sharky93> moin
4 2013-07-21T07:24:20 <ananasova> moin
5 2013-07-21T07:49:52 *** rciorba
6 2013-07-21T08:11:24 <sharky93> TheSheep: test for the htmlout conv. @ https://codereview.appspot.com/11650043
7 2013-07-21T08:12:11 <sharky93> TheSheep: test for rst_in .. patchset 2 @ https://codereview.appspot.com/11627043/#ps3001
8 2013-07-21T08:36:43 <TheSheep> looking
9 2013-07-21T08:54:05 <TheSheep> sharky93: using regex for modifying xml, seriously?
10 2013-07-21T08:55:09 <sharky93> TheSheep: that had been used at multiple places in other tests, and its a simple version i think
11 2013-07-21T08:55:37 <TheSheep> sharky93: what if that text that you are replacing appears in some other places too?
12 2013-07-21T08:55:43 <TheSheep> sharky93: http://stackoverflow.com/questions/1732348/regex-match-open-tags-except-xhtml-self-contained-tags/1732454#1732454
13 2013-07-21T08:57:35 <sharky93> TheSheep: true. but it serves out purpose for the test, no?
14 2013-07-21T08:58:53 <sharky93> #SO that is an awesome answer! :o
15 2013-07-21T08:59:25 <TheSheep> sharky93: can you at least try to find a way to do it correctly? It's true that a bad test is better than no test, so if you can't find a better way, it can stay, but if you looked for an hour or two?
16 2013-07-21T09:01:48 <sharky93> TheSheep: umm, you mean just for the test_image test or for rst_in too.. since rst_in, moinwiki many others employ the same regex method?
17 2013-07-21T09:04:16 <TheSheep> once you find a better solution, it can be employed all over
18 2013-07-21T09:04:52 <sharky93> ok, looking
19 2013-07-21T09:16:26 <sharky93> TheSheep: i closed issues 2,4 @ the bootstrap fork, added a comment for #3 and need some help with #5 :)
20 2013-07-21T09:18:20 <TheSheep> sharky93: we have two options: do what I did with the left panel, overflow:hidden, or just let it be
21 2013-07-21T09:18:35 <TheSheep> overflow:hidden makes it look better, but makes the text unreadable
22 2013-07-21T09:19:17 <sharky93> TheSheep: how about increasing the column width, / breaking the line?
23 2013-07-21T09:19:17 <TheSheep> of course the best way would be to avoid long, unbreakable text in the first place
24 2013-07-21T09:19:46 <TheSheep> but that would need to be done on case-by-case basis
25 2013-07-21T09:19:52 *** ashutosh1461
26 2013-07-21T09:19:53 <TheSheep> like adding a space after that comma
27 2013-07-21T09:20:31 <TheSheep> I think that we will have to increase the width of that panel a little anyways
28 2013-07-21T09:20:42 <TheSheep> because of the long words in German translation
29 2013-07-21T09:21:45 <sharky93> hmm, a little should do it i think .
30 2013-07-21T09:40:49 <ashutosh1461> ThomasWaldmann, might not be able to attend today's meeting, its an emergency here. My report on last week here https://pad.riseup.net/p/moin-itemid .
31 2013-07-21T09:44:22 *** ashutosh1461
32 2013-07-21T09:59:06 <ThomasWaldmann> ok, who's here for the meeting? please give a life sign.
33 2013-07-21T09:59:36 <dreimark> moin
34 2013-07-21T09:59:50 <TheSheep> moin
35 2013-07-21T10:00:28 <waldi> here
36 2013-07-21T10:01:31 <sharky93> moin
37 2013-07-21T10:01:44 <ananasova> moin
38 2013-07-21T10:01:49 <ThomasWaldmann> ok, sharky93 and TheSheep: please begin
39 2013-07-21T10:02:13 <sharky93> ok so
40 2013-07-21T10:02:54 <sharky93> My contributions this week were not in a regular way but a bit scattered.
41 2013-07-21T10:02:58 <sharky93> DONE:
42 2013-07-21T10:03:24 <sharky93> Finializing of a basic theme @ the bootstrap fork
43 2013-07-21T10:03:55 <sharky93> Fixed some minor issues, #2,4 almost #3 @ https://bitbucket.org/sharky93/moin-2.0-bootstrap
44 2013-07-21T10:04:36 <sharky93> Tests for image resize, cr's @ https://codereview.appspot.com/11650043 , https://codereview.appspot.com/11627043
45 2013-07-21T10:05:07 <sharky93> TODO:
46 2013-07-21T10:05:51 <sharky93> Get working on the theme, asap after finalizing the tests, and pushing the commit for search functionality which has been reviewed already
47 2013-07-21T10:06:00 <sharky93> BLOCKERS:
48 2013-07-21T10:06:01 <sharky93> None
49 2013-07-21T10:06:05 *** spy_
50 2013-07-21T10:06:14 <sharky93> EOF
51 2013-07-21T10:07:31 <ThomasWaldmann> sharky93: is the repository containing your theme work and in a state so one can successfully run it?
52 2013-07-21T10:07:59 *** spy_
53 2013-07-21T10:08:10 <sharky93> ThomasWaldmann: yes. that repo is only for the bootstrap theme, and can be run
54 2013-07-21T10:08:34 <ThomasWaldmann> are all known issues on that issue tracker?
55 2013-07-21T10:09:33 <sharky93> known to me, yes and i think TheSheep too.
56 2013-07-21T10:09:38 <TheSheep> just for the main view, so far
57 2013-07-21T10:09:48 <TheSheep> we will move on to other views as we finish this
58 2013-07-21T10:10:04 <TheSheep> of course feel free to add issues
59 2013-07-21T10:10:28 <ThomasWaldmann> ok, so it is show view + theme header/footer/sidebars right now?
60 2013-07-21T10:11:03 <TheSheep> yes
61 2013-07-21T10:11:15 <sharky93> ThomasWaldmann: other views are not broken, every view will work. just have not been customised.
62 2013-07-21T10:11:32 <sharky93> so you can feel free to browse with continuity
63 2013-07-21T10:11:35 <sharky93> :)
64 2013-07-21T10:11:41 <dreimark> btw. there is some movement visible on boostrap license issue
65 2013-07-21T10:12:10 <TheSheep> yeah, hopefully they will get it sorted out
66 2013-07-21T10:12:11 <ThomasWaldmann> ok. just as a note: i read "finializing" / "finishing" rather often recently, even for stuff that is not finished. :D
67 2013-07-21T10:13:30 <ThomasWaldmann> I'll try the theme stuff later.
68 2013-07-21T10:15:19 <ThomasWaldmann> and as I already said: I'ld like to have stuff committed and pushed after review before new work is done.
69 2013-07-21T10:16:13 * sharky93 is learning to context switch
70 2013-07-21T10:16:20 <ThomasWaldmann> whatever you have in your local repo / on codereview / whereever else and not in your public repo can't be easily tried / evaluated for midterm
71 2013-07-21T10:16:46 <TheSheep> this is my fault for being late with reviews
72 2013-07-21T10:17:44 <ThomasWaldmann> "and pushing the commit for search functionality which has been reviewed already" that rather sounded like it just did not get finished
73 2013-07-21T10:19:07 <TheSheep> ThomasWaldmann: I just reviewed it today
74 2013-07-21T10:19:24 <ThomasWaldmann> ah
75 2013-07-21T10:19:50 <ThomasWaldmann> ok, anything else for sharky93 / TheSheep ?
76 2013-07-21T10:20:13 <ThomasWaldmann> asingla: if you are there, you can start, otherwise I'll just paste your stuff
77 2013-07-21T10:20:22 <ananasova> /names
78 2013-07-21T10:20:52 * ananasova didn't mean it, just wanted to see who's on
79 2013-07-21T10:22:19 <ThomasWaldmann> ok, thanks to sharky93 / TheSheep. here come asingla's emergency notes:
80 2013-07-21T10:22:32 <ThomasWaldmann> DONE THIS WEEK:-
81 2013-07-21T10:22:33 <ThomasWaldmann> Finalized patches:-
82 2013-07-21T10:22:33 <ThomasWaldmann> sub-items view.
83 2013-07-21T10:22:33 <ThomasWaldmann> Added composite name support to indexing and protecting middleware files.
84 2013-07-21T10:22:33 <ThomasWaldmann> Fqname support if field is not unique + rendering links.
85 2013-07-21T10:22:35 <ThomasWaldmann> Repo updated to be in a working condition.
86 2013-07-21T10:22:37 <ThomasWaldmann> In progress.
87 2013-07-21T10:22:40 <ThomasWaldmann> patchset for handling namespace and item_root ready https://codereview.appspot.com/11584044/ (review pending).
88 2013-07-21T10:22:43 <ThomasWaldmann> /+deleted view (finally can complete it after revert view is fixed and UI stuff has been done.)
89 2013-07-21T10:22:46 <ThomasWaldmann> Making a changeset for different minor changes done.
90 2013-07-21T10:22:48 <ThomasWaldmann> TODO next week:-
91 2013-07-21T10:22:51 <ThomasWaldmann> This week shifting back from home to college, so time would be consumed in travelling and settling down.
92 2013-07-21T10:22:54 <ThomasWaldmann> Move on to views fixing some would be easy, some need a bit of thought.
93 2013-07-21T10:22:57 <ThomasWaldmann> Finalize them.
94 2013-07-21T10:22:59 <ThomasWaldmann> BLOCKERS:- None
95 2013-07-21T10:24:25 * ThomasWaldmann will try that repo later also, but yesterday it sounded rather like it is broken without extra patches.
96 2013-07-21T10:24:43 <ThomasWaldmann> any questions about the above stuff?
97 2013-07-21T10:25:35 <waldi> nop
98 2013-07-21T10:25:53 <ThomasWaldmann> ok, looks like not. ananasova / waldi: you're next, please.
99 2013-07-21T10:26:06 <ananasova> ok, starting
100 2013-07-21T10:26:24 <ananasova> DONE:
101 2013-07-21T10:26:29 <ananasova> * Finished with emailing tracebacks to admins
102 2013-07-21T10:26:33 <ananasova> * Update subscription validator
103 2013-07-21T10:26:37 <ananasova> * Indexing subscriptions list
104 2013-07-21T10:26:43 <ananasova> * Determining subscribers list by checking also subscription_patterns
105 2013-07-21T10:26:48 <ananasova> * Changes in views and templates where user subscription functions are used
106 2013-07-21T10:26:53 <ananasova> * Planning on mail notifications, metadiff, mail templates
107 2013-07-21T10:26:58 <ananasova> TODO next week:
108 2013-07-21T10:27:03 <ananasova> * Mail notifications + mail templates
109 2013-07-21T10:27:08 <ananasova> * Subscriptions UI in settings
110 2013-07-21T10:27:12 <ananasova> * Planning on bounce handling
111 2013-07-21T10:27:16 <ananasova> BLOCKERS: none
112 2013-07-21T10:28:30 <ThomasWaldmann> 12:26 ananasova$ * Changes in views and templates where user subscription functions are used
113 2013-07-21T10:28:37 <ThomasWaldmann> what do you mean by that precisely?
114 2013-07-21T10:29:31 <ananasova> the definition of some method has changed: i.e. from is_subscribed_to([pagename_list]) to is_subscribed_to(item)
115 2013-07-21T10:30:39 <ananasova> and respectively all the views that render a template that inherits from itemviews.html need to pass item object
116 2013-07-21T10:31:38 <ThomasWaldmann> ok
117 2013-07-21T10:31:44 <dreimark> that means you reviewed all stuff which created tracebacks related to sending mails to admins?
118 2013-07-21T10:31:55 <ananasova> same is with `subscribe()` and `unsubscribe()` methods
119 2013-07-21T10:33:04 <ananasova> dreimark: yes, there were 2 cr on that part iirc and the code was pushed to the public repo
120 2013-07-21T10:33:27 <ThomasWaldmann> ananasova: in case you have some time when you can't work on more urgent stuff, it would be nice to do some performance eval with many users
121 2013-07-21T10:33:58 <ananasova> good point. that means write some performance tests?
122 2013-07-21T10:34:38 <dreimark> ananasova: are there tests for these changes or have you tried that manually?
123 2013-07-21T10:35:03 <ananasova> there are simple tests for determining subscribers
124 2013-07-21T10:35:25 <ananasova> like, one item - one subscriber
125 2013-07-21T10:35:30 <ThomasWaldmann> yes. but as I said: that's low prio. also tests that take lots of time and are only for performance testing should be skipped in the default test run.
126 2013-07-21T10:36:16 * ananasova puts it on todo for the next week with a low prio flag
127 2013-07-21T10:37:31 <spy_> ThomasWaldmann: can I be next?
128 2013-07-21T10:37:48 <ThomasWaldmann> spy_: yes, after ananasova is finished
129 2013-07-21T10:37:55 <ThomasWaldmann> anything else for ananasova ?
130 2013-07-21T10:38:07 <ananasova> and the public repo is good for being pulled and tested
131 2013-07-21T10:38:57 <ThomasWaldmann> ok, thanks ananasova, spy_ is next.
132 2013-07-21T10:39:45 <ThomasWaldmann> ananasova: waldi: btw, i didn't see any bounce handling planning yet. that should be done asap or at some time you might run out of planned work.
133 2013-07-21T10:40:25 <spy_> DONE: Start implementing view +addcomment and input form to add new comment on a particular page. Looked through the bootstrap documentation. (My grandmother died a few days ago, so there was no time for work)
134 2013-07-21T10:40:29 <spy_> BLOCKED: nothing
135 2013-07-21T10:40:32 <spy_> TODO: Finish views/templates to be able to create simple one-level comments.
136 2013-07-21T10:40:37 <dreimark> to early
137 2013-07-21T10:40:57 <dreimark> ananasova: there is a py.test option for skipping if too long time is needed
138 2013-07-21T10:41:11 <ThomasWaldmann> spy_: oh :| sorry to hear that.
139 2013-07-21T10:42:21 <dreimark> spy_: oha, my condolences
140 2013-07-21T10:43:15 <dreimark> ThomasWaldmann: ananasova have we more or can we go on with spy_ ?
141 2013-07-21T10:43:27 <ananasova> dreimark: ok, pytest.mark.skipif i see in tests
142 2013-07-21T10:43:55 <spy_> thank you, it is all right, will continue working
143 2013-07-21T10:44:12 <ananasova> spy_: very sorry :(
144 2013-07-21T10:45:15 <ThomasWaldmann> spy_: try to get some stuff done AND pushed. there isn't much visible work from you in the repo and midterm is approaching.
145 2013-07-21T10:45:17 <spy_> should I start working on the bootstrap theme?
146 2013-07-21T10:45:44 <ThomasWaldmann> no, please don't merge anything except main repo
147 2013-07-21T10:46:25 <ThomasWaldmann> bootstrap is available in main repo, though, so maybe you can use some of it for content area stuff
148 2013-07-21T10:47:57 <ThomasWaldmann> but maybe you can just get the work / data flow right now and do design stuff later
149 2013-07-21T10:48:10 <spy_> ok, I think so too
150 2013-07-21T10:48:21 <dreimark> spy_: try to get that flow running
151 2013-07-21T10:48:56 <spy_> btw, I have some Comment itemtype stuff finished, but it is far from the ideal. Should I push it too?
152 2013-07-21T10:49:22 <dreimark> can you show it please
153 2013-07-21T10:49:47 <spy_> dreimark: https://codereview.appspot.com/10761044/
154 2013-07-21T10:50:16 <spy_> now I'm working on top of this patch
155 2013-07-21T10:50:36 <dreimark> thomas added a question to that
156 2013-07-21T10:51:13 <dreimark> the things you know are not best solved, have they ToDo markers?
157 2013-07-21T10:52:49 <ThomasWaldmann> xiaq: are you still away?
158 2013-07-21T10:53:16 <spy_> dreimark: there are a lot of todo stuff all the time))
159 2013-07-21T10:54:29 <dreimark> spy_: commit it, I guess you refactor it in the next weeks
160 2013-07-21T10:55:06 <ThomasWaldmann> ok, xiaq is still away, but didn't commit anything recently anyway. some work on codereview.
161 2013-07-21T10:58:39 <ThomasWaldmann> for all students: we'll begin doing/submitting midterm evals at july 29th, so try to have stuff in a good state and try to have all the work you've done somehow reflected in the repo or (if it was not coding work) in the calendar entries or in documentation
162 2013-07-21T11:00:18 <ThomasWaldmann> the deadline for mentors to submit midterm evals is Aug 2nd 19:00 UTC (but, as usual, don't rely on melange being stable in the last hours before the deadline)
163 2013-07-21T11:00:59 <ThomasWaldmann> ok, anything else?
164 2013-07-21T11:02:41 <ThomasWaldmann> meeting is over, thanks to everybody who managed to be here.
165 2013-07-21T11:21:44 <TheSheep> thanks
166 2013-07-21T11:22:15 <dreimark> :)
167 2013-07-21T11:55:18 <sharky93> TheSheep: some notes on the test, need your final comment on this
168 2013-07-21T11:55:23 <sharky93> TheSheep: @ http://pastebin.com/ie8fErUw
169 2013-07-21T11:57:34 <TheSheep> sharky93: I was rather thinking about finding an option in the xml library to do that without a regexp
170 2013-07-21T12:01:12 <sharky93> TheSheep: im not too sure if that can be done at all, since the 'xmlns' attribute is put into the string at the time of writing, there's functions for editing attributes for nodes, but xmlns is not a part when it is in the tree form
171 2013-07-21T12:08:20 <TheSheep> sharky93: you can look into that library's source code
172 2013-07-21T12:20:39 *** greg_
173 2013-07-21T12:51:10 *** moin4
174 2013-07-21T12:51:45 <moin4> recently, my wiki server performance is getting worse and worse
175 2013-07-21T12:52:32 <moin4> i found server process was in forever loop to read data/event and another log file in data dir
176 2013-07-21T12:52:54 <moin4> can some one shed some light on this, thanks,
177 2013-07-21T12:54:33 <TheSheep> moin4: wrong channel
178 2013-07-21T12:59:17 *** moin4
179 2013-07-21T14:37:13 <ThomasWaldmann> oh, we have a release of whoosh 2.5 since July 2nd
180 2013-07-21T14:52:46 *** warps
181 2013-07-21T14:52:53 <sharky93> TheSheep: i had a look at the emeraldtree code, there's not a good way to achieve what we want, it has to have the namespace string with "xmlns" in only the root node ..
182 2013-07-21T14:53:55 <sharky93> TheSheep: what we could realistically do is set a test flag and not allow it to write that? but is that a better method than using a simple regex? or rather needs to be done? im not sure.
183 2013-07-21T14:55:27 <TheSheep> sharky93: how about having a root node?
184 2013-07-21T14:55:55 <TheSheep> sharky93: and then just serializing a subtree without that node?
185 2013-07-21T14:59:53 <sharky93> TheSheep: when we serialize, it first gathers namespace info about the whole tree, and writes that in the root node. (putting it in a crude way)
186 2013-07-21T15:02:51 <sharky93> TheSheep: so we somehow have to stop the writing of that info, in the string we get back .., no?
187 2013-07-21T15:05:01 <TheSheep> I don't think it hurts if it's just in a single node
188 2013-07-21T15:06:57 * ThomasWaldmann gtg / bbl
189 2013-07-21T15:35:26 <xiaq> ThomasWaldmann: comments required on the new MoinMoin.schema package https://codereview.appspot.com/10889044/
190 2013-07-21T16:24:38 <sharky93> re
191 2013-07-21T16:25:16 <sharky93> TheSheep: hmm, so we leave it as it is ?, commit?
192 2013-07-21T16:35:26 <ThomasWaldmann> xiaq: did you anything else than moving the code?
193 2013-07-21T16:36:51 <TheSheep> sharky93: without the regexp
194 2013-07-21T16:46:01 *** rciorba
195 2013-07-21T17:17:33 *** warps
196 2013-07-21T18:03:30 <sharky93> TheSheep: without the regexp @ https://codereview.appspot.com/11650043/ . Though i haven't changed rst_in. removing regex from there will lead to changes in all current tests.
197 2013-07-21T18:05:21 <TheSheep> sharky93: remove the import
198 2013-07-21T18:05:54 <sharky93> oh right, sry.
199 2013-07-21T18:13:52 <TheSheep> sharky93: otherwise it's good
200 2013-07-21T18:15:13 *** greg_
201 2013-07-21T18:20:46 <sharky93> TheSheep: so with the tests done.. i'll commit the search sometime later , what's next?
202 2013-07-21T18:24:01 <TheSheep> sharky93: the editor maybe?
203 2013-07-21T18:24:27 <TheSheep> I mean the "modify" view
204 2013-07-21T18:25:22 <sharky93> TheSheep: hmm, okay. how should we go about developing that view?
205 2013-07-21T18:25:53 <sharky93> any suggested workflows?
206 2013-07-21T18:36:41 <TheSheep> sharky93: it's up to you
207 2013-07-21T18:38:17 *** xorRaxRax
208 2013-07-21T18:38:26 *** TheSheep
209 2013-07-21T18:38:26 *** sharky93
210 2013-07-21T18:38:26 *** eSyr-ng
211 2013-07-21T18:38:26 *** sunu
212 2013-07-21T18:38:26 *** dreimark
213 2013-07-21T18:38:26 *** waldi
214 2013-07-21T18:38:26 *** ThomasAH
215 2013-07-21T18:38:59 *** xorRaxRax
216 2013-07-21T18:40:23 *** xorRaxRax
217 2013-07-21T18:47:25 *** sunu
218 2013-07-21T18:47:25 *** waldi
219 2013-07-21T18:47:29 *** sharky93
220 2013-07-21T18:47:33 *** eSyr-ng
221 2013-07-21T18:47:49 *** waldi
222 2013-07-21T18:47:49 *** waldi
223 2013-07-21T18:48:07 *** TheSheep
224 2013-07-21T18:48:48 *** ThomasAH
225 2013-07-21T18:53:17 *** dreimark
226 2013-07-21T19:14:53 *** spy__
227 2013-07-21T19:20:08 *** spy_
228 2013-07-21T19:20:08 *** SteveMcIntyre
229 2013-07-21T19:20:54 *** SteveMcIntyre
230 2013-07-21T19:46:02 *** vpv
231 2013-07-21T19:53:11 *** vpv_
232 2013-07-21T19:57:30 *** vpv_
233 2013-07-21T19:59:38 *** vpv
234 2013-07-21T20:20:38 <dreimark> http://www.youtube.com/watch?v=RBL1cVzIQik
235 2013-07-21T20:20:46 <dreimark> some ideas for Nonlinear Revision Control for Images
236 2013-07-21T20:21:14 <dreimark> also the ui looks nice
237 2013-07-21T21:08:07 *** rciorba
238 2013-07-21T22:54:21 *** rciorba
239 2013-07-21T23:11:32 * sharky93 says gn
240
