1 2013-07-24T00:12:30 *** rciorba
2 2013-07-24T06:03:20 *** rciorba
3 2013-07-24T06:45:31 <TheSheep> ThomasWaldmann: no, I can't say I do
4 2013-07-24T06:46:35 <xiaq> ThomasWaldmann: you mean "any js bootstrap extensions"? :)
5 2013-07-24T06:48:14 <TheSheep> http://jasny.github.io/bootstrap/
6 2013-07-24T06:48:36 <xiaq> there are quite some out there... i've used https://github.com/jschr/bootstrap-modal and http://www.eyecon.ro/bootstrap-datepicker/
7 2013-07-24T06:48:52 <xiaq> TheSheep: ah... got it :)
8 2013-07-24T06:49:42 *** rciorba
9 2013-07-24T06:59:36 <TheSheep> ThomasWaldmann: looks good
10 2013-07-24T06:59:42 <TheSheep> sharky93: what do you think?
11 2013-07-24T07:34:17 <dreimark> moin
12 2013-07-24T07:35:09 <ananasova> moin
13 2013-07-24T07:36:41 <TheSheep> sharky93: the tabs don't work with javascript disabled
14 2013-07-24T08:27:15 <sharky93> moin
15 2013-07-24T08:28:44 *** not-xjjk
16 2013-07-24T08:29:33 *** dennda__
17 2013-07-24T08:29:56 *** dennda_
18 2013-07-24T08:29:58 *** xjjk
19 2013-07-24T08:30:24 <TheSheep> sharky93: http://twitter.github.io/bootstrap/base-css.html#forms <-- scroll to "buttons instead of text"
20 2013-07-24T08:30:30 <TheSheep> sharky93: do you think it would make sense to merge the comment input with the Save button like that?
21 2013-07-24T08:31:36 *** WarP|work
22 2013-07-24T08:36:40 * sharky93 looks
23 2013-07-24T08:40:17 <sharky93> TheSheep: it gets kinda confusing with that, gives an impression that only the comment gets saved and not the changes you do elsewhere like the main textarea? ..
24 2013-07-24T08:40:56 <TheSheep> like it is now, I have trouble finding the button at all
25 2013-07-24T08:41:11 <TheSheep> because it is in a strange place
26 2013-07-24T08:42:18 <sharky93> TheSheep: right below the heading doesnt work ?
27 2013-07-24T08:42:47 <TheSheep> banner blindness
28 2013-07-24T08:43:40 <TheSheep> I would normally expect to find it in a 'form-actions' block at the end of the form
29 2013-07-24T08:45:55 <sharky93> yeah, the end surely makes more sense.
30 2013-07-24T08:49:22 <sharky93> TheSheep: your take on double scrollbars?
31 2013-07-24T08:50:18 <TheSheep> I commented on the issu
32 2013-07-24T08:50:21 <TheSheep> issue
33 2013-07-24T08:56:08 <sharky93> TheSheep: i dont see anything here https://bitbucket.org/sharky93/moin-2.0-bootstrap/issue/14/modify-view-double-scrollbars maybe its still a draft
34 2013-07-24T08:56:56 <TheSheep> oh, I thought you mean https://bitbucket.org/sharky93/moin-2.0-bootstrap/issue/7/irritating-rendering-change-by-dis
35 2013-07-24T08:59:46 <TheSheep> commented
36 2013-07-24T08:59:52 <sharky93> i added a comment on #18
37 2013-07-24T09:01:02 <TheSheep> I know, I have notifications
38 2013-07-24T09:02:24 <sharky93> right :D i just put the phone on silent, too much sound :P
39 2013-07-24T09:07:35 <sharky93> TheSheep: this is the prblem with "active" http://imagebin.org/265467
40 2013-07-24T09:08:37 <TheSheep> sharky93: making all the tabs inactive is not the solution
41 2013-07-24T09:09:25 <sharky93> TheSheep: yes, true, just saying that is the reason i've not implemented that in the code
42 2013-07-24T09:10:00 <sharky93> TheSheep: no issue like that here http://icon.sheep.art.pl/moin/ so i think its the version.
43 2013-07-24T09:10:31 <TheSheep> ThomasWaldmann: did you get any anwswer from that xstatic packager for bootstrap?
44 2013-07-24T09:20:11 <sharky93> TheSheep: so for no JS should we fallback to a simpler layout and possible the General Meta and Extra Meta side by side even there.?
45 2013-07-24T09:20:50 <sharky93> *possibly
46 2013-07-24T09:21:17 <TheSheep> sharky93: no, just make all the tabs visible initially, and hide the inactive ones with js
47 2013-07-24T09:21:35 <TheSheep> sharky93: I thought that bootstrap does that by default
48 2013-07-24T09:27:59 *** greg_f
49 2013-07-24T09:44:48 <TheSheep> sharky93, ThomasWaldmann: by the way, I really recommend this book: http://books.google.pl/books/about/The_non_designers_design_book.html?id=8IlqSMtWCk0C
50 2013-07-24T09:45:45 <TheSheep> (I can "lend" you a copy when I'm home0
51 2013-07-24T09:57:52 <sharky93> TheSheep: hmm, i too find it weird that does happen by default :/
52 2013-07-24T10:02:24 <TheSheep> sharky93: just make all the tab panes active in the generated html
53 2013-07-24T10:07:32 <sharky93> TheSheep: there's an addon to that, will also have to add javascript to make the initial hide, since unless you click on the tab, bootstrap doesnt take over.
54 2013-07-24T10:11:32 * sharky93 wonders how to do that in a clean way.
55 2013-07-24T10:13:05 <TheSheep> just remove the classes on load
56 2013-07-24T10:16:42 <sharky93> TheSheep: maybe trigger a click on the first tab? .. removing is more tiresome
57 2013-07-24T10:17:22 <TheSheep> whatever works
58 2013-07-24T10:17:31 <sharky93> right.
59 2013-07-24T10:18:17 <sharky93> TheSheep: also the classification for basic and extra meta(withJSON) does not make much sense?
60 2013-07-24T10:18:44 <TheSheep> yeah, put them on a single tab
61 2013-07-24T10:49:58 <ThomasWaldmann> TheSheep: sharky93: no answer from xstatic bootstrap packager yet
62 2013-07-24T11:11:42 <ThomasWaldmann> TheSheep: sharky93: yeah, +1 for using same tab for meta. on top, the pretty stuff, below that the extra stuff as json
63 2013-07-24T11:20:50 <sharky93> ThomasWaldmann: we were rather thinking of putting them side by side, there's much screen space available, no?
64 2013-07-24T11:21:37 <sharky93> ThomasWaldmann: https://bitbucket.org/sharky93/moin-2.0-bootstrap/issue/17/display-general-meta-and-extra-meta-forms
65 2013-07-24T11:22:32 <ThomasWaldmann> for now, i'ld just simply arrange vertically
66 2013-07-24T11:22:56 <ThomasWaldmann> and make sure input fields are long enough to show whatever is in there
67 2013-07-24T11:24:08 <TheSheep> sharky93: you could also use form-horizontal
68 2013-07-24T11:24:17 <TheSheep> sharky93: that's a little more compact vertically
69 2013-07-24T11:27:05 * ThomasWaldmann commented on issue
70 2013-07-24T11:38:20 <TheSheep> ThomasWaldmann: if there is no answer about xstatic, can we make our own package?
71 2013-07-24T11:38:56 <TheSheep> sharky93: there is also the question of using bootstrap 3.0
72 2013-07-24T11:42:27 <ThomasWaldmann> i somehow feel it would be less work if we use bs3 from the beginning. the changelog suggests that quite some changes would be needed by the 2-to-3 upgrade
73 2013-07-24T11:43:14 <ThomasWaldmann> that is assuming that bs3 already works quite ok, which I do not know.
74 2013-07-24T11:44:40 <TheSheep> I think they are in beta
75 2013-07-24T11:45:25 <ThomasWaldmann> btw, the jasny extensions have some issues for us: no bs3 yet, still AL2 (no discussion there yet about MIT or so), maybe more dependency on JS.
76 2013-07-24T11:46:41 <ThomasWaldmann> i think we can live with smaller issues, it should just work for most stuff and not get big fundamental changes any more.
77 2013-07-24T11:47:36 <ThomasWaldmann> but maybe we better think about that at midterm
78 2013-07-24T11:48:59 <ThomasWaldmann> TheSheep: btw, what do you think about small/easy tickets getting solved with highest prio? just to get them off the table?
79 2013-07-24T11:49:52 <TheSheep> ThomasWaldmann: I don't want to micromanage sharky
80 2013-07-24T11:50:37 <TheSheep> ThomasWaldmann: I trust he can pick the tasks that have the best outcome himself
81 2013-07-24T11:53:04 <ananasova> ThomasWaldmann: can you please review when free https://codereview.appspot.com/11709044/
82 2013-07-24T11:53:49 <ananasova> if you need to check the changes, i can push the commit
83 2013-07-24T12:41:25 <ThomasWaldmann> ananasova: done. brb in 15mins.
84 2013-07-24T13:07:37 <ThomasWaldmann> ananasova: did you have a look?
85 2013-07-24T13:10:37 <ananasova> ThomasWaldmann: fixing and responding to some comments
86 2013-07-24T13:11:13 <ThomasWaldmann> spy__: what's up? i don't see any activity
87 2013-07-24T13:13:11 <ananasova> and i actually run the code, what for would i need the test first then?
88 2013-07-24T13:15:20 <ThomasWaldmann> ananasova: i just noticed the 2 constants in keys.py and the 3 constants imported in your code
89 2013-07-24T13:16:35 <ananasova> yeah, that was a mistake, used the replace keyword in some place, and then discarded.
90 2013-07-24T13:17:19 <ananasova> and forgot about the import, pycharm likes to shrink import statements
91 2013-07-24T13:20:57 <ananasova> ahh, now i see - it's actually used some place, you were right
92 2013-07-24T13:35:04 <sharky93> TheSheep: ThomasWaldmann about the upgrade from bs2 to 3, i think frameworks usually provide a nice guide, no? a lot of people would be willing to make the jump.. if that's the case an upgrade would not be much tedious.
93 2013-07-24T13:35:24 <sharky93> i think i;ve seen something similar with foundtaion. they recently upgraded to 4.
94 2013-07-24T13:38:07 <TheSheep> sharky93: but why do the same work twice?
95 2013-07-24T13:38:32 <TheSheep> sharky93: plus, bs3 probably has some nice things ;)
96 2013-07-24T13:39:37 <TheSheep> sharky93: take a look http://penguinwebdevelopment.com/bootstrap-3-docs/
97 2013-07-24T13:43:36 <sharky93> TheSheep: that sidebar is buggy :P
98 2013-07-24T13:44:36 <TheSheep> sue them
99 2013-07-24T13:45:24 <sharky93> some more nice features :)
100 2013-07-24T13:46:28 <sharky93> TheSheep: ThomasWaldmann there's one more thing, the bs guys probably have it planned to change the license in v3 only, right? they wont change the license for v2, no?
101 2013-07-24T13:47:32 <TheSheep> it's not clear
102 2013-07-24T13:50:10 <sharky93> hmm, so i carry on with v2 till we sort out the packages.
103 2013-07-24T14:00:34 <ThomasWaldmann> I'ld rather go with v3, but that decision can wait until midterm. your goal is to have something nice and working at midterm, so we shouldn't refactor now. :)
104 2013-07-24T14:01:52 * sharky93 hopes to get the modify view nicely working ;) today itself :)
105 2013-07-24T14:02:19 * ThomasWaldmann .oO(looks like at least 3 people from europython pre-ordered the ubuntu-edge on indiegogo)
106 2013-07-24T14:06:48 <TheSheep> ThomasWaldmann: how do you know?
107 2013-07-24T14:08:23 <ThomasWaldmann> via nothingtohide@librelist.com ML
108 2013-07-24T14:09:03 * ThomasWaldmann brb
109 2013-07-24T14:13:12 <TheSheep> list groups and panels look useful
110 2013-07-24T14:22:20 *** brunomartin
111 2013-07-24T15:22:22 <sharky93> ThomasWaldmann: TheSheep 'Save' sounds better than 'OK', no?
112 2013-07-24T15:23:40 <sharky93> i mean in the modfiy view.
113 2013-07-24T15:23:47 <sharky93> *modify
114 2013-07-24T15:24:01 <ThomasWaldmann> yes
115 2013-07-24T15:45:13 *** dave_largo
116 2013-07-24T16:01:45 <sharky93> TheSheep: ThomasWaldmann how about counting the number of '\n''s in the text to determine the row number for the textarea?
117 2013-07-24T16:04:44 <sharky93> the auto-resize functionality can be provided via JS but by this we get the initial functinality without JS :)
118 2013-07-24T16:16:43 <ThomasWaldmann> yes, might work.
119 2013-07-24T16:17:05 <ThomasWaldmann> it should not be below some specific lower limit, though.
120 2013-07-24T16:17:38 <ThomasWaldmann> ananasova: how is it going?
121 2013-07-24T16:23:29 *** greg_f
122 2013-07-24T16:31:15 * ananasova is writing tests for every possible situation
123 2013-07-24T16:31:47 <ananasova> ThomasWaldmann: and i also left some comments... one thing wasn't really clear to me
124 2013-07-24T16:48:39 *** WarP|work
125 2013-07-24T17:23:28 <ThomasWaldmann> ananasova: replied (I missed your questions at first as there was no new patch)
126 2013-07-24T17:25:40 * ThomasWaldmann brb
127 2013-07-24T19:20:29 <sharky93> ThomasWaldmann: TheSheep quick cr @ http://codereview.appspot.com/11776043
128 2013-07-24T19:34:13 <sharky93> TheSheep: why do you prefer 'self['extra_meta_text'].properties['rows'] = max(ROWS_META, linebreak_count)' over 'self['extra_meta_text'].properties['rows'] = max(linebreak_count, ROWS_META)'
129 2013-07-24T19:34:23 <sharky93> :)
130 2013-07-24T19:39:12 <TheSheep> no differtence, it just didn't show me my comment
131 2013-07-24T19:39:16 <TheSheep> so I repeated it
132 2013-07-24T19:39:23 <TheSheep> and it still didn't show for some reason
133 2013-07-24T19:41:16 *** rciorba
134 2013-07-24T19:41:29 <sharky93> ah, ok
135 2013-07-24T20:34:53 *** brunomartin
136 2013-07-24T20:38:05 *** brunomartin
137 2013-07-24T20:38:21 <sharky93> TheSheep: when a line wraps to the next line in the textarea, we cannot count that by '\n' 's .. hence that method might just not work to get rid of the scrollbar :(
138 2013-07-24T20:39:28 <sharky93> ThomasWaldmann: ^
139 2013-07-24T20:42:43 <TheSheep> sharky93: sure, the way to do it is to put that text in a div with the same css as textarea and check the div's height in the browser, then set the textarea's height to the same value
140 2013-07-24T20:42:53 <TheSheep> sharky93: with js, of course
141 2013-07-24T20:50:08 <sharky93> TheSheep: we might want to use a plugin which also does the auto-resize while modifying.
142 2013-07-24T20:52:28 <sharky93> there are many iirc
143 2013-07-24T21:03:13 <TheSheep> sure
144 2013-07-24T21:03:32 <TheSheep> but as I said, this is not top priority
145 2013-07-24T21:14:37 *** dave_largo
146 2013-07-24T21:21:29 <sharky93> right.
147 2013-07-24T21:47:24 <ananasova> ThomasWaldmann: updated https://codereview.appspot.com/11709044/ , please take a look when free
148 2013-07-24T21:48:30 <ThomasWaldmann> re
149 2013-07-24T22:28:42 *** rciorba
150 2013-07-24T22:42:21 <ThomasWaldmann> ananasova: done
