MoinMoin: MoinMoinChat/Logs/moin-dev/2013-07-26

   1 2013-07-26T00:14:04  *** brunomartin has quit IRC
   2 2013-07-26T05:51:38  <TheSheep> sharky93: no
   3 2013-07-26T05:51:53  <TheSheep> sharky93: you may be interested in this course: http://blog.udacity.com/2013/07/new-course-design-of-everyday-things.html
   4 2013-07-26T06:11:42  *** rciorba has joined #moin-dev
   5 2013-07-26T06:26:54  *** rciorba has quit IRC
   6 2013-07-26T06:40:13  *** rciorba has joined #moin-dev
   7 2013-07-26T08:12:43  *** rciorba has quit IRC
   8 2013-07-26T08:34:19  <sharky93> TheSheep: yeah, seems interesting :)
   9 2013-07-26T08:37:24  <sharky93> moin
  10 2013-07-26T08:37:44  <sharky93> TheSheep: what do you think of the modify view now?
  11 2013-07-26T09:11:23  *** ashutosh1461 has joined #moin-dev
  12 2013-07-26T10:38:35  *** greg_f has joined #moin-dev
  13 2013-07-26T11:30:04  <spy_> ThomasWaldmann: added more explicit checks https://codereview.appspot.com/11715043/
  14 2013-07-26T11:34:56  <TheSheep> sharky93: active tab still doesn't work
  15 2013-07-26T11:35:49  <TheSheep> metadata looks better
  16 2013-07-26T11:57:27  <ThomasWaldmann> moin
  17 2013-07-26T11:57:30  <ThomasWaldmann> ananasova: done
  18 2013-07-26T11:59:45  * ananasova is reading the comments
  19 2013-07-26T12:00:11  <ThomasWaldmann> spy_: you should also notify your mentor ( dreimark ) for reviews.
  20 2013-07-26T12:31:50  *** ashutosh1461 has quit IRC
  21 2013-07-26T12:43:01  *** dave_largo has joined #moin-dev
  22 2013-07-26T13:02:10  <ananasova> ThomasWaldmann: https://codereview.appspot.com/11709044/ updated :)
  23 2013-07-26T13:16:09  *** ashutosh1461 has joined #moin-dev
  24 2013-07-26T13:23:10  *** ashutosh1461 has quit IRC
  25 2013-07-26T13:36:25  *** ashutosh1461 has joined #moin-dev
  26 2013-07-26T14:03:46  <ThomasWaldmann> ananasova: done
  27 2013-07-26T14:10:08  <xiaq> ThomasWaldmann: got time to merge my pr? :) https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/177/3-changesets
  28 2013-07-26T14:10:27  <ThomasWaldmann> not yet
  29 2013-07-26T14:30:47  *** brunomartin has joined #moin-dev
  30 2013-07-26T15:10:57  *** TheSheep has quit IRC
  31 2013-07-26T15:40:02  *** eSyr has quit IRC
  32 2013-07-26T15:41:03  *** rciorba has joined #moin-dev
  33 2013-07-26T15:51:34  *** eSyr has joined #moin-dev
  34 2013-07-26T16:07:38  *** ashutosh1461 has quit IRC
  35 2013-07-26T16:11:20  *** TheSheep has joined #moin-dev
  36 2013-07-26T17:37:26  <spy_> ThomasWaldmann: dreimark: updated cr https://codereview.appspot.com/10761044/ (please look only at the changes specified in the description of the issue)
  37 2013-07-26T17:43:38  <spy_> ThomasWaldmann: dreimark: please review new changeset: https://codereview.appspot.com/11936043
  38 2013-07-26T17:45:06  *** brunomartin has quit IRC
  39 2013-07-26T17:53:09  *** greg_f has quit IRC
  40 2013-07-26T17:56:01  <sharky93> re
  41 2013-07-26T17:57:14  *** brunomartin has joined #moin-dev
  42 2013-07-26T18:15:27  <sharky93> TheSheep: updated with the active tab
  43 2013-07-26T18:45:54  <sharky93> TheSheep: is the modify nicer now? :)
  44 2013-07-26T20:47:01  <ananasova> waldi, ThomasWaldmann: sent you a mail with a sample of the notification on
  45 2013-07-26T20:47:57  <ananasova> item change. please give some feedback on the clearness of the message
  46 2013-07-26T21:09:10  *** dave_largo has quit IRC
  47 2013-07-26T21:13:29  <ananasova> ThomasWaldmann: what's best the way to write tests for the function that will translate diff tuples to text? add extra asserts to the old tests or write new?
  48 2013-07-26T21:49:22  * sharky93 says gn
  49 2013-07-26T21:49:28  <ThomasWaldmann> gn sharky93
  50 2013-07-26T21:49:47  <ThomasWaldmann> ananasova: write new, give tuples as test input, check output. write simple tests first.
  51 2013-07-26T22:28:54  *** brunomartin has quit IRC
  52 2013-07-26T22:32:31  <waldi> ananasova: don't use inline style, always use utf-8
  53 2013-07-26T22:50:54  *** rciorba has quit IRC
  54