1 2013-07-30T02:21:59 *** rciorba
2 2013-07-30T02:53:18 *** rciorba
3 2013-07-30T06:55:31 <ananasova> moin
4 2013-07-30T07:03:48 *** rciorba
5 2013-07-30T07:44:23 *** mtdkw
6 2013-07-30T07:59:54 *** WarP|work
7 2013-07-30T08:02:18 *** rciorba
8 2013-07-30T10:04:55 *** greg_f
9 2013-07-30T10:20:40 *** greg_f
10 2013-07-30T10:44:27 <ThomasWaldmann> moin
11 2013-07-30T11:32:53 *** mtdkw
12 2013-07-30T12:25:01 *** mtdkw
13 2013-07-30T12:34:22 *** dave_largo
14 2013-07-30T12:56:08 *** greg_f
15 2013-07-30T13:21:20 *** ashutosh1461
16 2013-07-30T14:05:32 <ananasova> waldi, ThomasWaldmann: please review when free -> https://codereview.appspot.com/12076044/
17 2013-07-30T14:32:56 *** brunomartin
18 2013-07-30T16:14:54 <ananasova> waldi: there are 3 more issues on cr, i have set you as a reviewer.
19 2013-07-30T16:29:13 <ThomasWaldmann> hi ananasova
20 2013-07-30T16:34:02 *** greg_f
21 2013-07-30T16:36:38 <ThomasWaldmann> ananasova: done
22 2013-07-30T16:59:17 *** mtdkw
23 2013-07-30T18:00:54 <ashutosh1461> ThomasWaldmann, please review https://codereview.appspot.com/11584044
24 2013-07-30T18:09:46 *** moin2
25 2013-07-30T18:09:53 *** moin2
26 2013-07-30T18:10:00 <inquirer> hi there
27 2013-07-30T18:10:16 <inquirer> anyone managed to fix the insert image bug on 1.9.7 ? if you could give me some pointers I could try doing it myself
28 2013-07-30T18:22:07 *** inquirer
29 2013-07-30T18:33:41 <sharky93> moin
30 2013-07-30T18:43:50 <TheSheep> sharky93: moin, so any ideas?
31 2013-07-30T18:49:05 <sharky93> TheSheep: if we have the category name in the metadata for theme specific things, there would not be much change in the way 'site actions' has been written, no?
32 2013-07-30T18:49:16 <sharky93> like you mentioned @ https://bitbucket.org/sharky93/moin-2.0-bootstrap/issue/21/the-site-actions-block-requires-a-complete
33 2013-07-30T18:50:50 <sharky93> why not simply define 'site actions', 'user actions', 'item nav' in config/default and use them in the basic theme?
34 2013-07-30T18:52:13 <TheSheep> sharky93: that would break all the other themes, as you noticed
35 2013-07-30T18:53:07 <TheSheep> sharky93: also, what if someone else makes a different theme that uses different icons with different names?
36 2013-07-30T18:58:42 <sharky93> TheSheep: hmm, ok. how about using a dictionary to map theme-name to icon for each value?
37 2013-07-30T18:59:30 <TheSheep> sharky93: how about putting that dict in the theme itself?
38 2013-07-30T19:00:40 <sharky93> TheSheep: putting in the theme as in ?
39 2013-07-30T19:01:37 <TheSheep> sharky93: so that it's bundled with the theme, and then every theme can use its own dict with whatever data it needs
40 2013-07-30T19:06:34 <sharky93> TheSheep: sounds good, so a separate config for each theme?
41 2013-07-30T19:06:49 <TheSheep> sharky93: why config?
42 2013-07-30T19:09:09 <sharky93> TheSheep: for defining such a dict? or do you mean define in the template itself?
43 2013-07-30T19:10:00 <TheSheep> for a stopgap solution, we can define it in the template, but I had an impression we can have python files in a theme too
44 2013-07-30T19:19:04 <sharky93> TheSheep: having python files in a theme?, like we have config/default.py 's variables in the template?
45 2013-07-30T19:19:33 *** WarP|work
46 2013-07-30T19:20:40 <TheSheep> sharky93: just put it in the template for now
47 2013-07-30T19:21:03 <TheSheep> sharky93: and rememeber to handle the default case -- because users can add their own actions that we don't know
48 2013-07-30T19:21:38 <sharky93> sure
49 2013-07-30T19:25:06 <sharky93> TheSheep: even then, the for loops for site actions, item nav, user actions would pretty much remain the same?
50 2013-07-30T19:26:17 <sharky93> TheSheep: since even thoug we find an element with category say 'site actions', we cannot render it unless the whole 'user_actions' is done
51 2013-07-30T19:26:28 <TheSheep> sharky93: you would get rid of the ifs, and only have one copy of the content
52 2013-07-30T19:26:54 <TheSheep> sharky93: you can have separate for loops for different categories
53 2013-07-30T19:27:57 <sharky93> TheSheep: hmm, ok, but then how do we separate the itemviews, into three categories?, define in the template?[C[C[C
54 2013-07-30T19:29:03 <sharky93> im not too sure of the restrictions jinja has for defining dicts / lists etc. i bet its not much.
55 2013-07-30T19:29:22 <sharky93> ^ s/much/much freedom
56 2013-07-30T19:29:45 <sharky93> *there's
57 2013-07-30T19:34:19 <ananasova> hi ThomasWaldmann :)
58 2013-07-30T19:35:06 <ananasova> left some comments and a fix on issue with base html mail -> https://codereview.appspot.com/12076044
59 2013-07-30T19:36:39 <sharky93> TheSheep: if jinja doesn't allow for it, then defin in config/default ? or try for a separate python file for each theme?
60 2013-07-30T19:38:25 *** rciorba
61 2013-07-30T19:41:27 <TheSheep> sharky93: try it firts
62 2013-07-30T19:41:30 <TheSheep> first
63 2013-07-30T19:41:40 <TheSheep> I have the impression that it allows it
64 2013-07-30T19:42:52 <sharky93> TheSheep: ok, willdo
65 2013-07-30T19:43:56 * sharky93 has to pack stuff, has a train to catch in about 2.5 hrs, travel for around 20-22 hrs.
66 2013-07-30T19:48:48 <TheSheep> have a safe trip
67 2013-07-30T19:53:29 <sharky93> thanks :)
68 2013-07-30T20:02:39 *** ronny_
69 2013-07-30T21:08:25 *** dave_largo
70 2013-07-30T21:20:57 <ThomasWaldmann> re
71 2013-07-30T21:25:51 <ThomasWaldmann> ananasova: done
72 2013-07-30T21:26:16 <ThomasWaldmann> ashutosh1461: looking now
73 2013-07-30T21:57:57 <ThomasWaldmann> ashutosh1461: done
74 2013-07-30T22:49:06 *** rciorba
75 2013-07-30T22:50:49 *** brunomartin
76
