MoinMoin: MoinMoinChat/Logs/moin-dev/2013-07-31

   1 2013-07-31T05:47:21  *** rciorba has joined #moin-dev
   2 2013-07-31T06:35:18  *** rciorba has quit IRC
   3 2013-07-31T06:53:23  <ananasova> moin
   4 2013-07-31T08:14:39  <ThomasWaldmann> moin
   5 2013-07-31T09:43:32  <ananasova> ThomasWaldmann: https://codereview.appspot.com/12076044/ updated with a comment about htmlmailboilerplate
   6 2013-07-31T09:44:17  <ananasova> empty lines make no difference, code is rendered correctly everywhere
   7 2013-07-31T09:51:16  <ananasova> waldi: please review -> https://codereview.appspot.com/12024044/
   8 2013-07-31T10:32:30  <ashutosh1461> moin
   9 2013-07-31T10:55:18  *** WarP|work has joined #moin-dev
  10 2013-07-31T11:58:01  *** greg_f has joined #moin-dev
  11 2013-07-31T13:40:27  <spy_> dreimark: ThomasWaldmann: please have a look when you are free: https://codereview.appspot.com/12164043/
  12 2013-07-31T13:41:54  *** brunomartin has joined #moin-dev
  13 2013-07-31T14:45:29  <ThomasWaldmann> ananasova: done
  14 2013-07-31T14:48:01  <ThomasWaldmann> ananasova: done
  15 2013-07-31T14:48:46  <ThomasWaldmann> spy_: I'am looking soon.
  16 2013-07-31T14:53:20  <ananasova> ThomasWaldmann: besides mentioning MIT license, should i include smth else? link to license? some special format of saying it?
  17 2013-07-31T15:00:59  <ThomasWaldmann> spy_: done
  18 2013-07-31T15:01:21  <ThomasWaldmann> ananasova: you can look into the MIT license what it is demanding...
  19 2013-07-31T15:02:00  <ThomasWaldmann> (but I guess mentioning author, website and "MIT licensed" is more or less OK)
  20 2013-07-31T15:14:47  <spy_> ThomasWaldmann: thank you, already answered on your comments
  21 2013-07-31T15:17:17  <ThomasWaldmann> ok, see there
  22 2013-07-31T15:52:23  <spy_> ThomasWaldmann: ok, about your comment here: https://codereview.appspot.com/11936043/diff/1/MoinMoin/apps/frontend/comment_views.py I guess the form might not be valid in case we have problems only with the contenttype of a comment. Other fields are optional or filled by the server side.
  23 2013-07-31T15:55:27  <spy_> If a user selects the valid contenttype and will not try to fill it with some hackish data everything should be ok
  24 2013-07-31T15:58:57  *** rciorba has joined #moin-dev
  25 2013-07-31T16:02:13  <spy_> later I plan to add another view or modify +addcomment in order to use it with ajax requests.
  26 2013-07-31T16:09:23  <ashutosh1461> ThomasWaldmann, why do we include the name=root_item argument here, https://bitbucket.org/thomaswaldmann/moin-2.0/src/78ed0ce6b718843a37d5b6722ba7f1d45f3caf51/MoinMoin/apps/misc/views.py?at=default#cl-41 ?
  27 2013-07-31T16:24:49  <ThomasWaldmann> spy_: well, usually one validates a form and gives it back with annotations what went wrong if it does not validate
  28 2013-07-31T16:26:16  <ananasova> waldi: updated the cr and left some comments
  29 2013-07-31T16:27:14  <ThomasWaldmann> ashutosh1461: because we want to fetch it from storage?
  30 2013-07-31T16:27:42  <ThomasWaldmann> ashutosh1461: btw, you did get the reminder from google?
  31 2013-07-31T16:28:07  <ThomasWaldmann> eSyr: ^^ same question
  32 2013-07-31T16:28:43  <ThomasWaldmann> you can fill out a preliminary version of the evaluation and do the rest later, but before the deadline.
  33 2013-07-31T16:30:30  <ashutosh1461> ThomasWaldmann, wont the revs list contain each and every existing revision already ? i mean even if we dont pass an additional arg.
  34 2013-07-31T16:30:38  <ashutosh1461> yes i got it
  35 2013-07-31T16:34:24  <ThomasWaldmann> ashutosh1461: it uses the "latest revs" index by default, so it will only get one revision
  36 2013-07-31T16:35:35  *** dave_largo has joined #moin-dev
  37 2013-07-31T16:37:09  <ThomasWaldmann> ashutosh1461: ehrm. maybe it should be **{NAME_EXACT: root_item} rather
  38 2013-07-31T16:38:23  <ThomasWaldmann> did ashutosh1461 btw, you repo is in latest and best state now? will try it out later today.
  39 2013-07-31T16:40:34  <ashutosh1461> ThomasWaldmann, yet to finalize the some stuff that is in progress.
  40 2013-07-31T16:41:58  <ashutosh1461> i committed fixes for some of the bugs though which you pointed out.
  41 2013-07-31T16:48:08  <ThomasWaldmann> ok, gtg / bbl
  42 2013-07-31T17:20:54  *** rciorba has quit IRC
  43 2013-07-31T17:31:53  <spy_> ThomasWaldmann: yes, but the issue is that +addcomment might be requsted from different locations, so we should determine the referer where to go back with the invalid form.
  44 2013-07-31T17:39:47  <spy_> ThomasWaldmann: honestly I would like to have only the ajax version of +addcomment, so it will return a json result of an action. Such a way we get rid of issues with redirects. I'm not sure if we should provide a non-javascript way to add comments as well.
  45 2013-07-31T17:42:18  *** greg_f has quit IRC
  46 2013-07-31T17:50:27  <spy_> ThomasWaldmann: maybe even design REST api for it, have you considered this idea before?
  47 2013-07-31T17:58:56  *** WarP|work has quit IRC
  48 2013-07-31T19:10:36  *** brunomartin has quit IRC
  49 2013-07-31T19:22:19  *** brunomartin has joined #moin-dev
  50 2013-07-31T20:57:49  *** dave_largo has quit IRC
  51 2013-07-31T21:10:52  *** rciorba has joined #moin-dev
  52 2013-07-31T22:22:42  *** brunomartin has quit IRC
  53 2013-07-31T23:02:18  *** rciorba has quit IRC
  54