MoinMoin: MoinMoinChat/Logs/moin-dev/2013-08-09

   1 2013-08-09T07:06:24  <ananasova> moin
   2 2013-08-09T07:53:21  <ananasova> ThomasWaldmann: if an item has several revisions, the item was deleted and afterwords an item with the same name was created, for notifications shall we consider it a CREATE or a MODIFY?
   3 2013-08-09T09:14:07  *** greg_f has joined #moin-dev
   4 2013-08-09T09:47:04  <ananasova> ThomasWaldmann: do we need to write tests for signal sending to check if the correct params are being sent or is it redundant?
   5 2013-08-09T10:02:11  <sharky93> moin
   6 2013-08-09T10:06:13  <ThomasWaldmann> ananasova: i guess we would look at the itemid. if it is the same, it is rather a modify 0 -> 1 names. if is is a new itemid, it is a create.
   7 2013-08-09T10:07:07  <ananasova> ok
   8 2013-08-09T10:08:06  <ThomasWaldmann> (the first one could be a revert, for example, or an admin modifying a garbage item)
   9 2013-08-09T10:10:10  <ThomasWaldmann> ... which is both the same. revert would be a garbage view option (for users), destroy would be also one (for admins)
  10 2013-08-09T10:10:44  <ananasova> and we also will tell the user explicitly that a revert happened, not just a modify
  11 2013-08-09T10:11:39  <ThomasWaldmann> the view knows it
  12 2013-08-09T10:15:37  <ananasova> ThomasWaldmann: what about the question with signalling? ^
  13 2013-08-09T10:19:31  <ThomasWaldmann> blinker is supposed to have tests, so you don't need to test if blinker is working correctly.
  14 2013-08-09T10:19:40  <ThomasWaldmann> but you need to test YOUR code
  15 2013-08-09T11:45:59  <ananasova> ThomasWaldmann: can you please review? https://codereview.appspot.com/12695043/
  16 2013-08-09T11:56:54  <ThomasWaldmann> ananasova: done, but see my comment
  17 2013-08-09T11:57:00  * ThomasWaldmann gtg now / bbl
  18 2013-08-09T12:14:09  <ananasova> ThomasWaldmann: when back, please take a look at the updated cr :)
  19 2013-08-09T12:48:33  <ananasova> waldi: can you please review? https://codereview.appspot.com/12665045/
  20 2013-08-09T12:51:23  *** dave_largo has joined #moin-dev
  21 2013-08-09T14:56:29  <ThomasWaldmann> asingla: are you having courses again?
  22 2013-08-09T16:16:31  <ThomasWaldmann> ananasova: sorry, was busy, but maybe can do it later...
  23 2013-08-09T16:16:42  * ThomasWaldmann bbl
  24 2013-08-09T16:18:42  <ananasova> no rush :) do it when you feel free
  25 2013-08-09T18:09:43  *** greg_f has quit IRC
  26 2013-08-09T18:31:37  *** ashutosh1461 has joined #moin-dev
  27 2013-08-09T18:31:39  <ashutosh1461> moin
  28 2013-08-09T18:32:16  <ashutosh1461> ThomasWaldmann, yes college has begun :(
  29 2013-08-09T19:13:03  <ashutosh1461> ThomasWaldmann, maybe a history like display for garbage view would be more suitable than the current view.
  30 2013-08-09T19:34:28  *** brunomartin has joined #moin-dev
  31 2013-08-09T20:10:40  *** brunomartin has quit IRC
  32 2013-08-09T20:17:41  <sharky93> re
  33 2013-08-09T20:18:13  <dreimark> moin
  34 2013-08-09T20:46:56  <ThomasWaldmann> https://bitbucket.org/sharky93/moin-2.0-bootstrap
  35 2013-08-09T20:47:00  *** mpathy has joined #moin-dev
  36 2013-08-09T20:47:06  <ThomasWaldmann> https://bitbucket.org/sharky93/moin-2.0-bootstrap
  37 2013-08-09T20:52:26  <sharky93> ThomasWaldmann: umm, ? :)
  38 2013-08-09T20:53:13  *** allure has joined #moin-dev
  39 2013-08-09T21:10:51  <sharky93> ThomasWaldmann: TheSheep for fixing https://bitbucket.org/sharky93/moin-2.0-bootstrap/issue/10/breaking-long-text-in-sidebars how about writing a filter that breaks text at intervals of some n chars and adds a '- ', and is further taken care by word-wrap on the frontend. ?
  40 2013-08-09T21:11:38  *** allure has quit IRC
  41 2013-08-09T21:16:24  *** dave_largo has quit IRC
  42 2013-08-09T21:49:14  <sharky93> ThomasWaldmann: TheSheep another alternative would be using something similar to the 'shorten_item_name' filter, which adds '...' in the middle of the text.
  43 2013-08-09T22:14:47  <ashutosh1461> ThomasWaldmann, changed the layout http://imagebin.org/index.php?mode=image&id=267045
  44 2013-08-09T22:15:47  <ashutosh1461> reverting works good and there is a entry in the garbage table if you rename ["foo","bar"] to any of ["foo"] / [] / ["buz"] ...
  45 2013-08-09T22:18:55  * sharky93 goes for the 'shorten_item_name' filter.
  46 2013-08-09T22:30:21  * sharky93 says gn
  47 2013-08-09T23:06:02  <ashutosh1461> ThomasWaldmann, please review when free https://codereview.appspot.com/12560043/
  48 2013-08-09T23:11:25  *** ashutosh1461 has quit IRC
  49