1 2013-08-11T00:00:55 <ashutosh1461> gn
2 2013-08-11T00:00:57 *** ashutosh1461
3 2013-08-11T06:36:43 <sharky93> moin
4 2013-08-11T06:44:07 *** TheSheep
5 2013-08-11T06:59:06 <sharky93> ThomasWaldmann: i saw the issues you filed on the tracker, some are for later on the timeline, should i put them on hold?
6 2013-08-11T07:03:48 <ananasova> moin
7 2013-08-11T07:54:15 *** TheSheep
8 2013-08-11T08:14:56 <ananasova> waldi: saw your comments. what about the cr on templates? any other comments or suggestions?
9 2013-08-11T09:21:49 *** ashutosh1461
10 2013-08-11T09:26:32 <ashutosh1461> moin
11 2013-08-11T09:59:20 <ThomasWaldmann> moin
12 2013-08-11T10:00:31 * sharky93 wonders if Thomas fixed the android alarm
13 2013-08-11T10:01:06 <waldi> moin
14 2013-08-11T10:01:23 <ThomasWaldmann> dreimark: eSyr: TheSheep: are you there?
15 2013-08-11T10:01:58 <ThomasWaldmann> ashutosh1461: please begin
16 2013-08-11T10:02:52 <ThomasWaldmann> sharky93: got an alarm in time
17 2013-08-11T10:03:47 <ashutosh1461> ok
18 2013-08-11T10:04:05 <ashutosh1461> Done Last Week:
19 2013-08-11T10:04:05 <ashutosh1461> Comitted namespace-root mapping.
20 2013-08-11T10:04:05 <ashutosh1461> Solved issues 10, 11, 18 (To make sure that global views operate on namepsace specific queries also) on my bugtracker.
21 2013-08-11T10:04:05 <ashutosh1461> More work on /+deleted view.
22 2013-08-11T10:04:05 <ashutosh1461> Further planning on what to do for the next half.
23 2013-08-11T10:05:00 <ashutosh1461> TODO next week :- Finish deleted view, and start with the history view.
24 2013-08-11T10:05:58 <ThomasWaldmann> as a general question: are you having courses again? i somehow had the impression you had not much time to work on your project last week.
25 2013-08-11T10:06:43 <ashutosh1461> yes, college has started.
26 2013-08-11T10:07:51 <ashutosh1461> last few weeks were hectic, but i will manage time from next week and onwards.
27 2013-08-11T10:08:05 <ThomasWaldmann> ok.
28 2013-08-11T10:09:08 <ThomasWaldmann> and about the global views, I don't think this is finished, we talked about some stuff yesterday, so it can't be finished now, right?
29 2013-08-11T10:11:08 <ThomasWaldmann> https://bitbucket.org/ashu1461/moin-2.0/commits/93080255a927fbc3e8c8e2659223cc3ab52f7fb6 can you explain?
30 2013-08-11T10:11:14 <ashutosh1461> yes, just a little replacement to do. with the 'all' identifier.
31 2013-08-11T10:11:43 <ThomasWaldmann> issues #10 and #11 is not touched at all
32 2013-08-11T10:11:55 <ThomasWaldmann> (on the tracker)
33 2013-08-11T10:12:31 <ashutosh1461> Global index creates an item with no name (name=u'') , so a check was missing.
34 2013-08-11T10:12:52 <ThomasWaldmann> so i suggest you don't say "solved" until you really have completed solving it, but rather "worked on ..."
35 2013-08-11T10:13:14 <ashutosh1461> ok.
36 2013-08-11T10:14:58 <ThomasWaldmann> and for this u'' in global index result: make sure you fix bugs at the right place, so it has to be checked if that is g.i. rather that should not return u''
37 2013-08-11T10:16:57 * TheSheep is late
38 2013-08-11T10:17:19 * ThomasWaldmann put this into tracker
39 2013-08-11T10:17:32 <ThomasWaldmann> ok, anything else for ashutosh1461 ?
40 2013-08-11T10:18:22 <TheSheep> no
41 2013-08-11T10:18:24 <ThomasWaldmann> ashutosh1461: and we should finish EP planning for the current stuff today, please clean up there, have some own thoughts and ping me afterwards
42 2013-08-11T10:18:56 <ThomasWaldmann> ok, thanks ashutosh1461. ananasova and waldi is next please.
43 2013-08-11T10:19:12 <ThomasWaldmann> are*
44 2013-08-11T10:19:58 <ananasova> ok
45 2013-08-11T10:20:16 <ananasova> DONE:
46 2013-08-11T10:20:16 <ananasova> * Manually tested the subscribe/unsubscribe functionally, fixed a bug
47 2013-08-11T10:20:16 <ananasova> * Passing information to the receivers of signal item_modified - https://codereview.appspot.com/12695043/
48 2013-08-11T10:20:19 <ananasova> * Performance testing for determining subscribers cr - https://codereview.appspot.com/12665045/
49 2013-08-11T10:20:29 <ananasova> TODO next week:
50 2013-08-11T10:20:30 <ananasova> * Create notification class for mail notifications
51 2013-08-11T10:20:30 <ananasova> * Method for formating the notifications according to their type
52 2013-08-11T10:20:30 <ananasova> * Method for sending notifications
53 2013-08-11T10:20:31 <ananasova> * Create a function item_modified signal receiver
54 2013-08-11T10:20:38 <ananasova> BLOCKERS: pending crs on HTML mail templates
55 2013-08-11T10:20:39 <ThomasWaldmann> dreimark: eSyr: can you look at the code produced by spy_ and xiaq how much usable stuff is in there and whether we want to merge it?
56 2013-08-11T10:24:53 <ThomasWaldmann> ananasova: so, the subscription sending is now practically working?
57 2013-08-11T10:25:06 <eSyr> ok.
58 2013-08-11T10:25:49 <ananasova> ThomasWaldmann: no, the notifications are not being sent to users atm.
59 2013-08-11T10:26:35 <waldi> why do you show the manual tests as done if they don't do anything?
60 2013-08-11T10:27:30 <ThomasWaldmann> so what did you test manually?
61 2013-08-11T10:29:19 <ananasova> changing the subscriptions via the Extra MetaData form, because the subscription textarea in the user settings is not yet present
62 2013-08-11T10:31:33 <ananasova> waldi: agree that it is not a task, so i'd have better skipped it.
63 2013-08-11T10:31:52 <ThomasWaldmann> ok, so you added subscriptions manually to user profile. and then?
64 2013-08-11T10:33:57 <ananasova> checking the value of subscribe/unsubscribe on item page. try to unsubscribe (successfully and unsuccessfully when it's a pattern subscription)
65 2013-08-11T10:33:59 <ThomasWaldmann> how about you btw, did courses also start again? had same impression that would didn't get too much done last week.
66 2013-08-11T10:35:04 <ThomasWaldmann> ah, ok, so you only tested the subscription list changing
67 2013-08-11T10:35:23 <ananasova> yes, didn't do much, was off for 2 days due to health problems, the poisoning :(
68 2013-08-11T10:35:42 <ThomasWaldmann> ok, i remember. try to catch up asap.
69 2013-08-11T10:35:53 <ananasova> but no, courses didn't start yet, so i will try to catch up as fast as possible next weeks
70 2013-08-11T10:37:21 * ThomasWaldmann reviewed the perf CR
71 2013-08-11T10:38:01 <ananasova> reload the page, pushed a patch right now
72 2013-08-11T10:38:16 <ThomasWaldmann> ananasova: is that "reverse engineering" stuff solved better now?
73 2013-08-11T10:39:24 <ananasova> yes, can i close this issue? do you any other comments on https://codereview.appspot.com/12695043/ ?
74 2013-08-11T10:43:50 <ThomasWaldmann> that's only for destroy, wasn't the issue present also for other notifications?
75 2013-08-11T10:44:30 <ThomasWaldmann> any other questions for ananasova / waldi ?
76 2013-08-11T10:44:30 <ananasova> it is also for other notification types
77 2013-08-11T10:45:29 <ThomasWaldmann> ok, so please review them all and make sure they are not having to reverse engineer
78 2013-08-11T10:46:02 <ThomasWaldmann> and try >10.000 :)
79 2013-08-11T10:46:21 <ananasova> try test in on my machine?
80 2013-08-11T10:46:28 <ThomasWaldmann> with index, hopefully 10.000 or 100.000 are no issue
81 2013-08-11T10:46:41 <ThomasWaldmann> sure, why not
82 2013-08-11T10:47:12 <ananasova> i have tried 5000, can show some results on cr
83 2013-08-11T10:48:07 <ThomasWaldmann> ok. thanks ananasova / waldi, sharky93 and TheSheep are next, please.
84 2013-08-11T10:48:34 <ThomasWaldmann> ananasova: url for blockers please
85 2013-08-11T10:49:05 <sharky93> ok
86 2013-08-11T10:49:08 <sharky93> Work was done as per the schedule @ http://etherpad.osuosl.org/moin-ui
87 2013-08-11T10:49:08 <sharky93> Week started with the Bootstrap version bump to 3.
88 2013-08-11T10:49:08 <sharky93> Worked on show view, modify view, main layout.
89 2013-08-11T10:49:08 <sharky93> New XStatic packages introduced, Font-Awesome and jquery-autoresize
90 2013-08-11T10:49:08 <sharky93> Some more bug-fixes throughout @ https://bitbucket.org/sharky93/moin-2.0-bootstrap/ #9, #10, #13, #19, #20, #22
91 2013-08-11T10:49:11 <sharky93> TODO:
92 2013-08-11T10:49:13 <sharky93> Refactoring and docs about building the theme, which i'll mostly finish today
93 2013-08-11T10:49:16 <sharky93> BLOCKERS:
94 2013-08-11T10:50:02 * ananasova will list the blockers after sharky finishes
95 2013-08-11T10:50:12 <ThomasWaldmann> sharky93: ?
96 2013-08-11T10:50:30 <sharky93> oh, sry
97 2013-08-11T10:50:36 <sharky93> BLOCKERS:
98 2013-08-11T10:50:37 <sharky93> None
99 2013-08-11T10:50:45 <sharky93> EOF
100 2013-08-11T10:50:49 <ThomasWaldmann> :)
101 2013-08-11T10:51:27 * ThomasWaldmann put some issue / suggestions onto tracker yesterday
102 2013-08-11T10:52:13 * sharky93 put in a comment on some, and thinks one or two other ones need to be put on-hold for later in the timeline as per the ep
103 2013-08-11T10:52:35 * TheSheep found milestones in the bitbucket issue tracker
104 2013-08-11T10:52:49 <TheSheep> sharky93: so you can add a milestone for every week
105 2013-08-11T10:52:54 <TheSheep> sharky93: and assign tickets to them
106 2013-08-11T10:53:07 * sharky93 looks up milestones
107 2013-08-11T10:53:16 <TheSheep> sharky93: it's in the repo settings in bitbucket
108 2013-08-11T10:54:04 <sharky93> looks good
109 2013-08-11T10:54:53 <ThomasWaldmann> sharky93: can you put DONE into EP at left of the items that are completed?
110 2013-08-11T10:55:31 <sharky93> willdo
111 2013-08-11T10:55:41 <ThomasWaldmann> breadcrumbs are not quite done yet, right?
112 2013-08-11T10:55:51 <TheSheep> with the milestones, we can put that EP timeline in the issue tracker
113 2013-08-11T10:56:24 <TheSheep> ThomasWaldmann: I just added one comment for the breadcrumbs
114 2013-08-11T10:56:39 <TheSheep> ThomasWaldmann: but there were no commetns at the meeting start
115 2013-08-11T10:58:17 <sharky93> TheSheep: tw filed some issues yesterday adn i think he refers to https://bitbucket.org/sharky93/moin-2.0-bootstrap/issue/23/combine-breadcrumbs
116 2013-08-11T10:58:21 <sharky93> *and
117 2013-08-11T10:58:49 <sharky93> TheSheep: maybe have a look at all new issues, we'll need your comments :)
118 2013-08-11T11:00:04 <TheSheep> ok, I will do that this evening
119 2013-08-11T11:01:59 <ThomasWaldmann> https://bitbucket.org/sharky93/moin-2.0-bootstrap/issue/33/theme-element-arrangement-ideas-visualized maybe we can talk about that after meeting.
120 2013-08-11T11:03:02 <TheSheep> ThomasWaldmann: I have a train at 13:50
121 2013-08-11T11:03:32 <ThomasWaldmann> I am also pro trying milestones, sharky93 do you please transfer last week and next week from EP to issue tracker using milestones?
122 2013-08-11T11:04:01 <ThomasWaldmann> TheSheep: ok, then another time.
123 2013-08-11T11:04:28 <sharky93> ThomasWaldmann: willdo :)
124 2013-08-11T11:05:06 <ThomasWaldmann> transfer == copy (until we know that milestone there really work :D )
125 2013-08-11T11:05:35 <sharky93> sure, im curious about how they work, hopefully they'll have an undo/edit feature
126 2013-08-11T11:06:40 <ThomasWaldmann> ok, anything else for sharky93 / TheSheep ?
127 2013-08-11T11:07:05 <sharky93> btw my courses match with ashutosh1461 :)
128 2013-08-11T11:07:19 <sharky93> same college, remember ?
129 2013-08-11T11:08:33 <ThomasWaldmann> ah :)
130 2013-08-11T11:08:52 <ThomasWaldmann> do you meet for hacking sometimes?
131 2013-08-11T11:09:21 <sharky93> yeah, sometimes, we're batchmates :)
132 2013-08-11T11:10:36 <sharky93> he is approximately 50 metres away :P
133 2013-08-11T11:10:56 <ThomasWaldmann> sometimes doing stuff together helps even if it is not working on exactly same stuff
134 2013-08-11T11:12:16 <sharky93> hmm
135 2013-08-11T11:12:18 <ThomasWaldmann> ok, looks like we are through for today. thanks to everybody attending.
136 2013-08-11T11:14:00 <ananasova> ThomasWaldmann: pending crs - https://codereview.appspot.com/12076044/ , https://codereview.appspot.com/12111043/
137 2013-08-11T11:14:12 <ananasova> https://codereview.appspot.com/12024044/ and https://codereview.appspot.com/12050047/
138 2013-08-11T11:14:28 <ananasova> they are related to mail templates
139 2013-08-11T11:18:05 <ThomasWaldmann> waldi: https://codereview.appspot.com/12076044/ waiting for you
140 2013-08-11T11:20:20 <ThomasWaldmann> ananasova: > There are del and ins tags. And don't use absolute sizes.
141 2013-08-11T11:20:20 <ThomasWaldmann> Are you suggesting creating constants inside the template?
142 2013-08-11T11:20:21 <ThomasWaldmann> {% set INSERT = "+" %} ?
143 2013-08-11T11:20:57 <ThomasWaldmann> if you talk about html and someone suggests that there are del and ins tags, it means <del> and <ins> and nothing else.
144 2013-08-11T11:21:28 <ThomasWaldmann> see https://codereview.appspot.com/12024044/
145 2013-08-11T11:22:14 <ThomasWaldmann> and there was no reply or work on not using abs. sizes.
146 2013-08-11T11:25:03 <ananasova> ok, i have changed all the fontsizes in em. will fix the margins to % probably.
147 2013-08-11T11:26:23 * ThomasWaldmann did review all of the CRs and added all I found.
148 2013-08-11T11:26:33 <ananasova> about <del> and <ins>, sorry, didn't know that. need to check the support for such tags for different mail clients
149 2013-08-11T11:26:44 <ThomasWaldmann> ananasova: maybe ask waldi for review again AFTER fixing all that is already clear or has already been said.
150 2013-08-11T11:27:13 <ThomasWaldmann> ananasova: ah, ok, yes, please check.
151 2013-08-11T11:29:12 <ananasova> ThomasWaldmann: thank you for reviewing :)
152 2013-08-11T11:33:32 *** ashutosh1461
153 2013-08-11T13:28:35 *** liyan
154 2013-08-11T13:58:56 <ThomasWaldmann> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/375/quicklinks-do-not-scale-get-ugly comments?
155 2013-08-11T14:09:32 <sharky93> ThomasWaldmann: maybe use "More..." to fetch more onclick ?
156 2013-08-11T14:09:59 <sharky93> s/fetch/show
157 2013-08-11T14:20:08 <ThomasWaldmann> if that's the only measure, it is still ugly. onclick ugly.
158 2013-08-11T14:21:04 <ThomasWaldmann> sharky93: do you have basic theme as default theme in your development setup? so you can test without logging in?
159 2013-08-11T14:23:37 <ThomasWaldmann> sharky93: http://localhost:8080/+highlight/rst doesn't work, is not highlighted. css for pygments missing. can you do a quick fix for that or do you need an issue tracker entry?
160 2013-08-11T14:42:36 * ThomasWaldmann filed one
161 2013-08-11T15:20:31 *** liyan
162 2013-08-11T15:35:31 <ananasova> ThomasWaldmann: posted the results for perf testing - https://codereview.appspot.com/12665045/
163 2013-08-11T15:39:44 <ThomasWaldmann> ananasova: seconds?
164 2013-08-11T15:40:13 <ThomasWaldmann> how did you get the values?
165 2013-08-11T15:40:28 <ananasova> with time module
166 2013-08-11T15:40:42 <ananasova> measuring the elapsed time
167 2013-08-11T15:42:14 <ThomasWaldmann> of what?
168 2013-08-11T15:42:54 <ananasova> just the one line where get_subscribers() is called
169 2013-08-11T15:43:23 <ananasova> subscribers = get_subscribers(self.item)
170 2013-08-11T15:46:16 <ThomasWaldmann> ok,as this is a performance test, how about just adding that code and printing the timing values?
171 2013-08-11T15:47:52 <ananasova> ok, i can push the printing parts of function
172 2013-08-11T15:54:07 <ThomasWaldmann> (the print output will only be visible if the is a failing test at the end, though)
173 2013-08-11T15:54:23 <ananasova> ThomasWaldmann: done
174 2013-08-11T15:56:58 <ThomasWaldmann> see there
175 2013-08-11T15:58:09 <ananasova> ok
176 2013-08-11T16:02:15 <ananasova> updated
177 2013-08-11T16:15:52 <ThomasWaldmann> looks ok.
178 2013-08-11T16:16:04 <ThomasWaldmann> currently you have 10000 subscribers found, right?
179 2013-08-11T16:16:17 <ThomasWaldmann> because it always matches
180 2013-08-11T16:17:19 <ThomasWaldmann> you could now try what happens, if only 1% of all users match
181 2013-08-11T18:41:49 *** rciorba
182 2013-08-11T18:58:07 <ananasova> i found a flaw in the performance test. the previous subscriptions must be removed by the time we test the next subscription type.
183 2013-08-11T18:58:58 * ananasova is fixing that
184 2013-08-11T19:22:26 * ThomasWaldmann tunes ugly 1.9 code
185 2013-08-11T19:26:17 <ananasova> ohh, since yesterday...
186 2013-08-11T20:09:51 *** ashutosh1461
187 2013-08-11T20:51:12 <ananasova> ThomasWaldmann: check when free https://codereview.appspot.com/12665045/ , i am running now the perf test
188 2013-08-11T20:59:10 * ananasova says gn
189 2013-08-11T21:12:57 <ThomasWaldmann> gn ananasova
190 2013-08-11T21:16:46 *** liyan
191 2013-08-11T21:21:42 *** liyan
192 2013-08-11T21:23:54 *** rciorba
193 2013-08-11T21:33:43 *** ashutosh1461
194
