1 2013-08-12T06:33:06  <ananasova> moin everybody :)
   2 2013-08-12T06:33:31  <ananasova> ThomasWaldmann: i've posted the last test results here - https://codereview.appspot.com/12665045/
   3 2013-08-12T07:56:56  <ThomasWaldmann> moin
   4 2013-08-12T07:59:00  <ThomasWaldmann> ananasova: that looks pretty good :)
   5 2013-08-12T07:59:52  <ThomasWaldmann> now, if you get it practically working, you solved one of moin 1.x scalability issues \o/
   6 2013-08-12T08:11:10  <ananasova> yey! with the help of mentors' knowledge and skills :)
   7 2013-08-12T08:32:03  <ananasova> ThomasWaldmann: this cr looks fine? can i commit and further base my work on it? https://codereview.appspot.com/12695043
   8 2013-08-12T08:35:24  <dreimark> i wonder abouzt the time import there
   9 2013-08-12T08:44:49  <ananasova> my reasoning was because it's a useless import for other tests from that file. performance tests are skipped when simply running `make test`
  10 2013-08-12T08:58:07  <ananasova> dreimark: ^
  11 2013-08-12T09:10:30  <dreimark> ok
  12 2013-08-12T09:10:58  <dreimark> thought it was not used, but thats likly because of the diff view of the codereview tool
  13 2013-08-12T09:12:08  <ananasova> just diff with an older patch from the cr :)
  14 2013-08-12T09:22:03  *** greg_f has joined #moin-dev
  15 2013-08-12T10:31:38  <ThomasWaldmann> ananasova: there isn't much there to be not ok. :) and you said you prefer doing some stuff that is not ok yet in a subsequent changeset, so just do that. :)
  16 2013-08-12T10:35:13  <ananasova> ok
  17 2013-08-12T10:37:07  <ananasova> i am reseaching now on <del> and <ins> support for mail clients. though i can't see the reason using strikethrough and underline in mails.
  18 2013-08-12T10:37:59  <ananasova> strikeout for deleted content is complicated to read
  19 2013-08-12T10:38:17  <ThomasWaldmann> the styling of these tags is a quite different topic, it is rather about their semantics
  20 2013-08-12T10:38:40  <ThomasWaldmann> (assuming that styling different from default would work)
  21 2013-08-12T10:39:53  <ananasova> their default styling is not suitable, and therefore they will require extra css for tweaking the look
  22 2013-08-12T10:40:35  <ananasova> but the important part is to see if the tags are not striped at all
  23 2013-08-12T12:01:18  *** rciorba has joined #moin-dev
  24 2013-08-12T12:40:27  *** ashutosh1461 has joined #moin-dev
  25 2013-08-12T13:00:41  <ananasova> waldi: please review the 'General base html mail template' cr - https://codereview.appspot.com/12076044/
  26 2013-08-12T13:14:33  <ashutosh1461> moin
  27 2013-08-12T13:15:35  *** rciorba has left #moin-dev
  28 2013-08-12T13:23:10  *** liyan has joined #moin-dev
  29 2013-08-12T13:37:20  *** liyan has quit IRC
  30 2013-08-12T14:08:22  *** ashutosh1461 has quit IRC
  31 2013-08-12T14:35:54  *** brunomartin has joined #moin-dev
  32 2013-08-12T15:13:20  *** ashutosh1461 has joined #moin-dev
  33 2013-08-12T15:41:57  *** allure has joined #moin-dev
  34 2013-08-12T15:41:57  *** allure has joined #moin-dev
  35 2013-08-12T15:51:36  <ashutosh1461> ThomasWaldmann, added a comment here https://bitbucket.org/ashu1461/moin-2.0/issue/18/global-index-does-not-show-any-items
  36 2013-08-12T15:51:57  *** allure has quit IRC
  37 2013-08-12T15:52:08  <ananasova> waldi: replied here - https://codereview.appspot.com/12076044/
  38 2013-08-12T16:50:19  <ashutosh1461> ThomasWaldmann, updated https://codereview.appspot.com/12560043/ please read the description.
  39 2013-08-12T17:02:47  *** dave_largo has joined #moin-dev
  40 2013-08-12T18:31:42  *** greg_f has quit IRC
  41 2013-08-12T18:45:28  *** dave_largo has quit IRC
  42 2013-08-12T18:58:04  <ThomasWaldmann> ashutosh1461: done
  43 2013-08-12T19:24:42  <ashutosh1461> ThomasWaldmann, added a comment here, https://codereview.appspot.com/12560043/diff/28001/MoinMoin/items/__init__.py
  44 2013-08-12T19:44:29  <ananasova> waldi: updated - https://codereview.appspot.com/12111043/ , https://codereview.appspot.com/12024044/ and https://codereview.appspot.com/12050047/
  45 2013-08-12T19:56:48  <ananasova> and also left some comments on the bb issue tracker.
  46 2013-08-12T20:10:49  <ashutosh1461> ThomasWaldmann, updated https://codereview.appspot.com/12560043
  47 2013-08-12T20:12:39  <ananasova> ThomasWaldmann: also left a screenshot link in the cr comments
  48 2013-08-12T20:24:05  <ThomasWaldmann> ananasova: that colour for ins/del comes from the mail client?
  49 2013-08-12T20:24:15  <ThomasWaldmann> (i mean: is it builtin?)
  50 2013-08-12T20:24:32  <ananasova> nope, it is set in the style tag
  51 2013-08-12T20:24:53  <ashutosh1461> ThomasWaldmann, at what point does a comment become eligible to be in trash ?
  52 2013-08-12T20:25:18  <ananasova> ins/del are basicaly just for semantics (as you mentioned before)
  53 2013-08-12T20:25:50  <ThomasWaldmann> ah, still all table driven
  54 2013-08-12T20:26:34  <ThomasWaldmann> waldi: ^
  55 2013-08-12T20:26:44  <ananasova> tables enforce the layout and are a good practise in mail templates
  56 2013-08-12T20:29:25  <ThomasWaldmann> btw, did you succeed in practical subscription tests or is there something missing so they can succeed?
  57 2013-08-12T20:29:44  <ThomasWaldmann> (I mean on the UI and getting some mail sent to you)
  58 2013-08-12T20:30:25  <ananasova> the mail sending is not implemented. it's this week main task
  59 2013-08-12T20:30:57  <ThomasWaldmann> but you have seen that there is already SOME code in moin for sending mails?
  60 2013-08-12T20:32:13  <ananasova> sure, i meant the part with receiving the signal, formating the mail and sending it using the already available functions
  61 2013-08-12T20:33:15  <ThomasWaldmann> there is no planning at all for bounce handling yet btw.
  62 2013-08-12T20:34:49  <ananasova> i was looking at some moin1.9 code. first we need to migrate the script for piping incoming mails
  63 2013-08-12T20:35:47  <ananasova> i suppose we could reuse the functions for incoming mail processing
  64 2013-08-12T20:36:09  <ThomasWaldmann> iirc that was doing some xmlrpc call. no such thing exists in moin2. suggest you do a http request instead.
  65 2013-08-12T20:37:16  <ananasova> yes, xmlrpc is used there
  66 2013-08-12T20:38:25  <ananasova> so far i don't know how to do it, but i will reseach
  67 2013-08-12T20:39:22  <ThomasWaldmann> if you or waldi don't have a better idea: just write a handler ("view") for it that accepts all the stuff as json.
  68 2013-08-12T20:40:15  <ThomasWaldmann> or maybe even the raw email directly?
  69 2013-08-12T20:40:40  <ThomasWaldmann> should have some auth, also
  70 2013-08-12T20:40:52  * ThomasWaldmann brb
  71 2013-08-12T20:44:43  * ananasova is going to bed, gn
  72 2013-08-12T20:56:47  <ashutosh1461> gn
  73 2013-08-12T20:56:48  *** ashutosh1461 has quit IRC
  74 2013-08-12T21:19:29  *** rciorba has joined #moin-dev
  75 2013-08-12T22:05:02  *** brunomartin has quit IRC
  76 2013-08-12T22:56:18  *** rciorba has quit IRC
  77

MoinMoin: MoinMoinChat/Logs/moin-dev/2013-08-12 (last edited 2013-08-12 06:45:03 by IrcLogImporter)