MoinMoin: MoinMoinChat/Logs/moin-dev/2013-08-30

   1 2013-08-30T12:55:07  *** moinBot has joined #moin-dev
   2 2013-08-30T13:21:13  *** ashutosh1461 has joined #moin-dev
   3 2013-08-30T14:20:26  *** MaikuMori has quit IRC
   4 2013-08-30T14:53:27  <ThomasWaldmann> ananasova: done
   5 2013-08-30T14:58:35  <ThomasWaldmann> interesting new feature: hg commit --amend
   6 2013-08-30T15:04:55  <ananasova> and git users say "finally!"
   7 2013-08-30T15:05:04  <ananasova> :D
   8 2013-08-30T15:14:09  <TheSheep> ThomasWaldmann: that's not really new
   9 2013-08-30T15:14:10  <ThomasWaldmann> ;) would be interesting if you get denied from --amend if you already pushed the stuff
  10 2013-08-30T15:14:18  <TheSheep> ThomasWaldmann: you do
  11 2013-08-30T15:15:23  <TheSheep> ThomasWaldmann: http://www.logilab.org/blogentry/88203
  12 2013-08-30T15:18:17  <ananasova> seems logical since you change the SHA with --amend
  13 2013-08-30T15:19:02  <ThomasWaldmann> ananasova: btw, after looking at flask-babel code i think we need a "use that locale in this with block" context manager
  14 2013-08-30T15:20:10  <ThomasWaldmann> maybe you want to discuss that with waldi (and mitsuhiko on #pocoo), just tell your use case and ask if they have a better idea than a ctxmgr temporarily setting a different local on the ctx stack and restoring it when the block is left.
  15 2013-08-30T15:23:22  <ananasova> ok, joining their channel
  16 2013-08-30T16:28:22  <ThomasWaldmann> maybe such stuff should be even rather part of flask-babel than moin...
  17 2013-08-30T16:31:33  <ananasova> if this is a common usecase, then a pull request to flask-babel would work
  18 2013-08-30T17:24:10  <ashutosh1461> ThomasWaldmann, please review https://codereview.appspot.com/13290045
  19 2013-08-30T18:24:21  <ananasova> ThomasWaldmann: https://github.com/mitsuhiko/flask-babel/issues/2 and there's also a pull request solving the problem
  20 2013-08-30T18:25:15  <ashutosh1461> ThomasWaldmann, also please review https://codereview.appspot.com/13440043/
  21 2013-08-30T19:03:17  <ThomasWaldmann> ananasova: you should add your use case on issue 2, currently it rather looks like "won't do anything about it"
  22 2013-08-30T19:04:30  <ThomasWaldmann> ashutosh1461: will have a look when I'm at home again.
  23 2013-08-30T19:08:44  <ThomasWaldmann> ananasova: you could just take that code and monkeypatch it into flask-babel until it officially gets there ;)
  24 2013-08-30T19:21:50  <ananasova> initially i wrote a much simpler ctxmanager, but then i accidently found the issue which describes exactly the same problem.
  25 2013-08-30T19:23:25  <ananasova> is it worth adding the usecase to the issue if it's similar to the other listed there?
  26 2013-08-30T19:57:11  <ananasova> ThomasWaldmann: here is a monkeypatch - https://codereview.appspot.com/13444043/
  27 2013-08-30T23:33:49  <ThomasWaldmann> ananasova: sure it's worth. and if only to show it is needed. :)