MoinMoin: MoinMoinChat/Logs/moin-dev/2013-08-31

   1 2013-08-31T00:03:17  <ashutosh1461> gn
   2 2013-08-31T00:03:17  *** ashutosh1461 has quit IRC
   3 2013-08-31T06:56:56  *** moinBot` has joined #moin-dev
   4 2013-08-31T06:59:48  *** eSyr_ has joined #moin-dev
   5 2013-08-31T07:01:00  *** moinBot has quit IRC
   6 2013-08-31T07:03:44  *** sunumons- has joined #moin-dev
   7 2013-08-31T07:10:02  *** SteveMcI1tyre has joined #moin-dev
   8 2013-08-31T07:11:24  *** eSyr has quit IRC
   9 2013-08-31T07:11:25  *** SteveMcIntyre has quit IRC
  10 2013-08-31T07:11:25  *** sunumonster has quit IRC
  11 2013-08-31T08:26:42  *** ashutosh1461 has joined #moin-dev
  12 2013-08-31T08:32:01  <ashutosh1461> moin ThomasWaldmann
  13 2013-08-31T08:35:30  <ashutosh1461> ThomasWaldmann, , replied to your comments here, https://codereview.appspot.com/13440043/
  14 2013-08-31T08:58:32  <ananasova> moin
  15 2013-08-31T09:12:32  <ashutosh1461> ThomasWaldmann, also updated http://etherpad.osuosl.org/moin-itemid 19-31
  16 2013-08-31T09:12:40  <ashutosh1461> ^^ about the history view.
  17 2013-08-31T12:46:40  *** ashutosh1461 has quit IRC
  18 2013-08-31T13:05:31  <ananasova> ThomasWaldmann: updated - https://codereview.appspot.com/13444043/
  19 2013-08-31T13:18:07  *** ashutosh1461 has joined #moin-dev
  20 2013-08-31T15:56:23  <ThomasWaldmann> moin
  21 2013-08-31T16:07:49  <ThomasWaldmann> ashutosh1461: looking...
  22 2013-08-31T16:55:35  <ashutosh1461> ThomasWaldmann, are you done ?
  23 2013-08-31T17:55:37  <ThomasWaldmann> yes, took a bit, got distracted
  24 2013-08-31T17:59:37  <ashutosh1461> ThomasWaldmann, replied here, https://codereview.appspot.com/13440043/diff/1/MoinMoin/forms.py
  25 2013-08-31T18:00:17  <ashutosh1461> ThomasWaldmann, also please review, https://codereview.appspot.com/13290045/
  26 2013-08-31T18:11:34  <ThomasWaldmann> replied on cr
  27 2013-08-31T19:21:54  <ThomasWaldmann> sharky93: btw, what's up? didn't see any recent work from you
  28 2013-08-31T19:56:23  * ThomasWaldmann filed multiple, easy to discover bugs.
  29 2013-08-31T20:32:33  <ashutosh1461> ThomasWaldmann, this should be better, https://codereview.appspot.com/13440043/
  30 2013-08-31T20:41:33  <ThomasWaldmann> ashutosh1461: btw, if you feel unconcentrated while coding late in the night, maybe you should take some other time?
  31 2013-08-31T21:23:31  <ashutosh1461> ThomasWaldmann, daytime i have classes, no other option left
  32 2013-08-31T21:26:38  <ashutosh1461> ThomasWaldmann, the code is working fine.. are there any problems ?
  33 2013-08-31T22:19:43  <ThomasWaldmann> no, that code can't work fine
  34 2013-08-31T22:19:56  <ThomasWaldmann> if you think that, you are not testing correctly
  35 2013-08-31T22:24:04  * ashutosh1461 tests again
  36 2013-08-31T22:29:52  <ashutosh1461> ThomasWaldmann, yes you are right, it is going into both the validators simultaneously. not step by step as expected
  37 2013-08-31T22:30:51  <ThomasWaldmann> just find out the type of attribute .validate
  38 2013-08-31T22:31:02  <ThomasWaldmann> if it's not obvious from the name.
  39 2013-08-31T22:45:18  <ThomasWaldmann> ananasova: maybe you shouldn't check for text types, but just call a diff method on the item, that is appropriate for that kind of item.
  40 2013-08-31T22:45:23  <ashutosh1461> ThomasWaldmann, what should i do to get that working ?
  41 2013-08-31T22:45:45  <ThomasWaldmann> read the docs?
  42 2013-08-31T22:45:55  <ashutosh1461> i was just reading about flatland
  43 2013-08-31T22:46:09  <ThomasWaldmann> so, what is the type of .validate?
  44 2013-08-31T22:48:54  <ashutosh1461> its a function
  45 2013-08-31T22:49:08  <ashutosh1461> that returns true/false depending upon the element is validated or not
  46 2013-08-31T22:50:24  <ThomasWaldmann> and how do you use .validate ?
  47 2013-08-31T22:52:40  <ashutosh1461> i found out where i was wrong
  48 2013-08-31T22:53:04  <ashutosh1461> if you call validate on a parent, it automatically checks the validators for the children
  49 2013-08-31T22:54:31  <ashutosh1461> but it is also written, "Note that recursion does not stop if it finds an invalid child: all children are evaluated, and each will have its valid attribute updated."
  50 2013-08-31T22:56:41  <ThomasWaldmann> https://codereview.appspot.com/13440043/diff/21001/MoinMoin/forms.py
  51 2013-08-31T22:57:03  <ThomasWaldmann> you talk of calling a function, i don't see that there in line 134 and 136
  52 2013-08-31T23:01:22  <ashutosh1461> hmm, its an instance method.
  53 2013-08-31T23:01:32  <ashutosh1461> ThomasWaldmann, managed a hack
  54 2013-08-31T23:01:48  * ashutosh1461 uploads a patch to cr ..
  55 2013-08-31T23:07:13  <ashutosh1461> ThomasWaldmann, updated https://codereview.appspot.com/13440043/
  56 2013-08-31T23:15:48  <ashutosh1461> ThomasWaldmann, i am not using form.validate(state) there because we dont want to validate names until we have a valid JSON meta.
  57 2013-08-31T23:20:30  <ThomasWaldmann> can't you do such stuff in the form validator?
  58 2013-08-31T23:22:12  <ThomasWaldmann> any, i suggest you continue that tomorrow
  59 2013-08-31T23:22:17  <ThomasWaldmann> anyway*
  60 2013-08-31T23:22:34  <ThomasWaldmann> (i mean after sleeping)
  61 2013-08-31T23:23:06  <ashutosh1461> i thought about doing that initially but didn't get any idea on how to do that
  62 2013-08-31T23:26:36  <ThomasWaldmann> read the docs, look at the pw code i already hinted you to
  63 2013-08-31T23:27:27  <ashutosh1461> ok thanks :)