MoinMoin: MoinMoinChat/Logs/moin-dev/2013-09-05

   1 2013-09-05T05:11:59  *** ashutosh1461 has joined #moin-dev
   2 2013-09-05T08:42:34  <ThomasWaldmann> ashutosh1461: done
   3 2013-09-05T09:32:59  <ashutosh1461> ThomasWaldmann, does rev.meta contain store CONTENT ?
   4 2013-09-05T09:34:46  <ashutosh1461> I mean the backend store stores meta and data separately but the whoosh indexer stores CONTENT into meta, so when we retrieve meta from revision it gives the meta from backend store, which does not contain the key CONTENT.
   5 2013-09-05T09:37:34  <ThomasWaldmann> if you want precise info, look at the code
   6 2013-09-05T09:37:46  <ThomasWaldmann> but roughly it is like that:
   7 2013-09-05T09:38:45  <ThomasWaldmann> when you lookup/search for stuff, it'll query whoosh and the whoosh documents contain metadata and (extracted) content.
   8 2013-09-05T09:39:31  <ThomasWaldmann> that's in whoosh's result document. when building a moin revision object from that, we will reuse what we already got from whoosh.
   9 2013-09-05T09:40:19  <ThomasWaldmann> so it often won't access backend storage for stuff we got already from the index.
  10 2013-09-05T09:48:45  <ashutosh1461> ThomasWaldmann, when the iterate through the meta, the iterator calls for loading the meta from the backend store. So, the content key does not exist there.
  11 2013-09-05T10:02:54  <ashutosh1461> ThomasWaldmann, updated https://codereview.appspot.com/13527045/
  12 2013-09-05T12:23:00  <ananasova> waldi: ThomasWaldmann: please review - https://codereview.appspot.com/13367047/
  13 2013-09-05T12:40:21  *** dave_largo has joined #moin-dev
  14 2013-09-05T17:31:01  <ThomasWaldmann> ananasova: that url somehow does not work
  15 2013-09-05T17:31:14  <ThomasWaldmann> "error: old chunk mismatch"
  16 2013-09-05T18:16:55  <ashutosh1461> ThomasWaldmann, when you are free please review https://codereview.appspot.com/13527045/
  17 2013-09-05T18:50:06  <ThomasWaldmann> ashutosh1461: so you don't need to delete that CONTENT member?
  18 2013-09-05T18:55:23  <ThomasWaldmann> ashutosh1461: done
  19 2013-09-05T19:09:00  <ashutosh1461> ThomasWaldmann, yes
  20 2013-09-05T19:48:17  <ashutosh1461> ThomasWaldmann, I added some things that should be done in the left weeks, http://etherpad.osuosl.org/moin-itemid (2-11).
  21 2013-09-05T19:50:57  <ananasova> ThomasWaldmann: try this - https://codereview.appspot.com/13418045/
  22 2013-09-05T20:55:53  <ThomasWaldmann> ashutosh1461: done
  23 2013-09-05T21:01:19  * ashutosh1461 has an exam tomorrow, will complete the discussion after that. gn :)
  24 2013-09-05T21:01:23  *** ashutosh1461 has quit IRC
  25 2013-09-05T21:04:33  *** dave_largo has quit IRC
  26 2013-09-05T21:09:03  <ThomasWaldmann> ananasova: some comments done
  27 2013-09-05T21:28:44  <ananasova> ThomasWaldmann: left some comments, https://codereview.appspot.com/13418045/
  28 2013-09-05T21:47:38  <ananasova> related to cr: oldtext / newtext?
  29 2013-09-05T22:29:19  <ThomasWaldmann> see there
  30 2013-09-05T22:35:24  <ananasova> my brain got blind :(
  31 2013-09-05T22:36:54  <ananasova> oldcontent?
  32 2013-09-05T22:49:25  * ananasova says good night
  33