MoinMoin: MoinMoinChat/Logs/moin-dev/2013-09-11

   1 2013-09-11T00:27:02  *** bilal has quit IRC
   2 2013-09-11T08:25:41  *** saif has joined #moin-dev
   3 2013-09-11T08:26:34  *** saif is now known as blackthunder
   4 2013-09-11T08:46:23  *** moin7 has joined #moin-dev
   5 2013-09-11T09:16:44  <ThomasWaldmann> moin
   6 2013-09-11T10:09:17  <blackthunder> moin
   7 2013-09-11T11:24:56  *** brunomartin has joined #moin-dev
   8 2013-09-11T11:57:42  *** brunomartin has quit IRC
   9 2013-09-11T12:31:52  <ThomasWaldmann> hi blackthunder
  10 2013-09-11T12:32:42  <ThomasWaldmann> you are working on moin-related development?
  11 2013-09-11T12:33:41  <ananasova> moin
  12 2013-09-11T12:34:12  <ananasova> ThomasWaldmann: please review a tiny cr - https://codereview.appspot.com/13301046/
  13 2013-09-11T12:46:57  <ThomasWaldmann> https://codereview.appspot.com/13301046/diff/1/MoinMoin/items/content.py
  14 2013-09-11T12:47:02  <ThomasWaldmann> doesn't work
  15 2013-09-11T12:48:39  <ananasova> indeed... fixing it
  16 2013-09-11T12:59:56  <ananasova> ThomasWaldmann: https://codereview.appspot.com/13242055/diff/1/MoinMoin/items/content.py
  17 2013-09-11T13:01:08  <ananasova> this was the third attempt, pretty odd... it gives sometimes this error of old chunk mismatch
  18 2013-09-11T13:14:55  <ThomasWaldmann> done
  19 2013-09-11T13:41:45  *** moin7 has quit IRC
  20 2013-09-11T13:52:05  *** ebo^ has joined #moin-dev
  21 2013-09-11T13:54:52  <ananasova> letf a comment - https://codereview.appspot.com/13242055/
  22 2013-09-11T13:54:57  <ananasova> left*
  23 2013-09-11T13:56:31  <ananasova> awww, moin7 user from moin channel is so friendly :)
  24 2013-09-11T13:59:37  <ThomasWaldmann> ananasova: what wrong with getting an empty list when splitting an empty string?
  25 2013-09-11T13:59:43  <ThomasWaldmann> +'s
  26 2013-09-11T14:04:19  <ananasova> previous tests say that's the expected behaviour, a diff between [u""] and [u"x"] will result in ["- ", "+ x"]
  27 2013-09-11T14:04:45  <ananasova> if we get [] and [u"x"], then the diff is [u"+ x"]
  28 2013-09-11T14:05:22  <ananasova> i thought we must be consistent about all diffs
  29 2013-09-11T14:06:30  <ThomasWaldmann> "nothing" is different from an empty line
  30 2013-09-11T14:07:27  <ThomasWaldmann> so u"" -> u"x" is removing an empty line, adding a line with x
  31 2013-09-11T14:07:46  <ThomasWaldmann> nothing -> u"x" is just adding a line with x
  32 2013-09-11T14:07:52  <ThomasWaldmann> seems perfectly valid
  33 2013-09-11T14:08:59  <ananasova> u"".splitlines() -> [] -> nothing, though there is an empty line there
  34 2013-09-11T14:15:38  <ThomasWaldmann> no, there is nothing
  35 2013-09-11T14:17:16  <ananasova> how then is nothing defined?
  36 2013-09-11T14:17:56  <ThomasWaldmann> no characters in the string is nothing ;)
  37 2013-09-11T14:18:43  <ananasova> and an empty line... u""? should it be at least u"\n"?
  38 2013-09-11T14:18:58  <ThomasWaldmann> think so
  39 2013-09-11T14:19:19  <sharky93> moin
  40 2013-09-11T14:19:24  <ananasova> must change the tests then
  41 2013-09-11T14:19:38  <sharky93> i'm getting an Assertion Error while loading the index .. somehow this function is receiving a '' with  self._name @
  42 2013-09-11T14:19:45  <sharky93> https://bitbucket.org/sharky93/moin-2.0-bootstrap/src/66110f4792afad5079ac8b32e9e39cecff1eb4fa/MoinMoin/storage/middleware/indexing.py?at=default#cl-903
  43 2013-09-11T14:19:48  <ThomasWaldmann> existing tests or your tests?
  44 2013-09-11T14:20:01  <sharky93> ThomasWaldmann: ^^
  45 2013-09-11T14:20:29  <sharky93> ThomasWaldmann: is that expected behaviour?, if yes, then we need to handle it in a better way
  46 2013-09-11T14:20:40  <ananasova> existing tests which assert u"" is an empty line and not nothing
  47 2013-09-11T14:21:21  <ThomasWaldmann> url?
  48 2013-09-11T14:23:33  <ThomasWaldmann> sharky93: be more precise
  49 2013-09-11T14:25:29  <sharky93> ThomasWaldmann: in my bootstrap repo, when i load /+index/ .. i get an Assertion error,
  50 2013-09-11T14:26:19  <ThomasWaldmann> if you do a fresh install of main repo, do you get that error, too?
  51 2013-09-11T14:26:19  <sharky93> ThomasWaldmann: on going through the debug i see that the function @ https://bitbucket.org/sharky93/moin-2.0-bootstrap/src/66110f4792afad5079ac8b32e9e39cecff1eb4fa/MoinMoin/storage/middleware/indexing.py?at=default#cl-903 .. receives a '' (empty string) in self._name .. which is causing the assertion to fail
  52 2013-09-11T14:28:06  <sharky93> ThomasWaldmann: no, the main repo install works fine
  53 2013-09-11T14:29:33  <ananasova> https://bitbucket.org/thomaswaldmann/moin-2.0/src/56ca9d2dcfc912ad042d5a791a3163ff5a7669df/MoinMoin/items/_tests/test_Content.py method on line 230
  54 2013-09-11T14:30:32  <ThomasWaldmann> sharky93: well, then find out why yours is not working fine
  55 2013-09-11T14:30:40  <ananasova> item1.rev.data is '' and item2.rev.data is "test_data"
  56 2013-09-11T14:31:31  <sharky93> ThomasWaldmann: yeah, i just wanted to confirm if its expected of that function to receive a '' in self._name ..
  57 2013-09-11T14:31:45  <ThomasWaldmann> sharky93: and also try starting from scratch with the wiki storage for your code (in case something weird sneaked in there and it is no problem if your code)
  58 2013-09-11T14:32:54  <ThomasWaldmann> of*
  59 2013-09-11T14:35:05  <ThomasWaldmann> ananasova: hmm, that's tricky, as the new line has no \n either...
  60 2013-09-11T14:35:56  <ananasova> soo.. that's confusing how it should be treated
  61 2013-09-11T14:36:49  <sharky93> ThomasWaldmann: i looked up the storage code, it is the same as on the main repo, so im kind of confused about how the error snekaed in.
  62 2013-09-11T14:37:33  <ThomasWaldmann> sharky93: use a debugger and see above
  63 2013-09-11T14:40:13  <sharky93> hmm
  64 2013-09-11T14:43:40  <ananasova> ThomasWaldmann: so i guess we leave it as split('\n')?
  65 2013-09-11T14:49:06  <ThomasWaldmann> ananasova: you can avoid the issue and keep the code by not having an empty string
  66 2013-09-11T14:49:20  <ThomasWaldmann> (keep the splitlines() code)
  67 2013-09-11T14:55:38  <ananasova> and update the tests to not use u"" at all?
  68 2013-09-11T15:09:20  <ananasova> ThomasWaldmann: updated https://codereview.appspot.com/13242055/
  69 2013-09-11T15:18:09  * ThomasWaldmann .oO(how to workaround a problem :D )
  70 2013-09-11T15:33:03  *** dave_largo has joined #moin-dev
  71 2013-09-11T15:38:30  <ananasova> btw any extra comments for the notification functionality? https://codereview.appspot.com/12745048/
  72 2013-09-11T15:55:09  * ThomasWaldmann reviews patch10/13 diff
  73 2013-09-11T16:17:53  *** brunomartin has joined #moin-dev
  74 2013-09-11T16:18:39  <ThomasWaldmann> ananasova: done
  75 2013-09-11T16:59:43  *** ebo^ has quit IRC
  76 2013-09-11T18:23:17  <sharky93> TheSheep: is there something left with #46?
  77 2013-09-11T19:08:23  <TheSheep> sharky93: the logo
  78 2013-09-11T19:10:55  <TheSheep> sharky93: also, put a class on the menu section titles, so that you can style them -- for example, make them bold
  79 2013-09-11T20:42:24  <sharky93> TheSheep: #46 is remake of the user settings, i added the menu section style..
  80 2013-09-11T21:16:21  *** dave_largo has quit IRC
  81 2013-09-11T22:17:10  *** bilal has joined #moin-dev
  82 2013-09-11T22:38:54  *** brunomartin has quit IRC
  83 2013-09-11T22:44:52  *** bilal has quit IRC
  84 2013-09-11T23:11:19  * sharky93 gn
  85