MoinMoin: MoinMoinChat/Logs/moin-dev/2013-09-20

   1 2013-09-20T00:46:30  *** uuliyan has joined #moin-dev
   2 2013-09-20T02:08:44  *** TheSheep has quit IRC
   3 2013-09-20T02:08:51  *** TheSheep has joined #moin-dev
   4 2013-09-20T02:17:49  *** uuliyan has quit IRC
   5 2013-09-20T02:30:32  *** uuliyan has joined #moin-dev
   6 2013-09-20T03:47:25  *** ThomasAH has quit IRC
   7 2013-09-20T03:47:35  *** ThomasAH has joined #moin-dev
   8 2013-09-20T03:49:52  *** uuliyan has quit IRC
   9 2013-09-20T03:50:39  *** uuliyan has joined #moin-dev
  10 2013-09-20T04:35:43  *** uuliyan has quit IRC
  11 2013-09-20T06:46:45  <sharky93> moin
  12 2013-09-20T10:21:44  *** uuliyan has joined #moin-dev
  13 2013-09-20T11:23:41  <ThomasWaldmann> https://togetherjs.com another candidate for collab editor
  14 2013-09-20T11:32:36  <ananasova> moin
  15 2013-09-20T12:22:15  <ananasova> ThomasWaldmann: waldi: i have updated https://codereview.appspot.com/13457059/ and https://codereview.appspot.com/13334053/ . please take a look when free
  16 2013-09-20T12:40:34  *** dave_largo has joined #moin-dev
  17 2013-09-20T12:56:55  *** uuliyan has quit IRC
  18 2013-09-20T13:11:27  <ThomasWaldmann> moin ananasova
  19 2013-09-20T13:11:40  <ThomasWaldmann> https://bitbucket.org/ana-balica/moin-2.0/src/337b8bb2c90337f7d4011f75f12c4835dd32d2aa/MoinMoin/log.py
  20 2013-09-20T13:12:04  <ThomasWaldmann> line 185 has subject as empty str
  21 2013-09-20T13:12:40  <ThomasWaldmann> is the other code also expecting a str or does it take unicode?
  22 2013-09-20T13:13:13  *** uuliyan has joined #moin-dev
  23 2013-09-20T13:13:17  <ThomasWaldmann> (if it is unicode, please also change 209 to use unicode literal)
  24 2013-09-20T13:13:41  <ThomasWaldmann> (and the docstring, telling wether str or unicode is expected there)
  25 2013-09-20T13:28:41  <ananasova> ThomasWaldmann: using unicode -> https://codereview.appspot.com/13629046
  26 2013-09-20T13:36:53  <ananasova> reproduced the infinite recursion error of the emailhandler, sendmail func raises exceptions and those are caught by the get_request_exception signal
  27 2013-09-20T13:46:21  *** moinBot has joined #moin-dev
  28 2013-09-20T13:46:33  <ThomasWaldmann> ah, good you could reproduce
  29 2013-09-20T13:47:38  *** moinBot` has quit IRC
  30 2013-09-20T13:49:38  <ananasova> now can't think of a solution. the log_exception func connected to the signal receives as sender the app object. if only i could determine that the exception is raised by sendmail...
  31 2013-09-20T14:01:13  <ThomasWaldmann> maybe you could set a flag when entering the email-log-handler "i am now in the handler"
  32 2013-09-20T14:01:21  <ThomasWaldmann> (and reset it when leaving)
  33 2013-09-20T14:01:56  <ThomasWaldmann> if the handler then gets entered and the flag is already set, don't try emailing.
  34 2013-09-20T14:02:59  <ThomasWaldmann> not sure what the best alternative is, exceptions should not get hidden
  35 2013-09-20T14:59:11  <ThomasWaldmann> ananasova: maybe have a look at the "propagate" feature of logging. if one would email AND log exceptions, it might be no problem if double-faults would not get emailed, but just end up in the log.
  36 2013-09-20T15:12:53  * ThomasWaldmann gtg
  37 2013-09-20T15:53:32  *** RogerHaase has joined #moin-dev
  38 2013-09-20T15:59:37  *** uuliyan has quit IRC
  39 2013-09-20T16:30:47  *** uuliyan has joined #moin-dev
  40 2013-09-20T17:02:13  <ananasova> solved using a flag - https://codereview.appspot.com/13274046/
  41 2013-09-20T17:02:59  <ananasova> trying also to define a separate logger for EmailHandler... so far unsuccessful
  42 2013-09-20T17:13:01  <ananasova> jek: hi, remember i asked you about appending strings when outputting flatland List of Strings...
  43 2013-09-20T17:15:29  <ananasova> and as it really depends on the specifics of the problem, can you please take a short look at the implementation? https://codereview.appspot.com/13240047/patch/7001/8001
  44 2013-09-20T17:15:58  <ananasova> your advice would be really appreciated
  45 2013-09-20T18:15:10  *** ashutosh1461 has joined #moin-dev
  46 2013-09-20T19:28:14  *** uuliyan has quit IRC
  47 2013-09-20T19:28:59  *** uuliyan has joined #moin-dev
  48 2013-09-20T19:56:16  *** brunomartin has quit IRC
  49 2013-09-20T20:20:34  <ashutosh1461> ThomasWaldmann, please review https://codereview.appspot.com/13790043/ when you are free :)
  50 2013-09-20T21:05:37  *** dave_largo has quit IRC
  51 2013-09-20T21:56:28  *** RogerHaase has left #moin-dev
  52 2013-09-20T22:08:27  <jek> ananasova: a bit hard for me to visualize after a hard day, any chance of seeing you play with the element in the python shell?
  53 2013-09-20T22:18:47  <ashutosh1461> gn
  54 2013-09-20T22:18:48  *** ashutosh1461 has quit IRC
  55