MoinMoin: MoinMoinChat/Logs/moin-dev/2013-10-29

   1 2013-10-29T02:13:18  *** sudo_dirk has quit IRC
   2 2013-10-29T02:19:18  *** sudo_dirk has joined #moin-dev
   3 2013-10-29T05:57:00  *** resurrectorx has joined #moin-dev
   4 2013-10-29T05:57:58  *** resurrectorx has joined #moin-dev
   5 2013-10-29T06:01:19  *** resurrectorx_ has joined #moin-dev
   6 2013-10-29T06:04:48  *** resurrectorx has quit IRC
   7 2013-10-29T06:28:23  *** SunuTheNinja has quit IRC
   8 2013-10-29T06:28:40  *** resurrectorx_ has quit IRC
   9 2013-10-29T06:31:18  *** sunu_ has joined #moin-dev
  10 2013-10-29T08:42:58  *** resurrectorx_ has joined #moin-dev
  11 2013-10-29T08:58:52  *** resurrectorx_ has quit IRC
  12 2013-10-29T09:22:40  <ThomasWaldmann> moin
  13 2013-10-29T09:23:31  <ThomasWaldmann> ananasova: as your code is merged into main repo, can you transfer the open issues from your issue tracker to the main issue tracker?
  14 2013-10-29T09:27:12  *** sunu_ has quit IRC
  15 2013-10-29T09:27:43  *** sunu_ has joined #moin-dev
  16 2013-10-29T09:28:30  *** greg_f has joined #moin-dev
  17 2013-10-29T09:41:12  <ananasova> moin
  18 2013-10-29T09:42:04  <ananasova> ThomasWaldmann: ok, will do
  19 2013-10-29T09:43:11  <ananasova> ThomasWaldmann: please review also this (infinite recursion problem with no globals) -> https://codereview.appspot.com/13274046/patch/30001/40001
  20 2013-10-29T09:45:49  <sharky93> moin
  21 2013-10-29T09:46:59  <ThomasWaldmann> hi sharky93
  22 2013-10-29T09:47:27  <ThomasWaldmann> sharky93: btw, waldi has recently reviewed your stuff and filed some issues to your tracker, please have a look
  23 2013-10-29T09:47:57  <sharky93> sure, will have a look
  24 2013-10-29T09:52:33  <ThomasWaldmann> btw, it would be great if we could merge your stuff soon. if we get accepted for gci, there could be a lot of bootstrap tasks.
  25 2013-10-29T10:08:30  <sharky93> ThomasWaldmann: what are teh blockers in the merging that?
  26 2013-10-29T10:08:32  <sharky93> *the
  27 2013-10-29T10:12:49  <ThomasWaldmann> well, look at the issues (I only talked shortly with waldi, didn't look myself into it yet)
  28 2013-10-29T11:02:08  * ThomasWaldmann merged ashutosh's gsoc work \o/
  29 2013-10-29T11:02:21  <ThomasWaldmann> (into main repo)
  30 2013-10-29T11:02:54  <ThomasWaldmann> please everybody pull/merge from there
  31 2013-10-29T11:03:37  <ThomasWaldmann> currently there is 1 failing unit test, likely ananasova's work also needs some fqname update...
  32 2013-10-29T11:24:02  * ananasova has pulled the changes and tries to fix the failing test :)
  33 2013-10-29T11:51:57  <ananasova> did anybody try to run and test manually the tip of moin? after creating an empty storage and index, and running locally, i get a KeyError on the very first attempt to load an unexisting item :/
  34 2013-10-29T11:54:44  <ThomasWaldmann> ananasova: same here, clear your cookies
  35 2013-10-29T11:55:10  <ThomasWaldmann> the problem might be that it tries to find a non-existing user profile
  36 2013-10-29T11:55:37  <ananasova> ThomasWaldmann: ahh, indeed, thanks a lot :)
  37 2013-10-29T11:55:54  <ThomasWaldmann> you could file a bug for this ;)
  38 2013-10-29T11:57:22  <ananasova> but it's not exactly a moin problem...
  39 2013-10-29T12:08:55  <ThomasWaldmann> well, it shouldn't crash, but just delete the cookie if it is not valid
  40 2013-10-29T12:29:55  <ananasova> hm... while saving it is checked whether fqname.field is NAME_EXACT, but on trashing the item fqname.field is ITEMID. maybe the if-else structure should be completed with other `field` options...
  41 2013-10-29T12:30:35  <ananasova> currently i can't backtrace it to any of the subscription/mail related changes
  42 2013-10-29T12:57:33  <ThomasWaldmann> ananasova: well, it just has no name in the old revision as the list of names is empty
  43 2013-10-29T12:58:05  <ThomasWaldmann> but the code that sends the notifies just needs some way to access the item, so any fqname should work
  44 2013-10-29T13:36:10  *** dave_largo has joined #moin-dev
  45 2013-10-29T13:52:40  <ananasova> ThomasWaldmann: found an issue (not related to the failing test, but quite annoying) and fixed it, please review - https://codereview.appspot.com/19110045/
  46 2013-10-29T13:53:03  <ananasova> the detailed information about the issue is in the description
  47 2013-10-29T14:08:43  *** RogerHaase has joined #moin-dev
  48 2013-10-29T14:29:11  <ananasova> ThomasWaldmann: migrated all issues/tasks to the main repo bb tracker
  49 2013-10-29T15:12:17  <ThomasWaldmann> ananasova: thanks. looking at the CR...
  50 2013-10-29T15:42:07  <ananasova> ThomasWaldmann: updated the cr and also left one comment -> https://codereview.appspot.com/19110045/
  51 2013-10-29T16:22:40  *** spy__ has quit IRC
  52 2013-10-29T16:47:13  *** spy__ has joined #moin-dev
  53 2013-10-29T16:52:35  *** brunomartin has joined #moin-dev
  54 2013-10-29T16:53:10  <RogerHaase> ThomasWaldmann: fix for quickinstall.py on windows, old python; unrelated change to DeleteTrailingSpaces: https://codereview.appspot.com/18710045/
  55 2013-10-29T16:55:19  <waldi> RogerHaase: please don't mix independent changes
  56 2013-10-29T16:55:27  <waldi> and no, this is still not correctz
  57 2013-10-29T17:00:26  <waldi> ThomasWaldmann: can't setuptools check the python version on it's own?
  58 2013-10-29T17:02:09  *** dreimark is now known as ReimarBauer
  59 2013-10-29T17:02:40  <waldi> RogerHaase: please check http://paste.debian.net/62815/
  60 2013-10-29T17:06:34  <waldi> Downloading/unpacking Python>=2.8 (from moin==2.0.0a0)
  61 2013-10-29T17:06:36  <waldi> okay, it can
  62 2013-10-29T17:07:05  <waldi> Could not find a version that satisfies the requirement Python>=2.8,<=2.9
  63 2013-10-29T17:07:32  <waldi> not sure what happens if a actually ask it to download Python and build it
  64 2013-10-29T17:53:40  *** greg_f has quit IRC
  65 2013-10-29T18:33:02  *** ReimarBauer is now known as dreimark
  66 2013-10-29T18:39:35  *** xorAxAx has quit IRC
  67 2013-10-29T18:40:17  *** xorAxAx has joined #moin-dev
  68 2013-10-29T19:02:08  *** sudo_dirk has quit IRC
  69 2013-10-29T19:03:12  *** sudo_dirk has joined #moin-dev
  70 2013-10-29T19:13:38  <RogerHaase> waldi: ok, will not mix patches
  71 2013-10-29T19:17:29  <RogerHaase> waldi:  applied you patch and tested, quickinstall completes successfully
  72 2013-10-29T19:20:10  <RogerHaase> waldi: compiling python will likely not succeed on most windows installations.  You object to just testing the windows version?
  73 2013-10-29T19:20:35  <RogerHaase> windows/Python
  74 2013-10-29T19:55:40  <waldi> okay, pushed
  75 2013-10-29T19:56:12  <waldi> i think that building python within a virtualenv will fail in many cases
  76 2013-10-29T20:17:43  *** spy has joined #moin-dev
  77 2013-10-29T20:19:28  *** spy__ has quit IRC
  78 2013-10-29T20:43:51  <ThomasWaldmann> re
  79 2013-10-29T21:07:36  *** RogerHaase has quit IRC
  80 2013-10-29T21:14:16  *** dave_largo has quit IRC
  81 2013-10-29T21:14:28  *** RogerHaase has joined #moin-dev
  82 2013-10-29T21:41:39  *** RogerHaase has quit IRC
  83 2013-10-29T22:41:35  *** brunomartin has quit IRC
  84