1 2014-02-16T00:00:23 <ajitesh> but the inspect element feature shows that the "checked" attribute is always set to true in the DOM
2 2014-02-16T00:01:49 <ThomasWaldmann> hmm, guess you should take some time for research
3 2014-02-16T00:02:03 <ThomasWaldmann> usually jquery based code is rather short and elegant
4 2014-02-16T00:02:26 <ThomasWaldmann> so i am wondering whether there is no simple method for setting checkboxes...
5 2014-02-16T00:39:09 *** derdon
6 2014-02-16T00:39:46 <penguinRaider_> ThomasWaldmann, regarding #407 I did some error handling to avert IndexError . I couldn't think of any appropriate comment to go at the line you pointed so removed it for now . Can you please review it again https://codereview.appspot.com/63500043/diff2/90001:110001/MoinMoin/items/__init__.py
7 2014-02-16T00:40:26 <ajitesh> ThomasWaldmann, made some changes : https://codereview.appspot.com/64160043
8 2014-02-16T02:16:03 *** sudo_dirk
9 2014-02-16T02:16:04 *** sudo_dirk_
10 2014-02-16T02:58:13 *** penguinRaider_
11 2014-02-16T02:58:19 *** penguinRaider
12 2014-02-16T03:11:51 *** jek
13 2014-02-16T03:15:56 *** jek_
14 2014-02-16T06:55:18 *** penguinRaider
15 2014-02-16T06:55:32 *** penguinRaider_
16 2014-02-16T07:14:52 *** merci
17 2014-02-16T07:15:41 <merci> i get the following error while running the quickinstall.py Error <urlopen error [Errno 111] Connection refused> while getting http://bitbucket.org/jek/flatland/get/tip.zip#egg=flatland-dev (from https://pypi.python.org/simple/flatland/)
18 2014-02-16T07:16:00 <merci> though the link opens fine in the browser.
19 2014-02-16T07:16:27 <merci> can someone please help..
20 2014-02-16T07:16:39 *** merci
21 2014-02-16T07:17:10 *** merci
22 2014-02-16T07:19:32 *** skathpalia
23 2014-02-16T07:20:15 *** skathpalia
24 2014-02-16T07:39:52 *** skathpalia
25 2014-02-16T07:59:00 *** merci
26 2014-02-16T08:50:54 *** skathpalia
27 2014-02-16T09:49:51 *** penguinRaider_
28 2014-02-16T09:49:57 *** penguinRaider
29 2014-02-16T11:21:34 *** skathpalia
30 2014-02-16T12:43:00 *** hellboy2k8
31 2014-02-16T13:03:07 <ThomasWaldmann> moin
32 2014-02-16T13:15:44 *** RogerHaase
33 2014-02-16T13:18:12 *** skathpalia
34 2014-02-16T13:23:08 *** derdon
35 2014-02-16T13:25:57 <ajitesh> moin
36 2014-02-16T13:27:07 <ajitesh> ThomasWaldmann, made some changes : https://codereview.appspot.com/64160043
37 2014-02-16T14:40:46 *** hellboy2k8
38 2014-02-16T14:41:13 *** penguinRaider
39 2014-02-16T15:01:02 <ThomasWaldmann> ajitesh: see there
40 2014-02-16T15:08:42 <ThomasWaldmann> btw, if you change stuff in moin, do you try it practically?
41 2014-02-16T15:09:25 <penguinRaider> ThomasWaldmann, I did exception handling as to avert IndexError. I could think of a suitable name for query, I removed the comment for a while . Please review https://codereview.appspot.com/63500043/diff2/90001:110001/MoinMoin/items/__init__.py
42 2014-02-16T15:09:37 <penguinRaider> s/could/couldn't
43 2014-02-16T15:11:32 <penguinRaider> by query I meant calling the method with anything other than name
44 2014-02-16T15:12:58 *** penguinRaider_
45 2014-02-16T15:13:22 *** RogerHaase
46 2014-02-16T15:22:11 <skathpalia> ThomasWaldmann, regarding the bug https://bitbucket.org/thomaswaldmann/moin-2.0/issue/400/creation-of-new-default-wiki-html-item for which I made the pull request. There was a problem in the new code
47 2014-02-16T15:22:48 <skathpalia> When we try to modify the "Home" it gives the same error so I fixed it in https://codereview.appspot.com/61650043/
48 2014-02-16T15:23:44 <skathpalia> You can review it here ^ so that I can make a new pull request :)
49 2014-02-16T15:24:20 <ajitesh> ThomasWaldmann, ofcourse i do... else how would i know if its even working ? the thing is that i thought toggle should uncheck everything previously checked and vice versa.. didnt know that it should toggle between all-checked and all-unchecked..
50 2014-02-16T15:24:32 <ajitesh> i'll change it..
51 2014-02-16T15:24:59 <skathpalia> Now I have fully tested the new code for all the type of wiki items (have tried creating and modifying almost all wiki items )
52 2014-02-16T15:29:30 <ThomasWaldmann> skathpalia: ah, good
53 2014-02-16T15:29:53 <ThomasWaldmann> did you notice anything special? if you do: check the issue tracker.
54 2014-02-16T15:30:32 <ThomasWaldmann> ajitesh: what does the item say where one clicks on?
55 2014-02-16T15:30:37 <ThomasWaldmann> toggle?
56 2014-02-16T15:30:52 <skathpalia> Thanks :)
57 2014-02-16T15:31:19 <ThomasWaldmann> or "(de)select all"?
58 2014-02-16T15:33:04 <skathpalia> ThomasWaldmann, I could not find anything special there
59 2014-02-16T15:33:27 <skathpalia> Whats that special thing ?
60 2014-02-16T15:34:56 <ThomasWaldmann> well, if you notice bugs or WTFs, file issues if we don't already have issues for that
61 2014-02-16T15:35:22 <ajitesh> ThomasWaldmann, It says toggle..
62 2014-02-16T15:35:47 <ThomasWaldmann> ajitesh: ok, then keep it that way
63 2014-02-16T15:38:29 <ajitesh> ok
64 2014-02-16T15:39:07 <ajitesh> ThomasWaldmann, should i send a pull request after adding the space ?
65 2014-02-16T15:39:46 <skathpalia> ThomasWaldmann, in the new code (the one for which I sent the pull request) I used the data_editor instead of basic_data_editor was not defined for modifying HTML wiki. But now I found that while modifying Home for the new code it gives an error that "data_editor is not defined" thats why I added an if statement that if the basic_data_editor is defined then use that else use data_editor
66 2014-02-16T15:48:59 <ThomasWaldmann> skathpalia: under what circumstances is one defined, under what the other?
67 2014-02-16T15:50:28 <skathpalia> ThomasWaldmann, in case of html basic_data_editor is not defined and for all the other types basic_data_editor is defined
68 2014-02-16T15:51:10 <skathpalia> Thats why I used data_editor for the case of HTML
69 2014-02-16T15:53:12 <ThomasWaldmann> skathpalia: the main question is "why?"
70 2014-02-16T15:53:34 <ThomasWaldmann> so, if it is not obvious from code or commit comments, find out
71 2014-02-16T15:55:30 <skathpalia> Ok I will try to why basic_data_editor is not defined for the html
72 2014-02-16T15:56:44 <ThomasWaldmann> waldi: thanks for helping as a mentor. maybe express your interest in some of the projects on https://moinmo.in/GoogleSoc2014 (there).
73 2014-02-16T16:06:22 <ajitesh> ThomasWaldmann, should i send a pull request after adding the space ?
74 2014-02-16T16:27:06 <ThomasWaldmann> ajitesh: yes, and please with a good commit comment
75 2014-02-16T16:27:14 <ThomasWaldmann> 1st line: short summary
76 2014-02-16T16:27:19 <ThomasWaldmann> 2nd line: empty
77 2014-02-16T16:27:45 <ThomasWaldmann> 3rd+ lines: longer description what, why and how you changed stuff
78 2014-02-16T16:34:17 <skathpalia> ThomasWaldmann, I think that the basic_data_editor is just a simple basic editor without any widgets but while modifying html wiki we need the widgets which are defined in data_editor
79 2014-02-16T16:36:24 <skathpalia> The widgets like underline,Bold etc are defined only for data_editor not while for all the basic needs we use basic_data_editor as we don't need these type of widgets for modifying other type of wikis
80 2014-02-16T16:39:15 <ThomasWaldmann> is that documented in the templates / classes?
81 2014-02-16T16:41:31 <skathpalia> No its not there
82 2014-02-16T16:41:40 <ajitesh> ThomasWaldmann, by 3rd+ lines you mean the description section in the pull request form ?
83 2014-02-16T16:55:37 <ThomasWaldmann> skathpalia: maybe make a separate changeset for improving the documentation
84 2014-02-16T16:56:03 <ThomasWaldmann> most of dealing with such issues is finding out what's going on and how it should be.
85 2014-02-16T16:56:34 <ThomasWaldmann> ajitesh: no, i said commit comment and i mean that
86 2014-02-16T16:56:43 <skathpalia> I will try to add this in the documentation in a separate changeset :)
87 2014-02-16T16:57:29 <ThomasWaldmann> ajitesh: hg commit (without any further args) starts an editor (sometimes vim, depends on your system) so you can enter a multiline comment
88 2014-02-16T16:59:50 <penguinRaider> ThomasWaldmann, Regarding #407 I did exception handling to the code to avoid IndexError. For the query comment it means calling method with anything other than name. I couldn't think of any suitable comment there https://codereview.appspot.com/63500043/diff2/90001:110001/MoinMoin/items/__init__.py . Please review again
89 2014-02-16T17:02:18 <ajitesh> ThomasWaldmann, Ok I'll do that :)
90 2014-02-16T17:06:28 *** skathpalia1
91 2014-02-16T17:07:04 <skathpalia1> ThomasWaldmann, Now should I make a new pull request for the changes in the code?
92 2014-02-16T17:07:09 <skathpalia1> ThomasWaldmann, I mean declining the first one and making fresh one :)
93 2014-02-16T17:08:14 *** skathpalia
94 2014-02-16T17:08:16 *** ronny
95 2014-02-16T17:08:23 *** skathpalia1
96 2014-02-16T17:14:06 <ThomasWaldmann> penguinRaider: see CR
97 2014-02-16T17:15:00 * ThomasWaldmann needs to go now, sorry
98 2014-02-16T17:16:26 *** ronny
99 2014-02-16T18:20:43 <skathpalia> ThomasWaldmann, made the pull request :)
100 2014-02-16T18:21:23 <skathpalia> ThomasWaldmann, I will soon add the information in the documentation :)
101 2014-02-16T18:22:56 <skathpalia> For this I have tested it by creating all the types of wiki and modifying them and the new code is working fine with all these operations
102 2014-02-16T19:51:06 *** penguinRaider
103 2014-02-16T19:51:12 *** penguinRaider_
104 2014-02-16T19:52:27 *** penguinRaider_
105 2014-02-16T19:53:02 *** penguinRaider
106 2014-02-16T22:18:45 *** penguinRaider
107 2014-02-16T22:18:53 *** penguinRaider_
108 2014-02-16T22:30:45 *** penguinRaider
109 2014-02-16T22:30:59 *** hellboy2k8
110 2014-02-16T22:32:04 *** derdon
111
