MoinMoin: MoinMoinChat/Logs/moin-dev/2014-03-10

   1 2014-03-10T02:12:25  *** sudo_dirk has quit IRC
   2 2014-03-10T02:13:23  *** sudo_dirk has joined #moin-dev
   3 2014-03-10T07:04:14  *** megapas has quit IRC
   4 2014-03-10T07:26:59  *** derdon has quit IRC
   5 2014-03-10T09:41:57  *** greg_f has joined #moin-dev
   6 2014-03-10T10:01:11  *** xorAxAx has quit IRC
   7 2014-03-10T10:01:38  *** xorAxAx has joined #moin-dev
   8 2014-03-10T10:01:38  *** xorAxAx has joined #moin-dev
   9 2014-03-10T12:25:02  *** greg__ has joined #moin-dev
  10 2014-03-10T12:26:40  *** greg_f has quit IRC
  11 2014-03-10T12:48:21  *** mansi has joined #moin-dev
  12 2014-03-10T13:14:36  *** Punit has joined #moin-dev
  13 2014-03-10T13:16:05  <Punit> ThomasWaldmann: Hey, is that flatland problem resolved?
  14 2014-03-10T13:16:13  <Punit> i have fixed that :D
  15 2014-03-10T13:30:18  <ThomasWaldmann> Punit: can you show a codereview of your fix?
  16 2014-03-10T13:34:04  <Punit> ThomasWaldmann: here it is : http://rn0.ru/show/lx79LNs5gyvIMcpki9i8/
  17 2014-03-10T13:34:20  <Punit> Just a change in setup.py
  18 2014-03-10T13:36:29  <ThomasWaldmann> https://wiki.python.org/moin/SummerOfCode/ApplicationTemplate2014 looks like psf wants students to use their template
  19 2014-03-10T13:37:34  <ThomasWaldmann> Punit: that is neither a patch nor a codereview.appspot.com post
  20 2014-03-10T13:37:59  <ThomasWaldmann> so, how should one review that?
  21 2014-03-10T13:38:23  <Punit> i have changed this file in my repo
  22 2014-03-10T13:38:34  <Punit> i can forked moin repo
  23 2014-03-10T13:38:59  <Punit> i can send merge request so that moin developers can review
  24 2014-03-10T13:40:19  <ThomasWaldmann> if you commit first and send a pull request, the only way to deal with that is accept or reject
  25 2014-03-10T13:40:51  <ThomasWaldmann> if there is reason to reject, the only (easy) way to improve is to add more commits
  26 2014-03-10T13:41:14  <ThomasWaldmann> and then we might end up with a lot of commits for the same thing
  27 2014-03-10T13:41:43  <Punit> so what to do then?
  28 2014-03-10T13:41:57  <ThomasWaldmann> thus, the recommended procedure is to use codereview.appspot.com (before committing)
  29 2014-03-10T13:43:56  <Punit> I have never used coderview before. I will post there in a few minutes
  30 2014-03-10T13:51:11  <Punit> ThomasWaldmann: here's the coderview link : https://codereview.appspot.com/73550043/
  31 2014-03-10T13:52:04  <ThomasWaldmann> dreimark_: btw, if you want to mentor for PSF/MoinMoin, you should sign up with PSF ASAP
  32 2014-03-10T14:05:32  <ThomasWaldmann> Punit: see there
  33 2014-03-10T14:19:24  <Punit> ThomasWaldmann: check there
  34 2014-03-10T14:20:16  <Punit> i am checking changes on my machine again
  35 2014-03-10T14:20:27  <Punit> i will upload modified files soon
  36 2014-03-10T14:38:15  <Punit> ThomasWaldmann: https://codereview.appspot.com/73590043/
  37 2014-03-10T14:47:21  *** ananasova has quit IRC
  38 2014-03-10T14:48:30  *** ingu_pc__ has quit IRC
  39 2014-03-10T14:49:35  *** ingu_pc___ has joined #moin-dev
  40 2014-03-10T14:52:07  *** RogerHaase has joined #moin-dev
  41 2014-03-10T14:53:09  *** ananasova has joined #moin-dev
  42 2014-03-10T14:54:23  <ThomasWaldmann> Punit: you should use the same id for same codereview, -i param
  43 2014-03-10T14:55:47  <Punit> ThomasWaldmann: there are so many test files. Is there some specific set of test files only to check whether this flatland version is breaking something ?
  44 2014-03-10T14:56:35  <Punit> ok, i will keep that -i parameter in mind while pushing in future :)
  45 2014-03-10T14:59:26  <ThomasWaldmann> usually there should be no test failures
  46 2014-03-10T14:59:44  <ThomasWaldmann> (you just run all the tests by running py.test in the toplevel dir)
  47 2014-03-10T15:00:14  <ThomasWaldmann> in case you see test fails, you can also check if YOU introduced them or if they also happened before your changes
  48 2014-03-10T15:07:39  <Punit> This is the result http://rn0.ru/show/WUDQSqu5uHsPl1dAyLSM/
  49 2014-03-10T15:08:13  <Punit> there is one failure but i don't think it is caused by my update
  50 2014-03-10T15:11:01  <ThomasWaldmann> yeah
  51 2014-03-10T15:12:46  <Punit> so what next? Shall i send a merge request?
  52 2014-03-10T15:17:40  <ThomasWaldmann> did you update the CR?
  53 2014-03-10T15:21:02  <Punit> CR?
  54 2014-03-10T15:22:04  <RogerHaase> CR = code review
  55 2014-03-10T15:22:44  <ThomasWaldmann> yup :) hi roger!
  56 2014-03-10T15:23:15  <RogerHaase> moin :)
  57 2014-03-10T15:23:50  <ThomasWaldmann> RogerHaase: btw, did you merge the stuff?
  58 2014-03-10T15:26:30  <RogerHaase> ThomasWaldmann: yes, but still trying to resolve the ns1 issue for the broken heading tests caused by adding TOC extension to markdown
  59 2014-03-10T15:29:20  * ThomasWaldmann meant that merge with the conflict in the template
  60 2014-03-10T15:30:50  <RogerHaase> ThomasWaldmann: yes, that was only trailing blanks issue
  61 2014-03-10T15:32:03  <Punit> ThomasWaldmann: here it is https://codereview.appspot.com/73590043/
  62 2014-03-10T15:34:01  *** dave_largo has joined #moin-dev
  63 2014-03-10T15:34:16  <ThomasWaldmann>  /join #python-gsoc
  64 2014-03-10T16:20:38  *** Punit has quit IRC
  65 2014-03-10T16:28:17  *** Punit has joined #moin-dev
  66 2014-03-10T16:33:28  *** Punit has quit IRC
  67 2014-03-10T17:11:23  * ThomasWaldmann tries to make a reasonable account creation / password definition / password recovery / email verification workflow
  68 2014-03-10T17:44:06  *** Punit has joined #moin-dev
  69 2014-03-10T17:46:47  <Punit> ThomasWaldmann: please check my merge request once again
  70 2014-03-10T18:08:18  *** mansi has quit IRC
  71 2014-03-10T18:23:21  *** milap has joined #moin-dev
  72 2014-03-10T18:23:51  <milap> hello
  73 2014-03-10T18:24:15  <milap> i'm milap, im looking for GSOC this year,
  74 2014-03-10T18:24:24  <milap> i'm intrested in mail related functionality project.
  75 2014-03-10T18:28:58  *** Punit has quit IRC
  76 2014-03-10T18:31:50  <ThomasWaldmann> (btw, most of the stuff on the ideas page is just that: IDEAS. your task is to assemble a project from these.)
  77 2014-03-10T18:32:47  <ThomasWaldmann> we can help you if you ask specific questions, though
  78 2014-03-10T18:33:28  *** greg__ has quit IRC
  79 2014-03-10T18:41:38  <ThomasWaldmann> milap: ?
  80 2014-03-10T18:43:09  <milap> yes, how could i start ?
  81 2014-03-10T18:46:57  <RogerHaase> milap: did you read http://moinmo.in/MoinMoin2.0 and install moin2 yet?
  82 2014-03-10T18:48:04  <milap> i'm doing, work in progress
  83 2014-03-10T18:53:09  <ThomasWaldmann> guess we'll have a flatland problem soon again...
  84 2014-03-10T18:57:27  <RogerHaase> milap: when you get to installing moin2 (https://moin-20.readthedocs.org/en/latest/admin/install.html), we have 2 bugs you may hit (1) https://bitbucket.org/thomaswaldmann/moin-2.0/issue/395/quickinstallpy-fails-with and (2) a flatland workaround https://codereview.appspot.com/73590043/
  85 2014-03-10T18:58:26  <milap> yeah, i need to fix these bugs ?
  86 2014-03-10T18:58:38  * ThomasWaldmann pulled and fixed punit's flatland fix and pushed
  87 2014-03-10T19:01:25  <milap> let me try
  88 2014-03-10T19:03:13  *** skathpalia has joined #moin-dev
  89 2014-03-10T19:04:12  <ThomasWaldmann> btw, to all new developers: please configure your editor correctly
  90 2014-03-10T19:04:53  <ThomasWaldmann> that is for python: always expand tabs to 4 spaces, always indent by multiples of 4 spaces
  91 2014-03-10T19:29:03  <skathpalia> ThomasWaldmann, are we required to use the psf template or the moin template for GSOC?
  92 2014-03-10T19:35:51  <skathpalia> Oh sorry didn't see the changes on the ideas page
  93 2014-03-10T19:36:12  <ThomasWaldmann> as you are applying to psf, the psf template
  94 2014-03-10T19:36:34  <ThomasWaldmann> (sorry that it came a bit late, but i didn't knew that before either)
  95 2014-03-10T19:37:28  <ThomasWaldmann> btw, if someone of you compares the templates, I would be interested in the differences ;)
  96 2014-03-10T20:14:23  <RogerHaase> ThomasWaldmann:  fix markdown tests broken by adding toc extension:  https://codereview.appspot.com/72860044/
  97 2014-03-10T21:04:25  *** dave_largo has quit IRC
  98 2014-03-10T21:12:10  * ThomasWaldmann looks
  99 2014-03-10T21:26:35  *** milap has quit IRC
 100 2014-03-10T21:37:00  <ThomasWaldmann> RogerHaase: done
 101 2014-03-10T21:40:14  <RogerHaase> ThomasWaldmann: sent pull request
 102 2014-03-10T21:44:42  <ThomasWaldmann> RogerHaase: how about order? shall i merge that one before the older one with the merge conflicts?
 103 2014-03-10T21:48:31  <RogerHaase> I pulled from your repo and merged everything.  You can still have conflicts?
 104 2014-03-10T22:05:13  <RogerHaase> ThomasWaldmann: I do not know how you deal with pull requests, I was thinking you would pull everything from my repo.
 105 2014-03-10T22:14:35  *** RogerHaase has left #moin-dev
 106