1 2014-03-31T00:05:10 *** penguinRaider
2 2014-03-31T00:40:06 *** magu_cic_
3 2014-03-31T01:09:19 *** not-xjjk
4 2014-03-31T01:13:40 *** xjjk
5 2014-03-31T02:35:55 *** penguinRaider
6 2014-03-31T05:31:41 *** penguinRaider
7 2014-03-31T08:36:09 *** penguinRaider
8 2014-03-31T10:10:54 <ThomasWaldmann> moin
9 2014-03-31T10:29:43 *** penguinRaider
10 2014-03-31T11:02:53 *** greg_f
11 2014-03-31T11:41:21 *** penguinRaider
12 2014-03-31T11:55:25 *** penguinRaider
13 2014-03-31T14:11:18 *** RogerHaase
14 2014-03-31T14:24:55 *** skathpalia
15 2014-03-31T14:41:01 <skathpalia> RogerHaase, moin
16 2014-03-31T14:41:40 <skathpalia> Sorry, I couldn't come up yesterday
17 2014-03-31T14:41:55 <skathpalia> I saw your cr in the logs
18 2014-03-31T14:43:59 <skathpalia> I had a doubt like I wanted to change the width to max-width in the basic.css file bu I am not able to figure out how this can be done
19 2014-03-31T14:45:45 <skathpalia> The way I was doing was I was adding that part in the basic.less file and then compiling that file but I saw that it doesn't replace the existing width part but adds those lines in the end of the file
20 2014-03-31T14:46:43 *** penguinRaider
21 2014-03-31T14:56:24 <RogerHaase> skathpalia: researching how to do that, I found http://stackoverflow.com/questions/9730263/setting-max-width-for-body-using-bootstrap. That suggests you cannot change the bootstrap default bootstrap css, but rather override it. ...
22 2014-03-31T14:59:24 <RogerHaase> there it suggests creating a custom bootstrap-custom.css, but if your way of appending it to the end of basic.less works, that seems better to me (maybe just add a comment to explain)...
23 2014-03-31T15:01:39 <skathpalia> No appending it doesn't work
24 2014-03-31T15:02:07 <skathpalia> I think we have to change the bootstrap default file
25 2014-03-31T15:06:46 <RogerHaase> No do not change the bootstrap default. Then overriding the default is the probably the reason for creating the .../ basic/static/custom.css so just add your CSS there...
26 2014-03-31T15:08:26 <RogerHaase> Also add a comment at the top as a partial fix to #425.
27 2014-03-31T15:10:01 <RogerHaase> But I still do not understand why the moin-* rules are in that file rather than in basic.less?
28 2014-03-31T15:14:07 <RogerHaase> skathpalia: Before you add to ..basic/static/custom.css; clarify "but adds those lines in the end of the file" - is the display OK, you just wanted to override rather than append near end of file?
29 2014-03-31T15:15:21 <skathpalia> No if we append near end of file then the display is not Ok
30 2014-03-31T15:18:43 <RogerHaase> hmmm, will download your patch and try...
31 2014-03-31T15:42:56 <RogerHaase> skathpalia: it is the bootstrap default width that is the problem, add "width: auto;" to your solution to set it back to the default value
32 2014-03-31T15:44:36 <skathpalia> Yeah that is working
33 2014-03-31T15:44:38 <skathpalia> :)
34 2014-03-31T15:44:59 <RogerHaase> great :)
35 2014-03-31T15:46:38 <skathpalia> Ok I am making a cr for the same
36 2014-03-31T16:49:33 *** penguinRaider
37 2014-03-31T17:33:17 <skathpalia> RogerHaase, I have made the changes you can review it here https://codereview.appspot.com/80700049/
38 2014-03-31T17:33:27 <skathpalia> I have excluded the changes of your cr
39 2014-03-31T17:41:44 <RogerHaase> ThomasWaldmann: did one last test of patch to add "--upgrade" to setup.py and make.py: works well, pulled in pep8-1.5.1 (same as fresh clone with no cache), but then: ===== 49 failed, 249 passed, 11 skipped, 702 deselected in 12.86 seconds ======
40 2014-03-31T17:42:00 <RogerHaase> http://rn0.me/show/hsdKGU5nGcMILoz53CIc/
41 2014-03-31T17:50:38 <RogerHaase> skathpalia: ah, so you found that max-width was not needed. looks OK. You checked many items and everything looks OK?
42 2014-03-31T17:50:52 *** greg_f
43 2014-03-31T17:57:34 <skathpalia> Everything(GUI) is working fine but there is some other problem
44 2014-03-31T17:58:28 <skathpalia> I updated my lessc and stylus version and I got some other changes also that should not come on running ./m css
45 2014-03-31T17:59:02 <skathpalia> Ohh may be I have to restart my computer to apply changes correctly
46 2014-03-31T17:59:24 <skathpalia> Ok I am restarting and I will see if still same issue is there or not
47 2014-03-31T17:59:34 *** skathpalia
48 2014-03-31T18:02:37 *** skathpalia
49 2014-03-31T18:24:32 <skathpalia> RogerHaase, After updating my stylus and lessc version I get the following diff http://rn0.me/show/zDDf4HdZaF8VpZEigXd4/
50 2014-03-31T18:25:11 <skathpalia> Gui looks fine bu I think the new version has removed some spaces/new lines
51 2014-03-31T18:25:45 <RogerHaase> skathpalia: usually ctrl+f5 will force the browser to reload all files. If you watch the terminal window running the built-in server you should see the difference between doing browser reload button and ctrl+f5
52 2014-03-31T18:26:37 <RogerHaase> skathpalia: did you upgrade stylus to 0.42.3?
53 2014-03-31T18:26:52 <skathpalia> Yeah
54 2014-03-31T18:27:22 <RogerHaase> :-D
55 2014-03-31T18:28:20 <RogerHaase> I noticed that yesterday, but could not believe it. Have not had a chance to get back to it yet to verify.
56 2014-03-31T18:28:55 <RogerHaase> back stylus off to 0.42.2
57 2014-03-31T18:29:22 <skathpalia> Ok then I will get back to older version
58 2014-03-31T18:29:54 <skathpalia> this might be a bug in the new version of stylus :D
59 2014-03-31T18:34:23 <RogerHaase> the thing that really confused me was that even with all those apparent deletions, the common.css files sizes seemed to be about the same. But I did not investigate much, just backed off to the version you had.
60 2014-03-31T18:56:48 <skathpalia> RogerHaase, I think I have to revert the lessc versionb also
61 2014-03-31T18:57:03 <skathpalia> which version are you using?
62 2014-03-31T18:57:59 <RogerHaase> 1.6.3
63 2014-03-31T18:59:08 *** derdon
64 2014-03-31T19:03:53 <RogerHaase> skathpalia: the stylus-foobar common.css floating point differences may be due to nodejs -- I have version 0.10.20 installed
65 2014-03-31T19:18:31 *** penguinRaider
66 2014-03-31T19:31:48 *** penguinRaider
67 2014-03-31T19:40:00 <skathpalia> RogerHaase, I have changed my lessc, nodejs, stylus version to ones that you have but still some unwanted changes are coming
68 2014-03-31T19:40:11 <skathpalia> The spaces and newline changes
69 2014-03-31T19:41:52 <RogerHaase> skathpalia: when you uninstalled and reinstalled stylus, did you remember the "-g" option?
70 2014-03-31T19:43:56 <skathpalia> No I didn't use -g option
71 2014-03-31T19:44:00 <skathpalia> using it now
72 2014-03-31T19:44:46 <skathpalia> RogerHaase, Yeah got it finally :)
73 2014-03-31T19:47:51 <skathpalia> RogerHaase, Now I have made the changes you can review it here https://codereview.appspot.com/80700049
74 2014-03-31T19:53:06 <RogerHaase> skathpalia: if you revert the changes to common.css, you are back to patchset 2, right?
75 2014-03-31T19:53:40 <skathpalia> Yeah
76 2014-03-31T19:57:20 <RogerHaase> what I would do is to delete patchset 3 and 4 (nothing of value there), revert the common.css changes, upload again to really verify you are back to patchset 2 (compare 2 to 3); then delete the new patchset 3
77 2014-03-31T19:58:07 <RogerHaase> I did do a bit of testing, looks OK to me
78 2014-03-31T19:58:32 <RogerHaase> gtg, back in 20-30 minutes
79 2014-03-31T19:59:38 <ThomasWaldmann> re
80 2014-03-31T20:02:56 *** skathpalia
81 2014-03-31T20:29:33 <RogerHaase> re
82 2014-03-31T20:57:25 <RogerHaase> ThomasWaldmann: foobar, modernized CSS cleanup using Stylus 0.42.2 https://codereview.appspot.com/82410043/
83 2014-03-31T22:08:18 *** RogerHaase
84 2014-03-31T22:29:54 *** randomax
85 2014-03-31T22:49:56 *** magu_cic
86 2014-03-31T22:53:19 *** magu_cic_
87 2014-03-31T23:59:56 *** magu_cic_
88
