1 2014-05-22T01:20:59 *** sl33k_
2 2014-05-22T01:21:09 *** sl33k__
3 2014-05-22T05:02:05 *** sl33k_
4 2014-05-22T05:56:14 *** magu_cic
5 2014-05-22T05:56:16 *** magu_cic_
6 2014-05-22T09:10:38 <dimazest> good morning
7 2014-05-22T09:13:09 *** greg_f
8 2014-05-22T09:24:57 *** skathpalia
9 2014-05-22T09:25:08 <skathpalia> moin
10 2014-05-22T10:54:48 *** sl33k_
11 2014-05-22T10:58:57 *** skathpalia
12 2014-05-22T11:01:21 *** sl33k_
13 2014-05-22T11:16:59 *** sl33k_
14 2014-05-22T11:32:16 *** skathpalia
15 2014-05-22T11:52:59 <dimazest> skathpalia: check my comments
16 2014-05-22T11:53:10 <dimazest> i think it worth writing a tests for this fix
17 2014-05-22T12:15:27 *** sl33k_
18 2014-05-22T12:34:15 <skathpalia> dimazest, First I thought that we should test it manually and then I will write tests
19 2014-05-22T12:37:19 *** dave_largo
20 2014-05-22T12:44:41 *** sl33k_
21 2014-05-22T12:45:27 <skathpalia> dimazest, I have updated the cr with some minor changes https://codereview.appspot.com/100720043
22 2014-05-22T13:02:23 <dimazest> see my comments
23 2014-05-22T13:08:19 <skathpalia> dimazest, Actually in your way there won't be similarity between the options of the select list
24 2014-05-22T13:08:48 <skathpalia> As sometimes there will be ITEMID and sometimes there will be name
25 2014-05-22T13:09:54 <skathpalia> also by this "choices = [(rev.meta[ITEMID], rev.meta[NAME][0]) for rev in revs if NAME in rev.META]" we will get only those elements which have name
26 2014-05-22T13:10:14 <skathpalia> items without name won't be selected
27 2014-05-22T13:19:10 <skathpalia> dimazest, I have added comment in the cr
28 2014-05-22T13:24:45 <skathpalia> dimazest, I am not able to understand what exactly you are trying to convey
29 2014-05-22T13:24:53 <dimazest> so
30 2014-05-22T13:24:53 <skathpalia> Can you please explain it ?
31 2014-05-22T13:25:12 <dimazest> if name doesn't exists, item_id is used instead
32 2014-05-22T13:25:38 <skathpalia> yeah
33 2014-05-22T13:25:41 <dimazest> rev.meta should have method .get()
34 2014-05-22T13:25:59 <dimazest> .get(key, default)
35 2014-05-22T13:26:13 <dimazest> in case key is not foud, default is returned
36 2014-05-22T13:27:02 <dimazest> so, in the list comprehension, if a revision doesn't have a name, we should use item_id
37 2014-05-22T13:27:16 <skathpalia> What default value is returned?
38 2014-05-22T13:27:26 <dimazest> the one you pass
39 2014-05-22T13:27:26 <skathpalia> I mean if NAME is not found
40 2014-05-22T13:27:42 <dimazest> it should be item_id
41 2014-05-22T13:27:52 <skathpalia> Yeah I think now I got it
42 2014-05-22T13:28:03 <skathpalia> I am giving it a try
43 2014-05-22T13:28:08 <dimazest> good :)
44 2014-05-22T13:29:21 <skathpalia> But here "choices = [(rev.meta[ITEMID], rev.meta.get(NAME, [ITEM_ID])][0]) for rev in revs]" , there is a problem
45 2014-05-22T13:29:45 <skathpalia> I mean name is a list while itemid is just a unicode string
46 2014-05-22T13:30:40 <dimazest> that's why it's [ITEM_ID]
47 2014-05-22T13:31:30 <skathpalia> But suppose that some items have name while some do not
48 2014-05-22T13:32:33 <dimazest> ok
49 2014-05-22T13:32:37 <skathpalia> then we will get something like this choices = [(some_itemid1, u"name1"), (some_itemid2, some_itemid2)]
50 2014-05-22T13:32:51 <skathpalia> Here this would create problems
51 2014-05-22T13:33:02 <dimazest> what kind?
52 2014-05-22T13:33:37 <skathpalia> here first item has name while second item has no name
53 2014-05-22T13:33:45 <dimazest> btw, revs, do they point to revisions of the same item, or to different items?
54 2014-05-22T13:34:02 <dimazest> ok , do you need to handle this situation differently?
55 2014-05-22T13:34:35 <skathpalia> But the first item is having name at its second index while second item has ITEMID in its second index
56 2014-05-22T13:34:52 <skathpalia> So we won't be able to differentiate between them
57 2014-05-22T13:36:11 <dimazest> why do you need to defferintiate?
58 2014-05-22T13:37:31 <skathpalia> I mean user has to differentiate between them
59 2014-05-22T13:38:22 <skathpalia> in my above example the select list will have options "name1" and "some_itemid2"
60 2014-05-22T13:38:49 <dimazest> ok, but what do you want instead?
61 2014-05-22T13:38:53 <skathpalia> Then how would he differentiate that first one is name and other is ITEMID
62 2014-05-22T13:38:54 <dimazest> btw, this line {% for value in field.properties['choice_specs'] %}
63 2014-05-22T13:39:14 <dimazest> why not to replace in to {% for item_id, name in field.properties['choice_specs'] %}
64 2014-05-22T13:39:18 <skathpalia> I think current method won't create these problems
65 2014-05-22T13:39:22 <dimazest> and get rid of values[0] and values[1]
66 2014-05-22T13:39:49 <dimazest> so it should be either all names or item_ids
67 2014-05-22T13:39:56 <skathpalia> Actually the same code is used for creating select lists at many places
68 2014-05-22T13:40:08 <skathpalia> Yeah that is my point
69 2014-05-22T13:40:51 <skathpalia> for example the same html code is used for creating select list for theme change
70 2014-05-22T13:41:36 <skathpalia> So giving them names such as itemid or name would create misunderstanding
71 2014-05-22T13:42:25 <dimazest> ok this is quite strange, better write a comment why try .. except is used there
72 2014-05-22T13:42:29 <dimazest> anyway
73 2014-05-22T13:42:58 <dimazest> there are some points in the template
74 2014-05-22T13:43:05 <skathpalia> Yeah I will add a comment which would give some explanation
75 2014-05-22T13:43:37 *** sl33k_
76 2014-05-22T13:45:14 <skathpalia> dimazest, points in template?
77 2014-05-22T13:45:27 <dimazest> i've just posted them
78 2014-05-22T13:48:44 *** sl33k_
79 2014-05-22T13:50:55 <skathpalia> dimazest, done the changes :)
80 2014-05-22T13:52:15 <dimazest> see my comments
81 2014-05-22T14:00:26 <skathpalia> dimazest, I have checked that every if statement is executed
82 2014-05-22T14:04:24 *** RogerHaase
83 2014-05-22T14:04:43 *** sl33k_
84 2014-05-22T14:06:02 <skathpalia> dimazest, I would search for some other alternative for that undefined thing
85 2014-05-22T14:06:34 <skathpalia> But replacing value with name and itemid would create misunderstanding
86 2014-05-22T14:07:10 <dimazest> why?
87 2014-05-22T14:07:33 <dimazest> value[0] and value[1] are too vague, to my mind
88 2014-05-22T14:07:43 <skathpalia> As it is used at many other places
89 2014-05-22T14:08:07 <skathpalia> Ok may be we should replace it with value, label as it was earlier
90 2014-05-22T14:08:21 <skathpalia> what do you say about this idea
91 2014-05-22T14:08:22 <skathpalia> >
92 2014-05-22T14:08:23 <skathpalia> ?
93 2014-05-22T14:09:37 <skathpalia> dimazest, ?
94 2014-05-22T14:09:43 *** sl33k_
95 2014-05-22T14:11:07 <dimazest> ok
96 2014-05-22T14:11:19 <dimazest> btw, if value[1] is undefined, what is the value of value[0]
97 2014-05-22T14:11:28 <dimazest> is it undefined as well?
98 2014-05-22T14:13:06 <skathpalia> value[0] = u''
99 2014-05-22T14:13:10 <skathpalia> https://bitbucket.org/thomaswaldmann/moin-2.0/src/4a997d9f5e26515b90c744582be8aa7393bb57d1/MoinMoin/forms.py?at=default#cl-356
100 2014-05-22T14:13:26 <skathpalia> It is clear from the above 356 line
101 2014-05-22T14:13:42 <skathpalia> Here (u'', None) is appended
102 2014-05-22T14:14:29 <dimazest> ok
103 2014-05-22T14:14:50 <dimazest> so, you want to pass None, None if name is none
104 2014-05-22T14:15:12 <skathpalia> Yeah
105 2014-05-22T14:15:24 <skathpalia> It just acts as empty label
106 2014-05-22T14:15:47 <skathpalia> i.e.it depends on nothing or superseded by None
107 2014-05-22T14:16:03 <skathpalia> I mean ticket in the above example
108 2014-05-22T14:16:26 <dimazest> then {{ gen.option(field, value=value or None, contents=label or value) }} should be enough
109 2014-05-22T14:16:36 <dimazest> though, value or None looks like a hack to me
110 2014-05-22T14:21:00 <skathpalia> but in this this won't be handled if label = ''
111 2014-05-22T14:21:10 <skathpalia> Then contents would be ''
112 2014-05-22T14:21:19 <skathpalia> as label is not None
113 2014-05-22T14:24:12 <skathpalia> Oh my mistake
114 2014-05-22T14:24:21 <skathpalia> Yeah it works
115 2014-05-22T14:25:34 <skathpalia> dimazest I am pushing the new code
116 2014-05-22T14:26:43 <dimazest> what if we remove value=value or None, and leave the file as it was?
117 2014-05-22T14:26:46 <dimazest> will it break?
118 2014-05-22T14:29:18 <skathpalia> dimazest, No it won't
119 2014-05-22T14:29:28 <skathpalia> I have tested that also
120 2014-05-22T14:29:57 <skathpalia> Thanks for pointing this out
121 2014-05-22T14:30:05 <skathpalia> I am pushing the new code
122 2014-05-22T14:30:42 <dimazest> :)
123 2014-05-22T14:31:35 <skathpalia> dimazest, Can I push it to my repo?
124 2014-05-22T14:32:44 *** randomax
125 2014-05-22T14:32:55 <dimazest> do you mean commit?
126 2014-05-22T14:33:01 <skathpalia> Yeah
127 2014-05-22T14:33:37 <dimazest> still an explanation why try .. except is missing
128 2014-05-22T14:34:17 <dimazest> what is commit policy? i guess they should be nice and tidy :) with meaningful commit messages
129 2014-05-22T14:34:23 <skathpalia> You mean adding comments regarding that try except statement?
130 2014-05-22T14:34:29 <dimazest> yes
131 2014-05-22T14:34:41 <skathpalia> Ok I will soon add comments regarding that
132 2014-05-22T14:35:30 <skathpalia> Yeah commit message should be meaningful :)
133 2014-05-22T14:35:43 <dimazest> btw, i used mq extension for mercurial
134 2014-05-22T14:35:51 <skathpalia> Ok will soon add comments in my cr and then I will commit it
135 2014-05-22T14:36:38 <dimazest> so i was creating patches as much as i wanted, but once i was done, I merged them and converted into a commit
136 2014-05-22T14:36:49 <dimazest> have a look to hg help mq
137 2014-05-22T14:36:55 <dimazest> if you are interested
138 2014-05-22T14:37:34 <skathpalia> Ok will see to that also :)
139 2014-05-22T14:38:09 <dimazest> make sure that you set
140 2014-05-22T14:38:24 <dimazest> [mq]
141 2014-05-22T14:38:24 <dimazest> secret = True
142 2014-05-22T14:38:41 <dimazest> otherwise, you can push a not ready work
143 2014-05-22T14:38:56 <dimazest> that's just a suggestion, you don't have to use it
144 2014-05-22T14:49:57 *** skathpalia
145 2014-05-22T15:24:52 *** skathpalia
146 2014-05-22T15:25:58 *** derdon
147 2014-05-22T15:28:21 *** derdon
148 2014-05-22T15:37:48 <ThomasWaldmann> dimazest: skathpalia: did you update your times to be UTC in the dudle?
149 2014-05-22T15:38:16 <ThomasWaldmann> randomax: you didn't yet, please do so ASAP https://dudle.inf.tu-dresden.de/moin_gsoc2014_weekly/
150 2014-05-22T15:38:53 *** skathpalia
151 2014-05-22T15:39:51 *** derdon
152 2014-05-22T15:39:52 <randomax> ThomasWaldmann, i filled it in UTC itself
153 2014-05-22T15:40:10 <ThomasWaldmann> you didn't fill in all currently available timeslots
154 2014-05-22T15:40:29 * ThomasWaldmann added 2h per day after noticing the utc vs. localtime issue
155 2014-05-22T15:41:14 *** derdon
156 2014-05-22T15:43:04 <randomax> ThomasWaldmann, done
157 2014-05-22T15:44:31 <dimazest> ThomasWaldmann: done
158 2014-05-22T15:45:00 <ThomasWaldmann> can you both put (UTC) after your names (see comments there)
159 2014-05-22T15:47:32 <ThomasWaldmann> but currently it looks quite good, we'll find a slot when everybody has time (assuming sk. already fixed times to UTC)
160 2014-05-22T15:50:41 *** randomax
161 2014-05-22T16:01:16 *** skathpalia
162 2014-05-22T16:01:43 <skathpalia> ThomasWaldmann, I have also updated according to utc
163 2014-05-22T16:04:59 <skathpalia> dimazest, ThomasWaldmann May be I won't be able to work for next 3-4 days as I have to out of town for passport :(
164 2014-05-22T16:05:51 <skathpalia> But still I will try to get time for work in these days
165 2014-05-22T16:06:42 <ThomasWaldmann> what's with your passport?
166 2014-05-22T16:07:15 <skathpalia> Actually I have filed the application for fresh passport
167 2014-05-22T16:07:42 <skathpalia> I don't have any passport yet :(
168 2014-05-22T16:08:46 <ThomasWaldmann> and why does that consume multiple days?
169 2014-05-22T16:09:36 <skathpalia> Actually my younger brother is also having exams on 24 and 25 and my appointment is on 26
170 2014-05-22T16:09:51 * ThomasWaldmann changed ebay password and security question/answer (see recent news, they were hacked)
171 2014-05-22T16:09:58 <skathpalia> So I have to leave by 23 evening
172 2014-05-22T16:10:32 <ThomasWaldmann> i can't follow, sorry
173 2014-05-22T16:10:35 *** randomax
174 2014-05-22T16:11:41 <skathpalia> I will go out of town by 23 evening
175 2014-05-22T16:12:17 <ThomasWaldmann> skathpalia: randomax: https://dudle.inf.tu-dresden.de/moin_gsoc2014_weekly/ please read and follow the comments, esp. regarding all times needing to be utc AND you declaring that in your name by appending "(UTC)"
176 2014-05-22T16:12:31 <skathpalia> As I will be staying with my brother who is having his college entrance exams on 24 and 25 and I have to go to passport office on 26
177 2014-05-22T16:13:31 <ThomasWaldmann> and you have no computer all the time?
178 2014-05-22T16:14:39 <skathpalia> I will be having computer but as I have to accompany my brother to exam centers so may be I will get less time for work
179 2014-05-22T16:14:50 <skathpalia> But its not that I will not do any work
180 2014-05-22T16:15:26 <skathpalia> I will surely do some work
181 2014-05-22T16:15:47 <ThomasWaldmann> ok, just make sure you don't lose too much time. if you don't have time for concentrated work, there is always the options to clean up the etherpad, do some planning, look at misc stuff
182 2014-05-22T16:16:09 <skathpalia> Yeah sure
183 2014-05-22T16:16:38 <ThomasWaldmann> the passport you get, does it have electronics inside?
184 2014-05-22T16:17:28 * ThomasWaldmann just curious. the german ones do have. RFID or similar.
185 2014-05-22T16:17:41 <skathpalia> No here we don't have
186 2014-05-22T16:18:19 *** derdon
187 2014-05-22T16:18:23 *** derdon_
188 2014-05-22T16:18:25 <ThomasWaldmann> to enter some countries, there is a minimum requirement of "machine readable" iirc.
189 2014-05-22T16:19:04 *** derdon_
190 2014-05-22T16:19:16 <dimazest> i guess, just a barcode is enough
191 2014-05-22T16:19:51 <skathpalia> Yeah we just have barcode
192 2014-05-22T16:20:13 <ThomasWaldmann> and they'll take a picture of your face and fingerprints...
193 2014-05-22T16:20:42 <dimazest> they do, for a long time already in Latvia
194 2014-05-22T16:21:20 <dimazest> the picture part is convenient, because they make a photo that is up to all the requirements, not a photo agency
195 2014-05-22T16:21:32 <dimazest> the fingerprint part is less convenient
196 2014-05-22T16:21:52 <ThomasWaldmann> such data is convenient to have, in case you ever have to log in via face recognition or fingerprint
197 2014-05-22T16:22:26 <ThomasWaldmann> but otoh, such stuff is stupid anyway and no "secret" at all
198 2014-05-22T16:22:48 <skathpalia> :)
199 2014-05-22T16:24:50 <ThomasWaldmann> looks like saturdays 16:00 UTC is our weekly meeting date
200 2014-05-22T16:29:26 <skathpalia> btw ThomasWaldmann I have a cr pending https://codereview.appspot.com/80700049/#ps20001
201 2014-05-22T16:29:47 <skathpalia> Can you please review it ?
202 2014-05-22T16:30:03 <skathpalia> The patchset2 is the relevant
203 2014-05-22T16:30:08 <ThomasWaldmann> https://moinmo.in/GoogleSoc2014 < updated. alle mentors, admins, students please subscribe to that page.
204 2014-05-22T16:30:39 <ThomasWaldmann> skathpalia: I have to leave in a few minutes, but I try to do it later.
205 2014-05-22T16:30:47 <skathpalia> Ok sure
206 2014-05-22T16:31:43 <ThomasWaldmann> pirate party meeting :)
207 2014-05-22T16:33:43 *** derdon
208 2014-05-22T16:33:53 * ThomasWaldmann bbl
209 2014-05-22T16:35:01 *** derdon
210 2014-05-22T16:39:52 *** sl33k_
211 2014-05-22T16:40:13 *** skathpalia
212 2014-05-22T16:44:14 <randomax> RogerHaase, does this http://picpaste.com/73-3uQOJmu2.png
213 2014-05-22T16:44:17 <randomax> look alright wrt to https://bitbucket.org/sharky93/moin-2.0-bootstrap/issue/73/sidebar-too-large
214 2014-05-22T16:44:24 <randomax> ?
215 2014-05-22T16:49:03 <RogerHaase> randomax: adding expand/collapse is OK, but I understand the original complaint as meaning the padding or margins around each individual link in the sidebar -- iirc there is 10p padding
216 2014-05-22T16:49:52 <randomax> ok.. i'll remove that too..
217 2014-05-22T16:52:54 *** sl33k_
218 2014-05-22T16:56:41 <randomax> RogerHaase, Here is how it looks like with 5px http://picpaste.com/pics/73p2-DyBCIYbg.1400777739.png
219 2014-05-22T16:56:53 *** dave_largo
220 2014-05-22T16:57:59 <randomax> should i make the padding even smaller ?
221 2014-05-22T17:01:03 *** skathpalia
222 2014-05-22T17:10:45 *** derdon
223 2014-05-22T17:13:52 *** derdon
224 2014-05-22T17:14:19 <RogerHaase> randomax: hard to tell, is the goal to have all expanded links visible on a 1280x1024 display, or ? Also show code changes, are you doing the expand/contract with bootstrap classes?
225 2014-05-22T17:18:50 <randomax> my laptop does not support 1280x1024 so i wont be able to tell about that.. but yeah i do notice issue 72 coming up at 1024x768..
226 2014-05-22T17:19:00 *** derdon
227 2014-05-22T17:19:13 <randomax> i am just using the "hidden" class with a few lines of javascript
228 2014-05-22T17:19:30 <randomax> i'll put up a codereview
229 2014-05-22T17:19:36 *** derdon
230 2014-05-22T17:25:39 <randomax> https://codereview.appspot.com/96520046
231 2014-05-22T17:25:43 *** randomax
232 2014-05-22T17:28:30 *** skathpalia
233 2014-05-22T17:33:44 *** greg_f
234 2014-05-22T18:10:29 *** eSyr_
235 2014-05-22T18:10:36 *** eSyr
236 2014-05-22T22:10:40 *** RogerHaase
237 2014-05-22T22:23:26 *** derdon
238 2014-05-22T22:24:41 *** derdon
239 2014-05-22T22:34:41 *** derdon
240 2014-05-22T22:37:05 *** derdon
241 2014-05-22T22:53:31 *** derdon
242 2014-05-22T22:57:10 *** derdon
243 2014-05-22T23:13:11 *** derdon
244
