1 2014-06-02T00:09:28 *** Cthulhux
2 2014-06-02T00:10:02 *** Cthulhux
3 2014-06-02T00:20:18 *** penguinRaider
4 2014-06-02T00:46:24 *** Cthulhux
5 2014-06-02T00:46:24 *** Cthulhux
6 2014-06-02T00:47:27 *** sl33k_
7 2014-06-02T01:55:14 *** derdon
8 2014-06-02T03:30:53 *** penguinRaider
9 2014-06-02T03:39:38 *** sl33k_
10 2014-06-02T03:42:55 *** penguinRaider
11 2014-06-02T04:44:31 *** skathpalia
12 2014-06-02T04:44:34 <skathpalia> moin
13 2014-06-02T04:45:19 <skathpalia> ThomasWaldmann, I think I got the method to display field along with value
14 2014-06-02T04:46:45 <skathpalia> In the MoinMoin.util.interwiki.CompositeName we can define a method get_label which looks on the field and returns the respective label which is defined and if no label is defined then it simply returns the fqname.field as label
15 2014-06-02T04:47:13 <skathpalia> This way we will define labels only at one place and whenever required this method can be called
16 2014-06-02T04:47:34 <skathpalia> ThomasWaldmann, What do you say about this idea?
17 2014-06-02T05:00:19 *** skathpalia
18 2014-06-02T05:46:32 *** skathpalia
19 2014-06-02T06:00:42 *** sl33k_
20 2014-06-02T07:14:47 *** skathpalia
21 2014-06-02T07:23:40 *** magu_cic
22 2014-06-02T07:26:45 *** magu_cic_
23 2014-06-02T07:28:06 *** skathpalia
24 2014-06-02T07:57:06 *** sl33k_
25 2014-06-02T08:07:16 *** skathpalia
26 2014-06-02T08:13:02 *** randomax
27 2014-06-02T09:20:04 *** greg_f
28 2014-06-02T10:29:15 <randomax> moin
29 2014-06-02T10:29:52 <randomax> ThomasWaldmann, about the quicklink shortening problem discussed earlier
30 2014-06-02T10:30:14 <randomax> i changed the code in the __init__.py after the call to split_navilink
31 2014-06-02T10:31:09 <randomax> but i needed to send in another variable in the return statement to the template for the href section
32 2014-06-02T10:31:42 <randomax> https://codereview.appspot.com/91680043/diff2/1:100001/MoinMoin/themes/__init__.py
33 2014-06-02T10:32:15 <randomax> i determined the variable "item_name" in case of wikilinks and quicklinks but
34 2014-06-02T10:33:04 <randomax> i have a doubt in what should be the equivalent in case of the sisterwiki
35 2014-06-02T11:42:05 *** derdon
36 2014-06-02T11:53:24 *** skathpalia
37 2014-06-02T12:08:39 <ThomasWaldmann> randomax: sisterwiki is same as local wiki, except that it is not local, thus you need to give the name of the other wiki also
38 2014-06-02T12:08:51 * ThomasWaldmann bbl
39 2014-06-02T12:30:31 *** derdon
40 2014-06-02T12:31:45 *** derdon
41 2014-06-02T12:40:08 *** dave_largo
42 2014-06-02T13:14:20 *** RogerHaase
43 2014-06-02T13:45:12 <randomax> RogerHaase, hi
44 2014-06-02T13:45:21 <randomax> changed the search ui a bit
45 2014-06-02T13:45:23 <randomax> http://picpaste.com/pics/search2-t4wiCSmf.1401716688.png
46 2014-06-02T13:46:55 <randomax> ThomasWaldmann, by the other wiki you mean the sisterwiki ?
47 2014-06-02T13:49:28 <RogerHaase> randomax: moin, I like the color highlighting of the suggestions
48 2014-06-02T13:52:19 <randomax> RogerHaase, any more changes you suggest i should make ?
49 2014-06-02T13:56:46 <RogerHaase> I think the input area should be wider. I was initially confused about the lack of a search button (did not realize I should just type into input area) I am unsure if other users will be confused as well. Does it need instructions or a search button?
50 2014-06-02T14:00:39 <randomax> Hmm.. we can give a placeholder text in the text box saying "Type in your search query"
51 2014-06-02T14:01:05 <RogerHaase> If one checks the "search all revisions", do you have to change the input area contents to see the effect?
52 2014-06-02T14:01:55 <RogerHaase> I don't think a place holder will work, because the user input is already in the input area.
53 2014-06-02T14:02:39 <ThomasWaldmann> randomax: yes
54 2014-06-02T14:03:56 <randomax> RogerHaase, then the only option is to give a small instruction below it
55 2014-06-02T14:04:23 <randomax> bcoz it is an ajax search and searches on the go so there is no need of a button
56 2014-06-02T14:07:40 <RogerHaase> checking the "search all revisions" does not update the search results, I think it should.
57 2014-06-02T14:11:10 <randomax> yeah it is not auto-updating
58 2014-06-02T14:11:18 <randomax> i'll work on that
59 2014-06-02T14:11:38 <RogerHaase> what do you think of adding check box (that starts as checked) labeled something like "search as you type"? That would turn off ajax search. Would big sites concerned about load want to turn off ajax search feature?
60 2014-06-02T14:14:13 <randomax> but there is another search box on the top..
61 2014-06-02T14:14:19 <randomax> that has a search button
62 2014-06-02T14:14:43 <randomax> 2 similar search boxes would be odd
63 2014-06-02T14:15:08 <randomax> it is still odd actually
64 2014-06-02T14:17:04 <RogerHaase> Right, 2 search boxes is odd. Google has feature to set Instant Predictions to Always/Never/Only when computer is fast/
65 2014-06-02T14:17:17 <skathpalia> ThomasWaldmann, I got one idea regarding the labels part which we were discussing yesterday
66 2014-06-02T14:17:19 <skathpalia> In the MoinMoin.util.interwiki.CompositeName we can define a method get_label which looks on the field and returns the respective label which is defined and if no label is defined then it simply returns the fqname.field as label
67 2014-06-02T14:17:41 <skathpalia> This way we will define labels only at one place and whenever required this method can be called and there won't be any code repetition
68 2014-06-02T14:18:06 <skathpalia> What do you say about this idea?
69 2014-06-02T14:21:49 <dreimark> moin
70 2014-06-02T14:21:51 <ThomasWaldmann> skathpalia: did you consider using __unicode__?
71 2014-06-02T14:22:41 <skathpalia> No
72 2014-06-02T14:22:41 <RogerHaase> randomax: for now, let's say turning ajax search on/off is a feature outside your project scope. Add a small instruction below the input box.
73 2014-06-02T14:23:03 <RogerHaase> dreimark: moin! long time no type
74 2014-06-02T14:23:19 <randomax> RogerHaase, Ok.. I'll do that..
75 2014-06-02T14:23:43 <skathpalia> ThomasWaldmann, How can we use that?
76 2014-06-02T14:24:02 <dreimark> RogerHaase: yeah, and so much other python todo still todo ;)
77 2014-06-02T14:25:27 <RogerHaase> dreimark: yes, the size of the todo list is still going the wrong way :-/
78 2014-06-02T14:26:27 <randomax> RogerHaase, code review for quicklinks - https://codereview.appspot.com/91680043/
79 2014-06-02T14:26:36 <randomax> bbl.. going for dinner
80 2014-06-02T14:27:04 <ThomasWaldmann> https://pypi.python.org/pypi/XStatic-JQuery.TableSorter/2.14.5.1 < radomir just packaged that one
81 2014-06-02T14:27:49 <RogerHaase> randomax: maybe look at turning off the UR search box by modifying search.html.
82 2014-06-02T14:39:27 *** skathpalia
83 2014-06-02T14:43:20 <RogerHaase> randomax: done, only one small comment. it is good idea to run tests after changes and before cr
84 2014-06-02T14:52:39 *** skathpalia
85 2014-06-02T14:54:06 <skathpalia> ThomasWaldmann, ^^
86 2014-06-02T14:58:25 <ThomasWaldmann> skathpalia: unicode(fqname)
87 2014-06-02T14:58:51 <ThomasWaldmann> if you don't know the usual python magic methods yet, you should catch up on them
88 2014-06-02T15:01:45 <skathpalia> I wanted to ask how is it beneficial in our case
89 2014-06-02T15:01:54 <skathpalia> I mean using this unicode methos
90 2014-06-02T15:01:57 <skathpalia> *methos
91 2014-06-02T15:02:18 <ThomasWaldmann> didn't you search for a text representation of a fqname?
92 2014-06-02T15:04:28 <skathpalia> I was thinking of a way to get labels also associated with CompositeName so that we can use it in message and subject of the mail
93 2014-06-02T15:05:53 <skathpalia> Text representation of fqname?
94 2014-06-02T15:07:19 <ThomasWaldmann> "You modified %s." % unicode(fqname)
95 2014-06-02T15:08:20 <ThomasWaldmann> or rather "%s was modified."
96 2014-06-02T15:09:03 <skathpalia> We can add this in message and subject
97 2014-06-02T15:09:21 <skathpalia> Also i think in logging also this can be added
98 2014-06-02T15:09:37 <skathpalia> right?
99 2014-06-02T15:10:02 <ThomasWaldmann> well, likely at any place where you need a text representation of such an object
100 2014-06-02T15:10:22 <skathpalia> Okay making changes in the code
101 2014-06-02T15:10:33 <RogerHaase> randomax: just noticed the last cr causes traceback in foobar theme, you need to fix that
102 2014-06-02T15:12:33 <RogerHaase> randomax: back to search ui, neither the modernized nor the foobar theme show the upper-right search box on the search item so it would be consistent to remove it from the basic theme
103 2014-06-02T15:22:55 <skathpalia> ThomasWaldmann, I have updated the cr (used unicode(fqname) instead of label) https://codereview.appspot.com/93570043
104 2014-06-02T15:29:10 <randomax> RogerHaase, yes i'll do that..
105 2014-06-02T15:35:32 <RogerHaase> randomax: you also need to do fix for basic theme css vs. less out of sync
106 2014-06-02T15:37:49 <RogerHaase> skathpalia: isn't there a requirement to update blog more frequently?
107 2014-06-02T15:40:14 <skathpalia> Yeah
108 2014-06-02T15:40:33 <skathpalia> I will soon write some blog-posts regarding my status
109 2014-06-02T15:40:48 <skathpalia> ThomasWaldmann, I have updated the cr
110 2014-06-02T15:48:16 <ThomasWaldmann> skathpalia: so how does the complete message now look like when it is expanded?
111 2014-06-02T15:49:23 <skathpalia> The name_of_item (url_of_item) on wiki_name has been modified
112 2014-06-02T15:50:00 <ThomasWaldmann> i mean the subject, line 219 in notifications.py
113 2014-06-02T15:50:48 <skathpalia> Oh I need to remove that with :(
114 2014-06-02T15:51:37 <ThomasWaldmann> ^^ stuff you could find if you did the first review yourself :)
115 2014-06-02T15:52:12 <skathpalia> Sorry for that
116 2014-06-02T15:52:30 <skathpalia> I will to not make such mistake from next time
117 2014-06-02T15:52:40 <skathpalia> I have removed that error
118 2014-06-02T15:52:47 <ThomasWaldmann> ok, after fixing the message, run pytest with pep8 check and do some practical tests also
119 2014-06-02T15:53:06 <ThomasWaldmann> from just looking at the code (i didn't run it), i don't see anything else
120 2014-06-02T15:54:00 <ThomasWaldmann> you can also check again the feedback you got in the past 20 reviews, whether you have reacted to all of it
121 2014-06-02T15:54:01 <randomax> RogerHaase, , yes i already did that.. should i make a code review for that ?
122 2014-06-02T15:54:24 <RogerHaase> yes
123 2014-06-02T15:55:27 <skathpalia> i have run pytests and pep-8 (./m tests)
124 2014-06-02T15:55:32 <skathpalia> No test is failing
125 2014-06-02T16:15:42 <skathpalia> RogerHaase, I forgot which version of stylus and node js is to be used for running ./m css
126 2014-06-02T16:16:03 <skathpalia> Can you please tell me their version?
127 2014-06-02T16:18:01 <skathpalia> My current version is causing some unnecessary changes
128 2014-06-02T16:19:17 <RogerHaase> skathpalia: stylus must be 0.42.2, lessc, nodejs, and npm can be any current version
129 2014-06-02T16:30:15 <randomax> RogerHaase, code review for basic.css https://codereview.appspot.com/100920043
130 2014-06-02T16:33:20 <randomax> Also fixed the foobar traceback - https://codereview.appspot.com/91680043/
131 2014-06-02T16:39:05 <RogerHaase> randomax: I thought stylus adding an extra blank line to the end of common.css was a Windows-only problem. Either revert it or run ./m coding-std to revert it and update the CR (I am booting ubuntu to retest stylus)
132 2014-06-02T16:41:11 <randomax> RogerHaase, updated it
133 2014-06-02T16:42:04 <skathpalia> RogerHaase, i am getting a name error on running ./m css
134 2014-06-02T16:42:20 <skathpalia> My stylus version is 0.42.2
135 2014-06-02T16:42:46 <skathpalia> It says screen-md is not defined in line 6 of basic.less
136 2014-06-02T16:44:00 <RogerHaase> randomax: ok, commit and push 100920043 to your public repo
137 2014-06-02T16:44:32 <randomax> actually i already have a pull request in waiting.. should i wait for it ?
138 2014-06-02T16:44:36 <randomax> RogerHaase, ^
139 2014-06-02T16:45:36 <RogerHaase> skathpalia: that is a lessc error. Your repo is way out of date - run ./m quickinstall to upgrade to bootstrap to 3.1.1.2, lots of other stuff will get updated too
140 2014-06-02T16:45:56 <RogerHaase> repo/virtualenv
141 2014-06-02T16:58:30 *** magu_cic_
142 2014-06-02T16:59:48 <RogerHaase> skathpalia: btw, https://codereview.appspot.com/100920043 will effect your output. We need to get that pushed to main repo and then you must pull it to get a clean changeset
143 2014-06-02T17:00:58 *** magu_cic
144 2014-06-02T17:05:42 <skathpalia> Yeah I will wait for it to be pushed to main repo and then I will make a pull request
145 2014-06-02T17:07:11 <skathpalia> RogerHaase, I pulled randomax's repo and after running quickinstall.py I ran ./m css then also same error is coming
146 2014-06-02T17:21:09 * ThomasWaldmann migrates a win xp machine to linux
147 2014-06-02T17:27:36 <RogerHaase> skathpalia: randomax has not yet pushed his change to his public repo; looking for screen-md...
148 2014-06-02T17:33:19 <randomax> RogerHaase, should i wait for the pull request to get merged ?
149 2014-06-02T17:38:10 <RogerHaase> randomax: no, push and then do another pull request (it will tell you to update old pull request)
150 2014-06-02T17:43:01 <skathpalia> RogerHaase, is that error coming in yours also?
151 2014-06-02T17:44:07 <RogerHaase> skathpalia: now remembering #409 was about screen-medium missing, new name is screen-mn and it should be defined way down in <venv>/site-packages/xstatic/pkg/bootstrap/data/less/variables.less line 273
152 2014-06-02T17:44:33 <RogerHaase> skathpalia: no I do not get error on either windows nor ubuntu
153 2014-06-02T17:45:15 <RogerHaase> sereen.mn/screen-md
154 2014-06-02T17:48:09 <RogerHaase> ..and note above it says screen-md is deprecated. screen-md-min is successor?
155 2014-06-02T17:48:37 <RogerHaase> skathpalia: what CR on you getting this error on?
156 2014-06-02T17:49:16 <skathpalia> I just pulled the repo and didn'r make any changes and simply ran ./m css
157 2014-06-02T17:52:51 <randomax> RogerHaase skathpalia pushed the commit to my public repo
158 2014-06-02T17:57:05 <RogerHaase> ?
159 2014-06-02T17:58:14 <randomax> *I pushed the commit to my repo
160 2014-06-02T17:58:59 <RogerHaase> skathpalia: try to pull from randomax again and rerun. I am not getting error here
161 2014-06-02T17:59:06 <RogerHaase> back in 20 min
162 2014-06-02T18:18:07 <RogerHaase> skathpalia: I pulled your repo into my copy of randomax's and did ./m css -- no errors
163 2014-06-02T18:18:40 <skathpalia> I think there is some problem with my lessc
164 2014-06-02T18:18:50 <skathpalia> I am installing it again
165 2014-06-02T18:21:33 *** randomax
166 2014-06-02T18:23:42 <skathpalia> Yeah problem was with lessc only
167 2014-06-02T18:23:52 <skathpalia> I am now updating the cr
168 2014-06-02T18:25:44 <RogerHaase> great!
169 2014-06-02T18:28:38 *** greg_f
170 2014-06-02T18:35:46 <skathpalia> RogerHaase, I have update the cr https://codereview.appspot.com/80700049
171 2014-06-02T18:35:57 <skathpalia> *updated
172 2014-06-02T18:37:55 <RogerHaase> skathpalia: you did not add the comment that tw wanted in basic.less
173 2014-06-02T18:39:00 <skathpalia> Oh I forgot to do that
174 2014-06-02T18:39:11 <skathpalia> I saw your comment on it just now
175 2014-06-02T18:42:52 <skathpalia> RogerHaase, I have added comment also (added the same comment that you mentioned in the cr as I felt that would be perfect)
176 2014-06-02T18:44:01 <RogerHaase> looks OK to me
177 2014-06-02T18:44:21 <skathpalia> Can I commit it to my repo?
178 2014-06-02T18:46:02 <RogerHaase> no guts, no glory -- go
179 2014-06-02T18:47:10 <skathpalia> Also should I make a new pull request or add it to existing one?
180 2014-06-02T18:48:25 <RogerHaase> yes, it helps tw. If he pulls per old request he will not pull the later changes
181 2014-06-02T19:24:36 <ananasova> moin :)
182 2014-06-02T19:31:22 <RogerHaase> ThomasWaldmann: prevent stylus vs. coding-std conflict on modernized common.css https://codereview.appspot.com/103840043/
183 2014-06-02T19:33:50 *** skathpalia
184 2014-06-02T19:55:56 *** skathpalia
185 2014-06-02T19:59:12 <skathpalia> ThomasWaldmann, I have tested the code
186 2014-06-02T19:59:30 <skathpalia> Now mail is being sent even if the there is no item_name
187 2014-06-02T19:59:57 <skathpalia> i found one error during testing
188 2014-06-02T20:00:33 <skathpalia> I removed that error by making some small changes in MoinMoin/util/subscriptions.py
189 2014-06-02T20:00:50 <skathpalia> Here is the cr https://codereview.appspot.com/93570043
190 2014-06-02T20:01:14 *** skathpalia
191 2014-06-02T20:40:45 *** sl33k_
192 2014-06-02T21:18:13 *** dave_largo
193 2014-06-02T22:13:50 *** RogerHaase
194 2014-06-02T23:06:01 *** penguinRaider
195 2014-06-02T23:06:09 *** penguinRaider
196 2014-06-02T23:26:51 *** sl33k_
197 2014-06-02T23:30:34 *** sl33k_
198 2014-06-02T23:30:39 *** sl33k_
199 2014-06-02T23:54:25 *** derdon
200
