1 2014-06-10T01:41:27 *** penguinRaider
2 2014-06-10T02:11:20 *** sl33k_
3 2014-06-10T02:25:01 *** penguinRaider
4 2014-06-10T02:41:58 *** penguinRaider
5 2014-06-10T04:31:29 *** penguinRaider
6 2014-06-10T04:42:30 *** skathpalia
7 2014-06-10T04:43:11 <skathpalia> ThomasWaldmann, I am facing a problem in creating tickets without any name initially
8 2014-06-10T04:45:18 <skathpalia> While saving it checks for fqname but for ticket items this cannot be defined initially as till then there is no itemid as well as no name so I am not able to understand hoe we can create tickets with no initial name
9 2014-06-10T04:45:41 <skathpalia> So do you have any idea of how this can be implemented?
10 2014-06-10T04:57:28 <skathpalia> At some places it is checked if that item already exist and for that it uses fqname and since we cannot provide any fqname do it raises error
11 2014-06-10T04:57:37 <skathpalia> *so it raises error
12 2014-06-10T04:59:27 *** sl33k_
13 2014-06-10T05:13:06 *** sl33k_
14 2014-06-10T05:18:58 *** sl33k_
15 2014-06-10T05:35:41 <skathpalia> For example here https://bitbucket.org/thomaswaldmann/moin-2.0/src/1663ebfcb4c4a474f02673b1dbe5ac02f4a79012/MoinMoin/storage/middleware/indexing.py?at=default#cl-870 it sees if item has no name then it looks for itemid but if while creating a ticket there is no ITEMID also until it is saved so this part raises an error
16 2014-06-10T05:37:50 *** skathpalia
17 2014-06-10T05:40:09 *** magu_cic
18 2014-06-10T05:41:58 *** sl33k_
19 2014-06-10T06:59:58 *** sl33k_
20 2014-06-10T07:53:49 <dimazest> morning
21 2014-06-10T07:54:30 <dimazest> skathpalia if you look to _fqname, it check whether name is none
22 2014-06-10T07:54:57 <dimazest> maybe, inside of fqname, you can check, whether an object has a name
23 2014-06-10T07:55:04 <dimazest> if it doesn't then pass None
24 2014-06-10T07:55:26 <dimazest> getattr() should help in this case
25 2014-06-10T08:27:43 *** sl33k_
26 2014-06-10T08:33:38 *** greg_f
27 2014-06-10T08:48:01 *** Bernard2
28 2014-06-10T08:54:02 <Bernard2> Just for your info. I had trouble to debug Moin2 using WingIDE. The developers of WingIDE had a work-arround, which work for me. I asked them, to edit http://moinmo.in/MoinMoin2/IdeSetup with there temporary solution.
29 2014-06-10T09:05:19 *** skathpalia
30 2014-06-10T09:48:14 <skathpalia> dimazest, I tried passing None but still we need some fqname or itemid as it is needed for configuring ACLs here https://bitbucket.org/thomaswaldmann/moin-2.0/src/1663ebfcb4c4a474f02673b1dbe5ac02f4a79012/MoinMoin/storage/middleware/protecting.py?at=default#cl-117
31 2014-06-10T09:53:29 <dimazest> why there is no itemid?
32 2014-06-10T09:57:07 <Bernard2> I would like to read the unrendered string of a wikipage. In content.py method _render_data(self) I can retrieve rendered data. But how can I retrieve the bare string content?
33 2014-06-10T09:58:38 <skathpalia> dimazest, Even I am not able to understand that why there is no itemid yet
34 2014-06-10T09:59:43 <dimazest> ok, do you know where item id is generated?
35 2014-06-10T09:59:53 <dimazest> all items have an item id, right?
36 2014-06-10T10:00:13 <dimazest> then we might check the acl too early, before an item is created
37 2014-06-10T10:00:40 <dimazest> on the other side, that might make sense, because we don't want to create an item, if a user is not allowed to
38 2014-06-10T10:00:48 <skathpalia> all items do have itemid
39 2014-06-10T10:01:21 <skathpalia> But its a ticket item so everyone should be able to create it
40 2014-06-10T10:01:38 <skathpalia> as it is there is bitbucket
41 2014-06-10T10:01:50 <skathpalia> everyone can report a bug
42 2014-06-10T10:07:26 <dimazest> i think that the code for item creation and acl check is general for all items
43 2014-06-10T10:07:44 <dimazest> so acl check should be here, we should not throw away it
44 2014-06-10T10:08:12 <dimazest> but we need to find a place which assumes that there is a *name* and relies on it
45 2014-06-10T10:11:44 <skathpalia> dimazest, at this place https://bitbucket.org/thomaswaldmann/moin-2.0/src/1663ebfcb4c4a474f02673b1dbe5ac02f4a79012/MoinMoin/storage/middleware/indexing.py?at=default#cl-946 some name or itemid should be there
46 2014-06-10T10:12:45 <skathpalia> query should have some unique field and value which we cannot provide because at this time no name or itemid is associated with the item
47 2014-06-10T10:14:12 <dimazest> ok
48 2014-06-10T10:14:21 <dimazest> do you have a stack trace
49 2014-06-10T10:14:33 <skathpalia> Yeah
50 2014-06-10T10:14:33 <dimazest> of the exception when the code expects a name
51 2014-06-10T10:18:13 <skathpalia> Here is the traceback if no initial name is passed http://paste.ubuntu.com/7622787/
52 2014-06-10T10:20:29 <dimazest> ok, that looks familiar
53 2014-06-10T10:21:43 <ThomasWaldmann> i have not much time, but a few hints:
54 2014-06-10T10:22:13 <ThomasWaldmann> the itemid/revid is created by storage system when creating/storing the item
55 2014-06-10T10:25:49 <dimazest> so, by this line, the item should already exist https://bitbucket.org/thomaswaldmann/moin-2.0/src/1663ebfcb4c4a474f02673b1dbe5ac02f4a79012/MoinMoin/items/__init__.py?at=default#cl-538
56 2014-06-10T10:26:48 <dimazest> as a remark, maybe self.fqname.query should not contain items which value is None
57 2014-06-10T10:27:12 <skathpalia> No item may or may not exist but fqname should exist
58 2014-06-10T10:28:05 <skathpalia> For other items it is fqname = CompositeName(namespace, u'name_exact', NAME_OF_ITEM)
59 2014-06-10T10:28:38 <skathpalia> But for ticket items we don't have any fqname as there is no name and itemid is not generated till then
60 2014-06-10T10:34:16 *** derdon
61 2014-06-10T10:39:17 <dimazest> i see
62 2014-06-10T10:39:33 <dimazest> should then fqname include item id?
63 2014-06-10T10:39:40 <ThomasWaldmann> it doesn't make much sense asking for a fqname of an item that does not yet exist
64 2014-06-10T10:40:40 <ThomasWaldmann> but to solve somehow similar problems a while ago, I made this DummyRev(ision) object, that just fakes a revision until we really have one.
65 2014-06-10T10:40:45 <skathpalia> ThomasWaldmann, it requires fqname before creating item as it needs to search that if that item already exist
66 2014-06-10T10:41:05 <ThomasWaldmann> NO IT DOES NOT
67 2014-06-10T10:41:33 <ThomasWaldmann> i already told you twice that you should go around that "try if it exists and offer creation if not" magic
68 2014-06-10T10:42:34 <ThomasWaldmann> so I'ld rather like to see issues (if any) if you really try that
69 2014-06-10T10:44:02 <ThomasWaldmann> you KNOW that this item is new
70 2014-06-10T10:45:20 <skathpalia> Yeah I am tried that but while making latest_doc https://bitbucket.org/thomaswaldmann/moin-2.0/src/1663ebfcb4c4a474f02673b1dbe5ac02f4a79012/MoinMoin/storage/middleware/indexing.py?at=default#cl-947 here it needs query
71 2014-06-10T10:45:46 <skathpalia> But query is None for ticket item
72 2014-06-10T10:47:01 <ThomasWaldmann> you mean query == {}, right?
73 2014-06-10T10:47:14 <skathpalia> Yeah
74 2014-06-10T10:48:14 <ThomasWaldmann> ok, what would happen if you put an "if query:" before line 949 and indent only line 949 one level
75 2014-06-10T10:52:25 <skathpalia> ThomasWaldmann, then also error is raised as that query is required afterwards also
76 2014-06-10T10:52:37 <skathpalia> In this line error is raised https://bitbucket.org/thomaswaldmann/moin-2.0/src/1663ebfcb4c4a474f02673b1dbe5ac02f4a79012/MoinMoin/storage/middleware/indexing.py?at=default#cl-821
77 2014-06-10T10:54:34 <ThomasWaldmann> so, why are you calling get_item if you know there is no such item?
78 2014-06-10T10:55:31 <ThomasWaldmann> (maybe the create_item just a few lines below would be better?)
79 2014-06-10T10:58:30 <skathpalia> For that also we need to send query which should consist of unique fields
80 2014-06-10T11:01:52 *** derdon
81 2014-06-10T11:01:57 *** derdon_
82 2014-06-10T11:02:10 <ThomasWaldmann> why?
83 2014-06-10T11:03:31 <skathpalia> It is mentioned in the comment in the method
84 2014-06-10T11:03:49 <skathpalia> Also it is then used by create method
85 2014-06-10T11:06:29 *** waldi
86 2014-06-10T11:13:00 <ThomasWaldmann> point me to the line where you think it doesn't work (or just try)
87 2014-06-10T11:13:20 * ThomasWaldmann needs to leave in 10mins
88 2014-06-10T11:14:32 <skathpalia> I tried and here it doesn't work https://bitbucket.org/thomaswaldmann/moin-2.0/src/1663ebfcb4c4a474f02673b1dbe5ac02f4a79012/MoinMoin/storage/middleware/indexing.py?at=default#cl-991
89 2014-06-10T11:17:48 *** waldi
90 2014-06-10T11:17:48 *** waldi
91 2014-06-10T11:26:12 <dimazest> that's a very strange code
92 2014-06-10T11:26:34 <dimazest> if not item:
93 2014-06-10T11:26:38 <dimazest> then return it
94 2014-06-10T11:30:56 *** derdon_
95 2014-06-10T11:45:51 <ThomasWaldmann> dimazest: likely the __bool__ / __nonzero__ method :)
96 2014-06-10T11:47:33 * ThomasWaldmann away
97 2014-06-10T11:51:57 *** sl33k_
98 2014-06-10T11:58:50 *** skathpalia
99 2014-06-10T12:07:32 *** sl33k_
100 2014-06-10T12:17:37 *** sl33k_
101 2014-06-10T12:40:46 *** dave_largo
102 2014-06-10T13:19:21 <dimazest> i'm wondering what does it mean for an item to be zero
103 2014-06-10T13:19:27 <dimazest> empty?
104 2014-06-10T13:25:53 *** randomax
105 2014-06-10T13:38:54 <dimazest> but then deciding that an item is newly created because it's emti
106 2014-06-10T13:39:05 <dimazest> *empty, is rather strange to me
107 2014-06-10T14:11:56 *** skathpalia
108 2014-06-10T14:23:29 *** sl33k_
109 2014-06-10T15:04:27 *** penguinRaider
110 2014-06-10T15:16:42 *** magu_cic
111 2014-06-10T15:33:41 *** skathpalia
112 2014-06-10T15:42:10 *** Bernard2
113 2014-06-10T15:52:34 <randomax> ThomasWaldmann, added advanced search - https://codereview.appspot.com/109730047
114 2014-06-10T15:52:44 <randomax> basic theme - http://picpaste.com/pics/basic-2Cuu6LaP.1402415472.png
115 2014-06-10T15:52:52 <randomax> foobar theme - http://picpaste.com/pics/foobar-Nzqm45uZ.1402415489.png
116 2014-06-10T15:53:10 <randomax> modernized theme - http://picpaste.com/pics/modernized-4hZMJ7G6.1402415506.png
117 2014-06-10T16:41:58 *** skathpalia
118 2014-06-10T17:01:36 *** sl33k_
119 2014-06-10T17:22:54 *** RogerHaase
120 2014-06-10T17:33:11 <RogerHaase> randomax: what does "older items", "newer items" radio button do?
121 2014-06-10T17:33:24 *** penguinRaider
122 2014-06-10T17:34:27 <RogerHaase> randomax: when I try to apply your CR patch to your current repo tip I get rejects on search.js
123 2014-06-10T17:36:47 <randomax> RogerHaase, one more thing.. this is currently an old repo.. i'll send the final pull on a new repo..
124 2014-06-10T17:37:09 <randomax> older items presents older items first
125 2014-06-10T17:37:19 <randomax> newer items presents newer items first
126 2014-06-10T17:40:07 <RogerHaase> randomax: the checkboxes under item types would exclude a type if checked?
127 2014-06-10T17:40:16 *** greg_f
128 2014-06-10T17:40:52 <randomax> no it would include the type that is checked
129 2014-06-10T17:41:25 <RogerHaase> randomax: is tere a way to exclude by date - before, after, between dates?
130 2014-06-10T17:41:38 <RogerHaase> tere/there
131 2014-06-10T17:42:53 <RogerHaase> randomax: then initial value for item types checkboxes should start as all checked?
132 2014-06-10T17:43:27 <randomax> RogerHaase, i can try to do that..
133 2014-06-10T17:43:47 <randomax> regarding the checkboxes
134 2014-06-10T17:43:58 <randomax> if somebody wants only a single item type
135 2014-06-10T17:44:23 <randomax> or 2-3 items (which will be mostly be the case i guess)
136 2014-06-10T17:44:31 <randomax> he'll have to uncheck all the others
137 2014-06-10T17:47:06 <RogerHaase> randomax: yes, that is a lot of unchecking.. but none selected means all is also confusing
138 2014-06-10T17:48:18 <RogerHaase> randomax: maybe add ar checkbox that starts checked that is labeled "all types"
139 2014-06-10T17:48:57 <RogerHaase> or "select all types" or ?
140 2014-06-10T17:49:06 <randomax> ok i'll do that
141 2014-06-10T17:50:06 <RogerHaase> randomax: are these all ajax activated when selected or deselected?
142 2014-06-10T17:50:25 <randomax> yes
143 2014-06-10T17:58:26 <RogerHaase> back in 20 min
144 2014-06-10T18:19:39 *** sl33k_
145 2014-06-10T18:23:52 *** derdon
146 2014-06-10T18:26:16 *** sl33k_
147 2014-06-10T18:30:44 *** sl33k_
148 2014-06-10T18:32:26 *** dave_largo
149 2014-06-10T18:42:24 *** skathpalia
150 2014-06-10T18:44:54 <RogerHaase> randomax: the css for basic, modernized and foobar are almost the same?
151 2014-06-10T18:45:00 *** sl33k_
152 2014-06-10T18:45:08 <randomax> yeah mostly
153 2014-06-10T18:46:18 <RogerHaase> randomax: on your plan, do you have something to eliminate the duplicate code among the themes?
154 2014-06-10T18:47:38 <randomax> RogerHaase, not on my proposed plan but surely i can try doing that..
155 2014-06-10T18:50:23 <RogerHaase> randomax: seems sharky93 made a start by putting 3 lines of code in static/css/ticket.css (stylus/ticket.styl)
156 2014-06-10T18:53:07 <RogerHaase> ThomasWaldmann: are we agreed upon the idea of adding more CSS common to all themes into MoinMoin/static/css; and that we should just code pure CSS rather than deal with stylus vs. lessc issues?
157 2014-06-10T18:54:08 <RogerHaase> skathpalia has been trying to confirm this same issue
158 2014-06-10T19:01:59 *** magu_cic
159 2014-06-10T19:05:28 <randomax> gn :)
160 2014-06-10T19:05:50 *** randomax
161 2014-06-10T19:27:43 *** magu_cic
162 2014-06-10T19:29:00 *** magu_cic
163 2014-06-10T19:39:17 *** magu_cic_
164 2014-06-10T19:43:01 *** magu_cic
165 2014-06-10T20:11:11 *** magu_cic_
166 2014-06-10T20:11:43 *** magu_cic
167 2014-06-10T20:37:12 *** moinBot
168 2014-06-10T22:02:18 *** RogerHaase
169 2014-06-10T22:38:31 *** penguinRaider
170 2014-06-10T22:47:36 *** penguinRaider
171
