1 2014-06-23T00:21:34 *** derdon
2 2014-06-23T06:11:31 *** penguinRaider
3 2014-06-23T08:35:15 *** penguinRaider
4 2014-06-23T09:10:18 *** greg_f
5 2014-06-23T10:10:40 *** derdon
6 2014-06-23T10:40:23 *** derdon_
7 2014-06-23T10:40:38 *** derdon
8 2014-06-23T10:52:43 *** skathpalia
9 2014-06-23T10:53:01 <skathpalia> removed jslint errors from tickets.js https://codereview.appspot.com/102600044/
10 2014-06-23T10:54:22 <skathpalia> dimazest, ^
11 2014-06-23T11:19:28 *** sl33k_
12 2014-06-23T11:31:42 *** randomax
13 2014-06-23T11:52:35 <skathpalia> Also worked on some UI part of tickets
14 2014-06-23T11:52:52 <skathpalia> Here is the screenshot http://picpaste.com/pics/Screenshot_from_2014-06-23_17_16_29-v7olY0yF.1403524034.png
15 2014-06-23T11:55:22 <skathpalia> and the cr https://codereview.appspot.com/107060043/
16 2014-06-23T11:56:45 *** penguinRaider
17 2014-06-23T12:18:42 *** skathpalia
18 2014-06-23T12:27:14 *** sl33k_
19 2014-06-23T12:29:10 <randomax> ThomasWaldmann, review on cr needed https://codereview.appspot.com/109730047
20 2014-06-23T12:30:12 *** sl33k_
21 2014-06-23T12:42:31 <dimazest> maybe it makes sense to show "assigned to" and other similar fields horizontally
22 2014-06-23T12:42:32 *** penguinRaider
23 2014-06-23T12:42:41 <dimazest> they take a lot of space
24 2014-06-23T12:47:35 *** dave_largo
25 2014-06-23T12:50:34 *** penguinRaider
26 2014-06-23T12:59:05 *** sl33k_
27 2014-06-23T12:59:57 *** Bernard1
28 2014-06-23T13:02:07 *** sl33k_
29 2014-06-23T13:10:22 * ThomasWaldmann did some CRs
30 2014-06-23T13:26:12 <randomax> ThomasWaldmann, updated the cr as mentioned in the comments - https://codereview.appspot.com/109730047
31 2014-06-23T13:26:41 <randomax> also updated the cr for pygments css classes - https://codereview.appspot.com/102430045/
32 2014-06-23T14:02:38 *** derdon_
33 2014-06-23T14:02:57 *** skathpalia
34 2014-06-23T14:03:40 <skathpalia> ThomasWaldmann, I have an idea to deal with filter by tags part
35 2014-06-23T14:04:20 <skathpalia> For that we can split the html of tags to get tags in an array and then we can compare the contents of array
36 2014-06-23T14:04:49 <skathpalia> How does this sound?
37 2014-06-23T14:35:59 *** sl33k_
38 2014-06-23T14:51:20 <ThomasWaldmann> skathpalia: the semantics of what you need is:
39 2014-06-23T14:52:00 <ThomasWaldmann> user_selected_tags is-subset-of present_tags_in_issue
40 2014-06-23T14:53:26 <ThomasWaldmann> in python that's quite easy with s.issubset(t) but i have no idea about js
41 2014-06-23T14:53:53 <skathpalia> In the search part this functionality is there
42 2014-06-23T14:54:10 <skathpalia> I mean in search bar one can search for tags also
43 2014-06-23T14:54:34 <ThomasWaldmann> but, to be able to finally finish the filter stuff, maybe just implement filters for stuff where it makes sense
44 2014-06-23T14:54:53 <ThomasWaldmann> which is maybe much less than you think
45 2014-06-23T14:55:20 <ThomasWaldmann> what do we have that is not a scalar value and not a tag?
46 2014-06-23T14:57:35 <skathpalia> My be we can remove filter option by tags as user can search for tags through search bar
47 2014-06-23T14:58:04 <skathpalia> And in other fields we can just check for text inside td tag
48 2014-06-23T14:59:23 <ThomasWaldmann> please answer my question first
49 2014-06-23T15:01:01 <skathpalia> According to the current code, we are just checking the string scalar value inside the td tags
50 2014-06-23T15:01:45 <skathpalia> ThomasWaldmann, I think I didn't get your question
51 2014-06-23T15:02:20 <skathpalia> I mean the columns in which filter option is there contain only scalar values in td tags
52 2014-06-23T15:02:40 <skathpalia> I mean string scalar values
53 2014-06-23T15:03:04 <ThomasWaldmann> did you read what i wrote in last Crß
54 2014-06-23T15:03:07 <ThomasWaldmann> CR?
55 2014-06-23T15:03:41 <skathpalia> Yeah i read that
56 2014-06-23T15:04:10 <ThomasWaldmann> ok, so why do you think it makes sense to filter for values that are scalar?
57 2014-06-23T15:04:40 <ThomasWaldmann> (like 1..5)
58 2014-06-23T15:05:11 <skathpalia> By this user can only view those tickets which have that particular scalar value
59 2014-06-23T15:05:32 <skathpalia> It is implemented in same way in bitbucket also
60 2014-06-23T15:05:41 <ThomasWaldmann> and why would anyone be interested in priority 4, but not 3 and 5 also?
61 2014-06-23T15:06:07 <ThomasWaldmann> don't take everything bitbucket makes without thinking
62 2014-06-23T15:06:31 <ThomasWaldmann> as we've already discussed, some of that stuff is severely lacking
63 2014-06-23T15:06:38 <skathpalia> Okay so you mean that we can have user define range of priority etc
64 2014-06-23T15:06:42 <skathpalia> right?
65 2014-06-23T15:07:08 <ThomasWaldmann> no, i mean the concept of filter just doesn't make too much sense for scalar things
66 2014-06-23T15:07:38 <ThomasWaldmann> of you're shopping and you want 1kg of bread, you might be also interested in offers of 0.9 and 1.1
67 2014-06-23T15:08:16 <ThomasWaldmann> so filtering the offers to just see 1kg makes not much sense as you just might miss interesting stuff that's quite what you wanted, but filtered out
68 2014-06-23T15:08:51 <ThomasWaldmann> so, sorting makes much more sense here
69 2014-06-23T15:09:36 <ThomasWaldmann> i've just tried your currently published code: the sorting works, but only for 1 column
70 2014-06-23T15:09:46 <skathpalia> so we should remove this filter part or have some other alternative for that?
71 2014-06-23T15:10:13 <ThomasWaldmann> so I could sort for prio, but not get prio sorted first and then effort also
72 2014-06-23T15:10:36 <ThomasWaldmann> filter makes sense for non-scalars
73 2014-06-23T15:11:12 <ThomasWaldmann> like open vs. closed (but you already did that by a different control)
74 2014-06-23T15:11:35 <skathpalia> ThomasWaldmann, tablesorter plugin sorts only by one column
75 2014-06-23T15:11:44 <ThomasWaldmann> it also makes somehow sense for tags, but not in the way as you implemented it right now
76 2014-06-23T15:11:58 <ThomasWaldmann> then you need another plugin
77 2014-06-23T15:12:32 <skathpalia> Yeah may be we have to switch to some other plugin
78 2014-06-23T15:12:47 <ThomasWaldmann> just think practically, as when you would like to use that ticket system
79 2014-06-23T15:13:15 *** RogerHaase
80 2014-06-23T15:13:21 <ThomasWaldmann> e.g. google runs that gci contest for younger students
81 2014-06-23T15:13:58 <ThomasWaldmann> and we couldn't use bitbucket because it was not possible to set tags like "easy" or classify the tickets
82 2014-06-23T15:14:32 <ThomasWaldmann> nor it is possible for ANY potential contributor to do any meaningful sorting / filtering of the issues
83 2014-06-23T15:15:21 <ThomasWaldmann> you may have experienced that personally also when looking for stuff you could do from our issue tracker
84 2014-06-23T15:16:31 <ThomasWaldmann> so the goal is to do some tracker that actually makes sense
85 2014-06-23T15:18:14 <skathpalia> Okay then I will look for some other suitable sorter plugin and also remove that filter option
86 2014-06-23T15:18:35 <ThomasWaldmann> (also, for the scalars, you have to consider that whoever assigns such a scalar values has to do a pretty much subjective and not easy to do decision. so someone may say effort 3 and someone else may say 4 or 5)
87 2014-06-23T15:20:42 <ThomasWaldmann> http://mottie.github.io/tablesorter/docs/ that is what you use?
88 2014-06-23T15:21:02 <skathpalia> yeah
89 2014-06-23T15:21:18 <ThomasWaldmann> the very first item says "Multi-Column sorting"
90 2014-06-23T15:21:56 <ThomasWaldmann> ah, shift key!
91 2014-06-23T15:22:13 <ThomasWaldmann> works :D
92 2014-06-23T15:22:23 <ThomasWaldmann> so you can keep it for now
93 2014-06-23T15:22:46 <ThomasWaldmann> but put that hint somewhere, otherwise nobody will find out
94 2014-06-23T15:22:48 <skathpalia> Oh I didn't see that part
95 2014-06-23T15:23:05 <skathpalia> Okay I will add a hint there
96 2014-06-23T15:24:01 <skathpalia> I have an idea of replacing filter section part by some search (may be advanced)
97 2014-06-23T15:24:39 <skathpalia> In this user can specify that ranges of priority etc and then only those will be shown in the table
98 2014-06-23T15:25:45 <skathpalia> ThomasWaldmann, what's your view in this?
99 2014-06-23T15:29:22 <ThomasWaldmann> skathpalia: complicated. clicking on sort is much easier and usually does the same job.
100 2014-06-23T15:29:35 <ThomasWaldmann> or a even better one if you sort by multiple criteria
101 2014-06-23T15:29:50 <skathpalia> Okay then we can completely remove filter part
102 2014-06-23T15:29:59 <ThomasWaldmann> but what we really need is tags-subset selection
103 2014-06-23T15:30:27 <ThomasWaldmann> (or "filtering")
104 2014-06-23T15:30:50 <ThomasWaldmann> if you want to see a (reasonable) example, see how github issue tracker does it
105 2014-06-23T15:32:29 <skathpalia> Yeah that is implemented very nicely
106 2014-06-23T15:32:45 <skathpalia> Will try to implement something similar :)
107 2014-06-23T15:34:11 <skathpalia> ThomasWaldmann, did you get some method to implement create-ticket button?
108 2014-06-23T15:44:45 *** Bernard1
109 2014-06-23T15:44:56 *** randomax
110 2014-06-23T15:50:54 <ThomasWaldmann> skathpalia: i am still somehow in the middle of that. noted some places that likely need changing, but no ready-to-commit solution yet.
111 2014-06-23T15:50:56 *** sl33k_
112 2014-06-23T15:51:41 <ThomasWaldmann> skathpalia: if you need something before I am finished with it, a clearly marked hack would be acceptable. (with some TODO: ...)
113 2014-06-23T15:53:02 <ThomasWaldmann> skathpalia: UI issue: E D S P are very much separated from their sort indicator/control
114 2014-06-23T15:53:36 <skathpalia> Okay will push it to somewhat left
115 2014-06-23T15:53:42 <ThomasWaldmann> so the control of the neighbor is near to the letter, but the right control for that column is far from it
116 2014-06-23T15:54:29 <ThomasWaldmann> is it possible to have the control directly left of the column title
117 2014-06-23T15:54:45 <skathpalia> Yeah
118 2014-06-23T15:55:50 <ThomasWaldmann> the mouseover-paint-it-in-grey makes it clear what belongs to what, but users might still navigate to wrong control first right now
119 2014-06-23T15:56:28 <skathpalia> Yeah I will push it to left of text
120 2014-06-23T15:57:09 *** sl33k_
121 2014-06-23T15:58:29 <ThomasWaldmann> hmm, if one uses shift-click to do a multi-column sort, the order of the columns is not clear
122 2014-06-23T15:58:46 <ThomasWaldmann> like what's used for sorting first, what second, what third
123 2014-06-23T15:59:49 <ThomasWaldmann> but well, one can always start from scratch to get a defined order
124 2014-06-23T16:00:21 <skathpalia> I think it is in the order is according to what is chosen first
125 2014-06-23T16:00:36 <skathpalia> as I saw in the example in that docs
126 2014-06-23T16:01:10 <ThomasWaldmann> yeah sure, like order of clicks. but just by looking at screen, you don't see it.
127 2014-06-23T16:01:49 <ThomasWaldmann> also if you would print it, it would not be directly visible (except by somehow reverse-deducting it from the sort-order you may see in the data)
128 2014-06-23T16:02:46 <ThomasWaldmann> remove sorting from tags column, doesn't make sense as there are sets of tags in these columns, not just single tags
129 2014-06-23T16:03:54 <ThomasWaldmann> this column*
130 2014-06-23T16:04:20 <skathpalia> But how can we specify that to this plugin?
131 2014-06-23T16:06:06 <ThomasWaldmann> sorter and parser = false maybe? see "headers"
132 2014-06-23T16:07:44 *** sl33k_
133 2014-06-23T16:07:52 <skathpalia> Yeah I got that :)
134 2014-06-23T16:10:17 <ThomasWaldmann> the truncation of the summary field (as rendered on my screen right now) happens far before the end of the field width is reached
135 2014-06-23T16:12:06 *** sl33k_
136 2014-06-23T16:12:17 <skathpalia> Oh this is because it only first 50 characters are being shown
137 2014-06-23T16:12:25 <skathpalia> Will remove that
138 2014-06-23T16:13:52 <ThomasWaldmann> on the create/modify form to a ticket, summary is a rather narrow input field, needs to be longer. maybe tags should also be a bit longer.
139 2014-06-23T16:14:25 <ThomasWaldmann> E D S P there has no default selection, which forces the user to specify.
140 2014-06-23T16:14:39 <skathpalia> Okay will increase the width of these
141 2014-06-23T16:14:41 <ThomasWaldmann> this is good and bad ;)
142 2014-06-23T16:15:08 <ThomasWaldmann> on the one hand, it is good to force the user to think about that stuff.
143 2014-06-23T16:15:48 <ThomasWaldmann> otoh, it is bad, because for some submitters, that might be undecidable, because they neither do know, nor they could reasonably estimate.
144 2014-06-23T16:16:59 <ThomasWaldmann> maybe just selecting 1 or 3 for everything might be better.
145 2014-06-23T16:17:11 <ThomasWaldmann> (i mean pre-selecting)
146 2014-06-23T16:17:30 <skathpalia> Actually I tried to set default selection but I couldn't do so
147 2014-06-23T16:17:54 <ThomasWaldmann> otoh, if someone just saves as is, someone else will never know whether this is really that specific value or just because it was not changed.
148 2014-06-23T16:17:55 <skathpalia> Can you please check where can I add this default selection?
149 2014-06-23T16:20:20 <ThomasWaldmann> (all that makes me think whether we need some "None / Unspecified" value there, or maybe we could also just NOT have the key/value pair in metadata if it is not specified)
150 2014-06-23T16:20:36 <ThomasWaldmann> skathpalia: yes, I have a look right now
151 2014-06-23T16:20:56 <ThomasWaldmann> skathpalia: how did it behave without the "required"?
152 2014-06-23T16:21:06 <ThomasWaldmann> what ended up being in metadata?
153 2014-06-23T16:21:42 <skathpalia> iirc if then that field no longer remain in meta data
154 2014-06-23T16:22:17 <skathpalia> I mean earlier if priority was not set then meta[PRIORITY] gives key error
155 2014-06-23T16:23:12 <ThomasWaldmann> we could use .get(PRIO)
156 2014-06-23T16:23:48 <ThomasWaldmann> we then either have an int or None, and then render as str(i) or "" for None
157 2014-06-23T16:24:04 <ThomasWaldmann> tablesorter has some way to specify how to sort the empty stuff
158 2014-06-23T16:24:58 <ThomasWaldmann> and the semantics are much more clear: if it doesn't show a value, it was not specified
159 2014-06-23T16:26:09 <skathpalia> Okay I will make those fields not necessary and show the meta data by above mechanism
160 2014-06-23T16:27:03 <ThomasWaldmann> ok.
161 2014-06-23T16:27:16 <ThomasWaldmann> how many CRs do you have open (not committed) right now?
162 2014-06-23T16:27:38 <skathpalia> I have one for gui of tickets
163 2014-06-23T16:27:52 <skathpalia> cr: https://codereview.appspot.com/107060043/
164 2014-06-23T16:28:03 <ThomasWaldmann> (midterm evals are starting today evening)
165 2014-06-23T16:30:06 *** sl33k_
166 2014-06-23T16:32:15 <ThomasWaldmann> skathpalia: if one clicks on "All" (Filter: ...) the display switches to showing all issues, but this is not indicated (like with "All" getting highlighted somehow)
167 2014-06-23T16:34:12 <ThomasWaldmann> (same for "Open" being the default when just loading /+tickets)
168 2014-06-23T16:35:35 <skathpalia> All is already highlighted
169 2014-06-23T16:36:19 <skathpalia> If one switches from open to all ticket button then all button's background color changes
170 2014-06-23T16:37:28 <ThomasWaldmann> not here. is that the stuff not committed yet?
171 2014-06-23T16:37:40 <skathpalia> yeah
172 2014-06-23T16:37:55 <ThomasWaldmann> ok, one more effect on the UI:
173 2014-06-23T16:38:25 <RogerHaase> ThomasWaldmann: did you miss ^^ <randomax> ThomasWaldmann, review on cr needed https://codereview.appspot.com/109730047
174 2014-06-23T16:38:50 <ThomasWaldmann> if the list of tickets changes (e.g. by filtering), the length of the summaries might change, which makes the rendering "jump" as the column boundaries are at different places then, columns changing width
175 2014-06-23T16:38:56 <RogerHaase> ThomasWaldmann: tested on windows, works OK
176 2014-06-23T16:39:28 <ThomasWaldmann> RogerHaase: reviewed that 2.5h ago
177 2014-06-23T16:40:08 <ThomasWaldmann> (mostly the python stuff)
178 2014-06-23T16:40:56 <RogerHaase> ThomasWaldmann: hmm, do not see any comments on cr
179 2014-06-23T16:41:52 <ThomasWaldmann> i published an empty comment right now, do you see that?
180 2014-06-23T16:42:26 <ThomasWaldmann> #10 is 2.5h ago, #11 is empty and from now
181 2014-06-23T16:44:07 <skathpalia> ThomasWaldmann, we can set fixed width for all columns
182 2014-06-23T16:45:48 <RogerHaase> ThomasWaldmann: sorry, I gave wrong #, meant pygments one https://codereview.appspot.com/102430045/
183 2014-06-23T16:46:07 <ThomasWaldmann> skathpalia: yes, make it fixed
184 2014-06-23T16:46:21 <skathpalia> Ok
185 2014-06-23T16:46:40 <ThomasWaldmann> later (as we can't sort for tags anyway), we could maybe append the tags to the summary, similar as github does
186 2014-06-23T16:47:19 <ThomasWaldmann> then we only have 1 column that varies in width and everything else is rather predictable
187 2014-06-23T16:53:05 <ThomasWaldmann> RogerHaase: i had a look at the CR, looks ok. If you practically tried it, commit. :)
188 2014-06-23T16:53:30 <ThomasWaldmann> randomax: ^^
189 2014-06-23T16:55:10 <ThomasWaldmann> skathpalia: github can only sort by 1 criteria :D
190 2014-06-23T16:57:28 <skathpalia> :D
191 2014-06-23T17:00:26 <ThomasWaldmann> skathpalia: pulled your pull request
192 2014-06-23T17:00:45 <skathpalia> Thanks :)
193 2014-06-23T17:03:59 <ThomasWaldmann> skathpalia: abort sorting: when you have the current stuff finished/committed, think about sort criteria:
194 2014-06-23T17:04:53 <ThomasWaldmann> creation time, modification time
195 2014-06-23T17:05:38 <skathpalia> Ok will try to add that also once I am done with other changes specified
196 2014-06-23T17:06:28 <ThomasWaldmann> maybe the 2nd one is enough (if a ticket is recently modified, do we care about when it was created?)
197 2014-06-23T17:07:22 <skathpalia> Yeah I also think so :)
198 2014-06-23T17:07:52 <skathpalia> only sorting by recently modified would be enough
199 2014-06-23T17:10:40 <ThomasWaldmann> if you implement, use iso 8601
200 2014-06-23T17:11:12 * ThomasWaldmann hates that "6d ago" stuff
201 2014-06-23T17:11:51 <ThomasWaldmann> while it is nice if you only need a rough impression, sometimes you need precise information (and you don't get it that way)
202 2014-06-23T17:23:55 *** skathpalia
203 2014-06-23T18:11:15 *** magu_cic
204 2014-06-23T18:17:44 *** greg_f
205 2014-06-23T20:04:47 *** metanosulfonic
206 2014-06-23T20:07:11 *** metanosulfonic
207 2014-06-23T21:05:23 <RogerHaase> ThomasWaldmann: created the u, ins, del, u issue: https://bitbucket.org/thomaswaldmann/moin-2.0/issue/440/replace-with-s-del-ins-u-tags
208 2014-06-23T21:20:58 *** dave_largo
209 2014-06-23T22:14:10 *** sl33k_
210 2014-06-23T22:19:20 *** penguinRaider
211 2014-06-23T22:20:02 *** penguinRaider
212 2014-06-23T22:20:02 *** RogerHaase
213 2014-06-23T23:12:03 *** magu_cic
214
