1 2014-07-07T03:29:45 *** RogerHaase
2 2014-07-07T03:35:26 *** RogerHaase
3 2014-07-07T05:05:03 *** magu_cic
4 2014-07-07T07:58:08 *** greg_f
5 2014-07-07T08:20:05 *** randomax
6 2014-07-07T08:53:57 <randomax> ThomasWaldmann, Hi.. can i commit this - https://codereview.appspot.com/106390046/
7 2014-07-07T09:20:01 *** skathpalia
8 2014-07-07T09:42:45 *** skathpalia
9 2014-07-07T09:59:34 *** skathpalia
10 2014-07-07T10:07:56 *** skathpalia
11 2014-07-07T10:56:48 *** randomax
12 2014-07-07T11:10:00 *** randomax
13 2014-07-07T11:18:22 *** magu_cic
14 2014-07-07T12:04:49 <randomax> ThomasWaldmann, updated crs
15 2014-07-07T12:05:01 <randomax> https://codereview.appspot.com/101630045
16 2014-07-07T12:05:11 <randomax> https://codereview.appspot.com/109440043/
17 2014-07-07T12:29:13 *** dreimark
18 2014-07-07T12:29:13 *** sharky93
19 2014-07-07T12:29:20 *** dreimark
20 2014-07-07T12:29:58 *** waldi
21 2014-07-07T12:30:06 *** sharky93
22 2014-07-07T12:46:58 *** RogerHaase
23 2014-07-07T12:48:54 *** sl33k_
24 2014-07-07T12:50:42 *** waldi
25 2014-07-07T12:50:42 *** waldi
26 2014-07-07T13:10:09 *** skathpalia
27 2014-07-07T13:11:31 <skathpalia> RogerHaase, I tried to find out the cause of meta data invalidation in modernized and foobar theme but I couldn't get it
28 2014-07-07T13:11:43 <skathpalia> Did you get the cause?
29 2014-07-07T13:14:34 <skathpalia> RogerHaase, I searched the flatland documentation and here I found it http://dag-flatland.readthedocs.org/en/latest/schema/schema/
30 2014-07-07T13:15:24 *** sl33k_
31 2014-07-07T13:15:25 <skathpalia> I mean here http://dag-flatland.readthedocs.org/en/latest/schema/schema/#flatland.schema.base.Element.raw
32 2014-07-07T13:16:17 <skathpalia> They have defined element.raw but I couldn't get what do they mean by unadapted value from input
33 2014-07-07T13:18:45 <skathpalia> RogerHaase, Can you please explain it?
34 2014-07-07T13:19:50 <randomax> RogerHaase, updated crs
35 2014-07-07T13:19:51 <randomax> https://codereview.appspot.com/109440043/
36 2014-07-07T13:20:02 <randomax> https://codereview.appspot.com/101630045/
37 2014-07-07T13:29:30 *** jhermann
38 2014-07-07T13:46:25 <ThomasWaldmann> randomax: done some reviews
39 2014-07-07T13:46:34 <RogerHaase> skathpalia: sorry, I don't understand it either and have not found the cause of the basic/modernized differences
40 2014-07-07T13:47:15 <ThomasWaldmann> randomax: when linking to all these new views, make sure you use a link text that makes really clear what one gets
41 2014-07-07T13:48:35 <randomax> ThomasWaldmann, ok
42 2014-07-07T13:48:45 <randomax> regarding supporting nameless items
43 2014-07-07T13:49:10 <randomax> i first to make changes to frontend.views.modify_item
44 2014-07-07T13:49:19 <randomax> *have to
45 2014-07-07T13:49:34 <randomax> in order to link nameless items
46 2014-07-07T13:49:55 <randomax> i was thinking of doing that in another changeset
47 2014-07-07T13:50:12 <randomax> and then added that support in those views
48 2014-07-07T13:50:24 <randomax> thats why for now i am using item name itself
49 2014-07-07T13:51:20 <randomax> also regarding the searcher.. i couldnt find any other way
50 2014-07-07T13:51:30 <randomax> plus the way i used is the documented way-
51 2014-07-07T13:51:37 <randomax> https://pythonhosted.org/Whoosh/api/searching.html#whoosh.searching.Searcher.documents
52 2014-07-07T13:52:45 <ThomasWaldmann> randomax: ok. then you should put some # TODO: support nameless items there so you don't forget
53 2014-07-07T13:53:14 <randomax> yeah i'll make an issue in my repo for that
54 2014-07-07T13:54:00 <skathpalia> randomax, you don't need to change modify_item for nameless items
55 2014-07-07T13:54:06 <skathpalia> It already supports that
56 2014-07-07T13:54:35 <skathpalia> You can pass something like this url_for('frontend.modify_item', item_name=fqname)
57 2014-07-07T13:54:40 <skathpalia> It works
58 2014-07-07T13:54:55 *** sl33k_
59 2014-07-07T13:54:57 <randomax> skathpalia, ok then.. i'll do that.. thanx
60 2014-07-07T13:55:42 <ThomasWaldmann> randomax: look into itemsize view, it also needs all items [all current revisions])
61 2014-07-07T13:56:02 <randomax> ThomasWaldmann, what should i display instead of the name in case of nameless items ?? itemid ?
62 2014-07-07T13:56:42 <ThomasWaldmann> you also see there that the index might be for multiple wikis and that you need to restrict lookup to the current wiki's interwikiname
63 2014-07-07T13:58:02 <ThomasWaldmann> randomax: one of you both gsoc students already solved that iirc
64 2014-07-07T13:58:12 <skathpalia> ThomasWaldmann, Can you please have a look at problem with the blog update in modernized theme?
65 2014-07-07T13:58:33 <skathpalia> Actually there is an error of meta data invalidation in modernized theme
66 2014-07-07T13:58:54 <skathpalia> In basic theme these blog items are working completely fine
67 2014-07-07T13:59:08 <ThomasWaldmann> randomax: maybe generate a valid fqname and render that using the existing method for that
68 2014-07-07T13:59:44 *** sl33k_
69 2014-07-07T13:59:48 <skathpalia> I am not able to get the cause of the problem
70 2014-07-07T13:59:58 <ThomasWaldmann> skathpalia: is it before or after your changes?
71 2014-07-07T14:00:01 <skathpalia> ThomasWaldmann, Can you please have a look at it?
72 2014-07-07T14:00:14 <skathpalia> Its before my changes
73 2014-07-07T14:00:19 <randomax> ThomasWaldmann, ok
74 2014-07-07T14:00:20 <ThomasWaldmann> did you file a bug?
75 2014-07-07T14:00:44 <skathpalia> It has been reported by RogerHaase in #421
76 2014-07-07T14:01:17 <skathpalia> my change is very trivial https://codereview.appspot.com/105590043/
77 2014-07-07T14:01:59 <skathpalia> Just changed the used template from layout.html to show.html to add modify and other required options
78 2014-07-07T14:08:12 <skathpalia> ThomasWaldmann, I checked the meta data for both themes
79 2014-07-07T14:08:23 <skathpalia> The meta data is very similar in both themes
80 2014-07-07T14:08:55 <skathpalia> But in modernized theme it is unvalidated and in basic theme it is valid
81 2014-07-07T14:09:17 <skathpalia> *meta data of blog items
82 2014-07-07T14:09:54 *** sl33k_
83 2014-07-07T14:16:31 <skathpalia> ThomasWaldmann, also can I commit this cr https://codereview.appspot.com/105590043/
84 2014-07-07T14:17:15 *** randomax
85 2014-07-07T14:25:46 *** sl33k_
86 2014-07-07T14:27:39 <skathpalia> ThomasWaldmann, ^^
87 2014-07-07T14:29:53 *** sl33k_
88 2014-07-07T14:35:12 <ThomasWaldmann> skathpalia: well, can't say much to 105590043 by just looking at source
89 2014-07-07T14:35:32 <ThomasWaldmann> but if you tried it and found the show template to be better suited, go on
90 2014-07-07T14:35:51 <skathpalia> Ok
91 2014-07-07T14:36:11 <ThomasWaldmann> btw, if you mean "not valid" don't say "unvalidated"
92 2014-07-07T14:36:35 <skathpalia> I mean meta data is validated before revision is stored
93 2014-07-07T14:37:21 <skathpalia> here https://bitbucket.org/thomaswaldmann/moin-2.0/src/bc0f43fecbc7699157d5d981d16f527c779d7b6d/MoinMoin/storage/middleware/indexing.py?at=default#cl-1099
94 2014-07-07T14:37:58 <skathpalia> so in case of modernized theme valid = False while in basic theme valid = True
95 2014-07-07T14:39:19 <skathpalia> for same meta data
96 2014-07-07T14:41:06 *** randomax
97 2014-07-07T14:43:50 <skathpalia> ThomasWaldmann, the problem is with the element.raw being None in case of modernized theme
98 2014-07-07T14:44:09 <skathpalia> as mentioned in #421
99 2014-07-07T14:44:28 <skathpalia> But I am not able to find the cause of it
100 2014-07-07T14:44:49 <ThomasWaldmann> "element.raw"? which element?
101 2014-07-07T14:45:09 <skathpalia> flatland element
102 2014-07-07T14:46:08 <skathpalia> its mentioned here in the docs http://dag-flatland.readthedocs.org/en/latest/schema/schema/#flatland.schema.base.Element.raw
103 2014-07-07T14:47:12 <ThomasWaldmann> well, it seems to be unhappy with the acl
104 2014-07-07T14:51:31 <ThomasWaldmann> VALIDATION_HANDLING = VALIDATION_HANDLING_WARN if you do not set that to STRICT, it will just warn, but nevertheless save
105 2014-07-07T14:52:55 *** randomax
106 2014-07-07T14:53:28 *** randomax
107 2014-07-07T14:53:55 <skathpalia> ThomasWaldmann, I got it
108 2014-07-07T14:54:42 <skathpalia> Actually acl field was missing in meta data of blog being shown
109 2014-07-07T14:56:42 <skathpalia> Also names field is missing
110 2014-07-07T14:58:09 <ThomasWaldmann> well, blog items likely shall be nameless (as tickets). but have a summary instead.
111 2014-07-07T14:59:30 <skathpalia> But generally should have some name
112 2014-07-07T14:59:49 <skathpalia> As we see in case of blogspot or wordpress blogs
113 2014-07-07T14:59:56 <skathpalia> They have subdomain
114 2014-07-07T15:00:36 <ThomasWaldmann> don't confuse the site with the entries
115 2014-07-07T15:01:41 <skathpalia> If blog items don't have name then how can a user create them?
116 2014-07-07T15:02:18 <skathpalia> I mean it should also have a blog-create button similar to that of ticket-create button?
117 2014-07-07T15:07:18 <skathpalia> ThomasWaldmann, I think the blog items are supposed to have name as per the tests for these items
118 2014-07-07T15:07:55 <skathpalia> I mean the tests in test_Blog.py
119 2014-07-07T15:08:59 <ThomasWaldmann> skathpalia: in the same way as tickets ;)
120 2014-07-07T15:09:57 <ThomasWaldmann> ehrm, you are talking about the blog main item, not the blog posts, right?
121 2014-07-07T15:10:17 <skathpalia> ThomasWaldmann, yeah
122 2014-07-07T15:10:24 <ThomasWaldmann> blog main item shall have a name, but not the posts
123 2014-07-07T15:13:17 <skathpalia> ThomasWaldmann, then how can one create a blog entry?
124 2014-07-07T15:15:17 <ThomasWaldmann> the same way as a ticket
125 2014-07-07T15:16:02 <ThomasWaldmann> (and in fact, there could be a ticket main item later so we can have different ticket trackers as we can have different blogs)
126 2014-07-07T15:18:29 <skathpalia> I think for now we can have names for blog entries also and once we get some method to create items without any initial name then we can switch to that
127 2014-07-07T15:18:52 <ThomasWaldmann> yes
128 2014-07-07T15:20:01 <skathpalia> ThomasWaldmann, fixed #421
129 2014-07-07T15:20:11 <skathpalia> cr https://codereview.appspot.com/105590043
130 2014-07-07T15:33:21 <skathpalia> ThomasWaldmann, TODO is required in case of blog_entry only as blogs have name
131 2014-07-07T15:34:40 <RogerHaase> skathpalia: on #421 fix, how was basic theme working before? your fix looks like it should have failed everywhere
132 2014-07-07T15:35:30 <skathpalia> Actually I have imported show.html which contains modify link, edit meta data link by itself
133 2014-07-07T15:35:48 <skathpalia> ^This is in basic theme only
134 2014-07-07T15:36:42 <skathpalia> for modernized theme edit meta data form is explicitly defined in blog/modify_main_meta.html
135 2014-07-07T15:37:06 <skathpalia> So for this theme I added acl and names in this form
136 2014-07-07T15:40:51 <skathpalia> ThomasWaldmann, RogerHaase updated the cr https://codereview.appspot.com/105590043
137 2014-07-07T15:43:41 *** dave_largo
138 2014-07-07T15:53:33 <skathpalia> Added TODO in modify_entry_meta.html in the above cr
139 2014-07-07T15:59:56 <randomax> ThomasWaldmann, here http://moin-20.readthedocs.org/en/latest/admin/configure.html?highlight=acl#namespaces
140 2014-07-07T16:00:13 <randomax> the does the acl configuration
141 2014-07-07T16:00:28 <randomax> under NAMESPACE_USERPROFILES
142 2014-07-07T16:00:50 <randomax> refer to the default acl for a user profile ?
143 2014-07-07T16:01:42 <randomax> as in just confirming that user profiles have different default acls right ?
144 2014-07-07T16:03:33 <ThomasWaldmann> randomax: it refers to all configured acls for that namespace: default, before, after and also the mode hierarchic or not
145 2014-07-07T16:04:48 <ThomasWaldmann> as you see, you can setup all kinds of acls depending on the namespace (or even item name)
146 2014-07-07T16:07:33 *** skathpalia
147 2014-07-07T16:08:19 <randomax> ok
148 2014-07-07T16:26:27 *** skathpalia
149 2014-07-07T16:26:47 <skathpalia> sorry I got disconnected due to power problem
150 2014-07-07T16:27:08 <skathpalia> ThomasWaldmann, I have added TODO and updated the cr
151 2014-07-07T16:40:33 *** sl33k_
152 2014-07-07T17:06:35 *** sl33k_
153 2014-07-07T17:08:23 *** skathpalia
154 2014-07-07T17:12:22 *** dave_largo
155 2014-07-07T17:17:35 <randomax> ThomasWaldmann, why does NAMESPACE_USERPROFILES have a '/' at the end here
156 2014-07-07T17:17:36 <randomax> https://bitbucket.org/thomaswaldmann/moin-2.0/src/bc0f43fecbc7699157d5d981d16f527c779d7b6d/MoinMoin/storage/__init__.py?at=default#cl-95
157 2014-07-07T17:17:57 <randomax> while in the user item it is just 'userprofile'
158 2014-07-07T17:18:26 <randomax> *'userprofiles'
159 2014-07-07T17:18:33 <randomax> RogerHaase, ^
160 2014-07-07T17:18:56 <ThomasWaldmann> because the full name of userprofile items is userprofile/...
161 2014-07-07T17:19:34 <ThomasWaldmann> and you don't want to put an item named userprofile_foo into that namespace/storage
162 2014-07-07T17:21:50 <randomax> but then i'll have to check specially for namespace matching of userprofile items..
163 2014-07-07T17:22:06 <randomax> is it ok if i do that ?
164 2014-07-07T17:29:16 <ThomasWaldmann> the protecting middleware has _get_configured_acls(self, fqname) method
165 2014-07-07T17:29:38 *** magu_cic_
166 2014-07-07T17:30:33 <ThomasWaldmann> it also has some other maybe interesting stuff
167 2014-07-07T17:32:59 *** magu_cic
168 2014-07-07T17:44:48 *** greg_f
169 2014-07-07T17:47:18 <randomax> what i am trying to do is matching namespaces of each item with those stored in the acl_mapping in the wiki configuration and retrieve default acl's accordingly
170 2014-07-07T17:47:30 <randomax> so thats when the problem comes
171 2014-07-07T17:47:49 <randomax> the wiki config has stored the namespace as 'userprofiles/'
172 2014-07-07T17:48:05 <randomax> while the userprofile items store it as 'userprofiles'
173 2014-07-07T17:53:01 <RogerHaase> randomax: that 446 issue also needs fixing in modernized theme
174 2014-07-07T17:54:05 <randomax> RogerHaase, ok.. i'll do that..
175 2014-07-07T18:15:51 <randomax> ThomasWaldmann, updated cr https://codereview.appspot.com/109440043/
176 2014-07-07T18:38:17 <randomax> Also ThomasWaldmann do you want me to remove checkboxes here ? https://codereview.appspot.com/101630045/diff/80001/MoinMoin/apps/admin/templates/admin/user_acl_info.html#newcode23
177 2014-07-07T18:59:01 *** sl33k_
178 2014-07-07T19:03:36 *** sl33k_
179 2014-07-07T19:04:01 <RogerHaase> randomax: I think tw said that, remove checkboxes and input tag, replace with Read (if user can read) or "" (if user cannot read)
180 2014-07-07T19:04:28 <randomax> RogerHaase, ok will do that
181 2014-07-07T19:37:15 <randomax> RogerHaase, users will always have names right ?
182 2014-07-07T19:39:40 <RogerHaase> haha, I hope so! (let's not suggest it)
183 2014-07-07T19:40:28 <randomax> ok :)
184 2014-07-07T19:44:44 *** RogerHaase
185 2014-07-07T19:47:37 *** RogerHaase
186 2014-07-07T19:49:08 <RogerHaase> we are having first rain in ~3 months, lost power for a few seconds
187 2014-07-07T19:49:47 <randomax> Hmm.. interesting.. first rains for monsoon here too :D
188 2014-07-07T20:11:53 <randomax> RogerHaase, ThomasWaldmann updated crs
189 2014-07-07T20:11:54 <randomax> https://codereview.appspot.com/109440043/
190 2014-07-07T20:12:04 <randomax> https://codereview.appspot.com/101630045/
191 2014-07-07T20:28:15 <randomax> also answered - https://codereview.appspot.com/109410043/
192 2014-07-07T21:02:14 <randomax> ok gonna sleep now
193 2014-07-07T21:02:15 <randomax> gn
194 2014-07-07T21:02:50 *** randomax
195 2014-07-07T21:45:00 *** sl33k_
196 2014-07-07T22:21:48 *** RogerHaase
197 2014-07-07T22:53:44 *** magu_cic_
198
