MoinMoin: MoinMoinChat/Logs/moin-dev/2014-07-08

   1 2014-07-08T02:52:07  *** sl33k_ has joined #moin-dev
   2 2014-07-08T04:10:29  *** sl33k_ has quit IRC
   3 2014-07-08T04:25:27  *** sl33k_ has joined #moin-dev
   4 2014-07-08T04:38:05  *** magu_cic has joined #moin-dev
   5 2014-07-08T04:42:19  *** skathpalia has joined #moin-dev
   6 2014-07-08T04:42:28  <skathpalia> moin
   7 2014-07-08T04:43:03  <skathpalia> ThomasWaldmann, I have added explanation of my cr https://codereview.appspot.com/105590043/ in my EP(line 85)
   8 2014-07-08T04:55:33  *** sl33k_ has quit IRC
   9 2014-07-08T06:50:18  <skathpalia> dimazest, ^^
  10 2014-07-08T06:52:07  <dimazest> hmmmm
  11 2014-07-08T06:52:15  <dimazest> hard to say
  12 2014-07-08T06:55:57  <skathpalia> hmm
  13 2014-07-08T07:08:56  <dimazest> i dont really know what it's about
  14 2014-07-08T07:09:16  <dimazest> wait for tw, i guess
  15 2014-07-08T07:29:42  <skathpalia> Ok I will wait for his reply
  16 2014-07-08T07:40:54  *** Bernard1 has joined #moin-dev
  17 2014-07-08T07:47:43  *** sl33k_ has joined #moin-dev
  18 2014-07-08T07:51:58  *** sl33k_ has quit IRC
  19 2014-07-08T07:53:34  *** randomax has joined #moin-dev
  20 2014-07-08T08:06:56  *** sl33k_ has joined #moin-dev
  21 2014-07-08T08:11:22  *** sl33k_ has quit IRC
  22 2014-07-08T08:31:02  <randomax> ThomasWaldmann, crs needed
  23 2014-07-08T08:31:09  <randomax> https://codereview.appspot.com/109440043/
  24 2014-07-08T08:31:16  <randomax> https://codereview.appspot.com/101630045/
  25 2014-07-08T08:31:22  <randomax> https://codereview.appspot.com/109410043/
  26 2014-07-08T08:37:29  *** sl33k_ has joined #moin-dev
  27 2014-07-08T08:41:33  *** sl33k_ has quit IRC
  28 2014-07-08T08:57:02  *** sl33k_ has joined #moin-dev
  29 2014-07-08T09:31:45  *** greg_f has joined #moin-dev
  30 2014-07-08T09:43:03  *** sl33k_ has quit IRC
  31 2014-07-08T09:51:11  *** penguinRaider has quit IRC
  32 2014-07-08T09:51:47  *** penguinRaider has joined #moin-dev
  33 2014-07-08T10:29:20  *** sl33k_ has joined #moin-dev
  34 2014-07-08T10:30:37  *** randomax has quit IRC
  35 2014-07-08T10:32:08  *** randomax has joined #moin-dev
  36 2014-07-08T10:42:36  *** randomax has quit IRC
  37 2014-07-08T10:48:09  <skathpalia> ThomasWaldmann, fixed #433 cr: https://codereview.appspot.com/112780043
  38 2014-07-08T10:54:16  *** skathpalia has quit IRC
  39 2014-07-08T11:09:52  *** skathpalia has joined #moin-dev
  40 2014-07-08T11:25:40  *** skathpalia has quit IRC
  41 2014-07-08T11:25:52  *** Bernard1 has quit IRC
  42 2014-07-08T11:35:03  *** randomax has joined #moin-dev
  43 2014-07-08T12:01:11  *** sl33k_ has quit IRC
  44 2014-07-08T12:07:17  *** sl33k_ has joined #moin-dev
  45 2014-07-08T12:12:40  *** skathpalia has joined #moin-dev
  46 2014-07-08T12:38:53  <randomax> ThomasWaldmann, would there be nameless wiki groups ?
  47 2014-07-08T12:51:27  *** sl33k_ has quit IRC
  48 2014-07-08T12:57:00  *** sl33k_ has joined #moin-dev
  49 2014-07-08T13:00:53  *** Bernard1 has joined #moin-dev
  50 2014-07-08T13:15:04  *** RogerHaase has joined #moin-dev
  51 2014-07-08T13:15:25  *** dave_largo has joined #moin-dev
  52 2014-07-08T13:17:08  <skathpalia> RogerHaase, fixed #433 cr: https://codereview.appspot.com/112780043
  53 2014-07-08T13:23:30  <RogerHaase> skathpalia: looks ok to me, but I haven't touched much code that uses fqname
  54 2014-07-08T13:24:23  <skathpalia> RogerHaase, I also added some explanation regarding my cr https://codereview.appspot.com/105590043/ on my EP
  55 2014-07-08T13:26:30  <RogerHaase> skathpalia: but it would be helpful to edit your cr title to add a bit of the issue title or similar "User Actions and Item Actions bar missing if there is no name of item in basic theme" - try to make your cr title your eventual commit title
  56 2014-07-08T13:28:12  <skathpalia> Ok :)
  57 2014-07-08T13:30:04  <skathpalia> RogerHaase, I have explained my cr for fix to #421 (Update blog items not working) which we were discussing yesterday on my EP
  58 2014-07-08T13:30:23  <skathpalia> line 85 http://etherpad.osuosl.org/moin-ticket-blog
  59 2014-07-08T13:45:57  <randomax> RogerHaase, added view for groups https://codereview.appspot.com/104590043/
  60 2014-07-08T13:46:03  <skathpalia> RogerHaase, ^^?
  61 2014-07-08T14:07:33  <RogerHaase> skathpalia: I saw on chat log
  62 2014-07-08T14:08:57  <skathpalia> RogerHaase, Can I commit it?
  63 2014-07-08T14:10:45  <RogerHaase> skathpalia: no, wait for tw
  64 2014-07-08T14:11:09  <skathpalia> Ok :)
  65 2014-07-08T14:17:11  *** sl33k_ has quit IRC
  66 2014-07-08T14:25:36  *** sl33k_ has joined #moin-dev
  67 2014-07-08T14:27:13  <RogerHaase> randomax: what is purpose of Group ACL Report column?
  68 2014-07-08T14:31:48  *** sl33k_ has quit IRC
  69 2014-07-08T14:38:03  *** skathpalia has quit IRC
  70 2014-07-08T14:49:29  <RogerHaase> randomax: on https://codereview.appspot.com/109410043/, you should add that explanation (or a more concise one) as a comment in the source code
  71 2014-07-08T14:49:30  *** skathpalia has joined #moin-dev
  72 2014-07-08T14:51:51  *** skathpalia has quit IRC
  73 2014-07-08T14:58:16  *** sl33k_ has joined #moin-dev
  74 2014-07-08T15:02:33  *** sl33k_ has quit IRC
  75 2014-07-08T15:03:48  <randomax> RogerHaase, sorry had gone for dinner
  76 2014-07-08T15:04:09  <randomax> the purpose of ACL report column is to give links to the group acl report view
  77 2014-07-08T15:04:23  <randomax> currently i am working on that in a separate patch
  78 2014-07-08T15:04:45  <randomax> will add hyperlinks once i setup the group acl report views
  79 2014-07-08T15:12:45  <RogerHaase> randomax: ok
  80 2014-07-08T15:33:51  *** skathpalia has joined #moin-dev
  81 2014-07-08T15:40:53  <skathpalia> RogerHaase, I observed one bug  regarding the quicklinks in basic theme
  82 2014-07-08T15:41:33  <skathpalia> quicklink to  nameless items items cannot be removed in basic theme
  83 2014-07-08T15:42:28  <skathpalia> the link it generates for removing quicklink is not correct
  84 2014-07-08T15:43:43  <RogerHaase> skathpalia: please add to issue tracker
  85 2014-07-08T15:44:34  <skathpalia> Ok will add it :)
  86 2014-07-08T16:14:13  *** Bernard1 has quit IRC
  87 2014-07-08T16:37:22  *** jhermann has joined #moin-dev
  88 2014-07-08T16:43:57  *** skathpalia has quit IRC
  89 2014-07-08T16:56:57  *** RogerHaase has left #moin-dev
  90 2014-07-08T17:14:48  *** sl33k_ has joined #moin-dev
  91 2014-07-08T17:41:25  *** skathpalia has joined #moin-dev
  92 2014-07-08T17:56:39  *** skathpalia has quit IRC
  93 2014-07-08T17:56:52  *** skathpalia has joined #moin-dev
  94 2014-07-08T17:59:50  *** skathpalia has joined #moin-dev
  95 2014-07-08T18:21:26  *** skathpalia has quit IRC
  96 2014-07-08T18:48:18  *** penguinRaider has quit IRC
  97 2014-07-08T18:48:20  *** randomax has quit IRC
  98 2014-07-08T18:49:58  *** penguinRaider has joined #moin-dev
  99 2014-07-08T18:54:58  *** randomax has joined #moin-dev
 100 2014-07-08T19:03:18  *** greg_f has quit IRC
 101 2014-07-08T19:03:41  *** sl33k_ has quit IRC
 102 2014-07-08T19:55:32  <randomax> Added group acl report https://codereview.appspot.com/112830043
 103 2014-07-08T19:56:57  <randomax> apply patch first for groupwise acl view https://codereview.appspot.com/104590043/
 104 2014-07-08T19:58:33  <randomax> then add you'll have to manually add href for linking to group acl report view like this
 105 2014-07-08T19:58:36  <randomax> <a href="{{ url_for('admin.group_acl_report', group_name=group['name'], group_type=group['grouptype']) }}">
 106 2014-07-08T20:01:02  *** randomax has quit IRC
 107 2014-07-08T20:16:45  *** penguinRaider has quit IRC
 108 2014-07-08T21:21:20  *** dave_largo has quit IRC
 109 2014-07-08T23:51:14  *** penguinRaider has joined #moin-dev
 110