MoinMoin: MoinMoinChat/Logs/moin-dev/2014-07-17

   1 2014-07-17T04:05:38  *** penguinRaider has quit IRC
   2 2014-07-17T04:07:00  *** penguinRaider has joined #moin-dev
   3 2014-07-17T06:34:07  *** mapreri has quit IRC
   4 2014-07-17T06:34:46  *** mapreri has joined #moin-dev
   5 2014-07-17T07:17:48  *** penguinRaider has quit IRC
   6 2014-07-17T07:21:36  *** randomax has quit IRC
   7 2014-07-17T07:35:45  *** penguinRaider has joined #moin-dev
   8 2014-07-17T08:12:50  *** penguinRaider has quit IRC
   9 2014-07-17T08:27:50  *** sl33k_ has joined #moin-dev
  10 2014-07-17T08:46:03  *** sl33k_ has quit IRC
  11 2014-07-17T08:50:53  *** sl33k_ has joined #moin-dev
  12 2014-07-17T08:57:03  *** sl33k_ has quit IRC
  13 2014-07-17T09:28:46  *** greg_f has joined #moin-dev
  14 2014-07-17T10:55:41  *** penguinRaider has joined #moin-dev
  15 2014-07-17T11:10:41  *** sl33k_ has joined #moin-dev
  16 2014-07-17T12:02:01  *** randomax has joined #moin-dev
  17 2014-07-17T12:25:38  *** sl33k_ has quit IRC
  18 2014-07-17T12:28:59  *** sl33k_ has joined #moin-dev
  19 2014-07-17T12:44:50  *** skathpalia has joined #moin-dev
  20 2014-07-17T12:45:56  <skathpalia> dimazest, Made summary necessary field in case of blog entries so that summary is shown instead of name in blog view
  21 2014-07-17T12:45:58  <skathpalia> https://codereview.appspot.com/114020043/
  22 2014-07-17T13:07:00  <dimazest> looks good
  23 2014-07-17T13:07:20  <dimazest> but ask ThomasWaldmann whether  it's a desired behavior
  24 2014-07-17T13:22:55  *** sl33k_ has quit IRC
  25 2014-07-17T13:32:39  <skathpalia> Ok will ask him
  26 2014-07-17T13:55:04  *** skathpalia has quit IRC
  27 2014-07-17T13:55:20  *** skathpalia has joined #moin-dev
  28 2014-07-17T14:06:03  *** RogerHaase has joined #moin-dev
  29 2014-07-17T14:12:24  *** skathpalia has quit IRC
  30 2014-07-17T14:21:02  <ThomasWaldmann>  moin
  31 2014-07-17T14:48:18  *** skathpalia has joined #moin-dev
  32 2014-07-17T14:48:58  <skathpalia> ThomasWaldmann, added TODO for adding fqname support to has_item https://codereview.appspot.com/112780043/
  33 2014-07-17T14:57:13  <ThomasWaldmann> skathpalia: ok, fine
  34 2014-07-17T14:57:31  <skathpalia> Ok I will commit it to my repo :)
  35 2014-07-17T14:58:19  <skathpalia> ThomasWaldmann, also made summary necessary field in blog entries so that only summary is being shown as blog_entry title
  36 2014-07-17T14:58:21  <skathpalia> https://codereview.appspot.com/114020043/
  37 2014-07-17T15:02:39  *** greg_f has quit IRC
  38 2014-07-17T15:07:41  *** greg_f has joined #moin-dev
  39 2014-07-17T15:33:19  <ThomasWaldmann> skathpalia: ah, good
  40 2014-07-17T15:33:30  * ThomasWaldmann looks at 2nd cr
  41 2014-07-17T15:34:35  <ThomasWaldmann> guess the same needs to be done for tickets
  42 2014-07-17T15:34:53  <skathpalia> Its already done for tickets
  43 2014-07-17T15:35:01  <ThomasWaldmann> :)
  44 2014-07-17T15:35:10  <skathpalia> summary is necessary field in case of tickets also
  45 2014-07-17T15:35:17  <skathpalia> ThomasWaldmann, Can I commit it?
  46 2014-07-17T15:36:09  <ThomasWaldmann> ok
  47 2014-07-17T16:02:10  <randomax> ThomasWaldmann, review needed
  48 2014-07-17T16:02:17  <randomax> https://codereview.appspot.com/110210043/
  49 2014-07-17T16:02:28  <randomax> https://codereview.appspot.com/109410043/
  50 2014-07-17T16:02:35  <randomax> https://codereview.appspot.com/101630045/
  51 2014-07-17T16:02:40  <randomax> https://codereview.appspot.com/109440043/
  52 2014-07-17T16:02:45  <randomax> https://codereview.appspot.com/104590043/
  53 2014-07-17T16:02:51  <randomax> https://codereview.appspot.com/112830043/
  54 2014-07-17T16:03:07  <randomax> https://codereview.appspot.com/113780043/
  55 2014-07-17T16:04:25  <ThomasWaldmann> randomax: {{ item }}|safe how does that work?
  56 2014-07-17T16:08:15  <randomax> ThomasWaldmann, i didnt get you ?
  57 2014-07-17T16:10:00  <ThomasWaldmann> well, if you try to explain how that works, you'll maybe find it does not
  58 2014-07-17T16:10:38  <ThomasWaldmann> (see cr)
  59 2014-07-17T16:10:51  <ThomasWaldmann> https://codereview.appspot.com/110210043/
  60 2014-07-17T16:12:29  <randomax> ohh yeah got it..
  61 2014-07-17T16:20:01  <ThomasWaldmann> https://codereview.appspot.com/101630045/diff2/160001:220001/MoinMoin/apps/admin/templates/admin/user_acl_report.html ?
  62 2014-07-17T16:20:45  <ThomasWaldmann> doesn't look like a "minor correction" or "changes as per comments"
  63 2014-07-17T16:21:21  <randomax> i just changed the name of the file
  64 2014-07-17T16:21:30  <ThomasWaldmann> jah
  65 2014-07-17T16:21:34  <ThomasWaldmann> -j
  66 2014-07-17T16:21:43  <randomax> to make it consistent with the other new acl report views
  67 2014-07-17T16:25:55  <randomax> ThomasWaldmann, updated - https://codereview.appspot.com/110210043/
  68 2014-07-17T16:33:28  <ThomasWaldmann> ok, now links work. in fact any html in externallinks could be used to xss there. maybe open a ticket that data going into externallinks needs to be checked for safety because of that line
  69 2014-07-17T16:40:16  <ThomasWaldmann> the last 3 CRs i need to do later, gtg now
  70 2014-07-17T16:41:32  <ThomasWaldmann> randomax: ^
  71 2014-07-17T16:41:43  <randomax> ThomasWaldmann, ok
  72 2014-07-17T17:08:10  *** skathpalia has quit IRC
  73 2014-07-17T17:49:29  *** penguinRaider has quit IRC
  74 2014-07-17T18:46:19  *** greg_f has quit IRC
  75 2014-07-17T19:18:16  *** RogerHaase has left #moin-dev
  76 2014-07-17T20:11:22  *** randomax has quit IRC
  77 2014-07-17T21:13:51  *** magu_cic has joined #moin-dev
  78 2014-07-17T22:46:50  *** penguinRaider has joined #moin-dev
  79 2014-07-17T22:52:37  *** sharky93 has quit IRC
  80 2014-07-17T22:52:41  *** eSyr has quit IRC
  81 2014-07-17T22:53:10  *** sharky93 has joined #moin-dev
  82 2014-07-17T22:53:10  *** eSyr has joined #moin-dev
  83 2014-07-17T22:54:01  *** ananasova has quit IRC
  84 2014-07-17T22:54:30  *** ananasova has joined #moin-dev
  85 2014-07-17T22:54:39  *** mapreri has quit IRC
  86 2014-07-17T22:54:42  *** xjjk has quit IRC
  87 2014-07-17T22:54:42  *** jhermann has quit IRC
  88 2014-07-17T22:54:47  *** ThomasWaldmann has quit IRC
  89 2014-07-17T22:55:06  *** waldi has quit IRC
  90 2014-07-17T22:55:06  *** dreimark has quit IRC
  91 2014-07-17T22:55:15  *** mapreri has joined #moin-dev
  92 2014-07-17T22:55:15  *** xjjk has joined #moin-dev
  93 2014-07-17T22:55:15  *** jhermann has joined #moin-dev
  94 2014-07-17T22:55:15  *** ThomasWaldmann has joined #moin-dev
  95 2014-07-17T22:56:24  *** waldi has joined #moin-dev
  96 2014-07-17T22:56:24  *** dreimark has joined #moin-dev
  97 2014-07-17T23:13:58  *** penguinRaider has quit IRC
  98 2014-07-17T23:39:11  *** eSyr has quit IRC
  99 2014-07-17T23:39:18  *** eSyr has joined #moin-dev
 100