1 2014-07-24T08:46:02  <ThomasWaldmann> moin
   2 2014-07-24T08:46:11  <ThomasWaldmann> greetings from europython!
   3 2014-07-24T08:47:47  <ThomasWaldmann> dreimark: ananasova: sunu: TheSheep: dimazest: <- all here and 1200 more pythonistas \o/
   4 2014-07-24T09:13:52  *** greg_f has joined #moin-dev
   5 2014-07-24T10:52:17  *** skathpalia has joined #moin-dev
   6 2014-07-24T10:54:11  <skathpalia> ThomasWaldmann, updated cr https://codereview.appspot.com/113830043/
   7 2014-07-24T10:54:31  <skathpalia> dimazest, Can I commit this https://codereview.appspot.com/119090043/ ?
   8 2014-07-24T10:55:08  <dimazest> yes
   9 2014-07-24T10:55:23  <skathpalia> Ok
  10 2014-07-24T10:55:58  <skathpalia> Now working on removing HTML validation errors from ticket view template
  11 2014-07-24T10:56:14  <dimazest> ok, great
  12 2014-07-24T10:56:31  <dimazest> btw, i'll be offline till august 10th
  13 2014-07-24T10:57:43  <skathpalia> Ok
  14 2014-07-24T11:20:13  *** sl33k_ has joined #moin-dev
  15 2014-07-24T11:30:19  *** sl33k_ has quit IRC
  16 2014-07-24T13:01:18  *** skathpalia has quit IRC
  17 2014-07-24T13:12:55  *** fdsfadf has joined #moin-dev
  18 2014-07-24T13:13:12  <fdsfadf> hi,everyone
  19 2014-07-24T13:13:59  <fdsfadf> UnicodeDecodeError
  20 2014-07-24T13:14:00  <fdsfadf> UnicodeDecodeError: 'utf8' codec can't decode byte 0xbc in position 2: invalid start byte
  21 2014-07-24T13:17:06  *** dave_largo has joined #moin-dev
  22 2014-07-24T13:55:45  *** RogerHaase has joined #moin-dev
  23 2014-07-24T14:03:06  *** sl33k_ has joined #moin-dev
  24 2014-07-24T14:07:57  *** skathpalia has joined #moin-dev
  25 2014-07-24T14:10:03  <skathpalia> RogerHaase, sorry I went to sleep bit early yesterday as was not feeling well
  26 2014-07-24T14:10:50  <RogerHaase> skathpalia: np
  27 2014-07-24T14:11:13  <skathpalia> I think I mis-interpreted #453
  28 2014-07-24T14:14:34  <skathpalia> Also regarding HTML validation error I need to change label tag's "for" generated but I am searching for away to do so
  29 2014-07-24T14:19:22  *** sl33k_ has quit IRC
  30 2014-07-24T14:23:10  *** sl33k_ has joined #moin-dev
  31 2014-07-24T14:31:04  <RogerHaase> skathpalia: in several cases, I do not think you want a label:  <dt><label for="f_meta_effort">Effort</label> </dt>  should just be <dt>Effort</dt>
  32 2014-07-24T14:32:01  <RogerHaase> afaik, there is no point in having a <label> except for checkboxes and radio buttons.
  33 2014-07-24T14:49:17  <RogerHaase> skathpalia: hmm, on those <select> tags, would clicking on the label do anything (like show the dropdown if the for had the right ID?) <dt><label for="f_meta_assigned_to">Assigned To</label></dt>
  34 2014-07-24T14:53:26  <skathpalia> No clicking on label for select tags doesn't do anything
  35 2014-07-24T14:53:34  <skathpalia> even if it has right id
  36 2014-07-24T14:55:42  <skathpalia> RogerHaase, I am not able to find out from where the value of for is set, I tried changing in this https://bitbucket.org/thomaswaldmann/moin-2.0/src/c040fb080073d26d050486d3e24d903aa62a2112/MoinMoin/templates/forms.html?at=default#cl-107 but still the change is not reflected in the view
  37 2014-07-24T15:06:38  <skathpalia> RogerHaase, also found some html validation errors in +tickets view, would try to solve those also :)
  38 2014-07-24T15:11:37  *** randomax has joined #moin-dev
  39 2014-07-24T15:21:16  *** sl33k_ has quit IRC
  40 2014-07-24T15:34:21  *** fdsfadf has quit IRC
  41 2014-07-24T15:35:23  <skathpalia> RogerHaase, removed HTML validation errors from +tickets view https://codereview.appspot.com/118280043
  42 2014-07-24T15:48:10  *** skathpalia_ has joined #moin-dev
  43 2014-07-24T15:50:44  *** skathpalia has quit IRC
  44 2014-07-24T15:52:45  *** skathpalia_ is now known as skathpalia
  45 2014-07-24T16:43:12  <randomax> RogerHaase, i was wondering about how to go about the new improving design and colors in the theme
  46 2014-07-24T16:43:34  <randomax> should i  draw up some basic samples and show them to you
  47 2014-07-24T16:43:56  <randomax> or should i show you color schemes and then decide
  48 2014-07-24T16:44:01  <randomax> or sthng else ?
  49 2014-07-24T16:53:12  <RogerHaase> skathpalia: done with cr
  50 2014-07-24T16:55:13  <RogerHaase> randomax: rereading your proposal...
  51 2014-07-24T16:58:24  *** sl33k_ has joined #moin-dev
  52 2014-07-24T17:04:14  <skathpalia> RogerHaase, Updated the cr https://codereview.appspot.com/118280043
  53 2014-07-24T17:04:26  <skathpalia> Removed br tag and added css
  54 2014-07-24T17:04:55  <RogerHaase> randomax: what are the biggest warts on current themes?
  55 2014-07-24T17:05:26  <randomax> the basic theme looks quite good as of now
  56 2014-07-24T17:05:35  <randomax> the foobar theme looks a bit dull
  57 2014-07-24T17:06:20  <randomax> maybe we can change its looks a bit
  58 2014-07-24T17:06:42  <randomax> while staying within the black and white theme color range
  59 2014-07-24T17:07:30  <randomax> also it requires a bit of polishing
  60 2014-07-24T17:08:50  <randomax> similar with the modernized theme i guess
  61 2014-07-24T17:09:56  <RogerHaase> skathpalia: basic view is OK, modernized needs work
  62 2014-07-24T17:11:29  <RogerHaase> randomax: on basic theme, I think biggest wart is that sidebar and "topbar" needs background shading so it does not compete with content
  63 2014-07-24T17:11:53  <RogerHaase> skathpalia: do you have an opinion on theme warts ^^
  64 2014-07-24T17:12:29  <RogerHaase> randomax: on modernized theme, biggest wart is the subitems sidebar
  65 2014-07-24T17:13:23  <randomax> also the topbar there too
  66 2014-07-24T17:13:38  <randomax> it extends into 2 lines
  67 2014-07-24T17:13:46  <randomax> and is duplicated at the bottom
  68 2014-07-24T17:16:39  <skathpalia> RogerHaase, According to me wart for modernized is subitems sidebar, fooobar meta-data section and trail
  69 2014-07-24T17:16:59  <RogerHaase> randomax: tw is thinking about killing the foobar theme (depends upon success of basic).  Right sidebars have some issues, like how to handle wide tables.  so maybe fix colors, but I would not spend much effort on foobar.
  70 2014-07-24T17:17:23  <randomax> ok.. then
  71 2014-07-24T17:17:38  <randomax> i'll try to come up with changes in basic and modernized then
  72 2014-07-24T17:18:24  <RogerHaase> randomax: let's try some ideas on ep
  73 2014-07-24T17:19:07  <skathpalia> RogerHaase, the 2 validation errors in modernized theme is not specific to +tickets view
  74 2014-07-24T17:19:20  <skathpalia> They are generic to modernized theme
  75 2014-07-24T17:19:23  <randomax> ok
  76 2014-07-24T17:19:56  <RogerHaase> skathpalia: I think randomax has fixed those in one of his CRs
  77 2014-07-24T17:21:15  <skathpalia> Ohh
  78 2014-07-24T17:22:10  <skathpalia> Then I think now +tickets view is valid as per my cr https://codereview.appspot.com/118280043
  79 2014-07-24T17:22:22  <skathpalia> Can I commit this?
  80 2014-07-24T17:24:17  <skathpalia> RogerHaase, ^^
  81 2014-07-24T17:26:56  <RogerHaase> skathpalia: on modernized, I meant the underline for the Tags heading  is overlaid by the table header, but if fixing tags is going to be a later fix, then OK
  82 2014-07-24T17:27:32  <skathpalia> Yeah I noticed that will surely fix in a later patch
  83 2014-07-24T17:28:01  <skathpalia> Also fix the same with foobar theme
  84 2014-07-24T17:28:26  <RogerHaase> ok
  85 2014-07-24T17:38:48  <skathpalia> RogerHaase, removed the overlapping border in the same cr https://codereview.appspot.com/118280043
  86 2014-07-24T17:40:23  <RogerHaase> skathpalia: looks ok
  87 2014-07-24T17:40:36  <skathpalia> Ok I will commit it :)
  88 2014-07-24T18:03:57  <RogerHaase> must break for ~30 min
  89 2014-07-24T18:10:00  *** skathpalia has quit IRC
  90 2014-07-24T18:20:02  *** greg_f has quit IRC
  91 2014-07-24T18:39:35  <RogerHaase> randomax: javascript removal was   Changeset:  2072 (d366d1af5e1e) fixes : Transcluding and Linking subitems bug, changed transcluding and linking buttons to only insert one Insername  https://paste.thinkmo.de/a2b7fc15-1dca-4c5a-a9f5-fe01761b076a
  92 2014-07-24T18:40:08  <RogerHaase> and I lied, it did not copy to clipboard, it pasted directly into content area
  93 2014-07-24T18:51:02  <randomax> np.. i was thinking that the toggle option would be better
  94 2014-07-24T18:51:35  <RogerHaase> I saw, still thinking about index pages...
  95 2014-07-24T18:56:50  <RogerHaase> randomax: one issue with subitems working like comments is whether there has to be another link to go the the Subitems Index page
  96 2014-07-24T18:59:27  <RogerHaase> But I think it is clear that we should kill the modernized subitems sidebar.  Whatever we end up with should work similar in all themes
  97 2014-07-24T18:59:45  <randomax> Hmm..
  98 2014-07-24T19:38:51  <RogerHaase> randomax: got this from ashu1461 repo - I positioned caret in textarea below xxxx, clicked the chain link icon and it inserted ",name_exact,Home/sub" in textarea https://paste.thinkmo.de/478495b6-779f-4737-bc88-10a01d86cfc4
  99 2014-07-24T19:44:27  *** sl33k_ has quit IRC
 100 2014-07-24T19:46:35  <randomax> i think i saw that link somewhere in the foobar theme too some time back
 101 2014-07-24T19:48:30  <randomax> i dont exactly remember where and how
 102 2014-07-24T19:48:36  <randomax> but i did see it
 103 2014-07-24T19:59:02  *** magu_cic has quit IRC
 104 2014-07-24T20:03:30  <randomax> RogerHaase, added answers for week 12 plan
 105 2014-07-24T21:18:42  *** dave_largo has quit IRC
 106 2014-07-24T22:15:52  *** randomax has quit IRC
 107 2014-07-24T22:19:03  *** RogerHaase has quit IRC
 108

MoinMoin: MoinMoinChat/Logs/moin-dev/2014-07-24 (last edited 2014-07-24 09:00:03 by IrcLogImporter)