1 2014-08-07T04:28:52 *** moinBot`
2 2014-08-07T04:28:52 -cameron.freenode.net- [freenode-info] help freenode weed out clonebots -- please register your IRC nick and auto-identify: http://freenode.net/faq.shtml#nicksetup
3 2014-08-07T04:30:53 *** dreimark_
4 2014-08-07T04:35:36 *** dreimark
5 2014-08-07T04:35:36 *** moinBot
6 2014-08-07T04:35:36 *** vpv
7 2014-08-07T04:36:33 *** vpv
8 2014-08-07T06:32:52 *** penguinRaider
9 2014-08-07T08:55:02 *** penguinRaider
10 2014-08-07T09:20:34 *** greg_f
11 2014-08-07T10:03:23 *** penguinRaider
12 2014-08-07T10:32:56 *** greg_f
13 2014-08-07T10:34:21 *** greg_f
14 2014-08-07T13:13:03 *** randomax
15 2014-08-07T13:21:39 *** skathpalia
16 2014-08-07T13:25:18 *** dave_largo
17 2014-08-07T13:50:00 <ThomasWaldmann> randomax: you are working on getting your stuff committed?
18 2014-08-07T13:51:06 <randomax> yes.. the rename of css files caused me to adjust some changes.. i'll commit them in a few minutes..
19 2014-08-07T14:02:15 <skathpalia> ThomasWaldmann, this https://bitbucket.org/thomaswaldmann/moin-2.0/issue/321/ticket-list-missing can be marked as resolved
20 2014-08-07T14:09:03 <ThomasWaldmann> skathpalia: do you have a specific changeset id that fixed it?
21 2014-08-07T14:10:04 <skathpalia> https://bitbucket.org/thomaswaldmann/moin-2.0/commits/8f93193cfd9bd7573885eb11ca821263347c7179
22 2014-08-07T14:29:34 * ThomasWaldmann closed it, thanks
23 2014-08-07T14:35:26 *** skathpalia
24 2014-08-07T14:35:42 *** skathpalia
25 2014-08-07T14:38:23 * ThomasWaldmann pulled / merged the PRs
26 2014-08-07T14:38:35 <ThomasWaldmann> skathpalia: randomax: please pull from main repo
27 2014-08-07T14:39:10 <randomax> ok
28 2014-08-07T14:39:29 <skathpalia> done :)
29 2014-08-07T14:44:02 <ThomasWaldmann> btw, did you see anything unusual related to the tests?
30 2014-08-07T14:48:15 <skathpalia> no ...
31 2014-08-07T14:48:49 <skathpalia> Just the name of the test files should be renamed so that they have small alphabets
32 2014-08-07T14:49:10 <skathpalia> Like test_Content.py should be renamed to test_content.py
33 2014-08-07T14:50:42 <ThomasWaldmann> randomax: hmm, global history still looks crappy. did you just fix it for 1 theme only?
34 2014-08-07T14:51:22 *** penguinRaider
35 2014-08-07T14:57:22 <ThomasWaldmann> skathpalia: create ticket button and "find tickets" field are not aligned
36 2014-08-07T14:58:27 <ThomasWaldmann> also, the login link in the tickets view is somehow strangely in the middle of the top bar
37 2014-08-07T14:59:46 <skathpalia> Ok will try to fix this in next patch :)
38 2014-08-07T15:00:38 <ThomasWaldmann> maybe just do a click-through, such stuff is rather easy to see
39 2014-08-07T15:02:38 <ThomasWaldmann> it still shows the ticket name and not the summary as "title"
40 2014-08-07T15:04:03 <skathpalia> In this https://codereview.appspot.com/114210043/ I have removed the name and now I am adding summary :)
41 2014-08-07T15:08:24 <ThomasWaldmann> that "n tickets found" message - is it useful?
42 2014-08-07T15:09:02 <ThomasWaldmann> you render all tickets anyway, so the user sees them
43 2014-08-07T15:09:35 <skathpalia> I think it would be useful as user can see a total number of tickets with that status(closed, open or all)
44 2014-08-07T15:09:39 <ThomasWaldmann> if it finds 0 tickets, the "No ticket found" msg could be in the same place as the ticket table usually is.
45 2014-08-07T15:11:35 <randomax> ThomasWaldmann, no i still working on committing that
46 2014-08-07T15:11:42 <randomax> *i am
47 2014-08-07T15:11:55 <ThomasWaldmann> ah
48 2014-08-07T15:12:18 <skathpalia> ThomasWaldmann, updated the cr https://codereview.appspot.com/114210043/
49 2014-08-07T15:12:30 <skathpalia> Used summary instead of name in heading
50 2014-08-07T15:15:10 <ThomasWaldmann> the spacing of ^v and E,D,S,P can also be improved
51 2014-08-07T15:16:13 <ThomasWaldmann> the sort up/down control needs to have less distance to the column label for which it applies than that column label has to the sort control of the next column
52 2014-08-07T15:16:37 <ThomasWaldmann> like 1/3 to 2/3 or so
53 2014-08-07T15:16:56 <ThomasWaldmann> not 1/2 to 1/2
54 2014-08-07T15:18:01 <skathpalia> I was thinking of making these small UI changes including those in +tickets view in a separate patch
55 2014-08-07T15:18:13 <ThomasWaldmann> also, add more space between "closed" filter button and the Sort dropdown (same spacing as between Open and Closed)
56 2014-08-07T15:18:26 <ThomasWaldmann> sure
57 2014-08-07T15:18:52 *** penguinRaider
58 2014-08-07T15:23:13 <ThomasWaldmann> randomax: on modernized, the user menu views look quite better than on basic theme
59 2014-08-07T15:24:34 <ThomasWaldmann> skathpalia: on modernized, ticket view button at the bottom are broken: strangely aligned and (german) text does not fit into button
60 2014-08-07T15:25:19 <randomax> ThomasWaldmann, Ok.. I'll try to improve the basic theme view
61 2014-08-07T15:28:19 <skathpalia> Ok will try to remove these errors in modernized theme
62 2014-08-07T15:31:13 *** penguinRaider
63 2014-08-07T15:36:57 <randomax> ThomasWaldmann, made some changes to the global history view
64 2014-08-07T15:36:58 <randomax> http://picpaste.com/pics/history-cqb9bQyD.1407425797.png
65 2014-08-07T15:37:53 <ThomasWaldmann> better :)
66 2014-08-07T15:38:16 <randomax> shall i commit ?
67 2014-08-07T15:38:25 <ThomasWaldmann> yes
68 2014-08-07T15:38:57 <randomax> ok
69 2014-08-07T15:43:34 <skathpalia> ThomasWaldmann, added a comment in https://codereview.appspot.com/115700043/
70 2014-08-07T15:51:58 <ThomasWaldmann> well, you didn't really answer the question
71 2014-08-07T15:53:46 <skathpalia> ThomasWaldmann, may be I didn't get your question... Can you please explain it ?
72 2014-08-07T15:53:57 <ThomasWaldmann> if fqname is @itemid/123456789... and you feed that into location breadcrumbs processing, what will be the output, what parts will be clickable?
73 2014-08-07T15:54:52 <ThomasWaldmann> if it behaves as for names, if would be [@itemid] / [123456789....] - [] meaning clickable
74 2014-08-07T15:55:00 <ThomasWaldmann> and that doesn't make sense
75 2014-08-07T15:56:08 <ThomasWaldmann> or said differently: processing something that is not a (hierarchical) name as it were one does not make sense
76 2014-08-07T15:56:08 <skathpalia> Currently just '~' is shown for nameless items
77 2014-08-07T15:56:56 <skathpalia> And if I simply display fqname then @itemid/123456789.... is shown so I displayed shortened fqname
78 2014-08-07T15:57:02 <ThomasWaldmann> nothing against showing something, but do not process it inadequatly
79 2014-08-07T15:59:14 <skathpalia> The processing is fine
80 2014-08-07T16:00:32 <skathpalia> Like even if fqname like this @itemid/a6ef8a556a424441a20a87e5fd5d8fdd is shown then also it acts as a link to single item (doesn't break it into 2 items )
81 2014-08-07T16:01:24 <skathpalia> I mean the whole fqname is clickable as one link
82 2014-08-07T16:05:26 *** penguinRaider
83 2014-08-07T16:10:55 <skathpalia> so I think processing is done correctly
84 2014-08-07T16:11:13 <skathpalia> ThomasWaldmann ^^
85 2014-08-07T16:12:31 <ThomasWaldmann> hmm, thought it simply splits on "/"...
86 2014-08-07T16:13:47 <skathpalia> So Can I commit this https://codereview.appspot.com/115700043/ ?
87 2014-08-07T16:14:40 <ThomasWaldmann> ah, the code has some special treatment if it is not a name
88 2014-08-07T16:14:45 <ThomasWaldmann> yes, ok
89 2014-08-07T17:09:12 *** greg_f
90 2014-08-07T17:26:32 <randomax> ThomasWaldmann, can I commit this ? https://codereview.appspot.com/119150043/
91 2014-08-07T17:39:56 <randomax> ThomasWaldmann, and regarding this cr - https://codereview.appspot.com/113780043/ i couldnt find any lists like the one i created..
92 2014-08-07T17:46:57 *** randomax
93 2014-08-07T18:20:07 *** magu_cic
94 2014-08-07T18:22:44 *** magu_cic_
95 2014-08-07T18:34:49 *** skathpalia
96 2014-08-07T18:59:33 *** magu_cic
97 2014-08-07T20:51:22 *** penguinRaider
98 2014-08-07T21:05:10 *** dave_largo
99
