1 2014-08-09T02:58:22 *** sl33k_
2 2014-08-09T05:36:29 *** sl33k_
3 2014-08-09T06:04:48 *** sl33k_
4 2014-08-09T08:34:56 *** sl33k_
5 2014-08-09T09:59:59 *** sl33k_
6 2014-08-09T11:41:33 *** penguinRaider
7 2014-08-09T12:10:12 *** sl33k_
8 2014-08-09T12:49:58 *** magu_cic
9 2014-08-09T12:55:55 *** randomax
10 2014-08-09T13:04:34 <randomax> Sorry i was having my course registrations in college yesterday so the whole day went into it
11 2014-08-09T13:04:49 <randomax> ThomasWaldmann, I removed all the remaining css in this - https://codereview.appspot.com/119150043/
12 2014-08-09T13:05:17 <randomax> because it didnt look good
13 2014-08-09T13:05:42 <randomax> with normal width there was space leftover to the right of the actual numbers
14 2014-08-09T13:05:56 <randomax> while their heading was being aligned to the right
15 2014-08-09T13:37:00 *** xiaq
16 2014-08-09T14:01:17 *** skathpalia
17 2014-08-09T14:01:20 <skathpalia> moin
18 2014-08-09T14:02:02 <skathpalia> sorry, I was offline for last 2 days as course registrations were going on
19 2014-08-09T14:02:46 <skathpalia> Will make the css patch having changes pointed by Thomas by tomorrow
20 2014-08-09T14:59:59 *** greg_f
21 2014-08-09T15:33:55 *** magu_cic_
22 2014-08-09T15:36:44 *** magu_cic
23 2014-08-09T15:57:04 <ThomasWaldmann> moin
24 2014-08-09T15:57:27 <skathpalia> moin
25 2014-08-09T15:57:42 <randomax> moin
26 2014-08-09T16:00:06 <ThomasWaldmann> dimazest: are you with us?
27 2014-08-09T16:01:26 <ThomasWaldmann> hmm, looks like dimazest and roger are still busy otherwise
28 2014-08-09T16:01:37 <ThomasWaldmann> ok, welcome to our weekly meeting
29 2014-08-09T16:01:50 <ThomasWaldmann> skathpalia: can you begin?
30 2014-08-09T16:01:53 <skathpalia> Ok
31 2014-08-09T16:02:00 <skathpalia> Done:
32 2014-08-09T16:02:06 <skathpalia> Finalized and commited crs:
33 2014-08-09T16:02:14 <skathpalia> Improvement in Blog UI
34 2014-08-09T16:02:19 <skathpalia> Modernized theme: https://codereview.appspot.com/121930043/
35 2014-08-09T16:02:24 <skathpalia> Foobar theme: https://codereview.appspot.com/118490044/
36 2014-08-09T16:02:30 <skathpalia> Basic theme: https://codereview.appspot.com/113830043/
37 2014-08-09T16:02:35 <skathpalia> Moved comments to right and meta-data to left in modify/submit view of tickets
38 2014-08-09T16:02:41 <skathpalia> cr: https://codereview.appspot.com/114210043/
39 2014-08-09T16:02:47 <skathpalia> Added ticket-create button and blog-entry-create button in +tickets view and blog view respectively
40 2014-08-09T16:02:52 <skathpalia> cr: https://codereview.appspot.com/116940044/
41 2014-08-09T16:02:58 <skathpalia> Now shortened fqname is shown in trail and also used fqname instead of item_name in location_breadcrumbs
42 2014-08-09T16:03:04 <skathpalia> cr: https://codereview.appspot.com/115700043/
43 2014-08-09T16:03:09 <skathpalia> New/Updated crs:
44 2014-08-09T16:03:16 <skathpalia> Also did the same for location_breadcrumbs in basic theme
45 2014-08-09T16:03:21 <skathpalia> cr: https://codereview.appspot.com/124090043
46 2014-08-09T16:03:28 <skathpalia> Also updated the cr of displaying only tags specific to ticket items in +tickets view and ticket view, still needs to define a function for extracting tags
47 2014-08-09T16:03:36 <skathpalia> cr: https://codereview.appspot.com/111410043/
48 2014-08-09T16:03:47 <skathpalia> Fixed #326 Removed duplicate "Add comment" and "message", used just Add Comment
49 2014-08-09T16:03:53 <skathpalia> cr: https://codereview.appspot.com/128800043/
50 2014-08-09T16:04:01 <skathpalia> Blocked: None
51 2014-08-09T16:04:05 <skathpalia> TODO:
52 2014-08-09T16:04:12 <skathpalia> Make a patch having css changes pointed by ThomasWaldmann
53 2014-08-09T16:04:18 <skathpalia> Look for some other bugs and solve them and also some more UI Improvements
54 2014-08-09T16:04:23 <skathpalia> Make necessary changes in documentation
55 2014-08-09T16:05:16 <ThomasWaldmann> I'ld also suggest to clean up etherpad. remaining issues / todo should go to issue tracker.
56 2014-08-09T16:05:30 <skathpalia> Ok will so that :)
57 2014-08-09T16:06:06 <ThomasWaldmann> did you close codereviews that are done?
58 2014-08-09T16:06:07 <skathpalia> *do
59 2014-08-09T16:06:12 <skathpalia> Yeah
60 2014-08-09T16:06:50 <ThomasWaldmann> ok, so I'll have a look at the remaining ones later.
61 2014-08-09T16:08:08 <ThomasWaldmann> as last week, try to get stuff committed asap, as your time for remaining fixes is coming to an end soon (as far as gsoc is concerned at least, of course stuff can be also fixed after gsoc, but it won't count for gsoc then).
62 2014-08-09T16:08:32 <ThomasWaldmann> randomax: same applies for you ^^
63 2014-08-09T16:08:35 <randomax> yeah
64 2014-08-09T16:08:39 <skathpalia> Ok
65 2014-08-09T16:09:42 <ThomasWaldmann> also, do a click-through for your stuff (using at least basic and modernized themes) to identify stuff that can be fixed easily. ui/ux issues / missing stuff.
66 2014-08-09T16:10:02 <ThomasWaldmann> just try to practically use it
67 2014-08-09T16:10:40 <skathpalia> Ok will look for such stuff and try to fix it by next week :)
68 2014-08-09T16:11:51 * ThomasWaldmann currently has no questions/comments, might come after next pull requests. I usually practically try stuff when it is committed/merged.
69 2014-08-09T16:12:36 <ThomasWaldmann> skathpalia: randomax: do you remember when your primary mentors will be back from vacation?
70 2014-08-09T16:12:54 <randomax> Roger said he'll be on vacation till 11th August
71 2014-08-09T16:13:28 <skathpalia> dimazest will also come by 11 August
72 2014-08-09T16:13:48 <ThomasWaldmann> ok, great
73 2014-08-09T16:14:02 <ThomasWaldmann> skathpalia: any questions from your side?
74 2014-08-09T16:14:23 <skathpalia> Just wanted to ask regarding https://codereview.appspot.com/111410043/
75 2014-08-09T16:14:40 <skathpalia> Where should I add the function to extract tags?
76 2014-08-09T16:14:50 <skathpalia> *ticket specific tags
77 2014-08-09T16:16:41 <ThomasWaldmann> well, check which module is importing stuff from which other
78 2014-08-09T16:17:25 <ThomasWaldmann> e.g. if the frontend module is importing stuff from items module anyway, you could just have the function in items and import it in frontend views
79 2014-08-09T16:18:29 <skathpalia> Ok will see for such module and add function there. May be in items it would be fine, but still look if there some other better option :)
80 2014-08-09T16:18:46 <ThomasWaldmann> also, think about generalization. I mean it should not just always extract tags from tickets.
81 2014-08-09T16:19:22 <skathpalia> Yeah I was also thinking of passing itemtype as parameter so that it is not restricted to just tickets
82 2014-08-09T16:19:42 <ThomasWaldmann> yup
83 2014-08-09T16:20:29 <ThomasWaldmann> anything else?
84 2014-08-09T16:20:43 <skathpalia> nope
85 2014-08-09T16:20:55 <ThomasWaldmann> ok, thanks skathpalia - randomax your stage :)
86 2014-08-09T16:21:03 <randomax> Done-
87 2014-08-09T16:21:09 <randomax> Added heading to global index view in Basic theme - https://codereview.appspot.com/123720043/
88 2014-08-09T16:21:13 <randomax> Improved global history view in basic theme - https://codereview.appspot.com/116560043/
89 2014-08-09T16:21:20 <randomax> Added css to acl reports in modernized and foobar themes - https://codereview.appspot.com/121470043/
90 2014-08-09T16:21:26 <randomax> Added css classes for making multicolumn lists - https://codereview.appspot.com/121730043/
91 2014-08-09T16:21:30 <randomax> Added capability to edit acl in item acl report view itself - https://codereview.appspot.com/119880046/
92 2014-08-09T16:21:39 <randomax> Blocked-
93 2014-08-09T16:21:41 <randomax> None
94 2014-08-09T16:21:46 <randomax> Next-
95 2014-08-09T16:21:50 <randomax> Complete the remaining CRs and find and fix errors
96 2014-08-09T16:22:45 <ThomasWaldmann> + <see above>
97 2014-08-09T16:23:03 <randomax> yeah
98 2014-08-09T16:23:14 <randomax> saw that :)
99 2014-08-09T16:24:56 <ThomasWaldmann> closed all codereviews that are done?
100 2014-08-09T16:25:21 <randomax> yes
101 2014-08-09T16:26:38 <ThomasWaldmann> ok, I have (total) 6 open codereviews from you both, will have another look at them after the meeting
102 2014-08-09T16:26:52 <ThomasWaldmann> 3 + 3
103 2014-08-09T16:27:56 <randomax> Umm i have 4
104 2014-08-09T16:27:59 <ThomasWaldmann> you also try to commit and PR your stuff asap, so i can merge it and roger and dimazest can try your stuff when they return
105 2014-08-09T16:28:20 <randomax> yes
106 2014-08-09T16:29:00 <skathpalia> Ok
107 2014-08-09T16:29:05 <ThomasWaldmann> skathpalia: do you have 3 open ones or a different count?
108 2014-08-09T16:29:20 <skathpalia> yeah 3
109 2014-08-09T16:29:45 <skathpalia> One of them I will update by adding function of itemtype specific tags
110 2014-08-09T16:29:46 <ThomasWaldmann> randomax: ok, so i need the urls of the 4 open ones to see which one codereview site is hiding
111 2014-08-09T16:29:52 <randomax> ok
112 2014-08-09T16:31:07 <randomax> https://codereview.appspot.com/119150043/
113 2014-08-09T16:31:13 <randomax> https://codereview.appspot.com/121730043/
114 2014-08-09T16:31:17 *** magu_cic
115 2014-08-09T16:31:19 <randomax> https://codereview.appspot.com/119880046/
116 2014-08-09T16:31:27 <randomax> https://codereview.appspot.com/121470043/
117 2014-08-09T16:32:55 <ThomasWaldmann> have: 3rd 1st + https://codereview.appspot.com/91680043/
118 2014-08-09T16:33:36 <ThomasWaldmann> do not have: 2nd 4th
119 2014-08-09T16:34:04 <randomax> https://codereview.appspot.com/91680043/ is still pending
120 2014-08-09T16:34:15 <ThomasWaldmann> so, if it shows a different picture to you, maybe you should file a bug to codereview project :D
121 2014-08-09T16:34:44 *** magu_cic_
122 2014-08-09T16:35:21 <ThomasWaldmann> skathpalia: can you show the ones it shows as open on your side?
123 2014-08-09T16:35:41 <skathpalia> https://codereview.appspot.com/111410043/
124 2014-08-09T16:35:49 <skathpalia> https://codereview.appspot.com/124090043/
125 2014-08-09T16:35:55 <randomax> ThomasWaldmann, yeah it will show up as open but i have yet to upload the next patch
126 2014-08-09T16:35:57 <skathpalia> https://codereview.appspot.com/128800043/
127 2014-08-09T16:37:33 *** magu_cic_
128 2014-08-09T16:37:58 <ThomasWaldmann> skathpalia: i have 1st + https://codereview.appspot.com/122940043/ https://codereview.appspot.com/108230043/
129 2014-08-09T16:38:05 <ThomasWaldmann> do not have 2nd / 3rd
130 2014-08-09T16:39:12 <skathpalia> This https://codereview.appspot.com/128800043/ is not valid as css was later changed by randomax
131 2014-08-09T16:39:35 <ThomasWaldmann> if it is done, close it
132 2014-08-09T16:39:40 <skathpalia> Ok
133 2014-08-09T16:40:24 <skathpalia> I have this also https://codereview.appspot.com/111410043/
134 2014-08-09T16:40:27 <skathpalia> https://codereview.appspot.com/124090043/
135 2014-08-09T16:40:45 <skathpalia> https://codereview.appspot.com/128800043/
136 2014-08-09T16:41:07 *** magu_cic
137 2014-08-09T16:41:13 <skathpalia> and one regarding test(I forgot to mention this) https://codereview.appspot.com/128800043/
138 2014-08-09T16:41:43 <ThomasWaldmann> ok, i'll have a look at these, using irc urls, not the list from codereview site :|
139 2014-08-09T16:42:29 <ThomasWaldmann> anything left over for the meeting? questions / comments?
140 2014-08-09T16:42:45 <randomax> nope
141 2014-08-09T16:43:10 <skathpalia> nope
142 2014-08-09T16:43:15 <ThomasWaldmann> ok, so thanks for attending, will do CR now ;)
143 2014-08-09T16:50:54 *** greg_f
144 2014-08-09T16:54:04 <skathpalia> ThomasWaldmann, updated the cr https://codereview.appspot.com/111410043/ (removed code duplication)
145 2014-08-09T17:03:09 *** sl33k_
146 2014-08-09T17:06:01 <skathpalia> ThomasWaldmann, Added docstring also in the above ^^ cr
147 2014-08-09T17:20:18 <ThomasWaldmann> skathpalia: if there was nothing else: commit & clos
148 2014-08-09T17:20:18 <ThomasWaldmann> e
149 2014-08-09T17:21:28 <skathpalia> OK
150 2014-08-09T17:24:43 <skathpalia> ThomasWaldmann, This https://codereview.appspot.com/128800043/ is valid and this ( https://codereview.appspot.com/108230043/ ) one was not valid
151 2014-08-09T17:24:58 <skathpalia> By mistake I gave the wrong link
152 2014-08-09T17:25:18 *** sl33k_
153 2014-08-09T17:26:24 <ThomasWaldmann> ok
154 2014-08-09T17:37:08 <ThomasWaldmann> skathpalia: ok, now I've processed all of your CRs, right?
155 2014-08-09T17:38:31 <skathpalia> yeah
156 2014-08-09T17:38:37 <waldi> dreimark_: du könntest bescheid sagen wenn du in der nähe bist
157 2014-08-09T17:40:53 <ThomasWaldmann> randomax: same for you
158 2014-08-09T17:41:09 <randomax> yeah
159 2014-08-09T17:41:26 *** sl33k_
160 2014-08-09T17:42:07 *** randomax
161 2014-08-09T17:42:25 *** randomax
162 2014-08-09T18:15:15 *** magu_cic
163 2014-08-09T18:18:22 *** magu_cic_
164 2014-08-09T18:49:15 *** magu_cic_
165 2014-08-09T18:49:50 *** penguinRaider
166 2014-08-09T18:52:22 *** magu_cic
167 2014-08-09T19:01:43 <randomax> ThomasWaldmann, review needed - https://codereview.appspot.com/127840043/
168 2014-08-09T19:10:07 *** sl33k_
169 2014-08-09T19:27:34 *** magu_cic
170 2014-08-09T19:30:50 *** magu_cic_
171 2014-08-09T19:44:49 *** magu_cic_
172 2014-08-09T19:48:22 *** magu_cic
173 2014-08-09T20:00:23 * ThomasWaldmann looks
174 2014-08-09T20:02:58 <ThomasWaldmann> randomax: these image files, did you check they were all the same?
175 2014-08-09T20:08:52 <randomax> yeah
176 2014-08-09T20:16:18 *** penguinRaider
177 2014-08-09T20:26:54 <ThomasWaldmann> randomax: how is the procedure if a theme wants different smileys?
178 2014-08-09T20:28:27 *** penguinRaider
179 2014-08-09T20:30:06 <randomax> I did that because all the themes were using the same smileys
180 2014-08-09T20:30:51 <randomax> if they would want it different we'll have to declare differently
181 2014-08-09T20:47:03 <ThomasWaldmann> well, themes are for having it potentially look different, so there should be a way to in fact do that
182 2014-08-09T20:49:35 *** magu_cic
183 2014-08-09T20:50:01 *** magu_cic_
184 2014-08-09T20:58:21 <randomax> ThomasWaldmann, so should i just add the css to basic theme and copy back the images to the 3 themes ?
185 2014-08-09T21:00:57 <ThomasWaldmann> having same stuff only at one place is not a bad idea per se
186 2014-08-09T21:01:08 <ThomasWaldmann> but you have to think it through to the end
187 2014-08-09T21:12:51 *** skathpalia
188 2014-08-09T21:14:07 <randomax> I cant think of any other way.. because if we have different smileys, we would require different css definitions.. :(
189 2014-08-09T21:18:22 *** magu_cic_
190 2014-08-09T21:21:51 *** penguinRaider
191 2014-08-09T21:22:29 *** magu_cic
192 2014-08-09T21:26:19 <randomax> ThomasWaldmann, made a new patch for fixing overflowing quicklinks and also their tooltips, as this is on a fresh repo.. uploading it on the old CR would have given an extremely huge unnecessary delta from the previous patchset..
193 2014-08-09T21:26:23 <randomax> https://codereview.appspot.com/123150043/
194 2014-08-09T21:33:31 * ThomasWaldmann looks
195 2014-08-09T21:45:13 <ThomasWaldmann> randomax: done
