1 2014-08-17T03:33:55 *** sl33k_
2 2014-08-17T06:47:51 *** skathpalia
3 2014-08-17T06:48:22 <skathpalia> dimazest, Fixed https://bitbucket.org/saurabh_k/moin-2.0/issue/10/traceback-in-admin-users-and-admin-groups
4 2014-08-17T06:48:27 <skathpalia> https://codereview.appspot.com/129320043
5 2014-08-17T07:20:29 *** sl33k_
6 2014-08-17T08:47:46 *** sl33k_
7 2014-08-17T09:16:36 *** skathpalia
8 2014-08-17T09:40:47 *** randomax
9 2014-08-17T10:51:53 *** sl33k_
10 2014-08-17T11:01:36 *** randomax
11 2014-08-17T12:28:33 *** skathpalia
12 2014-08-17T13:31:57 *** greg_f
13 2014-08-17T13:55:07 *** RogerHaase
14 2014-08-17T13:58:16 <skathpalia> RogerHaase, Fixed #10 of my repo https://bitbucket.org/saurabh_k/moin-2.0/commits/949994a4c3cfd60555df6209dbca2f2ff3086215
15 2014-08-17T13:58:51 <RogerHaase> skathpalia: I tested, works for me :)
16 2014-08-17T14:08:58 <skathpalia> RogerHaase, Changed the format of ticket submit/modify view
17 2014-08-17T14:09:17 <skathpalia> basic theme: http://picpaste.com/pics/tickets-basic-zyXJJJK1.1408284510.png
18 2014-08-17T14:09:36 <skathpalia> modernized theme: http://picpaste.com/pics/tickets-modernized-ugpoWm7W.1408284512.png
19 2014-08-17T14:11:08 <RogerHaase> skathpalia: yes, that looks better having comments on left
20 2014-08-17T14:11:29 <skathpalia> Ok making a codereview for it :)
21 2014-08-17T14:18:39 <skathpalia> RogerHaase, codereview for the above change https://codereview.appspot.com/130820043
22 2014-08-17T14:23:38 <skathpalia> dimazest ^^
23 2014-08-17T14:26:04 <skathpalia> dimazest, Can I commit it?
24 2014-08-17T14:26:35 <dimazest> better wait for RogerHaase comment
25 2014-08-17T14:26:42 <skathpalia> Ok
26 2014-08-17T14:34:50 <RogerHaase> skathpalia: looks nicer than before, but if you use the textarea drag-to-expand feature, the display gets a bit strange https://paste.thinkmo.de/64ec94d8-2e9e-4000-a479-ecde424fbc86
27 2014-08-17T14:43:50 <RogerHaase> skathpalia: if ticket/modify.html were changed to output comments first, and moin-ticket-metadata were floated left (eg float left on both), maybe the metadata would float under the comments if the user expanded the textarea?
28 2014-08-17T14:53:51 * ThomasWaldmann did some CRs / closed some issues
29 2014-08-17T14:54:19 <ThomasWaldmann> skathpalia: any questions about pastebin feedback?
30 2014-08-17T15:37:33 <skathpalia> sorry, had gone to dinner...
31 2014-08-17T15:45:47 <skathpalia> ThomasWaldmann, tried to fix some issues mentioned in the feedback
32 2014-08-17T15:52:31 <skathpalia> ThomasWaldmann, updated the cr https://codereview.appspot.com/128030043
33 2014-08-17T15:52:53 <skathpalia> Removed unnecessary line-height and also updated the above cr as per the current repo
34 2014-08-17T16:00:15 <skathpalia> RogerHaase, yeah after extending textarea the it comes over meta data
35 2014-08-17T16:00:57 <skathpalia> May be we have to restrict the width of the textarea
36 2014-08-17T16:03:57 *** magu_cic
37 2014-08-17T16:08:54 <skathpalia> RogerHaase, what do you say on this idea?
38 2014-08-17T16:15:15 <RogerHaase> skathpalia: one way is resize: vertical; the use case I am thinking of is pasting in a traceback and trying to view it without a lot of wordwrap or scroll bars
39 2014-08-17T16:16:54 <skathpalia> Yeah if we restrict the width of textarea then there won't be any overlapping and also textarea can be extended vertically
40 2014-08-17T16:19:25 <skathpalia> RogerHaase, updated the cr https://codereview.appspot.com/130820043/
41 2014-08-17T16:19:38 <skathpalia> Used resize vertical for textarea
42 2014-08-17T16:20:28 *** randomax
43 2014-08-17T16:20:33 <RogerHaase> skathpalia: on wide windows, the meta data takes more area than it needs. Have you tried setting the meta data width in EMs and letting the content take up the remainder of the window
44 2014-08-17T16:23:11 <skathpalia> RogerHaase, EMs?
45 2014-08-17T16:23:47 <randomax> ThomasWaldmann, i think its better to have three columns in the userbrowser view for the action buttons as it automatically uniformly and neatly without unnecessary css
46 2014-08-17T16:24:27 <RogerHaase> skathpalia: http://www.w3schools.com/cssref/css_units.asp
47 2014-08-17T16:24:46 <skathpalia> Oh unit :)
48 2014-08-17T16:26:07 <skathpalia> No I didn't try to do it in ems, trying it now
49 2014-08-17T16:29:45 <skathpalia> RogerHaase, updated the cr, used em instead of % https://codereview.appspot.com/130820043
50 2014-08-17T16:36:37 <RogerHaase> skathpalia: that h2 Provide metadata need to go in the div below it similar to how the h2 Describe the ticket is placed
51 2014-08-17T16:40:07 <skathpalia> RogerHaase, done the above change, updated the cr
52 2014-08-17T16:46:04 <RogerHaase> I cannot resize the textarea and the textarea is not filling the availbe space https://paste.thinkmo.de/5421b02c-3ef3-487e-a649-c77688f1cd2f
53 2014-08-17T16:48:04 <skathpalia> In basic theme, bootstrap doesn't allow extension in vertical but if we keep typing in the the textarea then it will automatically extend vertically
54 2014-08-17T16:48:53 <skathpalia> vertical extension is not there just by dragging in bootstrap
55 2014-08-17T16:51:08 <RogerHaase> skathpalia: ok, as you said it does expand in modernized
56 2014-08-17T16:51:57 <skathpalia> yeah
57 2014-08-17T16:52:31 <skathpalia> RogerHaase, Can I commit it?
58 2014-08-17T16:56:38 <RogerHaase> skathpalia: not yet, if you move that <div class="moin-ticket-comments"> into the <div id="moin-content-data" it will go under the textarea (assuming above and to right of textarea is unintended)
59 2014-08-17T16:59:06 *** greg_f
60 2014-08-17T17:01:21 <skathpalia> RogerHaase, I didn't get you ... Can you please explain?
61 2014-08-17T17:02:16 <RogerHaase> skathpalia: look at position of Submit Ticket button https://paste.thinkmo.de/5421b02c-3ef3-487e-a649-c77688f1cd2f
62 2014-08-17T17:04:08 <RogerHaase> skathpalia: modernized need some css fixes for metadata alignment: https://paste.thinkmo.de/b2f9a33f-6377-410f-be74-c240eb0e0afb
63 2014-08-17T17:13:23 <skathpalia> RogerHaase, I moved div of moin-ticket-comments into moin-content-data in submit.html but still the submit button is above text area
64 2014-08-17T17:18:42 <RogerHaase> skathpalia: hmm, I was looking at raw HTML when I suggested that, not source
65 2014-08-17T17:20:28 <RogerHaase> thhere are also issues when you make window size small - metadata floats under the textarea but stays right
66 2014-08-17T17:26:48 <RogerHaase> skathpalia: I am thinking try floating both <div id="moin-content-data" class="moin-ticket-comments"> and <div class="moin-ticket-metadata"> left and allow user to resize textarea both ways
67 2014-08-17T17:29:32 <skathpalia> This corrects resizing but then update button comes on top right
68 2014-08-17T17:31:52 <skathpalia> I think the issues related to window resizing and zooming in and out can be solved later and for now we can just make comments to left and metadata to right
69 2014-08-17T17:32:05 <skathpalia> RogerHaase, what do you say?
70 2014-08-17T17:33:09 <RogerHaase> skathpalia: I think the choice is to either put the submit button in the comments div or the metadata div, else it will float around
71 2014-08-17T17:34:08 <skathpalia> One more thing can be done that it can be put in center in bottom
72 2014-08-17T17:35:09 <skathpalia> as if we put it in metadata then it will be in bottom right and if we put it in comments it floats out so we can have above option
73 2014-08-17T17:37:14 <RogerHaase> or have 2 Submit Ticket buttons?
74 2014-08-17T17:42:54 <skathpalia> Yeah my be we can have that also
75 2014-08-17T17:43:22 <skathpalia> I think we should discuss it with ThomasWaldmann
76 2014-08-17T17:44:21 <skathpalia> RogerHaase, what do you say?
77 2014-08-17T17:46:42 <RogerHaase> skathpalia: one other way for one button always at the bottom is to add "clear:both; float:left" to <div class="moin-ticket-comments">
78 2014-08-17T17:49:57 <skathpalia> yeah this one works
79 2014-08-17T17:50:18 <RogerHaase> ...which is poorly named as it only contains a submit button
80 2014-08-17T17:51:21 <RogerHaase> and if you are looking at basic theme with screwed up footer on narrow window, the basic theme needs a clear:both for moin-footer
81 2014-08-17T17:52:16 <RogerHaase> randomax: ^^ a while back you added clear:both for moin-footer on modernized theme; basic theme needs it as well
82 2014-08-17T17:52:39 <skathpalia> RogerHaase, updated the cr https://codereview.appspot.com/130820043/
83 2014-08-17T17:55:30 <randomax> Ok
84 2014-08-17T17:57:39 <skathpalia> RogerHaase, defined a class for submit button and updated the cr
85 2014-08-17T17:57:51 <RogerHaase> skathpalia: better, modernized still needs a bit of work on metadata
86 2014-08-17T17:57:59 <RogerHaase> must break for ~30 min
87 2014-08-17T18:06:52 <skathpalia> RogerHaase, now meta data is properly aligned in modernized theme also https://codereview.appspot.com/130820043/
88 2014-08-17T18:20:02 <RogerHaase> skathpalia: OK, looks good!
89 2014-08-17T18:20:11 <skathpalia> Can I commit it?
90 2014-08-17T18:20:19 <RogerHaase> ok by me
91 2014-08-17T20:24:36 *** randomax
92 2014-08-17T21:05:09 *** skathpalia
93 2014-08-17T22:17:46 *** RogerHaase
94
