MoinMoin: MoinMoinChat/Logs/moin-dev/2014-09-01

   1 2014-09-01T00:02:16  *** sunu has joined #moin-dev
   2 2014-09-01T00:02:41  *** sharky93_ has joined #moin-dev
   3 2014-09-01T00:07:44  *** jhermann has quit IRC
   4 2014-09-01T00:08:21  *** jhermann has joined #moin-dev
   5 2014-09-01T00:09:20  *** sharky93 has quit IRC
   6 2014-09-01T00:11:30  *** sunu_ has quit IRC
   7 2014-09-01T07:15:55  *** greg_f has joined #moin-dev
   8 2014-09-01T13:48:36  *** waldi has quit IRC
   9 2014-09-01T13:48:44  *** waldi has joined #moin-dev
  10 2014-09-01T13:48:44  *** waldi has joined #moin-dev
  11 2014-09-01T16:18:01  *** greg_f has quit IRC
  12 2014-09-01T17:13:04  *** RogerHaase has joined #moin-dev
  13 2014-09-01T17:44:01  *** penguinRaider has joined #moin-dev
  14 2014-09-01T19:55:20  <RogerHaase> ThomasWaldmann: fix #446 ACL Admin Rights Given to Users with Write Authority https://codereview.appspot.com/133430043/
  15 2014-09-01T20:39:07  <ThomasWaldmann> hi RogerHaase
  16 2014-09-01T20:39:15  * ThomasWaldmann looking
  17 2014-09-01T20:44:20  <RogerHaase> ThomasWaldmann: moin :) if you have time there is also these http://moinmo.in/ThomasWaldmann/IssuesToBeClosed
  18 2014-09-01T20:50:50  <ThomasWaldmann> one finished, 4 to go...
  19 2014-09-01T20:55:21  <ThomasWaldmann> RogerHaase: py.test 2.6.1 changed pep8 tests semantics?
  20 2014-09-01T20:56:02  <RogerHaase> seems like it did, have you run ./ tests?
  21 2014-09-01T20:56:22  <RogerHaase> ./m tests
  22 2014-09-01T20:57:43  <RogerHaase> now it only pep8 checks coding_std.py that happens to be in /contrib/pep8/
  23 2014-09-01T20:58:43  * ThomasWaldmann runs tests ("as is")
  24 2014-09-01T21:02:10  <ThomasWaldmann> hmm, right, checks only that one file
  25 2014-09-01T21:02:44  <ThomasWaldmann> it is also with 2.6.0, so maybe a change at 2.6 boundary
  26 2014-09-01T21:02:59  <RogerHaase> ThomasWaldmann: on the ACL rights fix, both basic and now modernized themes do not show the ACL field on the modify form.  So the check in protecting.py is just trying to catch an unauthorized user trying to submit his own form
  27 2014-09-01T21:04:01  <RogerHaase> re. pep8, I googled but could not find any docs that -k pep8 used to work or was changed to not work
  28 2014-09-01T21:06:00  <RogerHaase> not work/no longer select only pep8 tests
  29 2014-09-01T21:08:56  <ThomasWaldmann> RogerHaase: protecting layer is unrelated to forms, it is just a part of storage middlewares and has to deal with anything that could come in by ANY means.
  30 2014-09-01T21:09:53  <ThomasWaldmann> but giving unmodified acl without admin privs shouldn't cause a problem
  31 2014-09-01T21:10:52  <RogerHaase> ok, will change code to test for changed ACL
  32 2014-09-01T21:11:53  * ThomasWaldmann can't find that pep8 change in changelog either
  33 2014-09-01T21:12:32  <RogerHaase> ThomasWaldmann: I did look at NAME_EXACT, seems like poor choice for name, but it is used in ~100 places
  34 2014-09-01T21:14:03  <ThomasWaldmann> well, we have NAME and NAME_EXACT.
  35 2014-09-01T21:14:31  <ThomasWaldmann> first is tokenized, second is used as is for 1:1 match
  36 2014-09-01T21:15:49  * ThomasWaldmann just asked on #pylib about the pep8 change
  37 2014-09-01T21:21:16  <RogerHaase> will try pycharm on 459 reverting a deleted item to see if there is a more sensible test to show item-id or name
  38 2014-09-01T21:25:28  <ThomasWaldmann> it is somehow strange that in NAME_EXACT case we show itemid, else we show names. why?
  39 2014-09-01T21:26:13  <ThomasWaldmann> something completely different: did you see memodump theme yet?
  40 2014-09-01T21:26:40  <ThomasWaldmann> (for moin 1.9.x)
  41 2014-09-01T21:27:09  <RogerHaase> I saw it in recent changes, but did not download
  42 2014-09-01T21:29:18  <ThomasWaldmann> http://wiki.linuxpadawan.net/ - they have a designer guy who looked through the stuff on ThemeMarket and chose memodump. will be practically tested there (is not active yet as default theme, but available)
  43 2014-09-01T21:50:04  <ThomasWaldmann> RogerHaase: pulled/merged from your repo
  44 2014-09-01T21:52:44  <RogerHaase> ThomasWaldmann: ok, you will have coding-std errors until the foobar theme is removed
  45 2014-09-01T21:52:48  <RogerHaase> gtg
  46 2014-09-01T21:52:52  *** RogerHaase has left #moin-dev
  47 2014-09-01T22:55:48  *** mapreri has quit IRC
  48 2014-09-01T23:08:35  *** mapreri has joined #moin-dev
  49