MoinMoin: MoinMoinChat/Logs/moin-dev/2014-09-25

   1 2014-09-25T04:50:38  *** waldi has joined #moin-dev
   2 2014-09-25T04:50:38  *** waldi has joined #moin-dev
   3 2014-09-25T04:53:00  *** waldi has quit IRC
   4 2014-09-25T04:55:17  *** waldi has joined #moin-dev
   5 2014-09-25T04:55:17  *** waldi has joined #moin-dev
   6 2014-09-25T08:52:49  *** greg_f has joined #moin-dev
   7 2014-09-25T09:44:00  *** eSyr-ng has joined #moin-dev
   8 2014-09-25T11:40:23  *** sharky93 has joined #moin-dev
   9 2014-09-25T14:08:12  *** eSyr has quit IRC
  10 2014-09-25T14:09:28  *** eSyr has joined #moin-dev
  11 2014-09-25T14:14:14  *** RogerHaase has joined #moin-dev
  12 2014-09-25T17:51:13  *** greg_f has quit IRC
  13 2014-09-25T19:10:02  *** pjoshi has joined #moin-dev
  14 2014-09-25T19:10:29  <pjoshi> RogerHaase: Hello
  15 2014-09-25T19:10:38  <pjoshi> I have uploaded the correct code
  16 2014-09-25T19:10:42  <pjoshi> Sorry for delay
  17 2014-09-25T19:13:33  <pjoshi> https://codereview.appspot.com/139660043/
  18 2014-09-25T19:23:44  <RogerHaase> pjoshi: moin, that has inconsistent blank lines - there is one blank line between macros except where deleted macro was, there are 3 there
  19 2014-09-25T19:25:53  <pjoshi> RogerHaase: Moin, I guess except the blank lines the code is working
  20 2014-09-25T19:26:20  <pjoshi> As I didn't deleted the blank lines after removing the macros
  21 2014-09-25T19:29:48  <RogerHaase> pjoshi: you should try to maintain a consistent coding style and not leave a hole with 3 blank lines when everywhere else in that module has 1
  22 2014-09-25T19:32:48  <pjoshi> RogerHaase: Okay, will take care of it from now, This won't happen again
  23 2014-09-25T19:33:16  <pjoshi> It was my first time with professionals :)
  24 2014-09-25T19:36:49  <RogerHaase> pjoshi: np, when you fix the lines, I think you can commit that, push to your public repo, and update your pull request.  Hopefully tw will accept it in two parts.
  25 2014-09-25T19:37:37  <pjoshi> RogerHaase: Great will do that.
  26 2014-09-25T19:37:50  <pjoshi> and then will start working on new bug
  27 2014-09-25T20:30:30  <pjoshi> RogerHaase: Tomorrow I have to talk about python in my college for a GDG event. I am a speaker for python talk
  28 2014-09-25T20:31:15  <pjoshi> :P
  29 2014-09-25T20:31:53  <RogerHaase> pjoshi: congrats, is python taught as a separate course?
  30 2014-09-25T20:32:13  <pjoshi> Naa not in our university :/
  31 2014-09-25T20:32:43  <pjoshi> RogerHaase: That will be my first talk ever
  32 2014-09-25T20:33:48  <RogerHaase> too bad... it is a rather nice language
  33 2014-09-25T20:34:52  <pjoshi> RogerHaase: I love python.. Python is too user friendly... the university focuses mainly on java and the algorithms
  34 2014-09-25T20:39:58  <pjoshi> gtg.. Good Night :)
  35 2014-09-25T20:40:02  *** pjoshi has quit IRC
  36 2014-09-25T22:16:04  *** RogerHaase has quit IRC
  37 2014-09-25T22:30:52  *** eSyr has quit IRC
  38 2014-09-25T22:31:00  *** eSyr has joined #moin-dev
  39 2014-09-25T23:47:22  *** eSyr has quit IRC
  40 2014-09-25T23:49:02  *** eSyr has joined #moin-dev
  41