1 2014-11-01T06:11:39 *** sl33k_
2 2014-11-01T06:56:03 *** sl33k_
3 2014-11-01T07:51:34 *** sl33k_
4 2014-11-01T08:02:07 *** sl33k_
5 2014-11-01T10:09:08 *** greg_f
6 2014-11-01T13:47:35 *** RogerHaase
7 2014-11-01T13:48:25 *** greg_f
8 2014-11-01T15:28:41 <RogerHaase> ThomasWaldmann: to continue conversation of fix #468 move moin table and zebra styling to common.css https://codereview.appspot.com/165920043/ ...
9 2014-11-01T15:30:46 <RogerHaase> common.css is loaded before theme.css, so zebra table colors etc. can be overridden by new (or old) theme https://paste.thinkmo.de/nGVQ7qKT making it look like https://paste.thinkmo.de/n4t2Tquh#ScreenShot.png ...
10 2014-11-01T15:33:06 <RogerHaase> where new theme has only info.json and /static/css/theme.css files.
11 2014-11-01T15:35:38 <RogerHaase> ...So adding moin table and zebra striping to common.css avoids duplication of code.
12 2014-11-01T16:55:58 <ThomasWaldmann> RogerHaase: ok, fine
13 2014-11-01T17:01:36 <ThomasWaldmann> RogerHaase: https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/240/installrst-bitbucket/diff
14 2014-11-01T17:01:54 <ThomasWaldmann> was there some reason that you used _ and not - ?
15 2014-11-01T17:02:10 <ThomasWaldmann> if not, we maybe rather fix the code than the docs
16 2014-11-01T17:02:38 <RogerHaase> ThomasWaldmann: probably just a typo, - vs. _ is a common point of confusion for me
17 2014-11-01T17:04:39 <ThomasWaldmann> ofc python identifiers cannot use -
18 2014-11-01T17:05:15 <ThomasWaldmann> but if we basically just pass through an option to virtualenv, we maybe can use same notation
19 2014-11-01T17:16:49 <RogerHaase> ThomasWaldmann: just tried it --download-cache fails with unrecognized arguments, --download_cache works so patch is correct
20 2014-11-01T17:48:24 <ThomasWaldmann> the question is whether we change the docs or the code
21 2014-11-01T18:14:39 *** yfunnel
22 2014-11-01T19:08:13 *** yfunnel
23 2014-11-01T19:09:52 <RogerHaase> ThomasWaldmann: better to change code to be consistent with pip using ... --download-cache
24 2014-11-01T19:36:59 <ThomasWaldmann> yup
25 2014-11-01T19:42:21 <RogerHaase> ThomasWaldmann: https://codereview.appspot.com/166040043/
26 2014-11-01T19:43:17 <ThomasWaldmann> looks ok, did you practically run it?
27 2014-11-01T19:45:07 <RogerHaase> yes
28 2014-11-01T19:46:47 <ThomasWaldmann> ok, include it in next PR, I'll comment and reject the other PR for now
29 2014-11-01T21:55:06 <RogerHaase> ThomasWaldmann: begin merge of basic snippets.html into snippets.html https://codereview.appspot.com/164450043/
30 2014-11-01T22:09:50 *** RogerHaase
31 2014-11-01T23:09:22 *** yfunnel
32
MoinMoin: MoinMoinChat/Logs/moin-dev/2014-11-01 (last edited 2014-11-01 06:15:02 by IrcLogImporter)