1 2015-01-22T01:01:13 *** jek_
2 2015-01-22T01:01:32 *** jek__
3 2015-01-22T01:50:19 *** yogicxl
4 2015-01-22T02:01:45 *** vpv_
5 2015-01-22T02:06:03 *** vpv
6 2015-01-22T05:20:32 *** grvanm
7 2015-01-22T05:51:39 *** grvanm
8 2015-01-22T06:37:30 *** aabs08
9 2015-01-22T06:59:50 *** aabs08
10 2015-01-22T07:48:41 *** grvanm
11 2015-01-22T08:01:10 <grvanm> Here is the patch for the bug i reported before regarding dirturbed alignment of form in create ticket in different resolutions : https://codereview.appspot.com/192500043
12 2015-01-22T08:20:41 *** grvanm
13 2015-01-22T08:25:28 *** Kallor
14 2015-01-22T08:38:17 *** Kallor
15 2015-01-22T08:40:14 *** Kallor
16 2015-01-22T08:40:34 *** ronny
17 2015-01-22T09:17:19 *** yogicxl
18 2015-01-22T09:18:13 *** Araya
19 2015-01-22T09:23:30 *** greg_
20 2015-01-22T09:26:32 *** greg_f
21 2015-01-22T09:32:51 *** DivanshuJain
22 2015-01-22T09:41:44 *** Kallor
23 2015-01-22T09:41:44 *** Araya
24 2015-01-22T09:54:36 *** DivanshuJain
25 2015-01-22T10:26:06 *** aabs08
26 2015-01-22T10:48:53 *** pjoshi_
27 2015-01-22T10:49:31 <pjoshi_> Moin everyone!! I was doing ./m sample for creating sample wiki but it is showing error
28 2015-01-22T10:55:18 <pjoshi_> error is "/bin/sh: 1: moin: not found
29 2015-01-22T10:59:05 <pjoshi_> ?
30 2015-01-22T11:26:05 *** pjoshi_
31 2015-01-22T11:27:08 *** pjoshi_
32 2015-01-22T11:28:34 <aabs08> pjoshi_, have u installed moinmoin by running quickinstall.py?
33 2015-01-22T11:29:01 <pjoshi_> yeah I did python quickinstall.py
34 2015-01-22T11:29:08 <pjoshi_> it created a virtualenv
35 2015-01-22T11:29:19 <pjoshi_> I am working under that virtualenv only
36 2015-01-22T11:31:16 <aabs08> tell me whats the output of python make.py
37 2015-01-22T11:32:28 <aabs08> sorry python make.py run
38 2015-01-22T11:34:29 <aabs08> and also python make.py sample
39 2015-01-22T11:36:48 *** pjoshi_
40 2015-01-22T11:38:22 *** pjoshi_
41 2015-01-22T11:41:49 *** pjoshi_
42 2015-01-22T11:50:27 *** aabs08
43 2015-01-22T11:51:37 *** aabs08
44 2015-01-22T12:00:51 *** grvanm
45 2015-01-22T12:04:14 <grvanm> ThomasWaldmann, The bug screenshots are here , Create ticket form in resolution more than 720p : http://i.imgur.com/1pCWEhX.png , while in 720p or less it is : http://i.imgur.com/RnB2nAp.png
46 2015-01-22T12:04:53 <grvanm> ThomasWaldmann, I have fixed the css and now its same in all the resolutions according to the correct form alignment :)
47 2015-01-22T12:11:19 *** Kallor
48 2015-01-22T12:12:07 *** grvanm
49 2015-01-22T12:42:37 *** dave_largo
50 2015-01-22T13:05:39 *** aabs08
51 2015-01-22T13:06:13 *** aabs08
52 2015-01-22T13:12:44 *** greg_f
53 2015-01-22T13:15:04 *** greg_
54 2015-01-22T13:28:34 *** aabs08
55 2015-01-22T13:31:21 *** DivanshuJain
56 2015-01-22T13:31:38 <DivanshuJain> hi
57 2015-01-22T13:32:34 <DivanshuJain> i have set up the environment ... where should i start ?
58 2015-01-22T13:32:52 <DivanshuJain> anything that i have to read up
59 2015-01-22T13:33:21 <DivanshuJain> some documentation or something like that maybe ...
60 2015-01-22T13:55:00 *** DivanshuJain
61 2015-01-22T14:13:45 *** aabs08
62 2015-01-22T14:36:23 *** aabs08
63 2015-01-22T14:38:16 *** DivanshuJain
64 2015-01-22T14:38:29 *** aabs08
65 2015-01-22T14:50:18 *** DivanshuJain
66 2015-01-22T15:16:08 *** grvanm
67 2015-01-22T15:20:10 <aabs08> ThomasWaldmann, can you review my code of login/logout redirection ?
68 2015-01-22T15:40:42 *** aabs08
69 2015-01-22T15:54:20 *** grvanm
70 2015-01-22T15:59:27 *** grvanm
71 2015-01-22T16:00:54 *** aabs08
72 2015-01-22T16:03:03 *** Kallor
73 2015-01-22T16:17:07 *** aabs08
74 2015-01-22T16:24:39 *** aabs08
75 2015-01-22T16:25:33 *** aabs08
76 2015-01-22T16:26:20 *** aabs08
77 2015-01-22T16:28:41 *** aabhas
78 2015-01-22T16:34:01 *** aabhas
79 2015-01-22T16:34:23 *** aabhas
80 2015-01-22T16:35:20 *** aabhas
81 2015-01-22T16:37:17 *** aabs08
82 2015-01-22T16:46:08 *** grvanm
83 2015-01-22T16:49:13 *** aabs08
84 2015-01-22T16:49:34 *** aabs08
85 2015-01-22T16:50:52 <aabs08> ThomasWaldmann, can you review my code for login/logout redirection ?
86 2015-01-22T16:54:15 *** dave_largo
87 2015-01-22T16:56:22 <aabs08> ThomasWaldmann, in case you see logs https://codereview.appspot.com/194330043/
88 2015-01-22T17:22:53 *** dave_largo
89 2015-01-22T18:12:24 *** sl33k_
90 2015-01-22T18:17:09 *** aabs08
91 2015-01-22T18:30:07 *** aabs08
92 2015-01-22T18:45:29 *** grvanm
93 2015-01-22T18:46:11 *** aabs08
94 2015-01-22T18:52:55 *** aabs08
95 2015-01-22T18:54:03 *** pjoshi_
96 2015-01-22T18:55:51 <pjoshi_> aabs08: Sorry I didn't catch you up
97 2015-01-22T18:56:11 <pjoshi_> when I did ./m sample
98 2015-01-22T18:56:12 *** greg_f
99 2015-01-22T18:56:16 <pjoshi_> I got this Creating a new wiki populated with sample data...
100 2015-01-22T18:56:16 <pjoshi_> Output messages redirected to m-new-wiki.txt.
101 2015-01-22T18:56:16 <pjoshi_> Important messages from m-new-wiki.txt are shown below:
102 2015-01-22T18:56:16 <pjoshi_> Error: attempt to create wiki failed. Do "./m log new-wiki" to see complete log.
103 2015-01-22T18:56:40 <aabs08> have you seen the log?
104 2015-01-22T18:57:08 <pjoshi_> yeah
105 2015-01-22T18:57:26 <aabs08> so whats there?
106 2015-01-22T18:57:57 <pjoshi_> log says /bin/sh: 1: moin: not found
107 2015-01-22T18:58:03 *** grvanm
108 2015-01-22T18:58:25 <aabs08> tell me the output of python make.py sample
109 2015-01-22T18:59:30 <aabs08> do u have a make.py in the folder?
110 2015-01-22T18:59:39 <pjoshi_> http://pastebin.com/0BdCufHv
111 2015-01-22T18:59:53 <pjoshi_> yup
112 2015-01-22T19:02:30 <pjoshi_> I have make.py there
113 2015-01-22T19:05:44 <aabs08> in make.py line no. 156 is the function which is called to make new wiki
114 2015-01-22T19:07:24 <aabs08> subprocess.call(command, shell=True, stderr=messages, stdout=messages) is not getting executed
115 2015-01-22T19:07:33 <aabs08> it returns false for you
116 2015-01-22T19:07:43 <aabs08> line no. 163
117 2015-01-22T19:08:20 *** pjoshi_
118 2015-01-22T19:28:41 *** pjoshi_
119 2015-01-22T19:30:35 <pjoshi_> aabs08: SO what to do to correct it ?
120 2015-01-22T19:31:50 *** yogicxl
121 2015-01-22T19:33:01 *** aabs08
122 2015-01-22T19:34:10 <pjoshi_> I am getting error while performing the command " ./m sample"
123 2015-01-22T19:34:11 <yogicxl> ThomasWaldmann, I am working on issue #463 "Access Denied when clicking on Show link on item history". I noticed that in Ticket class do_show just redirects to do_modify i.e there is no such readonly view for tickets so for that I need to create a view in which I have to pass the revid so Can you please guide how to create such view?
124 2015-01-22T19:34:24 <pjoshi_> error log is http://pastebin.com/0BdCufHv
125 2015-01-22T19:38:12 *** tanya_chuddhari
126 2015-01-22T19:39:17 <yogicxl> pjoshi_, I don't see the error log there. Paste complete log.
127 2015-01-22T19:40:48 <pjoshi_> yogicxl: here is the error log http://pastebin.com/0BdCufHv
128 2015-01-22T19:40:55 <pjoshi_> that was error message
129 2015-01-22T19:44:10 <yogicxl> pjoshi_, go to moin virtual environment by cd moin-2.0-venv-python/bin/sh and check for moin script. If thats not present theres problem with your quickinstall. Run that script again in that case
130 2015-01-22T19:44:38 *** sl33k_
131 2015-01-22T19:46:13 *** pjoshi_
132 2015-01-22T19:46:46 *** aabs08
133 2015-01-22T19:53:45 *** pjoshi_
134 2015-01-22T19:54:07 <pjoshi_> yogicxl: here is the log for quickinstall.py http://pastebin.com/0BdCufHv
135 2015-01-22T19:55:50 *** pjoshi_
136 2015-01-22T19:56:09 *** aabs08
137 2015-01-22T19:58:49 *** aabs08
138 2015-01-22T20:00:19 <aabs08> ThomasWaldmann, please review my code https://codereview.appspot.com/194330043/
139 2015-01-22T20:03:52 <ThomasWaldmann> moin
140 2015-01-22T20:04:09 <aabs08> ThomasWaldmann, , please review my code https://codereview.appspot.com/194330043/
141 2015-01-22T20:04:28 <aabs08> for login and logout redirection :)
142 2015-01-22T20:04:40 *** pjoshi_
143 2015-01-22T20:05:13 <pjoshi_> yogicxl: Sorry net problem
144 2015-01-22T20:06:15 <yogicxl> pjoshi_, I am not familiar with the error but its clear that quickinstall didn't work.
145 2015-01-22T20:06:26 <yogicxl> pjoshi_, not sure what to do
146 2015-01-22T20:07:56 <pjoshi_> yogicxl: Oh.. this seems problem
147 2015-01-22T20:08:01 <pjoshi_> Let me try again
148 2015-01-22T20:09:56 *** RogerHaase
149 2015-01-22T20:10:28 <aabs08> RogerHaase, I am so happy to see you :) , I am done with the login and logout redirection
150 2015-01-22T20:10:44 <aabs08> codereview , https://codereview.appspot.com/194330043/
151 2015-01-22T20:11:02 <pjoshi_> RogerHaase: Moin
152 2015-01-22T20:13:26 *** pjoshi_
153 2015-01-22T20:15:54 <aabs08> RogerHaase, I have created a new issue , which I will be working next https://bitbucket.org/thomaswaldmann/moin-2.0/issue/482/login-page-accessible-even-after-login
154 2015-01-22T20:17:41 <ThomasWaldmann> aabs08: done
155 2015-01-22T20:23:00 <yogicxl> RogerHaase, I am working on issue #463 "Access Denied when clicking on Show link on item history". I noticed that in Ticket class do_show just redirects to do_modify i.e there is no such readonly view for tickets so for that I need to create a view in which I have to pass the revid so Can you please guide how to create such view?
156 2015-01-22T20:23:56 <aabs08> ThomasWaldmann, how to get previous page if browser does not support it any ideas?
157 2015-01-22T20:25:40 <ThomasWaldmann> often this is solved by including a next=<thisurl> query or form param on the previous view, so that the next view can redirect to <next> (== usually back to where it came from)
158 2015-01-22T20:26:23 <ThomasWaldmann> but i still need the bug url. first it should be clear what you are fixing before you fix it.
159 2015-01-22T20:28:18 <ThomasWaldmann> yogicxl: looking at 463 now...
160 2015-01-22T20:29:16 <aabs08> it was mainly inspired from https://bitbucket.org/thomaswaldmann/moin-2.0/issue/19/user-settings-are-incomplete , there was a After login, jump to last visited page
161 2015-01-22T20:29:44 <aabs08> in user setting which was not present in 2.0
162 2015-01-22T20:30:41 <aabs08> but Roger told me to directly redirect without asking the user in setting
163 2015-01-22T20:30:51 <aabs08> should I file a issue?
164 2015-01-22T20:31:50 <ThomasWaldmann> yogicxl: assuming that the user created the ticket, he should be allowed to view it (and I think via the normal view, he is allowed to view it)
165 2015-01-22T20:32:13 <ThomasWaldmann> so the question is rather what's going wrong when coming via history.
166 2015-01-22T20:34:27 <ThomasWaldmann> aabs08: that ticket is talking about other stuff. maybe create a new ticket and describe what's going wrong. then comment about how you plan to solve.
167 2015-01-22T20:39:09 <ThomasWaldmann> aabs08: thanks for documenting the solution to the login issue on codereview
168 2015-01-22T20:40:23 <yogicxl> ThomasWaldmann, actually when going from history, both fqname and revid are sent. Here revid is an id and not Keyword "CURRENT". Where as in normal show fqname is passed and revid is CURRENT.
169 2015-01-22T20:41:10 *** pjoshi_
170 2015-01-22T20:41:47 <yogicxl> ThomasWaldmann, When we go to do_show method in items/ticket.py we see if revid!=CURRENT it gives 403 message. Otherwise it passes in do_modify method
171 2015-01-22T20:43:00 <yogicxl> ThomasWaldmann, so how should I proceed?
172 2015-01-22T20:44:01 <RogerHaase> pjoshi_: you saw this error: OSError: [Errno 13] Permission denied: '/home/prakhar/.pip/pip-download-cache'
173 2015-01-22T20:44:01 <RogerHaase> (1:40:02 PM) User is not logged in
174 2015-01-22T20:48:04 *** grvanm_
175 2015-01-22T20:48:17 <ThomasWaldmann> yogicxl: is there a comment why non-current is forbidden?
176 2015-01-22T20:48:28 *** grvanm
177 2015-01-22T20:49:08 *** grvanm_
178 2015-01-22T20:49:27 <ThomasWaldmann> yogicxl: you don't ever need to run stuff as root, this might cause issues like the one RogerHaase has just pointed to
179 2015-01-22T20:49:40 *** grvanm
180 2015-01-22T20:49:42 <yogicxl> ThomasWaldmann, That is so that user can't modify previous revisons of the ticket as per the #TODO on the page.
181 2015-01-22T20:49:54 <ThomasWaldmann> ehrm, last comment was for pjoshi_
182 2015-01-22T20:50:42 <yogicxl> ThomasWaldmann, got it :0
183 2015-01-22T20:50:45 <ThomasWaldmann> yogicxl: ok, so maybe you can use same view, but you need to avoid it can be used to modify old revisions
184 2015-01-22T20:51:21 <grvanm> RogerHaase: My codereview for the bug regarding the disturbed alignment of create new ticket is here: https://codereview.appspot.com/192500043/
185 2015-01-22T20:51:43 <yogicxl> ThomasWaldmann, sry I didn't get you.
186 2015-01-22T20:51:53 <ThomasWaldmann> https://moinmo.in/GoogleSoc2015 <- more mentors needed
187 2015-01-22T20:52:13 <ThomasWaldmann> yogicxl: instead of abort 403 rather readonly = True
188 2015-01-22T20:52:32 <grvanm> RogerHaase: I fixed the css for the page , can you please review , it , now it shows the form in correct alignment in all resolutions , earlier it got disturbed after 720p as in greater resolution .
189 2015-01-22T20:52:38 <ThomasWaldmann> (not sure how easy that'll be, so better check it :)
190 2015-01-22T20:53:31 <yogicxl> ThomasWaldmann, ok no problem, I ll check out.
191 2015-01-22T20:53:44 <ThomasWaldmann> ananasova: dreimark: eSyr: RogerHaase: SteveMcIntyre: sunu: waldi: xiaq: xorAxAx: ^^ (2 mins ago)
192 2015-01-22T20:58:55 <yogicxl> ThomasWaldmann, So I think I need to create a read-only view for tickets, right?
193 2015-01-22T20:59:04 <waldi> yeag
194 2015-01-22T20:59:04 <RogerHaase> grvanm: showing the metadata to the right of the comment area on large display screens was intended as a feature (maybe not a great feature if it is confusing)
195 2015-01-22T21:00:32 <grvanm> RogerHaase: But then the display looks odd as there is a great soace between the comment area and the submit button below .
196 2015-01-22T21:00:41 <grvanm> *soace-space
197 2015-01-22T21:01:49 <ThomasWaldmann> yogicxl: yes, somehow
198 2015-01-22T21:01:53 *** gaurav_
199 2015-01-22T21:02:09 * ThomasWaldmann twittered about moin needing more mentors for gsoc2015
200 2015-01-22T21:11:22 <aabs08> ThomasWaldmann, any ideas where should I change the code to add 'next' variable in url ?
201 2015-01-22T21:12:51 *** dave_largo
202 2015-01-22T21:15:07 <RogerHaase> grvanm: well... space is not that large. You may have a better argument if you point out that pasting a traceback into that textarea has an ugly result.
203 2015-01-22T21:17:09 <RogerHaase> grvanm: did you try adding text to your solution? Seems metadata overlays the text.
204 2015-01-22T21:18:51 *** vikramahuja1001
205 2015-01-22T21:20:56 <aabs08> ThomasWaldmann, should I append that the string 'next' in layout.html because I cannot think of doing it in frontend/views.py
206 2015-01-22T21:24:29 *** grvanm
207 2015-01-22T21:31:59 *** vikramahuja1001
208 2015-01-22T21:35:05 *** pjoshi_
209 2015-01-22T21:36:00 *** pjoshi_
210 2015-01-22T21:43:51 *** yogicxl
211 2015-01-22T21:50:06 <ThomasWaldmann> aabs08: usually url_for(..., next=...)
212 2015-01-22T21:50:39 <ThomasWaldmann> ^ query string. or a form field if it shall be in the post data.
213 2015-01-22T21:51:10 <aabs08> but where should I write it ?
214 2015-01-22T21:51:47 <ThomasWaldmann> in the view where you want to return to
215 2015-01-22T21:52:01 <aabs08> views.py?
216 2015-01-22T21:52:28 <ThomasWaldmann> look where the login link gets generated
217 2015-01-22T21:52:36 <ThomasWaldmann> likely in some theme template
218 2015-01-22T21:52:39 <aabs08> its in layout.html
219 2015-01-22T21:53:22 <aabs08> line 175 : {{ hyperlink(login_url, None, True, _('Login'), None, None) }}
220 2015-01-22T21:53:59 <aabs08> should i change this to < a href= url_for(..., next=...) > Login </a>
221 2015-01-22T21:54:29 <ThomasWaldmann> look what hyperlink does
222 2015-01-22T21:54:41 <aabs08> its a macro
223 2015-01-22T21:54:54 <aabs08> which does not take string queries
224 2015-01-22T21:55:14 <aabs08> macro hyperlink(href, title, exists, label, iconcls, mainclass)
225 2015-01-22T21:56:08 *** pjoshi_
226 2015-01-22T21:56:16 *** pjoshi_
227 2015-01-22T21:56:24 *** yogicxl
228 2015-01-22T21:56:54 <aabs08> the layout.html is in MoinMoin/themes/basic/templates
229 2015-01-22T21:56:59 <gaurav_> RogerHaase, yeah i found out the problem in my solution , the metadata is overlaying the text , Thanks :)
230 2015-01-22T21:57:24 <ThomasWaldmann> aabs08: MoinMoin.themes.login_url
231 2015-01-22T21:59:11 <aabs08> I thought we got login url link through theme_supp.login_url()?
232 2015-01-22T22:00:13 <ThomasWaldmann> https://www.youtube.com/watch?v=6uvQTTPr9Rw lol
233 2015-01-22T22:00:37 <ThomasWaldmann> aabs08: yes, that's the same
234 2015-01-22T22:01:50 <RogerHaase> gaurav_: you may want to try making the textarea wider. Pasting tracebacks is a common requirement. So then the metadata would float up when the display width is ~1600+
235 2015-01-22T22:01:55 <aabs08> a possible solution will be to convert macro hyperlink to manual <a href= {{ url_for(..., next=...) }} > Login</a>
236 2015-01-22T22:03:19 <aabs08> ThomasWaldmann, for that video :D :D :D
237 2015-01-22T22:04:58 <aabs08> ThomasWaldmann, thanx got it how to use with hyperlink
238 2015-01-22T22:05:21 <aabs08> it was used in logout also :P
239 2015-01-22T22:05:35 <aabs08> {{ hyperlink(url_for('frontend.logout', logout_submit=1), None, True,
240 2015-01-22T22:05:40 <aabs08> _('Logout'), "fa fa-sign-out fa-inverse", None) }}
241 2015-01-22T22:06:57 *** pjoshi_
242 2015-01-22T22:11:24 *** gaurav_
243 2015-01-22T22:11:41 * ThomasWaldmann gtg / bbl
244 2015-01-22T22:11:49 *** grvanm
245 2015-01-22T22:12:26 <aabs08> ThomasWaldmann, bye thanx a lot for your help :)
246 2015-01-22T22:12:41 <grvanm> RogerHaase, Sorry i logged on last time with different nickname gaurav_ , this is my commonly used nickname :)
247 2015-01-22T22:16:24 <RogerHaase> grvanm: np, open an issue for what you want to fix on the ticket create. Easier to find ideas and comments there rather than in chat log
248 2015-01-22T22:16:33 <RogerHaase> gtg
249 2015-01-22T22:16:39 *** RogerHaase
250 2015-01-22T22:17:58 *** pjoshi_
251 2015-01-22T22:18:48 <pjoshi_> The files MoinMoin/themes/modernized/static/css/stylus/normalize.css are not added when I am uploading my work for review
252 2015-01-22T22:18:56 <pjoshi_> Some one help me ?
253 2015-01-22T22:24:25 *** pjoshi_
254 2015-01-22T23:04:31 *** aabs08
255 2015-01-22T23:06:43 *** grvanm
256
