1 2015-03-07T00:56:34 *** dumindux
2 2015-03-07T01:03:00 *** aarjay
3 2015-03-07T04:12:11 *** karan
4 2015-03-07T04:12:20 <karan> Hi, I am using windows, I have cloned moin 2.0 bitbucket repository to my machine. I set up he moin on my machine. But how to run the moin ? There is no wikiserver.py file in my directory. Please help.
5 2015-03-07T04:22:38 *** AayushRanaut
6 2015-03-07T04:35:16 *** karan
7 2015-03-07T04:39:40 *** vipul20
8 2015-03-07T05:12:05 *** tonythomas
9 2015-03-07T05:39:40 *** pjoshi
10 2015-03-07T05:40:37 <pjoshi> Moin
11 2015-03-07T06:59:40 *** psd
12 2015-03-07T07:02:56 <pjoshi> ThomasWaldmann: please review this https://codereview.appspot.com/212150043/patch/1/10001
13 2015-03-07T07:04:38 <pjoshi> ThomasWaldmann: There are some problems in uploading as by mistake I committed it first and then tried to upload it for codereview so it shows error in uploading so I just added the previous code in comments and just removed the dependencies of different views
14 2015-03-07T08:01:57 *** aarjay
15 2015-03-07T08:17:26 *** aarjay
16 2015-03-07T08:53:44 *** grvanm
17 2015-03-07T09:10:34 *** pjoshi
18 2015-03-07T09:18:28 *** grvanm
19 2015-03-07T09:29:32 *** greg_f
20 2015-03-07T09:34:22 *** grvanm
21 2015-03-07T09:40:59 *** grvanm
22 2015-03-07T09:53:43 *** grvanm
23 2015-03-07T10:00:42 *** pjoshi
24 2015-03-07T10:15:41 *** pjoshi
25 2015-03-07T12:14:34 *** tonythomas
26 2015-03-07T12:20:50 *** bond007
27 2015-03-07T12:54:33 *** aabs08
28 2015-03-07T13:48:42 *** tonythomas
29 2015-03-07T14:21:31 *** aabs08
30 2015-03-07T14:30:47 *** pjoshi
31 2015-03-07T14:31:40 <pjoshi> ThomasWaldmann: Please review this https://codereview.appspot.com/212150043/patch/1/10001
32 2015-03-07T14:32:51 <pjoshi> ThomasWaldmann: There was just a slide mistake that I commit the code and then tried to applied for code review so didn't get it right way so I just commented the old code and put the right code under the function
33 2015-03-07T14:39:55 *** RogerHaase
34 2015-03-07T14:44:42 <aviraldg> RogerHaase: \o/
35 2015-03-07T14:44:52 <aviraldg> per macro config for #476?
36 2015-03-07T14:45:27 <pjoshi> RogerHaase: I got the error for that access denied on ticket hostory
37 2015-03-07T14:45:45 <pjoshi> RogerHaase: https://codereview.appspot.com/212150043/patch/1/10001 Please review that
38 2015-03-07T14:46:37 <pjoshi> RogerHaase: The commented code was the previous code. There are some problem in uploading as I committed first and now uploading
39 2015-03-07T14:46:45 <pjoshi> *uploaded
40 2015-03-07T14:51:03 <RogerHaase> aviraldg: I did not look at the code much, but it seems like the argument parsing should be left to the individual macro's needs. Footnote needs to parse the string for markup. In 1.9, even a one-line table within a footnote seems valid.
41 2015-03-07T14:52:35 <aviraldg> Also about the logout issue -- I wasn't able to explain it as clearly as I'd like to yesterday. Doesn't transcluding that on the homepage prevent you from logging in?
42 2015-03-07T14:57:01 <tonythomas> RogerHaase: continuing with yesterdays issue ( missing of moin.wsgi on 2.0 branch ), I created a new wiki with ./m new-wiki - here is the log https://dpaste.de/vL5p - but see that wiki folder which got created have only two folders - data, index - and no occurrence of a wsgi file.
43 2015-03-07T14:57:18 <tonythomas> shouldn't the new wiki have its own wsgi file ?
44 2015-03-07T15:00:30 <RogerHaase> pjoshi: done
45 2015-03-07T15:02:06 <pjoshi> RogerHaase: But I have also created one pull request that is still not mergerd
46 2015-03-07T15:02:13 <pjoshi> that will also get deleted
47 2015-03-07T15:04:17 <RogerHaase> pjoshi: you can create a new local repo and then pull from your public repo (or just create a new clone from your public repo)
48 2015-03-07T15:05:14 <pjoshi> RogerHaase: Okay will do that. Thanks :)
49 2015-03-07T15:05:41 <RogerHaase> I edited my /.hg/hgrc to look like:
50 2015-03-07T15:05:47 <RogerHaase> [paths]
51 2015-03-07T15:05:47 <RogerHaase> default = https://RogerHaase@bitbucket.org/thomaswaldmann/moin-2.0
52 2015-03-07T15:05:47 <RogerHaase> my_bitbucket = https://RogerHaase@bitbucket.org/RogerHaase/moin-2.0
53 2015-03-07T15:06:30 <RogerHaase> so I can do "hg pull -u" or "hg pull -u my_bitbucket"
54 2015-03-07T15:07:01 <pjoshi> Ah.. great. Will also do that
55 2015-03-07T15:07:29 <pjoshi> So that I don't have to clone again if I again messed up with the repo
56 2015-03-07T15:09:20 <aviraldg> RogerHaase: ?
57 2015-03-07T15:10:29 <RogerHaase> tonythomas: probably not, it is more likely the wsgi file will be in the repo root. But if you set the paths, you could probably put the wsgi file anywhere
58 2015-03-07T15:11:24 *** aabs08
59 2015-03-07T15:11:42 * aabs08 Moin to everybody :)
60 2015-03-07T15:14:24 <aabs08> RogerHaase, only issue #499, codereview : https://codereview.appspot.com/208570043
61 2015-03-07T15:14:37 <RogerHaase> aviraldg: if the ? is about the logout transclusion, I would say no bug, if the user wants to do something weird, he should get weird results
62 2015-03-07T15:15:16 <aviraldg> But then it works for all users (afaik), not just the user who created the link.
63 2015-03-07T15:16:16 <tonythomas> RogerHaase: okey - 'set paths' in the sense - environment variables ? or path in apache config ?
64 2015-03-07T15:18:38 *** pjoshi
65 2015-03-07T15:18:43 <RogerHaase> aviraldg: hmm, OK, you are claiming it is a security issue, where a vandal could set a transclusion on a page and log every else out? That soulds reasonable, add it to your issue report
66 2015-03-07T15:19:10 <aviraldg> Yep. In general, it's a bad idea to allow GET requests to alter state.
67 2015-03-07T15:19:20 *** bond007_
68 2015-03-07T15:20:52 *** bond007
69 2015-03-07T15:22:15 <RogerHaase> tonythomas: apache config has to point to wsgi file, paths in wsgi file have to point to moin code
70 2015-03-07T15:25:52 <tonythomas> RogerHaase: oeky - I will try to find out where the wsgi file is being kept
71 2015-03-07T15:27:09 <RogerHaase> tonythomas: I agree /contrib/wsgi should have a sample wsgi. Looks like it is missing. If you get it working, create a CR to add it
72 2015-03-07T15:27:45 <aabs08> RogerHaase, just to confirm , for adding time to view diff , you wanted me to create a macro to display all the information of a revision in utils.html and then this macro will be called in diff_text_atom.html , atom.html and diff_text.html ?
73 2015-03-07T15:27:48 <tonythomas> RogerHaase: okey. I will try that one. Now cloning moin1-9 to see how its implemented over there
74 2015-03-07T15:30:01 <RogerHaase> aabs08: yes, anytime you can improve moin and delete more code than you add, you get extra points
75 2015-03-07T15:30:30 <aabs08> RogerHaase, and how to view atom.html's and diff_text_atom output ? from my understanding they are related to feed .
76 2015-03-07T15:33:30 <RogerHaase> aabs08: it is broken, see #411 and #308
77 2015-03-07T15:36:06 <aabs08> RogerHaase, Thanx :D
78 2015-03-07T15:43:33 <vipul20> Hello RogerHaase, can you please review this fix for #249 https://codereview.appspot.com/213780043/
79 2015-03-07T15:51:35 *** bond007_
80 2015-03-07T16:05:00 <RogerHaase> aabs08: done with review
81 2015-03-07T16:11:27 <aabs08> RogerHaase, thanx :D
82 2015-03-07T16:13:02 <aabs08> I noticed creating new clone , makes ./m tests fail in a lot of cases .
83 2015-03-07T16:15:19 <aabs08> I got 91 failed, 208 passed, 11 skipped, 88 error in 7.90 seconds for my second clone.
84 2015-03-07T16:16:48 <aabs08> RogerHaase, got it Issue #429 .
85 2015-03-07T16:17:47 <aabs08> Sorry it was related to ./m sample .
86 2015-03-07T16:18:41 <aabs08> RogerHaase, has a bug been filed for that ?
87 2015-03-07T16:22:14 <tonythomas> aabs08: I too saw that one
88 2015-03-07T16:23:44 <RogerHaase> vipul20: done with review
89 2015-03-07T16:31:04 <aviraldg> RogerHaase: What's your opinion on #16? Should I try and contribute the lexers to Pygments, or keep them in our codebase?
90 2015-03-07T16:36:10 <RogerHaase> aviraldg: try contributing to pygments, wait a day to see response, then if no response put in our codebase, add comments to issue saying waiting for pygments
91 2015-03-07T16:36:59 <aviraldg> And is #505 worth implementing in your opinion?
92 2015-03-07T16:37:58 *** pjoshi
93 2015-03-07T16:41:45 <RogerHaase> vipul20: I missed spaces around =; before submitting stuff for CR it is best to to ./m coding-std and ./m tests - there is also broken test in history
94 2015-03-07T16:42:21 <aabs08> RogerHaase, how do you run tests on second clone ?
95 2015-03-07T16:42:49 <RogerHaase> cd to second clone, ./m tests
96 2015-03-07T16:43:20 <aabs08> I second clone gives 1779 ============= 91 failed, 1488 passed, 68 skipped in 221.29 seconds =============
97 2015-03-07T16:43:56 <aabs08> tests do not pass.
98 2015-03-07T16:44:39 *** bond007
99 2015-03-07T16:45:01 <aabs08> RogerHaase, as far as I and tonythomas are concerned our 2nd clone fails a lot of cases.
100 2015-03-07T16:46:21 <pjoshi> I guess there are 91 failing cases and need to be fixed even I got these much failing cases with the cloned code
101 2015-03-07T16:47:41 <RogerHaase> it is #492, the fix is in my repo, but ThomasWaldmann has not pulled it into main yet. See workaround in #492
102 2015-03-07T16:50:32 <aabs08> My pep8 is 1.5.7 but I still face it.
103 2015-03-07T16:53:00 <RogerHaase> aabs08: post m-pytest.txt; I just reran quickinstall and do not see errors (but I have patch for bug)
104 2015-03-07T16:55:12 <aabs08> probably i did not activate the the virtual environment , trying after activing it.
105 2015-03-07T16:56:15 <RogerHaase> aviraldg: cannot tell from 505 issue, where is dropdown and what will be in shown in dropdown? For a wiki with 1000 pages, how big will dropdown be? How is dropdown better than tags?
106 2015-03-07T16:56:57 *** aabs08
107 2015-03-07T16:57:15 *** aabs08
108 2015-03-07T16:59:25 <RogerHaase> aabs08: I rarely have a need to activate environment, as ./m xxxx does it when required - see make.py
109 2015-03-07T16:59:30 <aviraldg> RogerHaase: Wherever applicable. In this case, search fields. I'll make the size configurable. Incidentally, this is one of the other ideas on the GSOC idea page.
110 2015-03-07T17:01:38 <aviraldg> https://moinmo.in/GoogleSoc2015/InitialProjectIdeas#line-246
111 2015-03-07T17:04:49 <aabs08> RogerHaase, m-pytest.txt http://pastebin.com/QkyNhZfq
112 2015-03-07T17:05:10 <vipul20> RogerHaase: how can we add a clue for the user that there's more history when item id is clicked ? any suggestion ?
113 2015-03-07T17:05:55 <pjoshi> RogerHaase: https://bitbucket.org/thomaswaldmann/moin-2.0/src/ac10a2e3eaf61e3e3a97bf66b832026f62909ccc/MoinMoin/items/ticket.py?at=default on line 169 the do_show fuch
114 2015-03-07T17:05:59 <pjoshi> *fuction
115 2015-03-07T17:06:03 <pjoshi> *function
116 2015-03-07T17:06:27 <pjoshi> do we need different views for different versions
117 2015-03-07T17:06:27 <pjoshi> ?
118 2015-03-07T17:07:10 <RogerHaase> aviraldg: this line? Implement jquery_ui autocomplete on all textfields where it makes sense. e.g. search, widget to select tags
119 2015-03-07T17:07:22 <pjoshi> as in url already we have the revid so I guess it will be enough for differentiating between current and old versions ?
120 2015-03-07T17:10:12 <RogerHaase> pjoshi: for history.html, either fix in 2 places or contribute to https://bitbucket.org/thomaswaldmann/moin-2.0/issue/471/merge-most-basic-theme-templates-into
121 2015-03-07T17:11:17 <aabs08> RogerHaase, sorry suddenly my pep8 version changed to 1.6.2 i donot what happened probably different folders have different pep8 version .
122 2015-03-07T17:12:06 <aabs08> RogerHaase, your workaround works sorry for the inconvenience.
123 2015-03-07T17:13:09 <pjoshi> RogerHaase: Which 2 places ?
124 2015-03-07T17:13:57 <RogerHaase> aabs08: if you create a new clone or run ./m quickinstall, the virtualenv is updated with the latest versions subject to setup.py
125 2015-03-07T17:14:13 <aviraldg> RogerHaase: yep
126 2015-03-07T17:14:45 <pjoshi> RogerHaase: the access denied is due to the abort(403) in the do_show function, right ?
127 2015-03-07T17:14:46 <RogerHaase> pjoshi: templates/history.html and themes/basic/templates/history.html
128 2015-03-07T17:16:07 <RogerHaase> pjoshi: dk
129 2015-03-07T17:17:31 <pjoshi> RogerHaase: Okay one more thing as I asked before also does it required apply condition on revid != CURRENT as we include revid in the url so it doesn't matter if it is current or previous
130 2015-03-07T17:19:00 <pjoshi> RogerHaase: I started from those templates only and I just reached there as I guess other things looks okay other than that function (do_show) .
131 2015-03-07T17:21:30 <aabs08> RogerHaase, cr issue #499 https://codereview.appspot.com/208570043/
132 2015-03-07T17:25:44 <aabs08> RogerHaase, if you are not satisfied with the comments again do tell how to write them ?
133 2015-03-07T17:27:19 *** dumindux
134 2015-03-07T17:29:23 <RogerHaase> pjoshi: best answer is dk; per comments there - if we are showing user a non-current revision, we do not want user to have a modify link. Hopefully there is a better way to do that than 403.
135 2015-03-07T17:57:32 *** grvanm
136 2015-03-07T18:10:22 *** grvanm
137 2015-03-07T18:15:30 <aabs08> RogerHaase, issue #499 and #503 , codereviews https://codereview.appspot.com/208570043/ and https://codereview.appspot.com/209360043 .
138 2015-03-07T18:17:27 <aabs08> RogerHaase, aiming for some extra points with that cr :D
139 2015-03-07T18:20:35 *** faizansayed
140 2015-03-07T18:22:49 *** pjoshi
141 2015-03-07T18:23:32 *** pjoshi
142 2015-03-07T18:35:49 *** grvanm
143 2015-03-07T18:51:19 <aabs08> RogerHaase, sorry http://127.0.0.1:8080/+tickets?assigned_to=username&&selected_tags has nothing to do with the user
144 2015-03-07T18:52:00 <aabs08> It keeps the backend in good shape to work for future changes will remove the case .
145 2015-03-07T18:52:21 <aabs08> *case - comment
146 2015-03-07T18:54:53 <aabs08> probably writing http://127.0.0.1:8080/+tickets?assigned_to=username is more sensible
147 2015-03-07T18:55:19 <aabs08> as its the link given to each assignee in the ticket table to view all the tickets in name of him .
148 2015-03-07T18:56:47 *** greg_f
149 2015-03-07T18:57:16 <RogerHaase> aabs08: yes, that is what I saw, was trying to first click username, then tags; then tried tags followed by user name; but could not get the link in comments
150 2015-03-07T19:01:33 <pjoshi> RogerHaase: Is it okay to just show meta data for revised versions ?
151 2015-03-07T19:05:15 <RogerHaase> pjoshi: not sure what you mean
152 2015-03-07T19:05:38 *** grvanm
153 2015-03-07T19:06:49 <pjoshi> RogerHaase: I mean to say that can we just show the raw data(in plain/text form) for the revised versions ?
154 2015-03-07T19:08:50 <RogerHaase> pjoshi: are you taking the meta link from item history or some other view?
155 2015-03-07T19:10:16 <pjoshi> RogerHaase: I was thinking of calling the indexable function(from views) instead of show_item(from views) function in the url (history.html)
156 2015-03-07T19:12:49 <RogerHaase> pjoshi: fastest way to discuss that is to do CR with some comments (there is a lot of code and no one knows it all)
157 2015-03-07T19:18:00 <aabs08> RogerHaase, issue #499 and #503 , codereviews https://codereview.appspot.com/208570043/ and https://codereview.appspot.com/209360043 .
158 2015-03-07T19:18:45 <aabs08> Sorry for making some useless patches for #503 , did few typos in comments .
159 2015-03-07T19:18:49 *** faizansayed
160 2015-03-07T19:23:36 <pjoshi> RogerHaase: https://codereview.appspot.com/207500043/patch/1/10001
161 2015-03-07T19:23:40 <pjoshi> have a look at the CR
162 2015-03-07T19:24:24 <pjoshi> this will show the data in plain/text form
163 2015-03-07T19:28:33 * aabs08 is saying good bye to all and is thanking RogerHaase for very quick codereviews.
164 2015-03-07T19:29:13 *** aabs08
165 2015-03-07T19:29:13 <RogerHaase> aabs08: gn
166 2015-03-07T19:37:48 <pjoshi> RogerHaase: Or the other option seems to be we have to write a new function similar to show_item which only shows the item and user can't modify that
167 2015-03-07T19:42:22 <pjoshi> RogerHaase: I think we should not go for that indexable function way as its too ugly to suddenly see a plain/text data for revised version
168 2015-03-07T19:42:22 <pjoshi> :P
169 2015-03-07T19:44:35 <RogerHaase> pjoshi: agree, review done
170 2015-03-07T19:45:25 <pjoshi> RogerHaase: Any suggestions ?
171 2015-03-07T19:46:02 <RogerHaase> pjoshi: maybe on show view the Modify link could be changed to Revert To This Revision link
172 2015-03-07T19:48:09 <pjoshi> RogerHaase: Okay. Lets try that
173 2015-03-07T19:49:19 <pjoshi> RogerHaase: actually its not the issue with views, its issue with ticket.py as there we have the do_show() function
174 2015-03-07T19:57:41 <pjoshi> RogerHaase: What is the command to upload the code on the old CR ?
175 2015-03-07T20:02:43 <pjoshi> RogerHaase: Okay Please review this https://codereview.appspot.com/207510043/patch/1/10001
176 2015-03-07T20:04:58 *** bond007
177 2015-03-07T20:33:51 *** reyha
178 2015-03-07T20:53:44 *** aarjay
179 2015-03-07T21:25:58 *** pjoshi
180 2015-03-07T22:00:54 *** RogerHaase
181 2015-03-07T22:34:35 *** tonythomas
182 2015-03-07T23:14:24 *** grvanm
183
