1 2015-06-30T00:01:47 *** yask
2 2015-06-30T02:14:40 *** ponyofdeath
3 2015-06-30T04:53:03 *** yask
4 2015-06-30T07:55:37 *** greg_f
5 2015-06-30T12:41:02 *** dave_largo
6 2015-06-30T14:31:47 *** yask
7 2015-06-30T14:48:39 *** skathpalia
8 2015-06-30T14:53:49 *** skathpalia
9 2015-06-30T14:55:08 *** skathpalia
10 2015-06-30T14:58:39 *** skathpalia
11 2015-06-30T15:01:17 *** skathpalia
12 2015-06-30T15:03:06 *** randomax
13 2015-06-30T15:08:28 *** randomax
14 2015-06-30T15:11:36 *** randomax
15 2015-06-30T15:15:20 *** yask
16 2015-06-30T15:20:20 *** randomax
17 2015-06-30T15:20:38 *** randomax
18 2015-06-30T15:27:15 <yask> CR: https://codereview.appspot.com/245670043/ :) randomax skathpalia
19 2015-06-30T15:51:24 <ThomasWaldmann> yask: vipul20: btw, maybe it's a good idea to have a list of not-committed-to repo and still open CRs on your wiki homepage
20 2015-06-30T15:52:07 <ThomasWaldmann> meeting in 8 minutes, btw
21 2015-06-30T15:52:22 *** randomax
22 2015-06-30T15:52:59 <ThomasWaldmann> randomax: skathpalia: waldi: yask: vipul20: ^^
23 2015-06-30T15:53:52 <yask> Okkey!
24 2015-06-30T15:54:34 <ThomasWaldmann> (easier than to wade through irc logs)
25 2015-06-30T15:59:50 <waldi> .
26 2015-06-30T16:00:24 <ThomasWaldmann> so, who's here?
27 2015-06-30T16:00:47 <vipul20> moin
28 2015-06-30T16:00:49 <yask> moin
29 2015-06-30T16:01:01 *** randomax
30 2015-06-30T16:01:11 <ThomasWaldmann> skathpalia: ?
31 2015-06-30T16:01:39 <skathpalia> moin :)
32 2015-06-30T16:02:10 <ThomasWaldmann> ok, looks like we are complete. so, welcome to our weekly meeting, at mid-term time.
33 2015-06-30T16:02:28 <ThomasWaldmann> yask: can you begin?
34 2015-06-30T16:02:36 <yask> sure
35 2015-06-30T16:03:01 <yask> "DONE:
36 2015-06-30T16:03:01 <yask> Previous CR reviewed, code committed after resolving all the issues.
37 2015-06-30T16:03:01 <yask> CR #2: (Review pending)
38 2015-06-30T16:03:01 <yask> ChangeLog
39 2015-06-30T16:03:01 <yask> # Uses latest xstatic, bootstrap version: 3.3.5.1
40 2015-06-30T16:03:01 <yask> # Fix for footer jump. Now footer won't jump in any page ( Even when the content is null).
41 2015-06-30T16:03:01 <yask> # User setting forms rewritten in bootstrap form design fashion (without <td> <tl> tags) to suit the current design of theme.
42 2015-06-30T16:03:02 <yask> # Macros in forms.html changed for compatibility reasons (as their is no requirement of labels and input box to be in <td>.. tags.
43 2015-06-30T16:03:02 <yask> # written css rules in theme.less to override default styling of tables written in `common.css`.
44 2015-06-30T16:03:03 <yask> # minor changes in footer.
45 2015-06-30T16:03:03 <yask> # Various style improvements
46 2015-06-30T16:03:04 <yask> Changelog2:
47 2015-06-30T16:03:04 <yask> #fixed overlay issues afer reducing table width to ~900 pixels and clicking on the hamburger thing
48 2015-06-30T16:03:05 <yask> BLOCKERS:
49 2015-06-30T16:04:02 <ThomasWaldmann> yask: that changelog corresponds to...?
50 2015-06-30T16:04:18 <ThomasWaldmann> one CR?
51 2015-06-30T16:04:26 <yask> this CR: https://codereview.appspot.com/245670043/
52 2015-06-30T16:04:57 <ThomasWaldmann> ok, then i want to suggest that we try to have "clean commits" (and clean CRs)
53 2015-06-30T16:05:14 <ThomasWaldmann> focus on one topic, CR, commit, next topic
54 2015-06-30T16:05:41 <ThomasWaldmann> (not mixing a lot of stuff into one CR / one commit)
55 2015-06-30T16:06:15 <ThomasWaldmann> resist scope creep :D
56 2015-06-30T16:06:34 <yask> okkey! but sometimes CR takes more time than expected , and I tend to move on to next task while one thing gets reviewed (without committing ) ..
57 2015-06-30T16:07:10 <ThomasWaldmann> you can still work on multiple things, but keep them separate
58 2015-06-30T16:07:17 <yask> Okkey!
59 2015-06-30T16:08:26 <ThomasWaldmann> (i noticed same thing for your first commits also, so just try from now on)
60 2015-06-30T16:08:45 <ThomasWaldmann> might make CRs more quick and less painful
61 2015-06-30T16:09:06 <yask> Yea , it happened before as well. From now on I'll focus on cleaner CRs.
62 2015-06-30T16:09:22 <ThomasWaldmann> waldi: skathpalia: any feedback from you?
63 2015-06-30T16:09:40 <skathpalia> No :)
64 2015-06-30T16:09:42 <ThomasWaldmann> and randomax
65 2015-06-30T16:11:27 <ThomasWaldmann> waldi: randomax: ^
66 2015-06-30T16:11:38 <waldi> yask: no blockers at all?
67 2015-06-30T16:13:30 <ThomasWaldmann> yask: IIRC, you talked to Roger. Do you both now agree on what to do with / without bootstrap?
68 2015-06-30T16:13:51 <ThomasWaldmann> (so you don't work in conflicting directions)
69 2015-06-30T16:14:07 <yask> Yes that issue was resolved after talking to him
70 2015-06-30T16:14:33 <ThomasWaldmann> 18:11 waldi$ yask: no blockers at all?
71 2015-06-30T16:14:58 <waldi> yask: what was the agreement about this matter?
72 2015-06-30T16:15:17 <yask> waldi: Ah! I wrote the current unresolved stuff in todo by mistake "Todo: Also on some unresolved issues I have opened up here: https://bitbucket.org/yask123/moin-2.0/issues?status=new&status=open"
73 2015-06-30T16:15:51 <yask> waldi: the agreement was to make exclusive templates for bootstrap themes
74 2015-06-30T16:16:01 <waldi> okay
75 2015-06-30T16:16:17 <yask> *so that another theme developer isn't forced to use bootstrap
76 2015-06-30T16:16:23 <ThomasWaldmann> yask: usage of issue tracker is appreciated
77 2015-06-30T16:16:40 <yask> :)
78 2015-06-30T16:18:05 <ThomasWaldmann> yask: another thing: did you review your original schedule/plan and what would you say about whether you are on schedule or behind?
79 2015-06-30T16:18:56 <yask> yes I did , I am on schedule.
80 2015-06-30T16:20:07 <ThomasWaldmann> (only committed stuff is "done" for that matter, imho)
81 2015-06-30T16:21:12 <yask> I agree , but that CR is pending for a while and that was what I worked on last week.
82 2015-06-30T16:21:57 <waldi> then we are at the same point: they are too large
83 2015-06-30T16:22:33 <ThomasWaldmann> i do not see any mentor comment on the last CR
84 2015-06-30T16:22:34 <yask> yea!..I'll make it cleaner by splitting up .
85 2015-06-30T16:23:57 <yask> yea , there isn't. :/ . randomax and Roger Hasse mostly review my CR and both were busy this week I guess.
86 2015-06-30T16:25:01 <ThomasWaldmann> roger's feedback is very important and useful, but formally, of course your mentors should also give feedback. you have 3 of them.
87 2015-06-30T16:25:52 <ThomasWaldmann> but let's see whether the smaller/cleaner CRs work better.
88 2015-06-30T16:26:11 <yask> yea!
89 2015-06-30T16:26:29 <ThomasWaldmann> single topic, resist changing other stuff even if you find it. you can file an issue to not forget instead of fixing it right away.
90 2015-06-30T16:26:46 <yask> Got it!
91 2015-06-30T16:27:15 <waldi> or provide a separate patch on top of the still pending ones
92 2015-06-30T16:27:18 <ThomasWaldmann> waldi: randomax: skathpalia: please review that CR today, if possible. https://codereview.appspot.com/245670043/
93 2015-06-30T16:27:41 <skathpalia> Ok will try to do it
94 2015-06-30T16:29:45 <ThomasWaldmann> ok, guess we are through. thanks yask and mentors! vipul20, your stage.
95 2015-06-30T16:29:54 <vipul20> DONE: fixed the previous code and commit-pushed in the repo
96 2015-06-30T16:29:54 <vipul20> TODO/working on: Comments feature: create comments as items which will refer to a particular ticket
97 2015-06-30T16:29:54 <vipul20> BLOCKERS: Implementation of comment as an item (as suggested, I am trying to implement the workaround: to create a named item and then remove the name, something like implemented in ticket create view. Will update if it works or if get stuck
98 2015-06-30T16:29:54 <vipul20> CRs:
99 2015-06-30T16:29:54 <vipul20> https://codereview.appspot.com/246020043/ (file upload: added TODO)
100 2015-06-30T16:29:54 <vipul20> https://codereview.appspot.com/248280043/ (new field, do we need it) ?
101 2015-06-30T16:30:55 <skathpalia> vipul20, I think you can make pull request also to main repo
102 2015-06-30T16:32:09 <vipul20> yes I wanted to ask if I should make PRs after each commit or can I issue PR after making 1-2 commits
103 2015-06-30T16:32:36 <vipul20> if I make PR now it will include commits of ticket suggestion and UI improvements
104 2015-06-30T16:32:42 <ThomasWaldmann> https://codereview.appspot.com/248280043/ about that, i think the answer is "no", see my comment there. other opinions?
105 2015-06-30T16:33:05 <vipul20> ThomasWaldmann: yes I also felt the same
106 2015-06-30T16:33:09 <skathpalia> Just make one Pull Request and update that PR only
107 2015-06-30T16:33:24 <vipul20> ok
108 2015-06-30T16:33:53 <skathpalia> When you add a commit to an existing PR, just update the description of CR
109 2015-06-30T16:33:54 <skathpalia> *PR
110 2015-06-30T16:33:58 <ThomasWaldmann> as long as all commits in a PR (updated PR) are acceptable, no problem. problems come if that is not the case.
111 2015-06-30T16:34:39 <vipul20> ok, got it
112 2015-06-30T16:36:22 <skathpalia> Its good that you are working on some UI work in the mean time :)
113 2015-06-30T16:36:58 <vipul20> yes I was suggested that until the CR gets reviewed, I should work on UI in the mean time
114 2015-06-30T16:36:58 <ThomasWaldmann> btw, aside from refers_to to create a relationship between all comments, uploads and their main ticket item, I guess you'll also need some of reply_to later to make threaded comments.
115 2015-06-30T16:37:29 <ThomasWaldmann> UI needs a lot of work, indeed.
116 2015-06-30T16:38:11 <ThomasWaldmann> the suggestions for other tickets it has found should be declared as such, currently they just appear and one wonders what they are.
117 2015-06-30T16:39:02 <ThomasWaldmann> there's also a bug in tags functionality: tags are semantically a set, one specific tag can only appear once in there.
118 2015-06-30T16:39:40 <ThomasWaldmann> but if you click one tag multiple times, it just gets appended to the list.
119 2015-06-30T16:40:00 <vipul20> one can even type multiple times the same tag
120 2015-06-30T16:40:56 <ThomasWaldmann> yes, that also, but that is harder to avoid
121 2015-06-30T16:41:41 <ThomasWaldmann> also, tags are labelled as "suggested tags" - why are they "suggested". is is just "available tags"?
122 2015-06-30T16:42:29 <vipul20> it was already created earlier
123 2015-06-30T16:42:42 <vipul20> it is essentially "available tags"
124 2015-06-30T16:42:55 <ThomasWaldmann> ok, then we should change that string
125 2015-06-30T16:43:15 <vipul20> should we put a message like "tickets that may already have been created" if suggestions are available ?
126 2015-06-30T16:44:02 <vipul20> sorry not this message
127 2015-06-30T16:44:07 <ThomasWaldmann> Maybe rather something like "Do you find your issue in the list below?:"
128 2015-06-30T16:44:34 <ThomasWaldmann> or "Please check these tickets if they cover your issue:"
129 2015-06-30T16:45:05 <ThomasWaldmann> or "Do not file duplicate tickets, please check these first:"
130 2015-06-30T16:45:44 <vipul20> ok, and regarding threaded comments should it be like reddit style or like we have in bugzilla: like "reply to comment 2" or something like that ?
131 2015-06-30T16:45:44 <ThomasWaldmann> ticket is a more general word than issue
132 2015-06-30T16:46:37 <ThomasWaldmann> a threaded comments "tree" would be nice
133 2015-06-30T16:46:58 <ThomasWaldmann> but first finish the basic thing before diving into that
134 2015-06-30T16:47:31 <vipul20> yes you are right, first I should look for creating comment items in the best possible way
135 2015-06-30T16:47:51 <skathpalia> Yeah, I think you should first try to implement non-threaded comments
136 2015-06-30T16:48:04 <skathpalia> Then we can move to that threaded way
137 2015-06-30T16:48:08 <ThomasWaldmann> also try to make UI less confusing / misarranged than it is now.
138 2015-06-30T16:48:45 <vipul20> please can you suggest some improvements
139 2015-06-30T16:50:04 <ThomasWaldmann> latest repo code shows the comment entry field above the older comments. if one assumes older comments are on top, newer at bottom, the entry field should be below that.
140 2015-06-30T16:50:34 <ThomasWaldmann> because it will be the newest after submitting.
141 2015-06-30T16:50:49 <ThomasWaldmann> (just have a look how other do it, e.g. github)
142 2015-06-30T16:52:12 <vipul20> ok got it, didn't notice that, it should be below the comments
143 2015-06-30T16:52:41 <ThomasWaldmann> vipul20: about your progress and schedule, did you check current state against your plans and what would you say about whether you are on-schedule or behind?
144 2015-06-30T16:54:53 <vipul20> just waiting for the CR to be reviewed (posted earlier), rest I think I am on schedule
145 2015-06-30T16:55:10 *** greg_f
146 2015-06-30T16:56:03 <vipul20> 1 CR is now not needed to be reviewed which I will close
147 2015-06-30T16:56:37 <ThomasWaldmann> that's ongoing since 2.5 weeks, which is somehow way too loong
148 2015-06-30T16:57:51 <ThomasWaldmann> I'll have a look later today, skathpalia please do same. https://codereview.appspot.com/246020043/
149 2015-06-30T16:58:21 <skathpalia> Ok will see by tonight only
150 2015-06-30T16:58:22 <ThomasWaldmann> ok, anything else to/from vipul20 ?
151 2015-06-30T16:58:31 <skathpalia> No :)
152 2015-06-30T16:58:35 <vipul20> no :)
153 2015-06-30T16:59:26 <ThomasWaldmann> ok, then thanks for attending. hopefully we can speed up a little and get more productive in the next weeks. :)
154 2015-06-30T17:00:05 <ThomasWaldmann> vipul20: yask: you both filed your google forms, right?
155 2015-06-30T17:00:11 <vipul20> yes
156 2015-06-30T17:00:20 <yask> Yep!
157 2015-06-30T17:00:31 <ThomasWaldmann> aka midterm student evaluation (or so)
158 2015-06-30T17:00:54 <ThomasWaldmann> ok, so happy hacking.
159 2015-06-30T17:01:00 <yask> :)
160 2015-06-30T17:03:26 *** skathpalia
161 2015-06-30T17:46:24 *** randomax
162 2015-06-30T21:23:26 *** dave_largo
163 2015-06-30T22:58:56 *** Gnarlodious
164 2015-06-30T23:09:27 *** Gnarlodious
165
