1 2015-07-05T01:43:46 *** yask
2 2015-07-05T06:01:49 *** yask
3 2015-07-05T07:03:50 *** yask
4 2015-07-05T07:30:54 *** vipul20
5 2015-07-05T10:23:22 *** vipul20
6 2015-07-05T11:14:52 *** magu|_
7 2015-07-05T11:14:59 *** greg_f
8 2015-07-05T12:21:49 *** yask
9 2015-07-05T15:10:48 *** RogerHaase
10 2015-07-05T15:12:46 <RogerHaase> ThomasWaldmann: issues 369, 157, 522, 523, 524 can be closed
11 2015-07-05T15:18:04 <RogerHaase> ThomasWaldmann: fix several failing macros, fixes #532, #476, #353 https://codereview.appspot.com/254920043/
12 2015-07-05T15:18:49 <ThomasWaldmann> RogerHaase: hi. ok, closed them.
13 2015-07-05T15:19:12 <RogerHaase> moin :)
14 2015-07-05T15:19:32 <ThomasWaldmann> are these 3 related?
15 2015-07-05T15:20:57 <RogerHaase> I changed the parser re for macros, so almost all the macros needed corresponding changes
16 2015-07-05T15:22:29 <RogerHaase> the old _args_wiki.py split on spaces, most macros needed something other than that
17 2015-07-05T15:24:22 <ThomasWaldmann> i had a quick look, but i mostly see unrelated changes and a big mix of things
18 2015-07-05T15:24:56 <ThomasWaldmann> -> hard to review
19 2015-07-05T15:27:10 <RogerHaase> if you look at _args_wiki.py, then creole_in.py and moinwiki_in.py, you will see change to parser. then changes to macros and tests follow
20 2015-07-05T15:30:19 <RogerHaase> ThomasWaldmann: for example, formatting markup within footnotes was impossible when argument parser split on spaces and threw away commas
21 2015-07-05T15:31:11 <ThomasWaldmann> RogerHaase: also, does this overlap with https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/261/unicode-aware-arguments-formatted-macro/diff
22 2015-07-05T15:31:51 <ThomasWaldmann> which is still open as there are unclear parts (and I asked waldi I while ago and got no answer)
23 2015-07-05T15:33:41 <RogerHaase> ThomasWaldmann: yes, looks like overlap, will try to understand differences
24 2015-07-05T15:39:00 <ThomasWaldmann> i added my comments there, waldi. iirc last time i tried bitbucket did not let me post comments, so i tried to talk on irc to you.
25 2015-07-05T15:57:41 *** yask
26 2015-07-05T16:03:13 *** skathpalia
27 2015-07-05T16:03:18 <skathpalia> moin
28 2015-07-05T16:04:12 <skathpalia> yask, I didn't tell you to merge the CRs again
29 2015-07-05T16:04:12 <yask> moin skathpalia
30 2015-07-05T16:04:41 <skathpalia> I just asked to add the fixing of alignment to https://codereview.appspot.com/253770043/#ps1
31 2015-07-05T16:04:55 <skathpalia> But you again merged all the CRs into 1 CR
32 2015-07-05T16:06:07 <yask> The 3rd CR patch failed due to conflicting changes, so I had no option other than to merge CR (to avoid patch failing)
33 2015-07-05T16:06:40 <yask> the fix for alignment is in `layout.html` in the latest patch
34 2015-07-05T16:06:53 <yask> + the additional changes of 3rd patch
35 2015-07-05T16:07:08 <skathpalia> afaik we talked about it and the conclusion was to first get first 2 patches reviewed and then we can go to 3rd one
36 2015-07-05T16:08:12 <skathpalia> Remove the additional changes of the 3rd patch
37 2015-07-05T16:08:18 <yask> okkey!
38 2015-07-05T16:10:42 <skathpalia> Also remove all the unnecessary patches https://codereview.appspot.com/user/yask123
39 2015-07-05T16:11:02 <yask> I just thought the 2 CRs were reviewed and the only thing lacking was the "alignment thing"
40 2015-07-05T16:11:56 <skathpalia> See first CR was Ok
41 2015-07-05T16:12:06 <skathpalia> But in the second CR there was alignment issue
42 2015-07-05T16:12:51 <skathpalia> and your 2nd CR was concerned with improving global view which had alignment issue thats why I asked you to solve this alignment issue
43 2015-07-05T16:13:11 <skathpalia> I never talked about merging the 3rd CR in the process
44 2015-07-05T16:14:45 <skathpalia> We can deal with the 3d CR afterwards
45 2015-07-05T16:23:22 *** vipul20
46 2015-07-05T16:24:39 <yask> skathpalia: hey! I'll have to do a lot of manual work to bring you un merged CR and the fix for alinement is only a minor one in patch #2 of this CR
47 2015-07-05T16:25:04 <skathpalia> Ok I will try to use the merged one :)
48 2015-07-05T16:25:38 <yask> Thanks! this habit will not be repeated. :)
49 2015-07-05T16:27:19 <skathpalia> Looks nice
50 2015-07-05T16:27:44 <yask> :)
51 2015-07-05T16:28:55 <skathpalia> Why have you added templates in modernized/themes
52 2015-07-05T16:29:37 <skathpalia> I mean themes/modernized/templates
53 2015-07-05T16:29:41 <skathpalia> You can directly add in MoinMoin/templates
54 2015-07-05T16:30:04 <skathpalia> yask, ^^?
55 2015-07-05T16:30:09 <yask> roger hasse suggested to do so as he said making changes to global templates would force other moin theme developers to use bootstrap
56 2015-07-05T16:30:31 <skathpalia> Ok, then its fine. I thought this is not discussed
57 2015-07-05T16:31:27 <skathpalia> Looks Ok as of now
58 2015-07-05T16:31:51 <yask> cool !
59 2015-07-05T16:34:09 <skathpalia> Give me sometime to have a deeper look at it and then I will add comments :)
60 2015-07-05T16:34:19 <yask> sure! :)
61 2015-07-05T16:35:37 <vipul20> skathpalia: as both comments and file will refer to ticket's itemid, while querying files it'll also include the comments as file items in the list of uploaded files that's why I was trying to define itemtypes for comments and files so it is easy to distinguish. Is it right ?
62 2015-07-05T16:36:18 <vipul20> or should I add a different meta field to distinguish between comment and file ?
63 2015-07-05T16:37:08 <skathpalia> BTW Great Idea
64 2015-07-05T16:37:19 <vipul20> :)
65 2015-07-05T16:37:27 *** greg_f
66 2015-07-05T16:37:33 <skathpalia> I am not sure which method would be better
67 2015-07-05T16:37:46 <skathpalia> May be discuss it with Thomas or Roger
68 2015-07-05T16:38:13 <skathpalia> RogerHaase, What do you say on this ^^?
69 2015-07-05T16:43:21 <skathpalia> btw vipul20, what are you working on now?
70 2015-07-05T16:44:04 <vipul20> working on comments..
71 2015-07-05T16:44:52 <skathpalia> What method are you following?
72 2015-07-05T16:45:07 <vipul20> right now I am using a meta field
73 2015-07-05T16:45:14 <vipul20> to separate comments and files
74 2015-07-05T16:47:56 <skathpalia> I mean you are trying to store each comment as a file, so what would be the name of each file?
75 2015-07-05T16:48:25 <skathpalia> vipul20, ^^
76 2015-07-05T16:49:25 <vipul20> storing them as items: self.meta[ITEMID] + '/' + 'comment_' + current_timestamp. as named items are only created that's why I used timestamp
77 2015-07-05T16:49:41 <skathpalia> Ok
78 2015-07-05T16:49:51 <RogerHaase> skathpalia: vipul20 I have not worked on any code in that area, adding a meta field sounds reasonable
79 2015-07-05T16:50:22 <vipul20> Ok
80 2015-07-05T16:50:26 <skathpalia> Yeah seems good :)
81 2015-07-05T16:50:45 <skathpalia> Ok vipul20 you try that
82 2015-07-05T16:51:04 <vipul20> yes, sure
83 2015-07-05T16:51:32 <skathpalia> gtg
84 2015-07-05T16:52:53 *** skathpalia
85 2015-07-05T19:33:22 *** vipul20
86 2015-07-05T20:54:04 <RogerHaase> ThomasWaldmann: waldi: added comment to https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/261/unicode-aware-arguments-formatted-macro/diff
87 2015-07-05T21:52:12 *** RogerHaase
88 2015-07-05T23:11:49 *** yask
89
