1 2015-07-07T01:01:49 *** yask
2 2015-07-07T06:57:30 *** greg_f
3 2015-07-07T07:07:08 *** yask
4 2015-07-07T10:48:50 *** vipul20
5 2015-07-07T12:01:49 *** yask
6 2015-07-07T12:30:53 *** dave_largo
7 2015-07-07T13:14:12 *** RogerHaase
8 2015-07-07T13:15:28 *** skathpalia
9 2015-07-07T13:15:38 <skathpalia> moin
10 2015-07-07T13:23:22 *** vipul20
11 2015-07-07T14:08:07 *** vipul20
12 2015-07-07T14:10:39 *** skathpalia
13 2015-07-07T14:54:17 *** skathpalia
14 2015-07-07T15:19:58 *** skathpalia
15 2015-07-07T15:21:38 *** randomax
16 2015-07-07T15:24:07 *** yask
17 2015-07-07T15:26:25 *** skathpalia
18 2015-07-07T15:50:27 <waldi> yask: does the tabbed stuff still works without javascript?
19 2015-07-07T15:55:32 <yask> waldi: No, but bootstrap.js comes with it.
20 2015-07-07T15:55:53 <waldi> and how do i change my settings without javascript?
21 2015-07-07T15:57:05 <yask> I meant , it does use javascript function which comes in bootstrap (tabs.js).
22 2015-07-07T15:57:12 <yask> which setting are you referring to ?
23 2015-07-07T15:58:05 <yask> its easy to use it: http://getbootstrap.com/javascript/#markup
24 2015-07-07T15:58:24 <yask> and could also clean up our `common.js` script.
25 2015-07-07T15:58:59 <yask> *http://getbootstrap.com/javascript/#tabs
26 2015-07-07T16:01:31 <yask> okkey! so you meant if browser has disabled javascript, tabs won't work? waldi ?
27 2015-07-07T16:04:23 <waldi> yask: exactly. if the browser does not support javascript or have it disabled
28 2015-07-07T16:05:32 <yask> It won't work. But even our current tabs (in user settings ) are implemented by javascript and it won't work either without JS.
29 2015-07-07T16:07:54 <waldi> according to my calendar, we have meeting now
30 2015-07-07T16:08:47 <yask> yea! ThomasWaldmann moin :)
31 2015-07-07T16:10:04 *** greg_f
32 2015-07-07T16:12:36 <waldi> vipul20, yask, randomax, skathpalia, ThomasWaldmann: anyone here?
33 2015-07-07T16:12:42 <skathpalia> moin
34 2015-07-07T16:12:47 <yask> moin
35 2015-07-07T16:12:52 <vipul20> yes moin :)
36 2015-07-07T16:13:45 <randomax> yes
37 2015-07-07T16:15:22 <waldi> i think we'll start without ThomasWaldmann
38 2015-07-07T16:17:45 <waldi> yask: your turn
39 2015-07-07T16:17:54 <yask> okkey!
40 2015-07-07T16:18:40 <yask> #Done:
41 2015-07-07T16:18:40 <yask> Last CR reviewed by saurabh:
42 2015-07-07T16:18:40 <yask> #Blockers:
43 2015-07-07T16:18:40 <yask> “Improvement in error notifications” is not yet complete for basic theme.
44 2015-07-07T16:18:40 <yask> #Todo:
45 2015-07-07T16:18:41 <yask> I made following CRs and it’s review is pending:
46 2015-07-07T16:18:41 <yask> #1 Buttons positioning improvements in usersetting forms: https://codereview.appspot.com/246590044
47 2015-07-07T16:18:42 <yask> #2 Global Index improvements: https://codereview.appspot.com/247610043
48 2015-07-07T16:18:42 <yask> CR #3: Added HTML 5 Constraint validation at various places https://codereview.appspot.com/253950043
49 2015-07-07T16:18:43 <yask> After review and commit if time is left I’ll proceed to my next task:
50 2015-07-07T16:18:43 <yask> ": #Implement new design for quick links & left vertical menubar [Basic and Modern theme]"
51 2015-07-07T16:22:19 <yask> CR #4: Notification/Errors styles added in modernised theme : https://codereview.appspot.com/253000043/
52 2015-07-07T16:22:52 <skathpalia> yask, you CR https://codereview.appspot.com/253770043/ looks Ok to me, Ask for ThomasWaldmann's review and then you can commit it
53 2015-07-07T16:23:07 <yask> Okkey!
54 2015-07-07T16:23:48 <waldi> what puzzles me: there are huge changes in the generated css
55 2015-07-07T16:24:52 <waldi> if the environment changes, please to _one_ commit for all changes within autogenerated files but without anything else
56 2015-07-07T16:26:19 <waldi> s,to,do,
57 2015-07-07T16:27:18 <yask> I haven't made changes to `theme.less` file (for basic) and it doesn't appear in CRs. and since theme.css is compiled from `theme.less` it shouldn't appear in CR as well. I have using shelve extension and this error would be fixed probably after I commit changes
58 2015-07-07T16:27:40 <yask> *am
59 2015-07-07T16:28:01 <waldi> yask: my problem with it is: there are changes where none should be
60 2015-07-07T16:28:36 <waldi> so either there is no stable output or something changed
61 2015-07-07T16:30:06 <yask> in theme.css file did change because I updated bootstrap? But it shouldn't be appearing in CRs
62 2015-07-07T16:32:34 <yask> I meant, after I updated bootstrap for all the themes , basic.less generated a new `.css` file which is appearing in CR
63 2015-07-07T16:32:58 <yask> I haven't made those changes , those changes are from updated bootstrap only.
64 2015-07-07T16:33:13 <yask> *theme.less for basic theme
65 2015-07-07T16:34:18 <waldi> well. you did not change setup.py to pull in a new version. how did you get the new version?
66 2015-07-07T16:34:35 <yask> I did change setup.py
67 2015-07-07T16:34:50 <waldi> well, it is not in the changes you showed
68 2015-07-07T16:34:53 <waldi> or are in your repo
69 2015-07-07T16:35:34 <yask> waldi: its coming from this CR:https://codereview.appspot.com/253770043/diff/110001/setup.py
70 2015-07-07T16:35:52 <yask> it hasn't been yet committed , saurabh was reviewing it
71 2015-07-07T16:36:13 <yask> So to make clean CRs I used mercurial's shelve extension
72 2015-07-07T16:38:56 <waldi> yask: please start with ripping appart 253770043. one change for each fix
73 2015-07-07T16:40:31 <yask> It was ripped apart like this: https://codereview.appspot.com/251980043/ (Bootstrap update) -> https://codereview.appspot.com/253770043/ (Footer Fix) -> https://codereview.appspot.com/251990043/ (Usersettings bootstrapped) smile emoticon
74 2015-07-07T16:41:12 <yask> but the third patch couldn't be applied automatically as their were conflicting changes, so to avoid that I merged last CRs
75 2015-07-07T16:41:24 <waldi> okay, i have to sift through them all again. i have no access right now
76 2015-07-07T16:42:18 <waldi> randomax, skathpalia, ThomasWaldmann: any questions?
77 2015-07-07T16:42:40 <skathpalia> No :)
78 2015-07-07T16:42:50 <randomax> no
79 2015-07-07T16:43:07 <waldi> okay. thank you yask
80 2015-07-07T16:43:14 <waldi> vipul20: you are next
81 2015-07-07T16:43:28 <vipul20> DONE: changed current comment mechanism to item based comments, implemented threaded
82 2015-07-07T16:43:28 <vipul20> comments which refer to ticket id and contains reply_to field to create a tree structure (need to show this in the UI nicely)
83 2015-07-07T16:43:28 <vipul20> comment item_name is of the form: self.meta[ITEMID] + u'/comment_' + current_timestamp (need to have some name so I chose current_timestamp)
84 2015-07-07T16:43:28 <vipul20> TODO: Currently implemented comments as strings, need to add markdown support. fix few issues concerning with JQuery in comment reply. Create UI for threaded comments
85 2015-07-07T16:43:28 <vipul20> few things need to be improved, so I'll create the CR as soon as it is done.
86 2015-07-07T16:43:28 <vipul20> review: https://codereview.appspot.com/246020043/ (done by skathpalia, need ThomasWalmann's review)
87 2015-07-07T16:44:34 <waldi> skathpalia: i think you have to do that, i lack insight
88 2015-07-07T16:45:41 <skathpalia> vipul20, For now don't think of threaded comments, Just have normal comment section for now
89 2015-07-07T16:46:04 <skathpalia> Also do it a bit fast
90 2015-07-07T16:46:40 <skathpalia> Don't wait for pending CRs to get reviewed, you should work on some other work in parallel
91 2015-07-07T16:47:15 <vipul20> yes, I've implemented normal comments as items
92 2015-07-07T16:47:33 <skathpalia> Ok then make a CR for that
93 2015-07-07T16:47:35 <vipul20> comments implementation is also somewhat similar to files
94 2015-07-07T16:47:49 <skathpalia> Yeah I know, we discussed about this
95 2015-07-07T16:48:09 <skathpalia> btw whats you next plan
96 2015-07-07T16:48:18 <skathpalia> I mean after comments part is finished
97 2015-07-07T16:48:53 <vipul20> to implement advanced search feature
98 2015-07-07T16:48:59 <skathpalia> Ok
99 2015-07-07T16:49:52 <skathpalia> vipul20, any questions?
100 2015-07-07T16:50:24 <vipul20> no
101 2015-07-07T16:50:48 <skathpalia> any questions for vipul20 from randomax , waldi ?
102 2015-07-07T16:51:00 <randomax> no
103 2015-07-07T16:51:06 <waldi> no
104 2015-07-07T16:51:14 <waldi> thank you vipul20 and skathpalia
105 2015-07-07T16:51:32 <waldi> have fun hacking, i'm going home now
106 2015-07-07T16:51:44 <skathpalia> :)
107 2015-07-07T17:25:38 <ThomasWaldmann> sorry, i was busy until right now :|
108 2015-07-07T17:28:51 <waldi> and i'm home now
109 2015-07-07T17:41:34 *** RogerHaase
110 2015-07-07T17:43:10 *** randomax
111 2015-07-07T18:02:54 *** skathpalia
112 2015-07-07T19:40:23 *** RogerHaase
113 2015-07-07T20:55:25 *** dave_largo
114 2015-07-07T21:31:49 *** yask
115 2015-07-07T22:53:38 *** RogerHaase
116
