1 2015-07-14T00:51:51 *** yask
2 2015-07-14T02:08:38 *** ThomasAH
3 2015-07-14T02:08:44 *** ThomasAH
4 2015-07-14T02:53:25 *** vipul20
5 2015-07-14T07:02:36 *** yask
6 2015-07-14T07:21:26 *** ronny
7 2015-07-14T07:26:38 *** ronny
8 2015-07-14T07:38:51 *** vipul20
9 2015-07-14T09:10:53 *** greg_f
10 2015-07-14T10:31:51 *** yask
11 2015-07-14T10:33:25 *** vipul20
12 2015-07-14T12:37:27 *** dave_largo
13 2015-07-14T12:58:09 *** vipul20
14 2015-07-14T13:42:08 *** yask
15 2015-07-14T14:50:43 *** RogerHaase
16 2015-07-14T14:55:07 <ThomasWaldmann> vipul20: yask: your blog updates are missing still
17 2015-07-14T14:56:52 <ThomasWaldmann> vipul20: i don't see you using your bitbucket repo. how do you manage and backup the stuff you are working on?
18 2015-07-14T14:58:24 <yask> ThomasWaldmann: yep!.. I am writing right now
19 2015-07-14T15:17:42 <ThomasWaldmann> yask: the CR list on the gsoc wiki page, is it complete?
20 2015-07-14T15:18:01 <ThomasWaldmann> vipul20: no CR list entries there from you.
21 2015-07-14T15:18:10 <ThomasWaldmann> https://moinmo.in/GoogleSoc2015
22 2015-07-14T15:20:55 <yask> ThomasWaldmann: Nopes , Ajitesh was in the process of reviewing it. This line ` #word_suggestions =
23 2015-07-14T15:20:55 <yask> corrector.suggest(lastword, limit=3)` was causing a traceback error on search, so I had temporarily commented it. I was about to create an issue in issue tracker.
24 2015-07-14T15:21:29 <yask> Traceback error: https://www.irccloud.com/pastebin/N844RwLg/
25 2015-07-14T15:21:49 <ThomasWaldmann> ah, ok.
26 2015-07-14T15:23:48 <ThomasWaldmann> looks like it gets a utf8 str and wants to decode it to unicode
27 2015-07-14T15:24:10 <ThomasWaldmann> using the default ascii decoder, which of course fails
28 2015-07-14T15:24:36 <ThomasWaldmann> so that's either a bug in whoosh or we are feeding utf8 where we should feed unicode
29 2015-07-14T15:24:37 <RogerHaase> https://bitbucket.org/thomaswaldmann/moin-2.0/issues/534/whoosh-270-breaks-search-yields-traceback
30 2015-07-14T15:26:13 <ThomasWaldmann> if whoosh<2.7 would help, we could also do that
31 2015-07-14T15:43:33 <yask> RogerHaase: Regarding integer input fields ? Sliders do look good. http://i.imgur.com/puo5s6i.png (Haven't styled them yet)
32 2015-07-14T15:55:04 * ThomasWaldmann just finished a server upgrade to debian 8 :)
33 2015-07-14T15:56:45 <ThomasWaldmann> vipul20: yask: waldi: meeting in 4 mins. some mentors missing still. please speak up if you are here.
34 2015-07-14T15:59:09 <yask> moin
35 2015-07-14T15:59:56 <waldi> here
36 2015-07-14T16:00:01 <vipul20> moin
37 2015-07-14T16:01:13 <ThomasWaldmann> btw, next week I will be at EuroPython in Bilbao, so there's some propability that I can't make it to next week's meeting.
38 2015-07-14T16:01:53 <ThomasWaldmann> when I have internet and not being busy otherwise, I'll try to look in here.
39 2015-07-14T16:03:57 <ThomasWaldmann> ok, let's wait a few minutes in case randomax and ajtesh show up
40 2015-07-14T16:17:45 <ThomasWaldmann> ok, looks like both are missing the meeting
41 2015-07-14T16:17:59 <ThomasWaldmann> yask: please begin
42 2015-07-14T16:19:05 <yask> Done:
43 2015-07-14T16:19:05 <yask> #Got last Cr reviewed and committed/pushed changes
44 2015-07-14T16:19:05 <yask> # Added HTML5 constraint validations in various form field.
45 2015-07-14T16:19:05 <yask> # Modified `index` template to use bootstrap components (paginations,buttons..)
46 2015-07-14T16:19:05 <yask> # Styled usersetting tabs in modernized theme
47 2015-07-14T16:19:05 <yask> # Added sliders for inputting restricted input values for Editor size & History results per page
48 2015-07-14T16:19:06 <yask> # Fixed a bug in navbar (irregular collapse in mobile view)
49 2015-07-14T16:19:06 <yask> CR: https://codereview.appspot.com/250390043
50 2015-07-14T16:19:07 <yask> Blockers:
51 2015-07-14T16:19:07 <yask> #css validation styling
52 2015-07-14T16:19:08 <yask> #styling of local history page
53 2015-07-14T16:19:09 <yask> #edit image in footer logo with light color text.
54 2015-07-14T16:19:09 <yask> #html5 validation doesn’t work yet in safari and IE<9, requires validation styling.
55 2015-07-14T16:19:09 <yask> #Icons in navbar
56 2015-07-14T16:20:29 <ThomasWaldmann> so, what's blocking you there^ ?
57 2015-07-14T16:21:54 <yask> Ahh! mostly discussions with mentor and time
58 2015-07-14T16:22:19 <ThomasWaldmann> BTW, don't invest too much time in old IEs. Time will solve that problem.
59 2015-07-14T16:23:00 <yask> Yea! thats task is on lower priority
60 2015-07-14T16:23:55 <ThomasWaldmann> so, what's missing so that you are unblocked?
61 2015-07-14T16:24:50 <ThomasWaldmann> (not sure if we use same definition of blocker. blocker means that you can't continue on at least some or maybe all tasks.)
62 2015-07-14T16:25:26 <yask> okkey! I thought blockers are stuff that you couldn't do in the required time
63 2015-07-14T16:25:53 <ThomasWaldmann> no, that's called being behind schedule
64 2015-07-14T16:28:08 <ThomasWaldmann> waldi: ^ your student. any questions / remarks?
65 2015-07-14T16:28:29 <ThomasWaldmann> RogerHaase: you are not an official mentor, but feel free to comment also.
66 2015-07-14T16:28:38 <ThomasWaldmann> (and thanks for helping)
67 2015-07-14T16:29:11 <yask> I recently implemented sliders for input values (eg: in editor size). Ajitesh said sliders are okay but RogerHaase said we are not sure about the range of input values ?
68 2015-07-14T16:29:14 <ThomasWaldmann> yask: "NEXT" is missing, btw.
69 2015-07-14T16:29:42 <ThomasWaldmann> yask: yes, that's a fundamental issue, esp. if the range could be rather wide
70 2015-07-14T16:29:57 <waldi> ThomasWaldmann: the list of "blockers" reads more like a todo list
71 2015-07-14T16:30:29 <ThomasWaldmann> and if it is wide, there will be also usability issues, like being unable to precisely slide to a small value.
72 2015-07-14T16:30:52 * ThomasWaldmann had that with some price range slider recently
73 2015-07-14T16:31:11 <yask> hmm , we can have both.. a small input box next to slider to enter exact integer value ?
74 2015-07-14T16:31:19 <waldi> yask: do this sliders make the interface easier?
75 2015-07-14T16:31:30 <yask> slider will make sure we get an integer value
76 2015-07-14T16:31:41 <yask> I think so
77 2015-07-14T16:31:48 <waldi> wrong problem solved
78 2015-07-14T16:32:08 <waldi> input fields also only get integers, because the validation says so
79 2015-07-14T16:33:11 <ThomasWaldmann> maybe keep the input field for editor size. even better might be not needing that at all maybe, by making the editor a good size, depending on the browser size maybe?
80 2015-07-14T16:33:58 <yask> Okkey! .. but sliders did look good :) http://i.imgur.com/puo5s6i.png
81 2015-07-14T16:36:33 <ThomasWaldmann> yes, they look fancy, agreed. But better would be not having to care about the size manually.
82 2015-07-14T16:36:48 <ThomasWaldmann> Not sure how good that works, though.
83 2015-07-14T16:37:11 <yask> Okkey!
84 2015-07-14T16:38:33 <ThomasWaldmann> ok, anything else for / from yask?
85 2015-07-14T16:38:37 <waldi> i don't hae any more questions
86 2015-07-14T16:39:40 <ThomasWaldmann> yask: OK, we'll read your blog post as soon as it is ready.
87 2015-07-14T16:39:55 <yask> sure! , i'll post the link here.
88 2015-07-14T16:40:02 <ThomasWaldmann> ok, thanks yask. vipul20, it's your stage now.
89 2015-07-14T16:40:21 <vipul20> # DONE: threaded comments: ajax based reply to comments which adds a textbox below to reply to a comment, constructed a tree of comments/reply.
90 2015-07-14T16:40:21 <vipul20> CR: https://codereview.appspot.com/256840043/
91 2015-07-14T16:40:21 <vipul20> # TODO:
92 2015-07-14T16:40:21 <vipul20> create UI for rendering comment/reply tree
93 2015-07-14T16:40:21 <vipul20> fix an error in parsing comment tree
94 2015-07-14T16:40:21 <vipul20> # BLOCKERS:
95 2015-07-14T16:40:21 <vipul20> sometimes the comments are not in order of their timestamp. Therefore,
96 2015-07-14T16:40:22 <vipul20> I am trying yo sort the comments by timestamp using whoosh query but "sortedby=TIMESTAMP" gives error
97 2015-07-14T16:40:22 <vipul20> it says time.time() is not datetime and if I use datetime.datetime.now() as the timestamp, another error comes: datetime is not JSON serializable
98 2015-07-14T16:40:23 <vipul20> # Regarding last CR reviewed:
99 2015-07-14T16:40:23 <vipul20> If we do not use itemid in the name of files uploaded then the toplevel item created will be like : domain/<file_name> referring to ticket's itemid
100 2015-07-14T16:40:24 <vipul20> and it is more likely that people may have same names for files. In that case, it will overwrite the previous file even if a file of same name is uploaded from another ticket item. So, if we use name like: domain/<itemid>/<file_name>, it would be better and conistent with the ticket we are working on.
101 2015-07-14T16:42:58 <ThomasWaldmann> you should not need timestamps for order
102 2015-07-14T16:43:37 <vipul20> I've noticed the order of comments changes so I thought I should sort by timestamp
103 2015-07-14T16:43:39 <ThomasWaldmann> if you just get all items referring to the same item, then you could build up the tree using the reply_to information
104 2015-07-14T16:44:44 <vipul20> yes that is fine but if I create 3 comments without any reply then sometimes the comment created later appears first
105 2015-07-14T16:45:03 <ThomasWaldmann> you just use the reply_to "pointers" you (hopefully) made when saving the comment
106 2015-07-14T16:45:24 <ThomasWaldmann> ah
107 2015-07-14T16:45:56 <ThomasWaldmann> hmm, i don't see any sorting for the whoosh query
108 2015-07-14T16:46:10 <ThomasWaldmann> (on CR)
109 2015-07-14T16:46:47 <ThomasWaldmann> did you also try if older whoosh has same problem, like < 2.7?
110 2015-07-14T16:46:58 <ThomasWaldmann> (type and json issues)
111 2015-07-14T16:47:12 <vipul20> no the doc says that sortedby attribute came after whoosh 3
112 2015-07-14T16:47:28 <ThomasWaldmann> 3?
113 2015-07-14T16:48:58 <vipul20> can't find the doc. I will try the older version
114 2015-07-14T16:49:23 <ThomasWaldmann> did you use sortable=True in the schema?
115 2015-07-14T16:50:24 <ThomasWaldmann> also maybe have a look at global and local history of items, iirc they are (reverse) sorted by time
116 2015-07-14T16:50:52 <vipul20> yes but I am storing time as time.time() so it says it is not datetime but if I use dateime.now() instead, it says it is not JSON serializable
117 2015-07-14T16:51:19 <vipul20> ok I'll try that
118 2015-07-14T16:51:19 <ThomasWaldmann> btw, if you don't give sortedby=... you can't have any expectation on order, it is just undefined.
119 2015-07-14T16:52:29 <vipul20> yes, that's what I am concerned about. I'll try it again
120 2015-07-14T16:53:12 <ThomasWaldmann> you used fields.DATETIME in the schema?
121 2015-07-14T16:53:32 <vipul20> yes
122 2015-07-14T16:53:45 <vipul20> maybe I am making some mistake somewhere I'll review it again
123 2015-07-14T16:53:47 <ThomasWaldmann> you checked whoosh issue tracker?
124 2015-07-14T16:53:54 <vipul20> no
125 2015-07-14T16:54:32 <ThomasWaldmann> you could do a very minimal example of that problem (~10 lines of code) and if it still blows up, file a bug for whoosh
126 2015-07-14T16:54:53 <ThomasWaldmann> matt also needs to update whoosh docs site, it is still 2.5.6
127 2015-07-14T16:55:04 <vipul20> ok, sure I'll do that
128 2015-07-14T16:55:47 <ThomasWaldmann> if you can't get that working, just work unsorted and have a TODO in the code at the right place
129 2015-07-14T16:56:06 <vipul20> ok
130 2015-07-14T16:57:21 <ThomasWaldmann> about NAME of ticket comments / uploaded files: my idea was not having them show up in global name index.
131 2015-07-14T16:58:15 <ThomasWaldmann> for creation, you currently need a name, but you can modify the item and just remove the name, to make an anonymous item.
132 2015-07-14T16:58:49 <ThomasWaldmann> it still is related to the ticket via refers_to and you find the right position in the comment tree by reply_to.
133 2015-07-14T16:59:31 <vipul20> it does not show up in global name index
134 2015-07-14T16:59:33 <ThomasWaldmann> for file uploads, it ofc would be good to have the original file name somewhere, so a download behaves as expected.
135 2015-07-14T17:00:27 <ThomasWaldmann> vipul20: if you name stuff ITEMID/foo, then ITEMID is in global index, right?
136 2015-07-14T17:02:04 <vipul20> I tried that code just now, initially it shows up in the global index but later after first modify it goes
137 2015-07-14T17:06:38 <ThomasWaldmann> ah? ok, maybe i missed some detail in the CR.
138 2015-07-14T17:07:14 <vipul20> skathpalia has ran it once :)
139 2015-07-14T17:07:31 <ThomasWaldmann> ok, so for the comments query: try doing 1 query to get all related stuff and then built the tree. you do not need lots of queries...
140 2015-07-14T17:07:45 <vipul20> ok sure
141 2015-07-14T17:08:04 <ThomasWaldmann> the code is a bit complex/confusing btw. maybe try to do it simpler.
142 2015-07-14T17:08:30 <vipul20> ok
143 2015-07-14T17:09:22 * ThomasWaldmann still has one CR open for commenting, will finish after meeting
144 2015-07-14T17:10:20 <ThomasWaldmann> ok, anything else?
145 2015-07-14T17:10:28 <vipul20> no
146 2015-07-14T17:11:25 <ThomasWaldmann> vipul20: yask: grab your other mentors as soon as they show up. and they shall not miss next week's meeting please.
147 2015-07-14T17:11:42 <yask> yep!
148 2015-07-14T17:11:47 <vipul20> ok
149 2015-07-14T17:12:00 <ThomasWaldmann> ok, guess we are through. thanks everybody and happy hacking.
150 2015-07-14T17:12:34 <ThomasWaldmann> vipul20: don't forget your blog post. PSF requires it and your mentors like it, too. :)
151 2015-07-14T17:12:58 <vipul20> ThomasWaldmann: yes I've just published it
152 2015-07-14T17:14:38 <ThomasWaldmann> ah, good
153 2015-07-14T18:04:00 *** RogerHaase
154 2015-07-14T18:25:28 *** sharky93_
155 2015-07-14T18:30:49 *** dave_largo
156 2015-07-14T18:30:49 *** greg_f
157 2015-07-14T18:30:51 *** sharky93
158 2015-07-14T18:30:51 *** jhermann
159 2015-07-14T19:49:20 *** dave_largo
160 2015-07-14T19:49:24 *** jhermann
161 2015-07-14T20:31:52 *** yask
162 2015-07-14T20:59:02 *** eSyr
163 2015-07-14T21:03:11 *** eSyr
164 2015-07-14T21:20:41 *** dave_largo
165 2015-07-14T21:33:25 *** vipul20
166
