1 2015-08-11T07:29:10 *** ronny
2 2015-08-11T07:29:29 *** vipul20
3 2015-08-11T07:49:04 *** ronny
4 2015-08-11T08:08:57 *** greg_f
5 2015-08-11T10:18:36 *** vipul20
6 2015-08-11T12:38:52 *** dave_largo
7 2015-08-11T13:27:55 *** vipul20
8 2015-08-11T15:05:29 *** yask
9 2015-08-11T15:10:12 *** skathpalia
10 2015-08-11T15:10:14 <skathpalia> moin
11 2015-08-11T15:10:18 <yask> moin skathpalia
12 2015-08-11T15:10:44 <skathpalia> yask, what kind of editor improvements have you done?
13 2015-08-11T15:11:31 <yask> editor improvements adds toolbar widget for different wiki syntax, such as creole,markdown,mediawiki.. etc
14 2015-08-11T15:12:02 <yask> I used this plugin: http://markitup.jaysalvat.com/home/
15 2015-08-11T15:12:33 <yask> and wrote custom settings in `set.js` file for different wiki syntax
16 2015-08-11T15:12:44 <skathpalia> Did you discuss this with any mentor?
17 2015-08-11T15:13:04 <skathpalia> specifically the use of this plugin
18 2015-08-11T15:13:51 <yask> Yes!! I did, RogerHaase tested it on his machine and gave feedback as well
19 2015-08-11T15:14:22 <yask> https://moinmo.in/MoinMoinChat/Logs/moin-dev/2015-07-27
20 2015-08-11T15:15:11 <yask> for instance settings for creole syntax is contained in this file: https://codereview.appspot.com/259260043/diff/1/MoinMoin/static/js/wiki_creole/set.js
21 2015-08-11T15:15:34 <skathpalia> Ok I just needed to confirm
22 2015-08-11T15:15:35 <skathpalia> :)
23 2015-08-11T15:15:56 <yask> Also this plugin is being used by Bitbucket and codeforces as well.
24 2015-08-11T15:16:54 <skathpalia> so I should apply the diff file which you sent me
25 2015-08-11T15:16:58 <skathpalia> to see changes
26 2015-08-11T15:17:00 <skathpalia> right?
27 2015-08-11T15:17:16 <skathpalia> yask, ^^
28 2015-08-11T15:17:19 <yask> Yes, then edit any wiki with modernised theme
29 2015-08-11T15:18:34 <yask> an editor like this should appear: http://i.imgur.com/PoQiVZH.png
30 2015-08-11T15:20:15 <skathpalia> Why is the editor divided into 2 parts?
31 2015-08-11T15:20:42 <skathpalia> Oh ok ok
32 2015-08-11T15:20:55 <skathpalia> there might be some problem with my browser
33 2015-08-11T15:21:20 <yask> screenshot ?
34 2015-08-11T15:21:55 <skathpalia> no its fine
35 2015-08-11T15:22:50 <skathpalia> The functionality wise it looks good
36 2015-08-11T15:23:13 <skathpalia> but the UI of editor needs to be improved
37 2015-08-11T15:23:27 *** RogerHaase
38 2015-08-11T15:23:48 <yask> yea, and the settings for different syntax is organised well (e.g.: MoinMoin/static/js/wiki_creole/set.js
39 2015-08-11T15:23:48 <yask> MoinMoin/static/js/wiki_mediawiki/set.js
40 2015-08-11T15:23:48 <yask> MoinMoin/static/js/wiki_moinmoin/set.js..)
41 2015-08-11T15:24:12 <yask> Yea, the UI needs improvements.
42 2015-08-11T15:24:24 <yask> also Preview doesn't work as yet, I am working on it
43 2015-08-11T15:29:14 <yask> Also, test the quick links bar in modernised theme, Ajitesh reported a bug that it gets broken when quick links names are huge, I fixed that in this patch.
44 2015-08-11T15:30:18 <yask> skathpalia: ^
45 2015-08-11T15:30:37 <skathpalia> Ok will try that
46 2015-08-11T15:40:55 <skathpalia> yeah looks good
47 2015-08-11T15:42:33 <yask> I also fixed the quick links box's height with vertical scroll as you suggested in last meeting (For basic theme) in this patch.
48 2015-08-11T15:52:08 <skathpalia> looks good
49 2015-08-11T15:55:59 <vipul20> ThomasWaldmann: moin. I've already updated the CRs, you replied to the older comments there
50 2015-08-11T15:58:05 <skathpalia> vipul20, we had to add 3 comments just for removal of a print statement :/
51 2015-08-11T15:58:50 <skathpalia> Atleast you should check your CR once it has been uploaded and verify that it doen't have any unnecessary changes
52 2015-08-11T15:59:04 <vipul20> skathpalia: I tried to update it alongwith other changes suggested in previous meetings
53 2015-08-11T16:00:26 <ThomasWaldmann> ok, meeting time
54 2015-08-11T16:00:43 <ThomasWaldmann> waldi: here?
55 2015-08-11T16:00:55 <ThomasWaldmann> where's randomax?
56 2015-08-11T16:03:43 <skathpalia> seems both are unavailable
57 2015-08-11T16:05:16 <ThomasWaldmann> vipul20: ok, please start
58 2015-08-11T16:05:41 <vipul20> #DONE:
59 2015-08-11T16:05:41 <vipul20> UI improvements of advanced search view: more like /+search view
60 2015-08-11T16:05:41 <vipul20> CR: https://codereview.appspot.com/256230043
61 2015-08-11T16:05:41 <vipul20> fixed UI of ticket-comments as per the suggestions
62 2015-08-11T16:05:41 <vipul20> CR: https://codereview.appspot.com/256840043
63 2015-08-11T16:05:41 <vipul20> Tried multi-level indentation to create comment-reply threads but can't do it
64 2015-08-11T16:05:42 <vipul20> screenshot: http://i.imgur.com/dkfFko7.png
65 2015-08-11T16:05:43 <vipul20> #TODO:
66 2015-08-11T16:05:43 <vipul20> make open CRs ready to commit and final submission asap
67 2015-08-11T16:07:45 <ThomasWaldmann> can you make the layout of these boxes a bit prettier?
68 2015-08-11T16:07:57 <ThomasWaldmann> what was the problem with indentation?
69 2015-08-11T16:08:37 <vipul20> I am not able to create proper tree of comments-reply
70 2015-08-11T16:08:57 <ThomasWaldmann> why not?
71 2015-08-11T16:10:13 <ThomasWaldmann> to make it a bit prettier:
72 2015-08-11T16:10:24 <ThomasWaldmann> make "reply" button-like style
73 2015-08-11T16:11:08 <ThomasWaldmann> merge the other stuff into one line at the bottom: comment xxx posted by ... on ... in reply to yyy
74 2015-08-11T16:11:54 <vipul20> I was trying to create commen-reply tree as lists as: [comment, [ comment1, [] ]] but it did not go well
75 2015-08-11T16:12:10 <vipul20> ok fill fix it
76 2015-08-11T16:12:13 <ThomasWaldmann> and the message text font should somehow be a bit bigger or different font than this footer. lower padding is too much.
77 2015-08-11T16:12:38 *** cloudstrife
78 2015-08-11T16:13:43 <ThomasWaldmann> vipul20: do you take a pencial and a piece of paper when trying to design such datastructures/algorithms?
79 2015-08-11T16:14:44 <vipul20> yes I did. There's some problem in the recursive function I wrote for this purpose
80 2015-08-11T16:14:57 <ThomasWaldmann> where is that function?
81 2015-08-11T16:15:20 <vipul20> I've not updated in the CR as it didn't work
82 2015-08-11T16:15:51 <ThomasWaldmann> maybe put it in some other CR
83 2015-08-11T16:16:16 <vipul20> yes I'll create a new CR
84 2015-08-11T16:16:37 <ThomasWaldmann> in general, it helps to first get a clear idea of what you want to do and how before starting to code such stuff
85 2015-08-11T16:17:39 <vipul20> yes still I'll try to get it done
86 2015-08-11T16:18:12 <ThomasWaldmann> skathpalia: vipul20: any other questions/remarks?
87 2015-08-11T16:18:39 <ThomasWaldmann> vipul20: ping me with the tree building / rendering code after meeting
88 2015-08-11T16:18:41 <vipul20> no
89 2015-08-11T16:18:48 <vipul20> yes sure
90 2015-08-11T16:19:05 <skathpalia> vipul20, Just want to say that now GSoC period is bout to end so you have to get your open CRs committed asap
91 2015-08-11T16:19:26 <ThomasWaldmann> yeah, sure ^^^ yask also
92 2015-08-11T16:19:51 <vipul20> yes out of 3 one is ready to be committed and the advanced search one needs to be reviewed
93 2015-08-11T16:20:08 <ThomasWaldmann> code on CRs doesn't count. also test it, not working code isn't good either.
94 2015-08-11T16:21:10 <vipul20> yes will do it asap
95 2015-08-11T16:21:35 <ThomasWaldmann> waldi: ?
96 2015-08-11T16:22:14 <ThomasWaldmann> ok, thanks vipul20, yask, it's your stage, although 2/3 of your mentors are missing
97 2015-08-11T16:23:12 <yask> DONE:
98 2015-08-11T16:23:13 <yask> *committed and pushed admin UI changes
99 2015-08-11T16:23:13 <yask> *Fixed quicklinks bug where the navbar broke when quick links name were long.
100 2015-08-11T16:23:13 <yask> *Fixed height with vertical scroll to quick links box in basic theme
101 2015-08-11T16:23:13 <yask> *Completed writing editor toolbar widget settings for different wiki syntax
102 2015-08-11T16:23:13 <yask> ToDo:
103 2015-08-11T16:23:14 <yask> *UI improvements in editor
104 2015-08-11T16:23:14 <yask> *Optimise css file. Currently both basic and modernised theme imports lots of bootstrap components which aren’t being used, thereby unnecessary increasing style.css file size.
105 2015-08-11T16:23:15 <yask>
106 2015-08-11T16:24:15 <yask> open crs: https://codereview.appspot.com/259250043/
107 2015-08-11T16:24:15 <yask> https://codereview.appspot.com/259260043
108 2015-08-11T16:26:05 <ThomasWaldmann> i just commented some minutes ago there: all that 3rd party stuff should not be mixed with your stuff
109 2015-08-11T16:26:19 <ThomasWaldmann> and also be packaged separately
110 2015-08-11T16:26:23 <yask> Yea, I read that.. I'll split it
111 2015-08-11T16:26:28 <ThomasWaldmann> ok :)
112 2015-08-11T16:26:55 <ThomasWaldmann> are the images also from same 3rd party?
113 2015-08-11T16:27:35 <yask> Yes, those images are for different icons in toolbar widget such as bold icon, italics icon,... etc
114 2015-08-11T16:28:25 <yask> http://i.imgur.com/PoQiVZH.png
115 2015-08-11T16:29:20 <ThomasWaldmann> that choose file no file selected looks strange
116 2015-08-11T16:30:06 <yask> Yea, I have to make UI improvements in editor. Thats in ToDo.
117 2015-08-11T16:30:21 <ThomasWaldmann> that green checkmark is for ...?
118 2015-08-11T16:30:48 <yask> Thats for preview (Which doesn't work as yet).
119 2015-08-11T16:31:11 <ThomasWaldmann> maybe an "eye" or so
120 2015-08-11T16:31:35 <ThomasWaldmann> for which markups does that iconbar work?
121 2015-08-11T16:32:24 <yask> It works for all markups we have (MoinMoin wiki syntax,creole,mediawiki,markdown...)
122 2015-08-11T16:32:42 <ThomasWaldmann> you practically tested that?
123 2015-08-11T16:33:25 <ThomasWaldmann> (also, guess that might need some docs about how to add more markups)
124 2015-08-11T16:33:56 <yask> Yes, I did. The settings for each syntax is organized in separate .js file , for instance f or creole syntax settings are kept here: https://codereview.appspot.com/259260043/diff/1/MoinMoin/static/js/wiki_creole/set.js
125 2015-08-11T16:34:24 <yask> (e.g.: MoinMoin/static/js/wiki_creole/set.js
126 2015-08-11T16:34:24 <yask> MoinMoin/static/js/wiki_mediawiki/set.js
127 2015-08-11T16:34:24 <yask> MoinMoin/static/js/wiki_moinmoin/set.js..)
128 2015-08-11T16:34:43 <ThomasWaldmann> ah, ok
129 2015-08-11T16:35:07 <yask> Also its super easy to add syntax for another wiki as well, just create another `set.js` file with the syntax settings
130 2015-08-11T16:36:05 <yask> set.js file is easy to configure, e.g.: for Bold modify this: {name:'Bold', key:"B", openWith:"**", closeWith:"**"},
131 2015-08-11T16:36:22 <ThomasWaldmann> ok. how's progress compared to your plans?
132 2015-08-11T16:36:33 <ThomasWaldmann> vipul20: ^ check that also
133 2015-08-11T16:36:57 <yask> Progress is fine.
134 2015-08-11T16:38:37 <vipul20> According to plan, by this time i should've completed my work
135 2015-08-11T16:38:51 <vipul20> And doing final testing
136 2015-08-11T16:39:27 <vipul20> But i still have open crs
137 2015-08-11T16:40:54 * ThomasWaldmann commented all of them
138 2015-08-11T16:41:41 <ThomasWaldmann> yask: talk to waldi and random later here or by email. randomax missed last meeting also, talk to him.
139 2015-08-11T16:41:50 <ThomasWaldmann> +ax
140 2015-08-11T16:42:00 <cloudstrife> i've been here today
141 2015-08-11T16:42:05 <ThomasWaldmann> random letters missing ;)
142 2015-08-11T16:42:11 <ThomasWaldmann> cloudstrife: ?
143 2015-08-11T16:42:29 <cloudstrife> ohh sorry i just reinstalled ubuntu
144 2015-08-11T16:42:46 <cloudstrife> forgot to change the settings
145 2015-08-11T16:42:47 <ThomasWaldmann> ok, using the usual nickname would help also
146 2015-08-11T16:43:17 <ThomasWaldmann> ok, cloudstrife, any comments/questions from you?
147 2015-08-11T16:43:25 <cloudstrife> no
148 2015-08-11T16:43:40 *** cloudstrife
149 2015-08-11T16:44:14 <ThomasWaldmann> yask: any questions left from you? RogerHaase: or from you? ;)
150 2015-08-11T16:44:24 <skathpalia> no
151 2015-08-11T16:44:28 <RogerHaase> no
152 2015-08-11T16:44:55 <ThomasWaldmann> ok, then meeting is finished for today, happy hacking and keep the timeline in mind.
153 2015-08-11T16:51:47 *** randomax
154 2015-08-11T17:12:19 *** skathpalia
155 2015-08-11T17:29:53 *** greg_f
156 2015-08-11T17:35:03 *** skathpalia
157 2015-08-11T17:39:42 *** skathpalia
158 2015-08-11T17:50:22 *** skathpalia
159 2015-08-11T18:49:24 *** skathpalia
160 2015-08-11T18:58:36 *** vipul20
161 2015-08-11T19:10:12 *** RogerHaase
162 2015-08-11T19:10:13 *** skathpalia
163 2015-08-11T19:50:25 *** yask
164 2015-08-11T19:54:52 *** skathpalia
165 2015-08-11T20:03:29 *** RogerHaase
166 2015-08-11T20:58:43 *** dave_largo
167 2015-08-11T21:06:57 *** vipul20
168 2015-08-11T21:56:27 *** yask
169 2015-08-11T22:13:03 *** RogerHaase
170 2015-08-11T23:18:36 *** vipul20
171
