MoinMoin: MoinMoinChat/Logs/moin-dev/2016-01-07

   1 2016-01-07T00:26:40  *** bastianilso has quit IRC
   2 2016-01-07T00:30:53  *** bastianilso has joined #moin-dev
   3 2016-01-07T00:51:15  *** willingc is now known as willingc_away
   4 2016-01-07T00:58:29  *** willingc_away is now known as willingc
   5 2016-01-07T01:01:51  *** bastianilso has quit IRC
   6 2016-01-07T12:02:41  *** bastianilso has joined #moin-dev
   7 2016-01-07T13:15:29  *** vipul20 has joined #moin-dev
   8 2016-01-07T15:08:47  *** dave_largo has joined #moin-dev
   9 2016-01-07T15:11:28  *** skyrulerz has joined #moin-dev
  10 2016-01-07T15:52:03  *** RogerHaase has joined #moin-dev
  11 2016-01-07T15:52:15  *** skyrulerz has quit IRC
  12 2016-01-07T15:53:26  *** skyrulerz has joined #moin-dev
  13 2016-01-07T16:15:58  <RogerHaase> to do a code review, you now must do "python upload.py --oauth2" https://github.com/rietveld-codereview/rietveld/issues/537
  14 2016-01-07T16:41:49  <RogerHaase> ThomasWaldmann: Upgrading Werkzeug from 0.9.6 to 0.10.4 Breaks One Test, fixes #531 https://codereview.appspot.com/285040043/
  15 2016-01-07T17:05:55  <ThomasWaldmann> hi RogerHaase. happy new year!
  16 2016-01-07T17:07:20  <ThomasWaldmann> https://codereview.appspot.com/285040043/patch/1/10001 that somehow does not look werkzeug upgrade related, why is it in there?
  17 2016-01-07T17:08:57  <RogerHaase> ThomasWaldmann: moin :)
  18 2016-01-07T17:11:41  <RogerHaase> ThomasWaldmann: I tried to find a fix at a lower level, but could not. Without that abort there and werkzeug > 9.6; it converts the "page not found, create it now?" page and the test fails
  19 2016-01-07T17:13:57  <RogerHaase> page/item
  20 2016-01-07T17:17:20  <ThomasWaldmann> ok. did you need to do anything else when using latest werkzeug? i remember vaguely there was some security related change.
  21 2016-01-07T17:20:40  <RogerHaase> I am running 0.11.2 on one test repo. Tests work and I did light practical testing. Any idea as to what to try as a practical test?
  22 2016-01-07T17:22:59  <ThomasWaldmann> did you try without debug mode?
  23 2016-01-07T17:24:19  *** vidhan has joined #moin-dev
  24 2016-01-07T17:24:44  <RogerHaase> no, where is the setting?
  25 2016-01-07T17:27:39  * ThomasWaldmann doesn't remember, somewhere in the startup script
  26 2016-01-07T17:27:40  <RogerHaase> oh, wikiconfig... trying...
  27 2016-01-07T17:31:27  <RogerHaase> no, must be somewhere else, Get same "Debugger is active message" in console log from werkzeug with both true and false
  28 2016-01-07T17:38:54  *** skyrulerz has quit IRC
  29 2016-01-07T17:41:05  *** thabraze has joined #moin-dev
  30 2016-01-07T17:43:31  *** thabraze has quit IRC
  31 2016-01-07T19:30:39  *** vipul20_ has joined #moin-dev
  32 2016-01-07T19:38:31  *** vipul20 has quit IRC
  33 2016-01-07T19:38:35  *** vipul20_ is now known as vipul20
  34 2016-01-07T19:45:15  *** skyrulerz has joined #moin-dev
  35 2016-01-07T20:10:22  *** skyrulerz has quit IRC
  36 2016-01-07T20:15:22  *** skyrulerz has joined #moin-dev
  37 2016-01-07T20:50:55  <RogerHaase> ThomasWaldmann: werkzeug 0.11 has change: "Implemented PIN based authentication for the debugger." There is a pin number written to the console log. If you try to use the debugger to analyze a traceback, it now requests the pin number.
  38 2016-01-07T20:53:07  <ThomasWaldmann> maybe that was it, not sure
  39 2016-01-07T20:54:38  *** dave_largo has quit IRC
  40 2016-01-07T20:54:40  <RogerHaase> ThomasWaldmann: otoh, there appears to be no way to turn off the debugger. Setting DEBUG = False in wikiconfig has no effect. Also had no effect with werkzeug 9.6. Flask seems to have a "use_debugger" setting; but could not get the werkzeug debugger turned off even after modifying Flask code. Will try again later...
  41 2016-01-07T21:05:50  *** bastianilso has quit IRC
  42 2016-01-07T21:06:24  *** bastianilso has joined #moin-dev
  43 2016-01-07T21:43:00  *** skyrulerz has quit IRC
  44 2016-01-07T21:46:06  *** skyrulerz has joined #moin-dev
  45 2016-01-07T21:50:42  *** skyrulerz has quit IRC
  46 2016-01-07T21:51:11  *** skyrulerz has joined #moin-dev
  47 2016-01-07T21:56:41  *** RogerHaase has quit IRC
  48 2016-01-07T22:22:00  *** vipul20 has quit IRC
  49