Details
- Applies to
- 1.5.0
- Purpose
Minor improvements to the Toggle line numbers link that appears in formatted code
- Description
This patch changes the text "Toggle line numbers" that appears in formatted code listings into an internationalizable text phrase, so it can be properly translated. Also the toggle link itself is suppressed in hardcopy print output where it makes no sense, via CSS changes. (The line numbers are not altered in any way, only the link to toggle them). -- DeronMeranda 2006-01-13 22:30:09
Patch
toggle-linenumber-patch.diff It patches the following files:
MoinMoin/formatter/text_html.py
wiki/htdocs/classic/css/print.css
wiki/htdocs/modern/css/print.css
wiki/htdocs/rightsidebar/css/print.css
For history only, older patches are text_html.py.diff classic-print.css.diff modern-print.css.diff rightsidebar-print.css.diff
Discussion
So how does one toggle the line numbers in print view when the link is invisible? -- ThomasWaldmann 2006-01-14 01:57:24
Oh, it completely escaped me that when you do a Print View action that it also changed the media attribute of the <link> element for the print.css stylesheet. Those new CSS rules should only be in a media=print scope, so I should update the patches to put those rules inside an explicit @media print {...} section. So the Print View action is technically not identical to an actual hardcopy (in that it needs to remain interactive). But still doing a real print will hide the now useless clickable text. -- DeronMeranda 2006-01-14 05:22:30
- Ok, so please do that, test it on IE and Mozilla/Firefox at least and submit a single, full patch.
New patch submitted -- DeronMeranda 2006-01-16 16:34:10
Plan
- Priority: medium
Assigned to: ThomasWaldmann
- Status: i18n will get into moin 1.5, maybe also the css stuff depending on test results.