Description

In UserPreferences, when loggin in, it'd be nice if I could just press "Enter" after entering my username and password. Instead, what is happening instead is "create profile", which is a rarely done operation (done actually just once, normally).

See also: UserPreferencesRedesign

Make Login the default

When a user logs in on a system with email enabled, the button to Send Email is the default because it's first on the form - and is what is activated when the user presses Enter. Since the normal action is to log in, and users are used to pressing Enter after entering username and password, I suggest moving the button down a bit. This requires 2 changes to userform.py:

• Change line 389 to not reference html_sendmail and show help instead:

            ' ', _('(Used to send password reminders)'),

• Change line 350ff to add the send mail button to the list of buttons rather than using special code:

            if config.mail_smarthost:
                buttons = [
                    ('login', _('Login')),
                    ("save", _('Create Profile')),
                    ('login_sendmail', _('Mail me my account data')),
                ]
            else:
                buttons = [
                    ('login', _('Login')),
                    ("save", _('Create Profile')),
                ]

Example

URL: UserPreferences

Details

This Wiki.

Workaround

Click on "Login" instead of hitting enter.

Discussion

The problem is that the "Mail me my account data" is before the login button. Mozilla sends along the first button it finds, it seems. I've made a test page where this button is removed, and the login works with "Enter". Not sure how to fix this...

• These are possible solutions:

  • use the attrib tabindex

    • does not work in Gecko
  • reorder the form, duplicate the form

    • Reorder -- EricDavis

      • the form could probably just be redone like this, no?

             Login:     _____
             Passwword: _____  [Login]
             Repeat:    _____
             Email:     _____  [mail me my account data]
                        [create]

        So +1 -- TheAnarcat 2004-11-20 01:53:03

  • create a new page for password retrieval

    • +1 -- AlexanderSchremmer 2004-11-19 22:07:25

    • +1 -- TheAnarcat 2004-11-20 01:12:38

    • +1 -- EricDavis

  • put some JS magic into the page

    • -1 -- TheAnarcat 2004-11-20 01:53:03

This is a minor problem as you login once in your home/office, and once per session from a temporary location like Interent cafe, or another office etc.

I think the best solution is having different login, register and password retrieval screens, each simple and working correctly when you press enter. -- NirSoffer 2004-11-20 06:27:03

This was fixed in tla by moving the login button just after the password button, which make it "catch" the enter key press. But this is not a true fix, just a ugly hack that make the login screen even more confusing, with buttons spread all over the page with no order. A true fix is a separation of login, register and user preferences pages, each with simple design. This will also make the code much simpler. -- NirSoffer 2004-12-23 01:59:17

Fixed again as suggested by the bug reporter: all button on bottom, first button is login (gets the Enter). For 1.4 we need to redesign the user preferences interface. -- NirSoffer 2004-12-29 20:48:50

Plan

• Priority:
• Assigned to:
• Status: fixed in patch-507

CategoryMoinMoinBugFixed