MoinMoin: MoinMoinChat/Logs/moin-dev/2006-06-25

2006-06-25T00:00:54  <ThomasWaldmann> Kepplar: MoinMoin/se/se(i).py, MoinMoin/storage/se.py those modules should get sane names
2006-06-25T00:01:40  <ThomasWaldmann> MoinMoin/storage/ is ok, maybe the non-special stuff should be just there in __init__.py
2006-06-25T00:05:55  <ThomasWaldmann> Kepplar: Python doesn't usually use "return success" error condition signaling, but either nothing (everything is ok) or raising an Exception class
2006-06-25T00:24:34  <Kepplar> mitsuhiko: you have permission to bait me only when i've seen a shred of (Good) code from you
2006-06-25T00:24:55  <Kepplar> ThomasWaldmann: except: is evil i agree, at the moment I haven't looked at the individual exception that would be thrown
2006-06-25T00:25:06  <Kepplar> 22:41 < ThomasWaldmann> Kepplar: "if something is (not) None:" and "if (not) truthvalue:"
2006-06-25T00:25:13  <Kepplar> ^ reference to what?
2006-06-25T00:25:22  <Kepplar> ThomasWaldmann: regarding test - ok
2006-06-25T00:26:00  <Kepplar> se directory should have been deleted - although seems like it hasnt gone on the ep
2006-06-25T00:26:03  <Kepplar> rep*
2006-06-25T00:56:43  <mitsuhiko> Kepplar: which request problem?
2006-06-25T00:57:31  <Kepplar> not a problem now, Tom explained it
2006-06-25T00:57:46  <Kepplar> whether or not Tom should have needed to explain it is another question
2006-06-25T07:04:28  *** irc.freenode.net sets mode: +o ChanServ
2006-06-25T11:49:56  <ThomasWaldmann> moin
2006-06-25T11:50:49  <ThomasWaldmann> Kepplar: if you want to change the "except:" later, add some # TODO ... to it
2006-06-25T11:51:33  <ThomasWaldmann> the next was a generic comment about how to formulate such if clauses better, inspired by your code
2006-06-25T11:52:00  <Kepplar> re: todo ok
2006-06-25T11:55:15  <ThomasWaldmann> if you delete files and want to have them gone, you need to use hg rm
2006-06-25T11:56:34  <ThomasWaldmann> and for renaming stuff, use hg mv
2006-06-25T11:57:44  <Kepplar> ook
2006-06-25T11:57:46  <Kepplar> cleaned that up
2006-06-25T12:04:12  <ThomasWaldmann> +        # Set Character set. self.output_charset = config.charset # correct for wiki pages
2006-06-25T12:05:01  <ThomasWaldmann> i dont this that a comment like "set character set" for a code line reading ...output_charset = ... is very useful.
2006-06-25T12:05:20  <ThomasWaldmann> s/this/think/ %-)
2006-06-25T12:06:11  <ThomasWaldmann> +        # Set up class attributes.
2006-06-25T12:06:15  <ThomasWaldmann> same.
2006-06-25T12:09:34  <ThomasWaldmann> Kepplar: to your codec module question: you use codec's file operations on (encoded) files with known encoding you want to have decoded to unicode while reading.
2006-06-25T12:10:42  <ThomasWaldmann> so no use for your generic flatfile stuff
2006-06-25T12:13:25  <ThomasWaldmann> Kepplar: either explain for what your version numbers in the file headers are good for, or remove them. we have unique changeset ids assigned by mercurial.
2006-06-25T12:14:18  <ThomasWaldmann> use "from MoinMoin import storage", not "import storage"
2006-06-25T12:16:30  <ThomasWaldmann> check your assertEqual usage
2006-06-25T12:25:18  <ThomasWaldmann> Kepplar: class names use to start with an uppercase letter, like "Page" or "ItemRevision".
2006-06-25T12:29:09  <ThomasWaldmann> Kepplar: some of your files have executable permissions bit set, but don't contain executable code or other means that this could work. I suggest removing executable bit.
2006-06-25T18:04:11  <xorAxAx> lots of clueless questions in here :)
2006-06-25T18:04:26  <xorAxAx> greetings from the SCL airport, btw
2006-06-25T18:05:29  <ThomasWaldmann> do you already know whether they can they pay the fuel?
2006-06-25T18:06:24  <xorAxAx> no idea, they act like there is no problem
2006-06-25T18:06:39  <xorAxAx> but the flight is said to be 20 min. late
2006-06-25T18:06:47  <ThomasWaldmann> "a half full tank is enough for everybody" :)
2006-06-25T18:06:55  <xorAxAx> which meant 3 hours late when i heard that in paris 2 weeks ago
2006-06-25T18:07:02  <xorAxAx> yeah, thought about that as well
2006-06-25T18:07:55  <xorAxAx> "dear passengers, because of pro-actively calculated fuel reserves, we have to start landing here in the ocean. note that our non-existant partners chartered a ship that will take you home safely. thanks for swimming/flying varig (sic)"
2006-06-25T18:08:53  <mitsuhiko> xorAxAx: hehe. wish you luck :)
2006-06-25T18:09:01  <ThomasWaldmann> no fuel -> no ship :-P
2006-06-25T18:10:31  <xorAxAx> i think the "no partners" thing is a worse problem. but i'll see. brazil is a nice country as well - they dont speak there - they sing (esp. if you dont understand pt-br)
2006-06-25T18:14:43  * xorAxAx recommends http://en.wikipedia.org/wiki/Varig
2006-06-25T18:14:57  <xorAxAx> maybe it will have some pictures of flights landing in the ocean soon :)
2006-06-25T18:21:29  * xorAxAx tries boarding
2006-06-25T23:12:49  <Kepplar> hey
2006-06-25T23:12:54  <Kepplar> in python
2006-06-25T23:13:01  <Kepplar> how does a String react to boolean operation?
2006-06-25T23:14:41  <ThomasWaldmann> for example?
2006-06-25T23:18:52  <Kepplar> if not page_name
2006-06-25T23:19:17  <Kepplar> im guessing to it being set or not
2006-06-25T23:20:19  <ThomasWaldmann> 0, None, "", [], {}, ... evaluate to False, everything else to True
2006-06-25T23:21:38  <Kepplar> right, cool
2006-06-25T23:26:04  <Kepplar> cheers
2006-06-25T23:46:13  <Kepplar> rootpage being the first front page kinda thing?
2006-06-25T23:47:36  <ThomasWaldmann> you are talking of the virtual rootpage?
2006-06-25T23:48:38  <ThomasWaldmann> (like in request.py)
2006-06-25T23:50:40  * Kepplar notices an eccept: in page module
2006-06-25T23:53:06  <Kepplar> im talking about whatever is_rootpage on page.py:)