MoinMoin: MoinMoinChat/Logs/moin-dev/2007-01-25

2007-01-25T10:01:56  <ThomasWaldmann> dreimark: i am at osmb congress right now and yesterday someone had a new(?) idea for comments implementation
2007-01-25T10:03:01  <ThomasWaldmann> we could put comments inline into the main page, using some special macro/parser/markup.
2007-01-25T10:04:25  <ThomasWaldmann> they would get rendered into some div or span of class "comment" that can be toggled by some button in the UI
2007-01-25T10:04:35  <ThomasWaldmann> that would solve:
2007-01-25T10:04:45  <ThomasWaldmann> storage (no extra thing needed)
2007-01-25T10:04:46  <dreimark> so we can see comment without RC and Info
2007-01-25T10:04:56  <ThomasWaldmann> have comments at same place as content
2007-01-25T10:05:11  <ThomasWaldmann> don't disturb readers not interested in the comments
2007-01-25T10:05:29  <ThomasWaldmann> hm?
2007-01-25T10:06:07  <ThomasWaldmann> for moin dump, we would need a switch -nocomments that doesnt render comments at all (if you dont want to disclose them)
2007-01-25T10:06:28  <ThomasWaldmann> do you see any problem with that?
2007-01-25T10:07:45  <dreimark> currently a parser could solve this if you don't want each line entered into a macro. only parser could do multilines
2007-01-25T10:09:40  <dreimark> I am not sure if we speak about all the same comments, there are several input for comments
2007-01-25T10:09:48  <dreimark> we have ## int text already
2007-01-25T10:10:01  <dreimark> we have delete comments which are shown in RC
2007-01-25T10:10:30  <dreimark> and we can add a comment to a page change
2007-01-25T10:11:25  <dreimark> which is similiar to delete an attachment
2007-01-25T10:14:53  <ThomasWaldmann> comments as in mediawiki comment page
2007-01-25T10:15:27  <ThomasWaldmann> aka supplementation :)
2007-01-25T10:17:01  <dreimark> ok
2007-01-25T10:19:21  <dreimark> sounds interesting. The content has to be separated for editing and viewing.
2007-01-25T10:19:35  <ThomasWaldmann> has it?
2007-01-25T10:20:39  <ThomasWaldmann> maybe not separating would avoid duplication or questions
2007-01-25T10:21:20  <ThomasWaldmann> would be somewhat like a folding editor, comments can be folded or unfolded
2007-01-25T10:21:21  <dreimark> but if you use acls for the main page readonly
2007-01-25T10:22:03  <dreimark> then you can't edit if that part isn't extracted
2007-01-25T10:22:42  <ThomasWaldmann> if you want to use either ACLs for the main content or for the comments, you would have to use a separate page
2007-01-25T10:23:52  <ThomasWaldmann> and if you write protect a page you maybe dont want comments that can be shown inline anyway
2007-01-25T10:27:39  <dreimark> inline not but in addition like a separate page
2007-01-25T10:28:59  <dreimark> saving both in one raw text with a special kind of separator is that going into the direction of section edit?
2007-01-25T10:29:58  <ThomasWaldmann> no, but maybe we can combine that intelligently later
2007-01-25T10:32:33  <dreimark> I have to think a bit more on the idea to save both together in one raw file
2007-01-25T10:32:50  <dreimark> with a separator
2007-01-25T10:34:22  <dreimark> bbl 3h
2007-01-25T10:34:29  <ThomasWaldmann> i'll try to hack some parser for a first look
2007-01-25T12:09:06  <ThomasWaldmann> http://test.wikiwikiweb.de/CommentsAsCollapseableDivs
2007-01-25T12:31:21  <nomed> hi all
2007-01-25T12:31:55  <nomed> i noticed a strange behaviour ...
2007-01-25T12:32:03  <nomed> i wrote an action for moin
2007-01-25T12:32:21  <nomed> i tested it on moin 1.6 (dev) and moin-desktop
2007-01-25T12:32:45  <nomed> both python2.4
2007-01-25T12:33:03  <nomed> then i tested it on moin 1.5 and python2.3
2007-01-25T12:33:13  <nomed> this:
2007-01-25T12:33:13  <dreimark> nomed please tell your story at #moin
2007-01-25T12:33:26  <dreimark> it is 3rd party code
2007-01-25T12:33:37  <nomed> do u think at #moin ppl are interested ?
2007-01-25T12:33:45  <nomed> dreimark: ok
2007-01-25T12:33:55  <nomed> but that's not 3rd party
2007-01-25T12:34:06  <nomed> it's util.web.makeSelection
2007-01-25T12:34:21  <nomed> anyway ..
2007-01-25T12:34:25  <dreimark> ok
2007-01-25T12:35:50  <dreimark> if you think it's a bug then file a bug report at MM
2007-01-25T12:41:08  <nomed> dreimark: can u let me explain ... ?
2007-01-25T12:41:22  <dreimark> yeah
2007-01-25T12:42:26  <ThomasWaldmann> nomed: if it related to core code, go on
2007-01-25T12:42:39  <nomed> http://phpfi.com/197304
2007-01-25T12:42:55  <nomed> i can't figure out the reason of that
2007-01-25T12:44:46  <ThomasWaldmann> looks like there is some __repr__ missing maybe
2007-01-25T12:45:10  <nomed> http://phpfi.com/197305 <-- the real code
2007-01-25T12:45:45  <ThomasWaldmann> or __str__
2007-01-25T12:47:38  <xorAxAx> nomed: are you using psyco?
2007-01-25T12:48:25  <nomed> xorAxAx: i'm not
2007-01-25T12:49:35  <nomed> the only difference i see there is that it's a sarge box
2007-01-25T12:50:18  <nomed> anyway it's used the same in userform.py and it works there !
2007-01-25T13:13:38  <nomed> ok found .. i had to use unicode(util.web.makeSelection .. )
2007-01-25T13:18:03  <dreimark> ThomasWaldmann:FeatureRequests/IncludeOnDemand is from the behaviuor similiar to CommentsAsCollapseableDivs
2007-01-25T14:37:19  <ThomasWaldmann> re
2007-01-25T14:37:47  * ThomasWaldmann looks there
2007-01-25T14:40:57  <ThomasWaldmann> ah, ok. but using this needs 2 edits: one for the page with the macro and one for the page with the content to include
2007-01-25T14:42:17  <ThomasWaldmann> (and the include code of moin is ugly anyway :)
2007-01-25T14:59:29  <ThomasWaldmann> bbl