2007-06-20T00:15:14 <zenhase> ok, i will try to state some ideas and questions now
2007-06-20T00:16:25 <zenhase> basically, to make theming with a template-engine (genshi in this case) work nicely, i would like to turn around the way the theme-code gets invoked
2007-06-20T00:17:43 <zenhase> instead of pages/actions outputting themselves (like .send_page ...) and calling into the theme-code it should be the other way round
2007-06-20T00:18:42 <ThomasWaldmann> how would that work?
2007-06-20T00:18:55 <zenhase> request should determine if to use themes (other output-formats than html wouldn't need those) and then which one to load
2007-06-20T00:20:11 <zenhase> and instead of calling .send_page for example retrieve the page-content from the page-object
2007-06-20T00:20:25 <zenhase> (or the output of the action)
2007-06-20T00:20:46 <zenhase> ((if it's an action that goes with themes))
2007-06-20T00:22:17 <ThomasWaldmann> so you want to kill send_page or move it into theme code?
2007-06-20T00:22:17 <zenhase> this is of-course a bit problematic in terms of backward-compatibility
2007-06-20T00:23:07 <zenhase> kill send_page: yes, move it into theme-code: not really
2007-06-20T00:23:48 <zenhase> the actual sending of output to the user should happen in the request imo
2007-06-20T00:25:20 <zenhase> which als means that other parts shouldn't .write to the request themselves anymore, but the request arranges, that it gets all output from the different areas
2007-06-20T00:25:42 <zenhase> not by callback, but by fetch, if you know what i mean
2007-06-20T00:25:50 <ThomasWaldmann> or rather the theme
2007-06-20T00:25:57 <zenhase> hmm?
2007-06-20T00:26:14 <ThomasWaldmann> request is lowlevel
2007-06-20T00:27:09 <zenhase> well yes
2007-06-20T00:27:34 <ThomasWaldmann> we currently have 84 actions
2007-06-20T00:27:58 <ThomasWaldmann> (code files, the action count is even more)
2007-06-20T00:28:30 <zenhase> including or excluding 3rd-party?
2007-06-20T00:29:10 <ThomasWaldmann> excluding
2007-06-20T00:29:46 <zenhase> that's quite a lot
2007-06-20T00:29:58 <zenhase> i didn't really expect that much :>
2007-06-20T00:30:13 <ThomasWaldmann> well, look into MoinMoin/action/ :)
2007-06-20T00:31:11 <zenhase> hmm ... 41 files excluding __init__,py
2007-06-20T00:31:36 <zenhase> it doesn't look that much when just ls'ing the directory ...
2007-06-20T00:31:49 <ThomasWaldmann> oh, i also counted pyc :) but there are multiple in __init__
2007-06-20T00:32:26 <zenhase> yeah
2007-06-20T00:32:28 <ThomasWaldmann> so you need a more concrete plan to estimate the work needed
2007-06-20T00:33:11 <zenhase> yes
2007-06-20T00:34:04 <zenhase> wait a minute, i need to order my thoughts
2007-06-20T00:34:28 <ThomasWaldmann> btw, the actions (esp. the rendering) will depend on the mimetype of the item
2007-06-20T00:36:08 <ThomasWaldmann> we have something similar currently, driven by #format metadata
2007-06-20T00:36:36 <ThomasWaldmann> (but only for some few text/* types)
2007-06-20T00:37:50 <zenhase> that's what i meant when i said "if to use theming"
2007-06-20T00:38:14 <ThomasWaldmann> yes and no
2007-06-20T00:38:29 <ThomasWaldmann> there are 2 dimensions
2007-06-20T00:38:36 <ThomasWaldmann> a) mimetype
2007-06-20T00:38:51 <ThomasWaldmann> .... of the item
2007-06-20T00:39:36 <ThomasWaldmann> b) wanted output type (mimetype? at least 1. raw and 2. themed)
2007-06-20T00:40:17 <ThomasWaldmann> e.g. if you have a png item, we need some show action that makes a nice "pseudo wiki page" out of it:
2007-06-20T00:40:40 <ThomasWaldmann> picture/thumbnail at the left, some metadata niceley presented at the right or bottom
2007-06-20T00:40:41 <zenhase> ok
2007-06-20T00:41:15 <ThomasWaldmann> otoh, we need also raw action, just outputting the png with correct http headers
2007-06-20T00:42:26 <zenhase> raw just retrieves the item then, determines the mimetype to send and circumvents any themeing and just sends it to the browser, right?
2007-06-20T00:43:14 <zenhase> could you point me to an example of b) 2) in the code?
2007-06-20T00:43:41 <zenhase> just to get an idea how a pseudo-pages are created
2007-06-20T00:43:56 <zenhase> s/pages/page, s/are/is
2007-06-20T00:44:38 <ThomasWaldmann> b 2 is showing a normal wiki page
2007-06-20T00:44:48 <ThomasWaldmann> b 1 is action raw on a wiki page
2007-06-20T00:45:18 <ThomasWaldmann> currently we have only parser/formatter for this
2007-06-20T00:46:04 <ThomasWaldmann> but we could have pseudo "parsers" parsing a png and its metadata and calling the formatter to generate output
2007-06-20T00:46:46 <ThomasWaldmann> btw, this is one of the reasons why wiki.py is now called text_moin_wiki.py
2007-06-20T00:47:33 <zenhase> because moin supports more than the original intended wiki-markup now? :>
2007-06-20T00:47:53 <ThomasWaldmann> it does this for long
2007-06-20T00:48:18 <zenhase> s/now//
2007-06-20T00:48:37 <ThomasWaldmann> other actions have also to get more flexible, e.g. diff action on a png item
2007-06-20T00:49:26 <zenhase> this will make those actions quite complex doesn't it?
2007-06-20T00:49:48 <zenhase> if they have to support many different mimetypes
2007-06-20T00:49:54 <ThomasWaldmann> so i guess we have to move those actions to member functions of mimetype classes
2007-06-20T00:51:28 <ThomasWaldmann> (we are opening a big can here :)
2007-06-20T00:51:31 <zenhase> well, you would have different types of actions then ... those attached to specific mimetypes
2007-06-20T00:51:39 <zenhase> yeah, i see
2007-06-20T00:52:08 <zenhase> perhaps i could state some other ideas i got when reading thru the source
2007-06-20T00:52:29 <zenhase> (which i was still trying to put in a big design)
2007-06-20T00:53:58 <zenhase> am i right to assume, that most, if not even all output, going through the text/html-formatter is about to be shown themed?
2007-06-20T00:54:49 <ThomasWaldmann> which output?
2007-06-20T00:55:36 <ThomasWaldmann> the theme output is not completely through the formatter
2007-06-20T00:55:41 <zenhase> output in the sense of "stuff that calls text/html-formatter to format output it wants put somewhere"
2007-06-20T00:56:06 <ThomasWaldmann> and the content output is also not completely through the formatter
2007-06-20T00:56:55 * zenhase is currently looking at Page.py around line 1151
2007-06-20T00:57:15 <ThomasWaldmann> e.g. PageEditor outputs directly with request.write
2007-06-20T00:57:26 <zenhase> yeah, i saw that one too
2007-06-20T00:57:40 <zenhase> i would like to make this html external too
2007-06-20T00:58:15 <zenhase> you could output it via genshi too
2007-06-20T00:59:00 <zenhase> and perhaps even give theme-authors to represent the page-editor in a different way if they choose too
2007-06-20T00:59:12 <ThomasWaldmann> page content is mostly output through formatter, but not completely
2007-06-20T00:59:39 <zenhase> you are talking about the macros right?
2007-06-20T01:00:04 <ThomasWaldmann> e.g. some complex macros might emit raw html (well it is through formatter.rawHTML)
2007-06-20T01:00:15 <ThomasWaldmann> or it should be through that
2007-06-20T01:00:28 <zenhase> hmm
2007-06-20T01:00:50 <zenhase> so now for the idea regarding the html-formatter
2007-06-20T01:02:56 <zenhase> since i want to drive output from below, by collecting the parts of the page and then render out a theme/template with the appropiate context-data i would like to have things like page-content as a genshi-markup-stream too
2007-06-20T01:03:44 <zenhase> genshi has a very nice element-builder builtin, that also avoids the .element(on)-.element(off) style of the current formatter
2007-06-20T01:04:44 <zenhase> a build elementtree can be converted to a markup-stream or plain unicode then
2007-06-20T01:04:50 <zenhase> s/build/built
2007-06-20T01:05:16 <ThomasWaldmann> always remember we do not only output html, but also misc other formats
2007-06-20T01:05:39 <zenhase> well, that's what other formatters are for i thought
2007-06-20T01:06:13 <ThomasWaldmann> yes, with the same upper interface
2007-06-20T01:07:03 <zenhase> hmm ok
2007-06-20T01:07:36 <zenhase> i see where this might be a problem
2007-06-20T01:08:19 <zenhase> hmm, but then: couldn't this builder-pattern be adapted to the other formatters too?
2007-06-20T01:08:49 <zenhase> the builder-code in genshi is actually quite small
2007-06-20T01:09:16 <ThomasWaldmann> i guess we will change that parser/formatter stuff at some time, but it won't fit into your soc time scope
2007-06-20T01:09:25 <zenhase> ok
2007-06-20T01:10:24 <ThomasWaldmann> there are quite some things we need a good plan for when doing this: include, toc, evaluation order, dependencies
2007-06-20T01:10:25 <zenhase> then i would take the approach of capturing output again
2007-06-20T01:10:55 <zenhase> but at the mentioned other level and killing .send_page in the process
2007-06-20T01:11:19 <ThomasWaldmann> if that works, you should go that way
2007-06-20T01:11:45 <zenhase> i think this would work
2007-06-20T01:12:58 <zenhase> it means to have page-content as a big blob, when rendering templates, but this can be fixed later on in the formatters then
2007-06-20T01:15:04 <zenhase> there is another issue of awkwardness for current theme authors on my list
2007-06-20T01:15:42 <zenhase> it's the "copy over all css/images for a new theme"-part
2007-06-20T01:17:57 <zenhase> i think this will not really be such a huge deal, but it means deciding on the way fallback is done
2007-06-20T01:18:57 <zenhase> fallback to some default-content or fallback to the content of the default-theme would be the first decision coming to my mind
2007-06-20T01:19:24 <zenhase> those could be different ...
2007-06-20T01:19:31 <ThomasWaldmann> the problem here is that moin just generates hrefs to those icons
2007-06-20T01:19:45 <ThomasWaldmann> it does not really know whether they are there or not
2007-06-20T01:20:14 <ThomasWaldmann> so there would be some flag in the theme telling "use default icons"
2007-06-20T01:20:24 <zenhase> hmm
2007-06-20T01:20:49 <zenhase> perhaps make the flag a 'directory-flag'?
2007-06-20T01:20:58 <ThomasWaldmann> but the question is rather why we should do that
2007-06-20T01:21:12 <zenhase> "if theme has it's own css-directory, use that"
2007-06-20T01:21:15 <ThomasWaldmann> we dont need to save 50k of disk space
2007-06-20T01:21:49 <ThomasWaldmann> but some more structure in the icons/images and css area would do no harm :)
2007-06-20T01:21:56 <zenhase> it's not really about having space-issues
2007-06-20T01:22:34 <zenhase> but more about having to maintain your css and images when basing your theme on another one
2007-06-20T01:22:47 <ThomasWaldmann> moin does not even know where the css directory is
2007-06-20T01:24:29 <zenhase> hmm
2007-06-20T01:24:58 <ThomasWaldmann> it could be even on a remote server
2007-06-20T01:25:11 <ThomasWaldmann> see static.wikiwikiweb.de :)
2007-06-20T01:26:31 <zenhase> it just inserts the %staticprefix/%themename/ before every link to an external resource, right?
2007-06-20T01:27:53 <ThomasWaldmann> yes
2007-06-20T01:28:37 <ThomasWaldmann> of course the theme code module can know what it has and what not
2007-06-20T01:29:29 <ThomasWaldmann> (this stuff is lower prio than genshi stuff)
2007-06-20T01:30:24 <zenhase> yeah, same opinion here
2007-06-20T01:31:07 <zenhase> now about backward-compatibility:
2007-06-20T01:31:50 <zenhase> ah damnit ... break
2007-06-20T01:32:04 <zenhase> missed something
2007-06-20T01:33:22 <zenhase> there are still calls from external actions/macros to the theme ...
2007-06-20T01:33:41 <zenhase> even if i move down a layer from .send_page
2007-06-20T01:35:19 <ThomasWaldmann> what do you mean by external actions?
2007-06-20T01:37:16 <zenhase> ignore what i said ... i just panicked for a moment, but it's actually quite similar to what i did with the genshi-like theme
2007-06-20T01:39:57 <zenhase> hmm
2007-06-20T01:45:52 <zenhase> ok, i again scanned quickly over the code with grep
2007-06-20T01:49:19 <zenhase> apart from page/pageeditors there are 16 calls to .send_* methods of themes in 13 actions
2007-06-20T01:49:46 <zenhase> meaning those output a completely themed page themselves
2007-06-20T01:50:15 <zenhase> this will be the ones i will have to look for when capturing output
2007-06-20T01:50:31 <zenhase> s/look for/look at/
2007-06-20T01:55:26 <zenhase> hmm ok, well ... i will put together a plan then
2007-06-20T02:14:46 <zenhase> i will catch some sleep now, cu tomorrow
2007-06-20T08:14:39 <ThomasWaldmann> moin
2007-06-20T09:41:25 <vpv> wow, a "co-worker" of mine, who does KDE code during the summer, was attacked in Helsinki and his laptop was stolen. He got his laptop back but the attackers kicked him in the head and stuff. Crazy world...
2007-06-20T10:24:51 <grzywacz> shit happens, unfortunately
2007-06-20T10:24:58 <grzywacz> He wouldn't get his laptop here. ;s
2007-06-20T10:26:19 <vpv> I guess the police found the people who did it and returned the laptop. The guys attacked someone else the same evening too :/
2007-06-20T10:27:24 <grzywacz> Congrats to your police forces, then.
2007-06-20T10:36:09 <ffesti> Helsinki doesn't sound that dangerous, one would think
2007-06-20T10:36:50 <vpv> yeah, generally it isn't... but back to work, I'll hg push, beware ;)
2007-06-20T10:37:13 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2138:283530fa9c52 1.7-maninfo-vpv/MoinMoin/Page.py: avoid acl KeyError for xml/xslt pages (ported from 1.6)
2007-06-20T10:37:19 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2139:ea879bd7935d 1.7-maninfo-vpv/jabberbot/ (xmlrpcbot.py xmppbot.py): Fix some names as pointed out by pylint.
2007-06-20T10:37:20 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2140:d3a34ba5614a 1.7-maninfo-vpv/ (.hgignore wikiconfig.py): Revert my test changes.
2007-06-20T10:37:21 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2141:ea091b3eedc2 1.7-maninfo-vpv/wiki/config/more_samples/jabber_wikiconfig.py: Add a sample config with notification bot's options.
2007-06-20T10:37:23 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2142:4e02a7cef128 1.7-maninfo-vpv/wiki/config/more_samples/jabber_wikiconfig.py: Merge with my branch.
2007-06-20T10:37:24 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2143:2941aad83666 1.7-maninfo-vpv/MoinMoin/Page.py: Merge with main.
2007-06-20T10:37:27 <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2144:42b85d3d3f8f 1.7-maninfo-vpv/MoinMoin/_tests/test_macro_Hits.py: test_macro_Hits: unittest for macro Hits
2007-06-20T10:37:30 <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2145:3741d741113e 1.7-maninfo-vpv/MoinMoin/_tests/test_macro_Hits.py: test_macro_Hits: change in comments
2007-06-20T10:37:35 <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2146:0fe9e533f00e 1.7-maninfo-vpv/MoinMoin/_tests/test_macro_Hits.py: test_macro_Hits: removed some unused imports
2007-06-20T10:37:40 <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2147:3accd05a36f3 1.7-maninfo-vpv/ (22 files in 10 dirs): Merge with my branch
2007-06-20T10:37:43 <CIA-27> moin: Alexander Schremmer <alex AT alexanderweb DOT de> * 2148:ff428fa12e3c 1.7-maninfo-vpv/MoinMoin/_tests/ (19 files): Added legacy warning to old unittests.
2007-06-20T10:37:46 <CIA-27> moin: Alexander Schremmer <alex AT alexanderweb DOT de> * 2149:9c7c784281b7 1.7-maninfo-vpv/MoinMoin/_tests/test_converter_text_html_text_moin_wiki.py: Removed unittest.main call.
2007-06-20T10:37:49 <CIA-27> moin: Alexander Schremmer <alex AT alexanderweb DOT de> * 2150:d84535cb9f65 1.7-maninfo-vpv/MoinMoin/_tests/_test_template.py: Simplify test template.
2007-06-20T10:37:52 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2151:b97040fcd8e1 1.7-maninfo-vpv/MoinMoin/ (8 files in 2 dirs): added some new tests, move util tests to MoinMoin/util/_tests
2007-06-20T10:38:03 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2152:05557f1ce219 1.7-maninfo-vpv/MoinMoin/events/emailnotify.py: Fix sending of email notifications after changes to messages.py
2007-06-20T10:38:06 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2153:f153b3155240 1.7-maninfo-vpv/ (4 files in 3 dirs): Send notifications about creation of users to Superusers with JID set.
2007-06-20T10:38:09 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2154:85854afc1aa2 1.7-maninfo-vpv/ (5 files in 3 dirs): Merge with my devel branch.
2007-06-20T10:38:12 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2155:b01a6ef1be4c 1.7-maninfo-vpv/MoinMoin/ (config/multiconfig.py events/jabbernotify.py): Get rid of the global xmlrpc Server object. Instantiate one in config.
2007-06-20T10:38:16 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2156:8181ec5cd86c 1.7-maninfo-vpv/MoinMoin/ (config/multiconfig.py events/jabbernotify.py): Merge with my devel branch.
2007-06-20T10:38:21 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2157:7def1e49e757 1.7-maninfo-vpv/jabberbot/config.py: Add a sample config for the notification bot.
2007-06-20T10:38:24 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2158:3417a1d559d0 1.7-maninfo-vpv/MoinMoin/_tests/ (20 files): Merge the changes from main.
2007-06-20T10:38:27 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2159:dd3abe290142 1.7-maninfo-vpv/MoinMoin/util/web.py: Add a makeMultiSelection() function which creates a multiple <select> element.
2007-06-20T10:38:32 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2160:cf4c4a3d6085 1.7-maninfo-vpv/MoinMoin/ (config/multiconfig.py events/__init__.py user.py userform.py): Add a list of selectable events user wants to be notified about.
2007-06-20T10:38:36 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2161:8e772d72ec6e 1.7-maninfo-vpv/MoinMoin/ (5 files in 4 dirs): Merge with my devel branch.
2007-06-20T10:38:39 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2162:f2ae2f08958d 1.7-maninfo-vpv/MoinMoin/events/jabbernotify.py:
2007-06-20T10:38:44 <CIA-27> moin: Honor event subscriptions when sending jabber notifications. Fix missing import.
2007-06-20T10:38:46 <CIA-27> moin: Also don't send empty JIDs to the jabber bot.
2007-06-20T10:38:48 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2163:4138e1f06617 1.7-maninfo-vpv/MoinMoin/userform.py: Make it possible to unset user's jid in preferences.
2007-06-20T10:38:53 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2164:e2aa8372c4bf 1.7-maninfo-vpv/jabberbot/xmppbot.py: Warn if a command with empty user jid has been received.
2007-06-20T10:38:58 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2165:c3bf2fa18b9a 1.7-maninfo-vpv/jabberbot/xmppbot.py: Backed out changeset e2aa8372c4bf462dde0fe18fb647d782c3f1f615
2007-06-20T10:39:01 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2166:22a7080b4ac5 1.7-maninfo-vpv/jabberbot/xmppbot.py: Don't process commands with no jid and issue a warning. That's a proper fix.
2007-06-20T10:39:06 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2167:a8941968efa1 1.7-maninfo-vpv/ (3 files in 3 dirs): Merge with my devel branch.
2007-06-20T10:39:09 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2168:7c8ee12f8c1d 1.7-maninfo-vpv/MoinMoin/ (config/multiconfig.py events/jabbernotify.py): Fix an error with missing bot_host attribute. Use more descriptive names.
2007-06-20T10:39:15 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2169:af1eb45c937e 1.7-maninfo-vpv/wiki/config/more_samples/jabber_wikiconfig.py: Fix the sample config to use new attribute name.
2007-06-20T10:39:20 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2170:e6dd69d3ac69 1.7-maninfo-vpv/MoinMoin/ (config/multiconfig.py events/jabbernotify.py): Merge with my devel branch.
2007-06-20T10:39:23 <CIA-27> (4 lines omitted)
2007-06-20T10:40:24 <ffesti> vpv, seen my replay on fedora-devel?
2007-06-20T10:41:55 <vpv> ffesti: no, I may have missed it, the list is such high traffic
2007-06-20T10:42:09 <ffesti> vpv: just being curious: what are you currently planning to do?
2007-06-20T10:42:15 <ffesti> yes, it is
2007-06-20T10:42:31 <ffesti> should have put you an cc...
2007-06-20T10:43:02 <vpv> I see it now, KMail search to the rescue ;)
2007-06-20T10:47:06 <vpv> ffesti: The idea that me and Karsten currently have for the publication phase is to use doclifter by ESR to convert the man pages into DocBook XML and then use the 4suite that prints them in Moin
2007-06-20T10:48:23 <ffesti> yes, that's the easy part
2007-06-20T10:48:40 <vpv> for "phase 2", editing, we thought about man->XML->wiki markup->XML->"any" format that is wanted
2007-06-20T10:49:40 <vpv> since a lot of projects don't keep their man pages as groff markup, they may be Perl documentation or whichever other format
2007-06-20T10:49:58 <ffesti> sounds easy, but you have to make sure that the XML -> wiki markup part is lossless
2007-06-20T10:50:44 <ffesti> or converting back won't be that easy...
2007-06-20T10:50:51 <vpv> I agree, sounds easy, might not actually be that easy...
2007-06-20T10:51:33 <ffesti> I'd suggest to write down some conversion tables for all features needed
2007-06-20T10:52:18 <ffesti> then you can see where you run into trouble with a 1 to 1 mapping
2007-06-20T10:53:08 <ffesti> if you have that table implementing to conversion shouldn't be that hard
2007-06-20T10:58:41 <vpv> good idea
2007-06-20T11:00:00 <xorAxAx> ffesti: thats all solved already in the docbook branch
2007-06-20T11:00:12 <xorAxAx> well, not all, but much
2007-06-20T11:00:37 <ffesti> so where is the mapping? ;)=
2007-06-20T11:00:50 <xorAxAx> ffesti: see the docbook branch
2007-06-20T11:03:27 <ffesti> got that branch merged?
2007-06-20T11:04:34 <xorAxAx> ffesti: oh well
2007-06-20T11:04:42 <vpv> no, but I might try to merge it during my project, since it seems that it'll be useful
2007-06-20T11:04:45 <xorAxAx> ffesti: that should be vpv's task ... the mentor is the same :)
2007-06-20T11:04:58 <ffesti> ok
2007-06-20T11:05:08 <xorAxAx> of course only if he needs it
2007-06-20T11:05:26 <xorAxAx> but if karsten shows the same level of goal-orientation like last year ... *sigh* :)
2007-06-20T11:40:19 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2166:2a7b535b1e44 1.7/MoinMoin/_tests/test_xmlrpc_multicall.py: Add a test for xmlrpc Fault serialization.
2007-06-20T11:40:23 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2167:37e16cdc3a84 1.7/jabberbot/ (xmlrpcbot.py xmppbot.py): Make the output of GetPageInfo command human-readable
2007-06-20T11:40:24 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2168:f10336f74a6e 1.7/MoinMoin/events/emailnotify.py: Make function names pep8-compatible.
2007-06-20T11:40:25 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2169:8aad85519f76 1.7/MoinMoin/userform.py: Fix error occuring when user has no subscribed events.
2007-06-20T11:40:26 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2170:3cfc01315d3a 1.7/ (5 files in 4 dirs): Merge with my devel branch.
2007-06-20T11:40:28 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2171:a3a19bdc0b9a 1.7/ (5 files in 4 dirs): merge jabber branch
2007-06-20T12:15:24 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2172:c15ec6a2c69e 1.7/MoinMoin/_tests/ (test_request.py test_security.py test_wikiutil.py): reduce number of failing tests
2007-06-20T12:29:19 <dreimark> ImportError: No module named events ???
2007-06-20T12:30:21 <xorAxAx> dreimark: did thomas pull in again untested code? :)
2007-06-20T12:33:05 <dreimark> investigating
2007-06-20T12:36:44 <xorAxAx> grzywacz: the event handlers must be cached in the config as well
2007-06-20T12:36:54 <xorAxAx> grzywacz: because they are cfg-dependant
2007-06-20T12:37:17 <xorAxAx> grzywacz: and please have a look at the test failure we have now ....testHitsNoArg
2007-06-20T12:43:07 <ThomasWaldmann> grzywacz: I suggest you concentrate on bugfixing and do no other changes so we finally get the main branch working again
2007-06-20T12:44:53 <xorAxAx> he didnt push to the main branch :)
2007-06-20T12:45:07 <xorAxAx> and i pushed only working stuff besides his configs AFAIK :)
2007-06-20T12:55:40 <ThomasWaldmann> the stuff you pushed failed the test due to bot_host AttributeError
2007-06-20T12:55:47 <ThomasWaldmann> tests
2007-06-20T12:57:35 <xorAxAx> hmm
2007-06-20T12:57:50 <xorAxAx> ok, so we should run tests before pushing to main
2007-06-20T12:58:11 <dreimark> yeah and the students should do that too
2007-06-20T12:58:47 * ThomasWaldmann tries to bring the tests to 0 failures
2007-06-20T12:59:25 <dreimark> and if they see something unfinished it should be commented during their push
2007-06-20T13:00:00 <ThomasWaldmann> (in some cases where the tests are known broken or the code is known unfinished, this just means skipping the test - of course we should try to reduce the skipped tests also, but not by making them failed tests)
2007-06-20T13:00:33 <dreimark> ok
2007-06-20T13:01:25 * ThomasWaldmann likes py.test quite a bit more than unittest
2007-06-20T13:01:30 <xorAxAx> hehe
2007-06-20T13:02:21 <dreimark> ThomasWaldmann: xorAxAx: what do you think on neagulms idea to merge reverend bayes filter into 1.7 code (2 files) for the basic configuration. Making the code extensible for exchanging the classifier
2007-06-20T13:02:22 <ThomasWaldmann> the only thing less nice is that it is not in stdlib and not in moin
2007-06-20T13:03:11 <xorAxAx> dreimark: you mean copying third-party libs?
2007-06-20T13:03:28 <dreimark> yes
2007-06-20T13:04:13 <xorAxAx> how are they licensed?
2007-06-20T13:04:37 <dreimark> http://divmod.org:81/svn/Divmod/trunk/Reverend/reverend/thomas.py
2007-06-20T13:04:58 <dreimark> GNU Lesser General Public License
2007-06-20T13:05:11 <xorAxAx> is it dead?
2007-06-20T13:05:16 <xorAxAx> 90% of the divmod projects are dead
2007-06-20T13:05:16 <ThomasWaldmann> hehe
2007-06-20T13:05:25 * ThomasWaldmann thought the same
2007-06-20T13:06:08 <dreimark> no idea neagulm checks that
2007-06-20T13:06:22 <xorAxAx> dreimark: but that doesnt matter if it is such small, he can fix the bugs we encounter
2007-06-20T13:06:26 <xorAxAx> but he should be prepared for that
2007-06-20T13:06:38 <xorAxAx> otherwise he may want to look at something that is maintained
2007-06-20T13:07:00 <ThomasWaldmann> well, if he would have to write the same code again and rather prefers to get this one running (and even fix it in case it is broken), there is MoinMoin.support. for such stuff
2007-06-20T13:08:36 <xorAxAx> yes, it would go to MoinMoin.support
2007-06-20T13:09:09 <ThomasWaldmann> remember lupy, though X)
2007-06-20T13:19:43 <dreimark> xorAxAx: _test_template has utf-8 coding, is that wanted ?
2007-06-20T13:21:04 <xorAxAx> dreimark: yes, why not? :)
2007-06-20T13:21:21 <xorAxAx> in fact, it is encoded in ascii only but the header lets python interpret it as utf-8
2007-06-20T13:22:59 <dreimark> some chinese or some other strings could used for tests too
2007-06-20T13:24:19 <xorAxAx> yes
2007-06-20T13:44:36 <ThomasWaldmann> don't use utf-8 encoding if you can avoid it
2007-06-20T13:45:54 <ThomasWaldmann> (in the source)
2007-06-20T13:57:15 <ThomasWaldmann> gna, broken tarfile triggers failing tests
2007-06-20T14:12:01 <dreimark> may be AttachFile should list the mimetype too, so we can use that info in AttachList(,mimetype)
2007-06-20T14:14:40 * ThomasWaldmann .oO(dead code)
2007-06-20T14:56:06 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2173:789c1a37e4ab 1.7/MoinMoin/_tests/ (test_formatter.py test_wikiutil.py): don't run docbook formatter test when we have no 4suite installed, add test for non-empty SystemPagesGroup
2007-06-20T14:56:08 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2174:f5f4dbbd0c51 1.7/MoinMoin/ (_tests/maketestwiki.py action/backup.py support/tarfile.py): added tarfile.py from py 2.5.1 (backported to work with py 2.3/2.4), fix imports to use it for tests/backup (ported from 1.6)
2007-06-20T14:56:09 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2175:7a3f7ac4f6e0 1.7/MoinMoin/ (_tests/test_formatter.py conftest.py formatter/text_xml.py): fix formatter setup for tests, skip broken dom_xml formatter test, add small/big to text_xml formatter (ported from 1.6)
2007-06-20T15:02:33 <ThomasWaldmann> xorAxAx: /srv/moin_tw/moin-1.7-main/MoinMoin/_tests/test_packages.py:60 fails
2007-06-20T15:05:07 <ThomasWaldmann> dreimark: /srv/moin_tw/moin-1.7-main/MoinMoin/_tests/test_macro_Hits.py:111 fails
2007-06-20T15:05:33 <ThomasWaldmann> they both fail on a fresh made test wiki, but not if run the second time
2007-06-20T15:06:30 <ThomasWaldmann> aside from that, after the 3rd py.test run you now get: tests finished: 101 passed, 16 skipped in 1.53 seconds
2007-06-20T15:12:22 <xorAxAx> ThomasWaldmann: yeah, that looks like an error introduced by reimar, i will have a loo :)
2007-06-20T15:12:37 <xorAxAx> (its printing a message because of something)
2007-06-20T15:12:46 <xorAxAx> or maybe the test had been broken forever ... but i will see
2007-06-20T15:14:36 <dreimark> xorAxAx: ThomasWaldmann it was well working here before some other patches were added
2007-06-20T15:14:40 <dreimark> but lets see
2007-06-20T15:15:18 <ThomasWaldmann> dreimark: it does not fail when you run it on a non fresh test wiki
2007-06-20T15:16:12 <dreimark> hmm, then I have done something wrong, xorAxAx will find it i guess
2007-06-20T15:40:08 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2176:7917222e0e05 1.7/MoinMoin/util/_tests/test_util.py: MoinMoin.util: some tests added
2007-06-20T16:22:49 <grzywacz> re...
2007-06-20T16:27:14 <xorAxAx> grzywacz: have you seen the messages?
2007-06-20T16:35:30 <grzywacz> Yes.
2007-06-20T16:37:17 <grzywacz> I'll take care of these issues in a few hours, now I have something else to finish.
2007-06-20T16:44:13 <xorAxAx> ok
2007-06-20T16:45:03 <dreimark> bbl
2007-06-20T16:45:43 * ThomasWaldmann suggests the students do a pull from 1.7 repo now as I am soon committing a 1.6 branch merge
2007-06-20T16:46:25 <xorAxAx> 1.6 branch merge?
2007-06-20T16:46:26 <grzywacz> Is anything going to break? ;]
2007-06-20T16:46:34 <xorAxAx> what is a 1.6 branch merge?
2007-06-20T16:46:45 <grzywacz> Prolly fixes from 1.6?
2007-06-20T16:47:01 <xorAxAx> well, we are cherry picking them currently
2007-06-20T16:47:09 <xorAxAx> in both directions :)
2007-06-20T16:47:41 <grzywacz> Happens in all projects which actually try to support their software. :p
2007-06-20T16:48:14 <ThomasWaldmann> i just pulled from 1.6 into 1.7 and merged. I am currently reviewing the stuff.
2007-06-20T16:48:22 <xorAxAx> ThomasWaldmann: umm
2007-06-20T16:48:23 <grzywacz> O_o;
2007-06-20T16:48:56 <xorAxAx> i wouldnt expect that to work well, but if you think that it works out, fine :)
2007-06-20T17:02:06 <ThomasWaldmann> it worked better than expected :) of course johill's auth changes generate conflicts, but the rest seems ok.
2007-06-20T17:24:38 <ThomasWaldmann> hmm, some hunks are strange...
2007-06-20T18:27:44 <Fabi> re
2007-06-20T20:24:34 <zenhase> re
2007-06-20T20:27:28 <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2177:3719548ae9a2 1.7/MoinMoin/_tests/ (macro/test_Action.py macro/test_Hits.py test_macro_Hits.py): test of Hits moved to macro and converted for py.test, a test for the Action macro added
2007-06-20T20:28:47 <dreimark> I am not sure if the Hits test is fixed now, but it seems to work
2007-06-20T20:30:01 <dreimark> another point i learned that i do need different testpage names for each test otherwise the page gots to be immutable
2007-06-20T20:30:13 <dreimark> and the test fails
2007-06-20T20:30:58 <dreimark> for hits I have removed in setup_class the event_log at startup
2007-06-20T20:34:20 <dreimark> the test for 4suite shows broken code e.g. AttributeError: DocBookOutputFormatter instance has no attribute 'domHeadNode'
2007-06-20T20:35:09 <xorAxAx> yes, two hints about that: a) in the docbook branch, the code is much better b) might be api breakage in 4suite
2007-06-20T21:24:09 <CIA-27> moin: Marian Neagul marian@info.uvt.ro * 2179:0df30eef883d 1.7-classify-mneagul/MoinMoin/classifier/ (SpamBayes.py __init__.py): Send mimetype as feature
2007-06-20T21:24:12 <CIA-27> moin: Marian Neagul marian@info.uvt.ro * 2180:399d9fa0fafe 1.7-classify-mneagul/MoinMoin/ (3 files in 2 dirs): Add classification log
2007-06-20T21:24:13 <CIA-27> moin: Marian Neagul marian@info.uvt.ro * 2181:3a1aad9d60d8 1.7-classify-mneagul/MoinMoin/action/ (edit.py info.py): Modify info action to show classification data
2007-06-20T21:24:15 <CIA-27> moin: Marian Neagul marian@info.uvt.ro * 2182:9af8242f248a 1.7-classify-mneagul/MoinMoin/ (action/RenamePage.py action/edit.py classifier/__init__.py): Rename page action
2007-06-20T21:40:33 <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2178:e35adb666eca 1.7/MoinMoin/_tests/macro/test_ImageLink.py: test_ImageLink: some tests for ImageLink
2007-06-20T22:15:09 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2179:e81af778f99d 1.7/MoinMoin/logfile/editlog.py: fixed cleaning of edit comments
2007-06-20T22:15:11 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2180:80fc914af5c8 1.7/docs/ (CHANGES CHANGES.fpletz): integrated CHANGES.fpletz into main CHANGES, TODOs/unclear stuff went to MoinMoin:XapianIntegration
2007-06-20T22:15:17 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2181:340ae0e7529e 1.7/ (3 files in 3 dirs): replace xmlrpc getUser by getUserProfile, auth can be done by getAuthToken/applyAuthToken in the same multicall, use for interwiki auth
2007-06-20T22:15:18 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2182:261d406b560f 1.7/MoinMoin/_tests/ (4 files in 2 dirs): merged main
2007-06-20T22:16:42 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2183:d133bf86ed58 1.7/MoinMoin/macro/MonthCalendar.py: MonthCalendar: fix wrong relative links
2007-06-20T22:24:52 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2184:b3dc2a7d1cce 1.7/MoinMoin/i18n/Makefile: i18n Makefile fixes
2007-06-20T22:40:12 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2185:ca3e7fdab76e 1.7/moin.spec: fix date format in moin.spec file
2007-06-20T22:45:56 <zenhase> eek
2007-06-20T22:47:57 <zenhase> hmm, i didn't even link to the designpaper yet and already people start adding stuff
2007-06-20T22:48:34 <xorAxAx> man RC :)
2007-06-20T22:49:02 <zenhase> i am still in preview-mode, but how to keep this addition?
2007-06-20T22:49:22 <zenhase> i thought some "conflict"-markers would spawn up
2007-06-20T22:49:27 <xorAxAx> hmm?
2007-06-20T22:49:36 <xorAxAx> you only get them if there is a conflict of course
2007-06-20T22:50:14 <zenhase> ok, will see on save
2007-06-20T22:53:34 <xorAxAx> on preview, its merged as well
2007-06-20T22:53:44 <xorAxAx> btw, that should go to #moin :)
2007-06-20T22:54:16 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2186:87cdbb744f1b 1.7/ (MoinMoin/parser/text_moin_wiki.py docs/CHANGES): revert the rest of changeset 1694: fdf01f9f3143 (except the bugfix)
2007-06-20T22:54:17 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2187:15c11fe8f6b2 1.7/MoinMoin/config/ (__init__.py multiconfig.py): config/multiconfig: minor cleanup
2007-06-20T22:54:19 <CIA-27> moin: Alexander Schremmer <alex AT alexanderweb DOT de> * 2188:30a153cfa8f8 1.7/MoinMoin/script/maint/mkpagepacks.py: Make testwiki check in mkpagepacks windows-compatible.
2007-06-20T22:54:20 <CIA-27> moin: Alexander Schremmer <alex AT alexanderweb DOT de> * 2189:a37491dbb605 1.7/MoinMoin/ (PageEditor.py security/__init__.py): Correctly check the ACL lists in the PageEditor for the admin check instead of the wrapping objects, reordered some comments and doc strings, return None instead of 0 in may if applicable. Should be ported to 1.7.
2007-06-20T22:54:23 <CIA-27> moin: Alexander Schremmer <alex AT alexanderweb DOT de> * 2190:a34d054835d3 1.7/MoinMoin/security/__init__.py: Added some documentation to the docstrings of MoinMoin.security, reordered some lines of code. Should be ported to 1.7.
2007-06-20T22:55:09 <CIA-27> moin: Alexander Schremmer <alex AT alexanderweb DOT de> * 2191:fc90d8319bba 1.7/MoinMoin/ (config/multiconfig.py security/__init__.py): Add hierarchical ACLs, clean the module doc string of MoinMoin.security.
2007-06-20T22:56:45 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2192:ab895b8095c4 1.7/MoinMoin/security/__init__.py: security: fix spelling, remove unneeded import
2007-06-20T22:58:08 <starshine> 20
2007-06-20T22:59:27 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2193:cb913c851e91 1.7/MoinMoin/config/multiconfig.py: credits: added title attr, added some comments, added GPL credit
2007-06-20T22:59:28 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2194:3ae6b91e4f72 1.7/wiki/htdocs/ (3 files in 3 dirs): fixed order of .comment and .red/green/blue css definitions, copied them to classic and rightsidebar, fixes missing pre.comment css in rightsidebar
2007-06-20T22:59:29 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2195:386caaa698d8 1.7/MoinMoin/ (3 files in 2 dirs): comments: moved the check for the user setting to the formatter, fixes caching issue
2007-06-20T23:03:46 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2196:45cf51902c61 1.7/MoinMoin/parser/text_moin_wiki.py: wiki comment divs: fix caching behaviour
2007-06-20T23:03:48 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2197:9b404a43e59c 1.7/MoinMoin/theme/__init__.py: use standard RSS icon
2007-06-20T23:58:53 <CIA-27> moin: Marian Neagul marian@info.uvt.ro * 2183:9d7b34f3e4d5 1.7-classify-mneagul/ (10 files in 4 dirs): Remove design error: singleton
2007-06-20T23:58:54 <CIA-27> moin: Marian Neagul marian@info.uvt.ro * 2184:fbe7eaba925d 1.7-classify-mneagul/MoinMoin/util/Reverend.py: Import DivMod Reverend to MM
2007-06-20T23:58:55 <CIA-27> moin: Marian Neagul marian@info.uvt.ro * 2185:1756cf6a4fcd 1.7-classify-mneagul/ (7 files in 4 dirs): Integrated Reverend with MM. Needs more work.
MoinMoin: MoinMoinChat/Logs/moin-dev/2007-06-20 (last edited 2007-10-29 19:10:35 by localhost)
